aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* pg, `PostgreSQL::Name` to hold schema qualified names.Yves Senn2014-05-301-2/+43
|
* Move `type_cast_for_write` behavior over to the serialized type objectSean Griffin2014-05-291-29/+0
|
* Refactor serialized types to be partially defined as custom propertiesSean Griffin2014-05-292-12/+2
| | | | | | | Many of the methods defined in `AttributeMethods::Serialization` can be refactored onto this type as well, but this is a reasonable small step. Removes the `Type` class, and the need for `decorate_columns` to handle serialized types.
* Result sets never override a model's column typeSean Griffin2014-05-292-0/+50
| | | | | | | | | | | | MySQL and PostgreSQL provide a column type override in order to properly type cast computed columns included in a result set. This should never override the known types of full fledged columns. In addition to messing up computed properties, this would have led to inconsistent behavior between a record created with `new`, and a record created with `last` on the mysql adapter in the following cases: - `tinyint(1)` with `emulate_booleans` set to `false` - `text`, `string`, `binary`, and `decimal` columns
* Maintain column order when overriding existing columnsSean Griffin2014-05-281-0/+5
| | | | | | Working towards re-implementing serialized attributes to use the properties API exposed the need for this, as serializing a column shouldn't change the order of the columns.
* Merge pull request #15389 from sgrif/sg-property-inheritanceRafael Mendonça França2014-05-281-0/+19
|\ | | | | Ensure custom properties work correctly with inheritance
| * Ensure custom properties work correctly with inheritanceSean Griffin2014-05-281-0/+19
| |
* | Merge pull request #15370 from sgrif/sg-type-namespaceRafael Mendonça França2014-05-283-143/+131
|\ \ | |/ |/| Move types to the top level `ActiveRecord` namespace
| * Move types to the top level `ActiveRecord` namespaceSean Griffin2014-05-273-143/+131
| | | | | | | | | | `ActiveRecord::ConnectionAdapters::Type::Value` => `ActiveRecord::Type::Value`
* | Merge pull request #15387 from sgrif/sg-remove-column-coderSantiago Pastorino2014-05-281-20/+0
|\ \ | | | | | | Remove unused `Column#coder`
| * | Remove unused `Column#coder`Sean Griffin2014-05-281-20/+0
| |/ | | | | | | | | It appears this property was added, but never actually used. It would be broken if it were, as it only type casts one way.
* / pg, keep `hstore` and `json` attributes as `Hash` in @attributes.Yves Senn2014-05-282-0/+18
|/ | | | | | | | | | | The solution presented in this patch is not efficient. We should replace it in the near future. The following needs to be worked out: * Is `@attributes` storing the Ruby or SQL representation? * `cacheable_column?` is broken but `hstore` and `json` rely on that behavior Refs #15369. /cc @sgrif @rafaelfranca
* Add test case for clear mappingsAkshay Vishnoi2014-05-281-0/+10
|
* Test Case - Change method nameAkshay Vishnoi2014-05-281-1/+1
|
* Merge pull request #15371 from sgrif/sg-silence-deprecation-warningRafael Mendonça França2014-05-271-0/+3
|\ | | | | Silence deprecation warning in test
| * Silence deprecation warning in testSean Griffin2014-05-271-0/+3
| | | | | | | | Missed a case that only occured for mysql/mysql2
* | Merge pull request #14834 from al2o3cr/issue14155Aaron Patterson2014-05-271-0/+10
|\ \ | |/ |/| Correctly alias table names when joining more than once
| * WIP: pass existing joins to construct_join_dependencyMatt Jones2014-05-161-0/+10
| |
* | Merge pull request #15295 from sgrif/sg-deprecate-decimalsRafael Mendonça França2014-05-274-1/+13
|\ \ | | | | | | Deprecate decimal columns being automatically treated as integers
| * | Deprecate decimal columns being automatically treated as integersSean Griffin2014-05-274-1/+13
| | | | | | | | | | | | | | | | | | With ActiveRecord::Properties, we now have a reasonable path for users to continue to keep this behavior if they want it. This is an edge case that has added a lot of complexity to the code base.
* | | Fix redefine a has_and_belongs_to_many inside inherited classArthur Neves2014-05-271-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | After ad7b5efb55bcc2e0ccd3e7f22a81e984df8676d1, which changed how has_an_belongs_to_many used to work, we start raising an error when redefining the same has_an_belongs_to_many association. This commits fix that regression. [Fixes #14983]
* | | Fix syntax error from 5eae77cZachary Scott2014-05-261-1/+1
| | |
* | | Move test to the proper fileRafael Mendonça França2014-05-262-7/+7
| | | | | | | | | | | | All preload tests are in the eager_test file
* | | Add test case for b13d260Rafael Mendonça França2014-05-261-0/+9
|/ /
* | Add a public API to allow users to specify column typesSean Griffin2014-05-262-0/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As a result of all of the refactoring that's been done, it's now possible for us to define a public API to allow users to specify behavior. This is an initial implementation so that I can work off of it in smaller pieces for additional features/refactorings. The current behavior will continue to stay the same, though I'd like to refactor towards the automatic schema detection being built off of this API, and add the ability to opt out of automatic schema detection. Use cases: - We can deprecate a lot of the edge cases around types, now that there is an alternate path for users who wish to maintain the same behavior. - I intend to refactor serialized columns to be built on top of this API. - Gem and library maintainers are able to interact with `ActiveRecord` at a slightly lower level in a more stable way. - Interesting ability to reverse the work flow of adding to the schema. Model can become the single source of truth for the structure. We can compare that to what the database says the schema is, diff them, and generate a migration.
* | Merge pull request #15300 from arthurnn/refactor_reflectionsRafael Mendonça França2014-05-261-1/+6
|\ \ | | | | | | Refactor reflections
| * | Merge pull request #15210 from arthurnn/fix_hbtm_reflectionArthur Neves2014-05-241-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fix habtm reflection Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/counter_cache.rb activerecord/lib/active_record/reflection.rb activerecord/test/cases/reflection_test.rb
* | | Merge pull request #15336 from sgrif/sg-quotingMatthew Draper2014-05-272-20/+12
|\ \ \ | | | | | | | | Remove checks against `column.type` in abstract adapter quoting
| * | | Remove checks against `column.type` in abstract adapter quotingSean Griffin2014-05-262-20/+12
| | | | | | | | | | | | | | | | | | | | | | | | The intention is to eventually remove `column` from the arguments list both for `quote` and for `type_cast` entirely. This is the first step to that end.
* | | | Add missing test case for quoting behaviorSean Griffin2014-05-262-0/+11
|/ / / | | | | | | | | | | | | | | | | | | | | | It appears that the only time that `quote` is called with a column, but without first calling `type_cast` is when where is called with an array. My previous pull request broke this behavior, without failing tests. This adds a test for the only case I can think of that exercises the `if column.type == :integer` branch of `quote` effectively.
* | | Merge pull request #15307 from sgrif/sg-type-cast-for-writeYves Senn2014-05-261-1/+0
|\ \ \ | | | | | | | | Add an interface for type objects to control Ruby => SQL
| * | | Add an interface for type objects to control Ruby => SQLSean Griffin2014-05-261-1/+0
| |/ / | | | | | | | | | | | | Adds the ability to save custom types, which type cast to non-primitive ruby objects.
* / / remove unused variable warningKuldeep Aggarwal2014-05-261-1/+1
|/ / | | | | | | `warning: assigned but unused variable - album`
* | Merge pull request #15290 from sgrif/sg-consolidate-zero-scale-decimalRafael Mendonça França2014-05-231-6/+10
|\ \ | | | | | | Remove special case in schema dumper for decimal without scale
| * | Remove special case in schema dumper for decimal without scaleSean Griffin2014-05-231-6/+10
| | |
* | | Remove duplicated parameter check on #where!Sergey Alekseev2014-05-231-1/+1
|/ / | | | | | | | | | | | | | | | | | | It seems that #where! is not designed to be used as a chained where. See initial implementation at 8c2c60511beaad05a218e73c4918ab89fb1804f0. So, no need to check twice. We should not test #where! https://github.com/rails/rails/pull/15285#discussion_r13018316
* | Merge pull request #15282 from sgrif/sg-remove-column-primaryRafael Mendonça França2014-05-234-40/+5
|\ \ | | | | | | Remove `Column#primary`
| * | Remove `Column#primary`Sean Griffin2014-05-234-40/+5
| | | | | | | | | | | | | | | | | | | | | | | | It appears to have been used at some point in the past, but is no longer used in any meaningful way. Whether a column is considered primary is a property of the model, not the schema/column. This also removes the need for yet another layer of caching of the model's schema, and we can leave that to the schema cache.
* | | Merge pull request #15271 from sgrif/sg-remove-duplicated-setupRafael Mendonça França2014-05-231-4/+3
|\ \ \ | | | | | | | | Remove duplicated setup in test
| * | | Remove duplicated setup in testSean Griffin2014-05-231-4/+3
| |/ /
* | | Merge pull request #15274 from sgrif/sg-move-type-testsRafael Mendonça França2014-05-232-159/+159
|\ \ \ | | | | | | | | Change typecasting unit tests to test type objects directly
| * | | Change typecasting unit tests to test type objects directlySean Griffin2014-05-232-159/+159
| |/ / | | | | | | | | | | | | | | | There's no longer type casting behavior of any kind inside of `Column` for the general case. These tests can be made clearer by testing the type objects directly.
* | | Fixed serialization for records with an attribute named `format`.Godfrey Chan2014-05-223-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * * * This bug can be triggered when serializing record R (the instance) of type C (the class), provided that the following conditions are met: 1. The name of one or more columns/attributes on C/R matches an existing private method on C (e.g. those defined by `Kernel`, such as `format`). 2. The attribute methods have not yet been generated on C. In this case, the matching private methods will be called by the serialization code (with no arguments) and their return values will be serialized instead. If the method requires one or more arguments, it will result in an `ArgumentError`. This regression is introduced in d1316bb. * * * Attribute methods (e.g. `#name` and `#format`, assuming the class has columns named `name` and `format` in its database table) are lazily defined. Instead of defining them when a the class is defined (e.g. in the `inherited` hook on `ActiveRecord::Base`), this operation is deferred until they are first accessed. The reason behind this is that is defining those methods requires knowing what columns are defined on the database table, which usually requires a round-trip to the database. Deferring their definition until the last-possible moment helps reducing unnessary work, especially in development mode where classes are redefined and throw away between requests. Typically, when an attribute is first accessed (e.g. `a_book.format`), it will fire the `method_missing` hook on the class, which triggers the definition of the attribute methods. This even works for methods like `format`, because calling a private method with an explicit receiver will also trigger that hook. Unfortunately, `read_attribute_for_serialization` is simply an alias to `send`, which does not respect method visibility. As a result, when serializing a record with those conflicting attributes, the `method_missing` is not fired, and as a result the attribute methods are not defined one would expected. Before d1316bb, this is negated by the fact that calling the `run_callbacks` method will also trigger a call to `respond_to?`, which is another trigger point for the class to define its attribute methods. Therefore, when Active Record tries to run the `after_find` callbacks, it will also define all the attribute methods thus masking the problem. * * * The proper fix for this problem is probably to restrict `read_attribute_for_serialization` to call public methods only (i.e. alias `read_attribute_for_serialization` to `public_send` instead of `send`). This however would be quite risky to change in a patch release and would probably require a full deprecation cycle. Another approach would be to override `read_attribute_for_serialization` inside Active Record to force the definition of attribute methods: def read_attribute_for_serialization(attribute) self.class.define_attribute_methods send(attribute) end Unfortunately, this is quite likely going to cause a performance degradation. This patch therefore restores the behaviour from the 4-0-stable branch by explicitly forcing the class to define its attribute methods in a similar spot (when records are initialized). This should not cause any extra roundtrips to the database because the `@columns` should already be cached on the class. Fixes #15188.
* | | Don't recurse infinitely when calling non-existent method on superKris Kemper2014-05-221-0/+12
|/ /
* | Push limit to type objectsSean Griffin2014-05-221-3/+3
| | | | | | | | | | Columns and injected types no longer have any conditionals based on the format of SQL type strings! Hooray!
* | Merge pull request #15249 from sgrif/sg-register-types-in-adapterRafael Mendonça França2014-05-221-9/+1
|\ \ | | | | | | Use the generic type map for all PG type registrations
| * | Use the generic type map for all PG type registrationsSean Griffin2014-05-221-9/+1
| | | | | | | | | | | | | | | | | | | | | We're going to want all of the benefits of the type map object for registrations, including block registration and real aliasing. Moves type name registrations to the adapter, and aliases the OIDs to the named types
* | | Merge pull request #15248 from sgrif/sg-additional-type-map-argsRafael Mendonça França2014-05-221-0/+17
|\ \ \ | | | | | | | | Allow additional arguments to be used during type map lookups
| * | | Allow additional arguments to be used during type map lookupsSean Griffin2014-05-221-0/+17
| |/ / | | | | | | | | | | | | | | | | | | | | | Determining things like precision and scale in postgresql will require the given blocks to take additional arguments besides the OID. - Adds the ability to handle additional arguments to `TypeMap` - Passes the column type to blocks when looking up PG types
* | | pg test, extract tsvector tests into `postgresql/full_text_test.rb`Yves Senn2014-05-222-27/+31
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-09 23:23:02 +0000