aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | Don't map id to primary key in raw_write_attributeEugene Kenny2017-06-151-0/+6
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `raw_write_attribute` method is used to update a record's attributes to reflect the new state of the database in `update_columns`. The hash provided to `update_columns` is turned into an UPDATE query directly, which means passing an `id` key results in an update to the `id` column, even if the model uses a different attribute as its primary key. When updating the record, we don't want to apply the `id` column change to the primary key attribute, since that's not what happened in the query. Without the code to handle this case, `write_attribute_with_type_cast` no longer contains any logic shared between `raw_write_attribute` and `write_attribute`, so we can inline the code into those two methods.
* | | | | Merge pull request #29462 from ↵Rafael França2017-06-151-0/+6
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | kamipo/fix_dump_schema_information_with_empty_versions Fix `dump_schema_information` with empty versions
| * | | | | Fix `dump_schema_information` with empty versionsRyuta Kamizono2017-06-151-0/+6
| |/ / / / | | | | | | | | | | | | | | | Fixes #29460.
* | | | | Merge pull request #29453 from kamipo/add_test_case_for_28274Guillermo Iguaran2017-06-151-0/+46
|\ \ \ \ \ | |/ / / / |/| | | | Add test cases for #28274
| * | | | Add test cases for #28274Ryuta Kamizono2017-06-151-0/+46
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | `object.id` is correctly restored since #29378 has merged. Closes #28274, Closes #28395. [Ryuta Kamizono & Eugene Kenny]
* | | | Merge pull request #29409 from eugeneius/skip_test_uuid_column_defaultRafael França2017-06-151-1/+2
|\ \ \ \ | |/ / / |/| | | Allow `uuid_test.rb` to be loaded on all adapters
| * | | Allow `uuid_test.rb` to be loaded on all adaptersEugene Kenny2017-06-141-1/+2
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | Running `bin/test` from the activerecord directory produces this error: test/cases/adapters/postgresql/uuid_test.rb:43:in `<class:PostgresqlUUIDTest>': undefined method `supports_pgcrypto_uuid?' for #<ActiveRecord::ConnectionAdapters::SQLite3Adapter:0x007fc405e72a68> (NoMethodError) The test only actually runs on the PostgreSQL adapter; we can avoid triggering the error on other adapters with this `respond_to?` guard.
* | | Merge pull request #29378 from kamipo/avoid_overwriting_id_attribute_methodsRafael França2017-06-143-12/+21
|\ \ \ | | | | | | | | Avoid overwriting the methods of `AttributeMethods::PrimaryKey`
| * | | Avoid overwriting the methods of `AttributeMethods::PrimaryKey`Ryuta Kamizono2017-06-073-12/+21
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | Currently the methods of `AttributeMethods::PrimaryKey` are overwritten by `define_attribute_methods`. It will be broken if a table that customized primary key has non primary key id column. It should not be overwritten if a table has any primary key. Fixes #29350.
* | | Use `require_relative` instead of `require` with full pathbogdanvlviv2017-06-141-1/+1
| | |
* | | Add test for backward compatibility when using change_tableKoichi ITO2017-06-131-0/+15
|/ /
* | Merge pull request #28868 from yahonda/pg10_oid_unknown_to_textMatthew Draper2017-06-071-8/+8
|\ \ | | | | | | PostgreSQL 10 converts unknown type to text type
| * | PostgreSQL 10 converts unknown OID 705 to text 25Yasuo Honda2017-06-061-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Rename test cases from `unknown` to `unrecognized` since unknown OID is one of possible unrecognized types by Rails - Use "select 'pg_catalog.pg_class'::regclass" whose OID is 2205, which will not be converted to recognized type in PostgreSQL 10. activerecord_unittest=# select oid, typname from pg_type where oid in (2205, 2277); oid | typname ------+---------- 2205 | regclass 2277 | anyarray (2 rows) Addresses #28868
* | | Merge pull request #29362 from kamipo/remove_redundant_assert_nothing_raisedMatthew Draper2017-06-063-11/+0
|\ \ \ | | | | | | | | Remove redundant `assert_nothing_raised` before another assertions
| * | | Remove redundant `assert_nothing_raised` before another assertionsRyuta Kamizono2017-06-063-11/+0
| |/ / | | | | | | | | | These `assert_nothing_raised` are covered by following assertions.
* / / Fix `test_pluck_without_column_names` when using OracleKoichi ITO2017-06-061-2/+5
|/ /
* | Testing `ReservedWordTest` for all adaptersRyuta Kamizono2017-06-052-151/+132
| | | | | | | | | | `ReservedWordTest` expects that any identifiers are quoted properly. It should be tested for all adapters.
* | Remove assert_nothing_raised, as test is already testing the required concernsPrathamesh Sonpatki2017-06-031-3/+3
| |
* | Remove a redundant default_scope testsKoichi ITO2017-06-031-10/+0
| |
* | Merge pull request #29282 from ↵Eileen M. Uchitelle2017-06-022-1/+7
|\ \ | | | | | | | | | | | | kamipo/prevent_making_bind_param_if_casted_value_is_nil Prevent making bind param if casted value is nil
| * | Prevent making bind param if casted value is nilRyuta Kamizono2017-05-312-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | If casted value is nil, generated SQL should be `IS NULL`. But currently it is generated as `= NULL`. To prevent this behavior, avoid making bind param if casted value is nil. Fixes #28945.
* | | Remove the redundant `test_find_all_with_join` in ARKoichi ITO2017-06-021-10/+0
| | |
* | | Merge pull request #29308 from koic/correct_a_has_many_association_testMatthew Draper2017-06-022-1/+2
|\ \ \ | | | | | | | | Correct a has_many association test
| * | | Correct a has_many association testKoichi ITO2017-06-012-1/+2
| | | |
* | | | Simplify `assert_no_match %r{colname.*limit:}` regexRyuta Kamizono2017-06-011-14/+4
| | | | | | | | | | | | | | | | | | | | In `test_schema_dump_includes_limit_constraint_for_integer_columns`, unified `assert_match` and `assert_no_match` to simple regex.
* | | | Merge pull request #29220 from kamipo/consolidate_database_specific_json_typesMatthew Draper2017-06-014-56/+87
|\ \ \ \ | | | | | | | | | | Consolidate database specific JSON types to `Type::Json`
| * | | | Consolidate database specific JSON types to `Type::Json`Ryuta Kamizono2017-05-304-56/+87
| | | | |
* | | | | Merge pull request #29293 from kamipo/fix_sti_with_default_scopeMatthew Draper2017-06-011-1/+6
|\ \ \ \ \ | |_|/ / / |/| | | | Fix `default_scoped` with defined `default_scope` on STI model
| * | | | Fix `default_scoped` with defined `default_scope` on STI modelRyuta Kamizono2017-05-311-1/+6
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | This regression is caused by d1249c1. If STI model is defined `default_scope`, `base_rel` is not respected. I fixed to merge `base_rel` in that case.
* | | | Merge pull request #26634 from kamipo/extract_numeric_dataRafael França2017-05-315-86/+81
|\ \ \ \ | | | | | | | | | | Extract `NumericData` model for tests
| * | | | Restore the override of numeric attributes properlyRyuta Kamizono2016-12-221-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `attribute :world_population, :integer` is not a same with default decimal without scale type unless #26302 is merged. Should be `attribute :world_population, :big_integer` for now.
| * | | | Extract `NumericDataTest` to `test/cases/numeric_data_test.rb`Ryuta Kamizono2016-12-222-68/+71
| | | | | | | | | | | | | | | | | | | | | | | | | To ease to find the numeric data tests, extract `NumericDataTest` to `test/cases/numeric_data_test.rb` dedicated file.
| * | | | Extract `NumericData` model for testsRyuta Kamizono2016-09-274-19/+6
| | | | | | | | | | | | | | | | | | | | Currently `NumericData` model is defined some places.
* | | | | Add missing `delegate :extending, to: :all`Ryuta Kamizono2017-06-012-0/+8
| |/ / / |/| | |
* | | | Remove a redundant test case of HABTM_associations_testKoichi ITO2017-05-311-13/+0
| |/ / |/| |
* | | Add an extra test showing why collections are cachedMatthew Draper2017-05-301-0/+7
| | | | | | | | | | | | | | | The assert_same above obviously guarantees this will pass, but this seems less likely to be deleted just because the implementation changed.
* | | Merge pull request #29098 from kamipo/fix_association_with_extension_issuesMatthew Draper2017-05-305-2/+31
|\ \ \ | | | | | | | | | | | | Fix association with extension issues
| * | | Cache the association proxy objectRyuta Kamizono2017-05-281-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some third party modules expects that association returns same proxy object each time (e.g. for stubbing collection methods: https://github.com/rspec/rspec-rails/issues/1817). So I decided that cache the proxy object and reset scope in the proxy object each time. Related context: https://github.com/rails/rails/commit/c86a32d7451c5d901620ac58630460915292f88b#commitcomment-2784312
| * | | Fix association with extension issuesRyuta Kamizono2017-05-284-2/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following issues. * `association_scope` doesn't include `default_scope`. Should use `scope` instead. * We can't use `method_missing` for customizing existing method. * We can't use `relation_delegate_class` for sharing extensions. Should extend per association.
* | | | Merge pull request #29273 from ↵Rafael França2017-05-291-0/+11
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | kamipo/deserialize_raw_value_from_database_for_json Deserialize a raw value from the database in `changed_in_place?` for `AbstractJson`
| * | | | Deserialize a raw value from the database in `changed_in_place?` for ↵Ryuta Kamizono2017-05-301-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `AbstractJson` Structured type values sometimes caused representation problems (keys sort order, spaces, etc). A raw value from the database should be deserialized (normalized) to prevent the problems.
* | | | | Fix UUID column with `null: true` and `default: nil`Ryuta Kamizono2017-05-301-0/+10
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | `quote_default_expression` can be passed nil value when `null: true` and `default: nil`. This addressed in that case. Fixes #29222.
* | | | Merge pull request #29248 from yawboakye/rename-should-rename-table-pkeyGuillermo Iguaran2017-05-291-0/+23
|\ \ \ \ | | | | | | | | | | `rename_table` should rename primary key index name
| * | | | `rename_table` renames primary key index nameYaw Boakye2017-05-291-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Formerly, `rename_table` only renamed primary key index name if the column's data type was sequential (serial, etc in PostgreSQL). The problem with that is tables whose primary keys had other data types (e.g. UUID) maintained the old primary key name. So for example, if the `cats` table has a UUID primary key, and the table is renamed to `felines`, the primary key index will still be called `cats_pkey` instead of `felines_pkey`. This PR corrects it.
* | | | | Remove a redundant test assertionKoichi ITO2017-05-291-6/+0
|/ / / /
* | | | Merge pull request #29208 from ↵Guillermo Iguaran2017-05-281-0/+11
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | kamipo/default_env_fall_back_to_default_env_when_rails_env_or_rack_env_is_empty_string `DEFAULT_ENV` falls back to `default_env` when `RAILS_ENV` or `RACK_ENV` is an empty string
| * | | | `DEFAULT_ENV` falls back to `default_env` when `RAILS_ENV` or `RACK_ENV` is ↵Ryuta Kamizono2017-05-251-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | an empty string Follow up of #27399.
* | | | | Deprecate passing arguments and block at the same time to `count` and `sum` ↵Ryuta Kamizono2017-05-291-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in `ActiveRecord::Calculations` `select`, `count`, and `sum` in `Relation` are also `Enumerable` method that can be passed block. `select` with block already doesn't take arguments since 4fc3366. This is follow up of that.
* | | | | Merge pull request #29258 from koic/remove_redundant_command_recorder_testMatthew Draper2017-05-291-5/+0
|\ \ \ \ \ | | | | | | | | | | | | Remove a redundant test case of command_recorder_test
| * | | | | Remove a redundant test case of command_recorder_testKoichi ITO2017-05-291-5/+0
| | |/ / / | |/| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-07 23:18:25 +0000