aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* properly namespace the fixture exceptionAaron Patterson2012-03-221-1/+1
|
* Deprecate eager-evaluated scopes.Jon Leighton2012-03-2117-71/+97
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't use this: scope :red, where(color: 'red') default_scope where(color: 'red') Use this: scope :red, -> { where(color: 'red') } default_scope { where(color: 'red') } The former has numerous issues. It is a common newbie gotcha to do the following: scope :recent, where(published_at: Time.now - 2.weeks) Or a more subtle variant: scope :recent, -> { where(published_at: Time.now - 2.weeks) } scope :recent_red, recent.where(color: 'red') Eager scopes are also very complex to implement within Active Record, and there are still bugs. For example, the following does not do what you expect: scope :remove_conditions, except(:where) where(...).remove_conditions # => still has conditions
* Remove valid_scope_name? check - use rubyJon Leighton2012-03-211-19/+0
| | | | | | | scope is syntactic sugar for defining a class method. Ruby allows redefining methods but emits a warning when run with -w. So let's not implement our own logic for this. Users should run with -w if they want to be warned about redefined methods.
* changed all.map to pluckSandeep2012-03-191-1/+1
|
* Merge pull request #3329 from armstrjare/autosave_collection_new_record_bugJosé Valim2012-03-181-0/+10
|\ | | | | Autosave association doesn't save all records on a new record for a collection association if there are records marked for destruction
| * Fix bug with autosave collection association on new record with a marked for ↵Jared Armstrong2012-03-181-0/+10
| | | | | | | | destroy record in autosave collection.
* | Fix typo in ActiveRecord::Relation#blank? testRuben Davila2012-03-171-1/+1
| |
* | Merge pull request #5321 from pfeiffer/uniqueness_validator_conditionsJosé Valim2012-03-171-0/+12
|\ \ | | | | | | Add :conditions option to uniqueness validator
| * | Change syntax to accept an AR::Relation instead of old conditions hash/array.Mattias Pfeiffer2012-03-071-1/+1
| | |
| * | Add :conditions option to uniqueness validatorMattias Pfeiffer2012-03-071-0/+12
| | |
* | | Fix ActiveRecord::Relation#blank? testsRafael Mendonça França2012-03-161-12/+15
| | |
* | | Merge pull request #5469 from yakko/masterJosé Valim2012-03-161-0/+19
|\ \ \ | |_|/ |/| | tests for Relation .present? .blank?
| * | test relation presence fixThiago Almeida2012-03-161-4/+4
| | |
| * | tests for Relation .present? and .blank? are check cases and shouldn't force ↵Thiago Almeida2012-03-161-0/+19
| | | | | | | | | | | | sql-count
* | | Merge pull request #5327 from kennyj/fix_explicitly_inheraitance_columnAaron Patterson2012-03-151-0/+10
|\ \ \ | |/ / |/| | Don't reset inheritance_column when setting explicitly.
| * | Don't reset inheritance_column when setting explicitly.kennyj2012-03-081-0/+10
| |/
* | Address the dump file format for hstoreYasuo Honda2012-03-151-1/+1
| |
* | Fix GH #5430. A Payload name for schema_search_path should be SCHEMA.kennyj2012-03-151-0/+7
| |
* | Remove IdentityMapCarlos Antonio da Silva2012-03-1312-695/+23
| |
* | Fix GH #5399. connection_pools's keys are ↵kennyj2012-03-141-1/+7
| | | | | | | | ActiveRecord::Base::ConnectionSpecification objects.
* | make sure connections returned after close are marked as in_useAaron Patterson2012-03-121-0/+10
| |
* | Add dynamic find_or_create_by_{attribute}! method.Andrew White2012-03-124-0/+52
| |
* | fix activerecord query_method regression with offset into FixnumDenis Jean2012-03-121-0/+4
| | | | | | | | | | | | add test to show offset query_methods on mysql & mysql2 change test to cover public API
* | In AR depths use &:to_i before :uniq to process mixed arrays likes ["1", 1] ↵Alexey Vakhov2012-03-091-0/+7
| | | | | | | | correct
* | ensure that released connections move between threadsAaron Patterson2012-03-081-0/+18
| |
* | make active_connection? return true only if there is an open connection in ↵Aaron Patterson2012-03-081-0/+35
| | | | | | | | use for the current thread. fixes #5330
* | Merge pull request #5306 from kennyj/fix_69c7f02José Valim2012-03-082-2/+2
|\ \ | | | | | | Change the message string to use in test case.
| * | Change the string to use in test case.kennyj2012-03-072-2/+2
| |/
* | Merge pull request #5289 from rafaelfranca/fix-through-associationsJon Leighton2012-03-084-4/+33
|\ \ | | | | | | Fix has_many through associations when mass_assignment_sanitizer is strict
| * | Not need to pass join attributes to association buildRafael Mendonça França2012-03-073-12/+11
| | |
| * | Add test case to has_many through association when mass_assignment_sanitizer isRafael Mendonça França2012-03-054-4/+34
| |/ | | | | | | :strict
* | Merge pull request #5162 from kennyj/schema_cache_dumpAaron Patterson2012-03-071-0/+15
|\ \ | | | | | | [Proposal] Schema cache dump
| * | Add support schema cache dump and load.kennyj2012-03-011-0/+15
| | |
* | | Add tests to test that through associations are not readonly, and we can ↵kuahyeow2012-03-081-0/+11
| | | | | | | | | | | | update the records we retrive from the association
* | | Merge pull request #5315 from ↵Aaron Patterson2012-03-071-2/+41
|\ \ \ | | | | | | | | | | | | | | | | travisjeffery/enhance_postgresql_adapter_schema_support Enhance PostgreSQL Adapter schema support
| * | | Adds #create/drop_schema on the PostgreSQL Adapter.Travis Jeffery2012-03-071-2/+37
| | | |
| * | | Add #schema_names to PostgreSQL Adapter.Travis Jeffery2012-03-071-0/+4
| | | |
* | | | attribute_present? should return false for empty stringsJacob Green2012-03-061-0/+3
| |_|/ |/| |
* | | Fix #5069 - Protect foreign key from mass assignment throught association ↵Jean Boussier2012-03-052-0/+38
| | | | | | | | | | | | builder
* | | Merge pull request #5274 from tigrish/masterJosé Valim2012-03-051-0/+19
|\ \ \ | | | | | | | | Update I18n defaults for activerecord.errors.messages.record_invalid
| * | | Tweak ↵Christopher Dell2012-03-051-1/+2
| | | | | | | | | | | | | | | | activerecord/test/cases/validations/i18n_generate_message_validation_test.rb
| * | | Test that RecordInvalid exception's translation falls back to the :errors ↵Christopher Dell2012-03-051-0/+18
| | | | | | | | | | | | | | | | namespace
* | | | Fix message assertions for quoting database name in "show tables" for mysqlCarlos Antonio da Silva2012-03-042-2/+2
|/ / /
* | | Merge pull request #5268 from carlosantoniodasilva/ar-new-record-warningJon Leighton2012-03-041-0/+9
|\ \ \ | | | | | | | | Fix ActiveRecord warning in tests with Marshal
| * | | Initialize @stale_state to nil in associationCarlos Antonio da Silva2012-03-041-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This apparently fix the warning related to @new_record variable not being initialized in AR's test suit, when an association is built and the object is marshalled/loaded. See these tests in AR's base_test.rb: test_marshalling_with_associations test_marshalling_new_record_round_trip_with_associations Closes #3720.
| * | | Added test case for new_record round trip with associations problemkennyj2012-03-041-0/+14
| |/ /
* | | Merge pull request #5267 from kennyj/fix_4674Jon Leighton2012-03-041-0/+24
|\ \ \ | | | | | | | | Fix GH #4674. Reset column information and sequence name when setting table_name.
| * | | Don't clear sequence name when we explicitly assign it.kennyj2012-03-041-0/+11
| | | |
| * | | Fix GH #4674. Reset column information and sequence name when setting ↵kennyj2012-03-041-0/+13
| | | | | | | | | | | | | | | | table_name.
* | | | Fix GH #3163. Should quote database on mysql/mysql2.kennyj2012-03-052-0/+21
|/ / /
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-30 19:17:01 +0000