aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | Fix update counters of multiple records with touch: trueRyuta Kamizono2017-01-031-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently does not work the following example in the doc: ```ruby # For the Posts with id of 10 and 15, increment the comment_count by 1 # and update the updated_at value for each counter. Post.update_counters [10, 15], comment_count: 1, touch: true # Executes the following SQL: # UPDATE posts # SET comment_count = COALESCE(comment_count, 0) + 1, # `updated_at` = '2016-10-13T09:59:23-05:00' # WHERE id IN (10, 15) ```
* | | | | | | Remove duplicated testutilum2017-01-021-8/+0
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | b8f74860b61782e3b949ade3bb51bff40899e89b provided a nicer version of `#test_structure_load` but the old version was not removed.
* | | | | | Merge pull request #27526 from kirs/database-tasks-schema-cacheRafael França2017-01-011-0/+10
|\ \ \ \ \ \ | | | | | | | | | | | | | | Dump schema cache for custom connection
| * | | | | | Dump schema cache for custom connectionKir Shatrov2017-01-011-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Today `rake db:schema:cache:dump` only supports dumping cache for a single connection (`ActiveRecord::Base.connection`). This doesn't work for apps with multiple databases. This PR makes `DatabaseTasks` to provide an API for dumping schema cache for any connection.
* | | | | | | Replace sleep with synchronizationMatthew Draper2017-01-022-2/+8
| | | | | | |
* | | | | | | Fix tests with counter cache touching and more.Kasper Timm Hansen2017-01-011-84/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Refactor to use `touch_updates` Ensures we only call `current_time_from_proper_timezone` from one place. * Clarify touch default in tests. Not interested in what happens when passed false but that nothing passed means no touching. * Backdate touched columns in tests. We can't be sure a test progresses through time, so our touching code may be working correctly but the test itself is brittle. Fix by backdating that's further in the past akin to what the timestamps tests do: https://github.com/rails/rails/blob/d753645d40e925973724e4c3a8617b654da90e41/activerecord/test/cases/timestamp_test.rb#L17 * Expand changelog entry. Elaborate and show examples. Closes #26995. [ Jarred Trost & Kasper Timm Hansen ]
* | | | | | | Added option to ActiveRecord::CounterCache methods.Jarred Trost2017-01-011-0/+141
| | | | | | |
* | | | | | | Change `timestamp_attributes_for_{create,update}` from symbol to stringRyuta Kamizono2017-01-011-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `timestamp_attributes_for_{create,update}` is defined as symbol but always used as string with `to_s`. This allocates extra strings. To avoid extra allocation, change the definitions from symbol to string. ```ruby pp ObjectSpace::AllocationTracer.trace { 1_000.times { |i| Post.create! } } ``` Before: ``` ["~/rails/activerecord/lib/active_record/timestamp.rb", 121]=>[1002, 0, 750, 0, 1, 18528], ["~/rails/activerecord/lib/active_record/timestamp.rb", 105]=>[1002, 0, 750, 0, 1, 7720], ["~/rails/activerecord/lib/active_record/timestamp.rb", 101]=>[1002, 0, 750, 0, 1, 7720], ["~/rails/activerecord/lib/active_record/timestamp.rb", 109]=>[1002, 0, 750, 0, 1, 13896], ["~/rails/activerecord/lib/active_record/timestamp.rb", 61]=>[4008, 0, 3000, 0, 1, 30880], ``` After: ``` ["~/rails/activerecord/lib/active_record/timestamp.rb", 120]=>[1000, 0, 756, 0, 1, 17184], ["~/rails/activerecord/lib/active_record/timestamp.rb", 104]=>[1000, 0, 756, 0, 1, 7160], ["~/rails/activerecord/lib/active_record/timestamp.rb", 100]=>[1000, 0, 756, 0, 1, 7160], ["~/rails/activerecord/lib/active_record/timestamp.rb", 108]=>[1000, 0, 756, 0, 1, 12888], ```
* | | | | | | Dump array subtype options correctlyRyuta Kamizono2017-01-011-3/+5
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | Currently schema dumper does not dump array subtype `precision` and `scale` options. This commit fixes the issue.
* | | | | | Remove deprecated `#uniq`, `#uniq!`, and `#uniq_value`Ryuta Kamizono2016-12-304-33/+1
| | | | | |
* | | | | | Remove deprecated `#insert_sql`, `#update_sql`, and `#delete_sql`Ryuta Kamizono2016-12-301-6/+0
| | | | | |
* | | | | | Remove deprecated #use_transactional_fixtures configurationRafael Mendonça França2016-12-291-18/+0
| | | | | |
* | | | | | Remove deprecated conditions parameter from #delete_allRafael Mendonça França2016-12-291-6/+0
| | | | | |
* | | | | | Remove deprecated conditions parameter from `#destroy_all`Rafael Mendonça França2016-12-291-6/+0
| | | | | |
* | | | | | Remove deprecated support to passing arguments to `#select` when a block is ↵Rafael Mendonça França2016-12-291-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | provided.
* | | | | | Remove deprecated support to query using commas on LIMITRafael Mendonça França2016-12-291-12/+2
| | | | | |
* | | | | | Remove deprecated support to passing a class as a value in a queryRafael Mendonça França2016-12-291-9/+0
| | | | | |
* | | | | | Raises IrreversibleOrderError when using last with an irreversible orderRafael Mendonça França2016-12-291-1/+1
| | | | | |
* | | | | | Raise when a through association has an ambiguous reflection nameRafael Mendonça França2016-12-291-1/+1
| | | | | |
* | | | | | Raises when `ActiveRecord::Migration` is inherited directly.Rafael Mendonça França2016-12-291-12/+6
| | | | | |
* | | | | | `#tables` and `#table_exists?` and returns only tables and not viewsRafael Mendonça França2016-12-2910-84/+61
| | | | | |
* | | | | | Remove deprecated `name` argument from `#tables`Rafael Mendonça França2016-12-293-8/+2
| | | | | |
* | | | | | Remove deprecated support to passing a column to #quoteRafael Mendonça França2016-12-291-12/+12
| | | | | |
* | | | | | Set time as a timezone aware type and remove related deprecationRafael Mendonça França2016-12-291-3/+0
| | | | | |
* | | | | | Remove deprecated force reload argument in association readersRafael Mendonça França2016-12-296-47/+4
| | | | | |
* | | | | | Remove deprecated i18n scopes in Active RecordRafael Mendonça França2016-12-292-39/+0
| | | | | |
* | | | | | Merge pull request #27437 from kirs/structure-load-dump-flagsKasper Timm Hansen2016-12-293-4/+81
|\ \ \ \ \ \ | | | | | | | | | | | | | | Make ActiveRecord structure load/dump configurable
| * | | | | | Make ActiveRecord structure load/dump configurableKir Shatrov2016-12-223-4/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this patch it's impossible to pass extra flags to mysqldump/pg_dump when running `rake db:structure:dump` or `load` The following config variables (`structure_load_flags` and `structure_dump_flags`) make it better configurable.
* | | | | | | Should not update children when the parent creation with no reasonRyuta Kamizono2016-12-293-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This issue was introduced with d849f42 to solve #19782. However, we can solve #19782 without causing the issue. It is enough to save only when necessary. Fixes #27338.
* | | | | | | Fix Rubocop violations and fix documentation visibilityRafael Mendonça França2016-12-282-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some methods were added to public API in 5b14129d8d4ad302b4e11df6bd5c7891b75f393c and they should be not part of the public API.
* | | | | | | Merge pull request #27442 from kamipo/fix_27434Eileen M. Uchitelle2016-12-271-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Add a record to target before any callbacks loads the record
| * | | | | | | Add a record to target before any callbacks loads the recordRyuta Kamizono2016-12-231-1/+1
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `append_record` was added at 15ddd51 for not double adding the record. But adding `append_record` (checking `@target.include?(record)`) caused performance regression #27434. Instead of checking not double adding the record, add a record to target before any callbacks loads the record. Fixes #27434.
* | | | | | | assert_equal takes expectation firstAkira Matsuda2016-12-268-19/+19
| | | | | | |
* | | | | | | "Use assert_nil if expecting nil from ...:in `...'. This will fail in MT6."Akira Matsuda2016-12-254-10/+10
| |_|_|_|/ / |/| | | | |
* | | | | | "Use assert_nil if expecting nil. This will fail in minitest 6."Akira Matsuda2016-12-2522-77/+77
| | | | | |
* | | | | | Privatize unneededly protected methods in Active Record testsAkira Matsuda2016-12-2411-11/+11
|/ / / / /
* | | | | fix #create_fixtures when equal table names in different databasesJulia Lopez2016-12-215-0/+25
| | | | |
* | | | | Merge pull request #27400 from kamipo/remove_useless_test_supports_primary_keyEileen M. Uchitelle2016-12-191-6/+0
|\ \ \ \ \ | | | | | | | | | | | | Remove useless `test_supports_primary_key`
| * | | | | Remove useless `test_supports_primary_key`Ryuta Kamizono2016-12-191-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `supports_primary_key?` method is defined in `AbstractAdapter` so does not raise any errors.
* | | | | | Consolidate duplicated elsif branchRyuta Kamizono2016-12-191-6/+1
|/ / / / /
* | | | | Merge pull request #27329 from kamipo/simplify_unsigned_regexEileen M. Uchitelle2016-12-171-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Simplify the regex for `unsigned?` method
| * | | | | Simplify the regex for `unsigned?` methodRyuta Kamizono2016-12-111-1/+1
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | It is enough to distinguish only the trailing `unsigned` and `unsigned zerofill`.
* | | | | Merge pull request #27375 from kirs/fixture-error-messageRafael França2016-12-162-2/+15
|\ \ \ \ \ | | | | | | | | | | | | Throw friendly error message when fixture is not a hash
| * | | | | Throw friendly error message when fixture is not a hashKir Shatrov2016-12-152-2/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Right now, when fixture is not a Hash we throw an error message saying "fixture is not a hash". This is not very user friendly because it's not saying which fixture is invalid.
* | | | | | fix QueryCache nil dupRichard Monette2016-12-152-2/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | make sql statements frozen dup if arel is not our string expect runtime error dont wrap runtime error in invalid log errors will now be treated as runtime errors update changelog
* | | | | | fix new warning in ruby 2.4yuuji.yaginuma2016-12-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following warning. ``` test/caching_test.rb:986: warning: parentheses after method name is interpreted as test/caching_test.rb:986: warning: an argument list, not a decomposed argument test/cases/adapters/mysql2/reserved_word_test.rb:146: warning: parentheses after method name is interpreted as test/cases/adapters/mysql2/reserved_word_test.rb:146: warning: an argument list, not a decomposed argument ``` Ref: https://github.com/ruby/ruby/commit/65e27c8b138d6959608658ffce2fa761842b8d24
* | | | | | Merge pull request #27042 from kirs/yaml-schema-cacheRafael França2016-12-132-4/+384
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Schema cache in YAML
| * | | | | Use YAML to serialize schema cacheKir Shatrov2016-11-272-4/+384
| | | | | |
* | | | | | Remove duplicated lineRyuta Kamizono2016-12-111-1/+0
| |_|/ / / |/| | | |
* | | | | Fix CI failure caused by #25227 and #25280 were merged at the same timeRyuta Kamizono2016-12-101-1/+1
| |/ / / |/| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 08:47:59 +0000