Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Add `create_join_table` migration helper to create HABTM join tables | Rafael Mendonça França | 2012-01-27 | 3 | -1/+82 |
| | |||||
* | Fix regression from Rails 3.1 | Paul McMahon | 2012-01-27 | 1 | -0/+11 |
| | | | | | | Under Rails 3.1, you were allowed to pass a hash to a find_or_create method with multiple attribute names, but this was broken as the arguments were being improperly validated. | ||||
* | Merge pull request #4696 from rafaelfranca/issue-4653 | Aaron Patterson | 2012-01-26 | 1 | -2/+0 |
| | | | | Remove extra attributes from HABTM join tables in AR tests | ||||
* | disable automatic explain if there is no logger [closes #4671] | Xavier Noria | 2012-01-26 | 1 | -1/+15 |
| | |||||
* | fix fixtures test as table_name is a string now | Sergey Nartimov | 2012-01-26 | 1 | -2/+2 |
| | |||||
* | call to_s on value passed to table_name= | Sergey Nartimov | 2012-01-26 | 1 | -0/+5 |
| | |||||
* | The primary key is always initialized in the @attributes hash to nil (unless | Aaron Patterson | 2012-01-25 | 2 | -2/+3 |
| | | | | another value has been specified). | ||||
* | Handle nil in add_index :length option in MySQL | Paul Sadauskas | 2012-01-24 | 1 | -1/+7 |
| | | | | | | | | | | | | | | | | | Our schema.rb is being generated with an `add_index` line similar to this: add_index "foo", ["foo", "bar"], :name => "xxx", :length => {"foo"=>8, "bar=>nil} This is the same as it was on Rails 3.1.3, however, now when that schema.rb is evaluated, its generating bad SQL in MySQL: Mysql::Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '))' at line 1: CREATE UNIQUE INDEX `xxx` ON `foo` (`foo`(8), `bar`()) This commit adds a check for nil on the length attribute to prevent the empty parens from being output. | ||||
* | Moving AR::TestCase in to the AR tests directory | Aaron Patterson | 2012-01-24 | 2 | -1/+64 |
| | |||||
* | Merge pull request #4558 from stephencelis/type-cast-unknown-should-fail | Aaron Patterson | 2012-01-23 | 2 | -7/+5 |
|\ | | | | | Don't type-cast unknown types to YAML. | ||||
| * | Don't type-cast unknown types to YAML. | Stephen Celis | 2012-01-20 | 2 | -7/+5 |
| | | |||||
* | | Fix typo | Jari Jokinen | 2012-01-22 | 1 | -1/+1 |
| | | |||||
* | | change AR default_timezone to :utc since it's the default for AR::Railtie | Akira Matsuda | 2012-01-21 | 1 | -2/+2 |
|/ | |||||
* | Fix another race condition. | Jon Leighton | 2012-01-20 | 1 | -0/+8 |
| | | | | | | From 2c667f69aa2daac5ee6c29ca9679616e2a71532a. Thanks @pwnall for the heads-up. | ||||
* | adding tests for previous_changes hash | Aaron Patterson | 2012-01-19 | 1 | -0/+25 |
| | |||||
* | Add ActiveRecord::Base#with_lock | Olek Janiszewski | 2012-01-18 | 1 | -0/+20 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a `with_lock` method to ActiveRecord objects, which starts a transaction, locks the object (pessimistically) and yields to the block. The method takes one (optional) parameter and passes it to `lock!`. Before: class Order < ActiveRecord::Base def cancel! transaction do lock! # ... cancelling logic end end end After: class Order < ActiveRecord::Base def cancel! with_lock do # ... cancelling logic end end end | ||||
* | Merge pull request #4487 from sarenji/fix-reset-counters | Aaron Patterson | 2012-01-17 | 6 | -2/+43 |
|\ | | | | | Fix bug where reset_counters resets the wrong counter cache. | ||||
| * | Fix bug where reset_counters resets the wrong counter cache. | David Peter | 2012-01-16 | 6 | -2/+43 |
| | | | | | | | | | | | | | | | | If a model belongs_to two associations with the same class, then reset_counters will reset the wrong counter cache. Finding the right reflection should use the foreign_key instead, which should be unique. | ||||
* | | disable transactions for this test | Aaron Patterson | 2012-01-17 | 1 | -1/+4 |
| | | |||||
* | | validate related records in the same validation context as parent. | Emmanuel Oga | 2012-01-17 | 1 | -0/+17 |
|/ | | | | | | | | | | | | | | | | | | | | E.G.: ```ruby class Parent < ActiveRecord::Base has_one :child validates_presence_of :name, :on => "custom_context" validates_associated :child end class Child < ActiveRecord::Base belongs_to :parent validates_presence_of :name, :on => "custom_context" end p = Parent.new(:name => "Montoto", :child => Child.new) p.valid?(:custom_context) # => Returns true, even though the child is not valid under the same context. ``` | ||||
* | stop more ddl changes | Aaron Patterson | 2012-01-16 | 2 | -14/+16 |
| | |||||
* | stop ddl modifications for another test | Aaron Patterson | 2012-01-16 | 2 | -12/+10 |
| | |||||
* | use one based indexes for the mock migrations | Aaron Patterson | 2012-01-16 | 1 | -16/+16 |
| | |||||
* | stop making ddl changes for migrator tests | Aaron Patterson | 2012-01-16 | 2 | -67/+78 |
| | |||||
* | actually use the variable I created. :bomb: thanks @exviva | Aaron Patterson | 2012-01-16 | 1 | -1/+1 |
| | |||||
* | move another migrator to use sensors | Aaron Patterson | 2012-01-16 | 2 | -12/+18 |
| | |||||
* | Deprecate inferred JOINs with includes + SQL snippets. | Jon Leighton | 2012-01-16 | 18 | -59/+157 |
| | | | | | | See the CHANGELOG for details. Fixes #950. | ||||
* | infer references from Relation#order | Jon Leighton | 2012-01-16 | 1 | -1/+21 |
| | |||||
* | store references as a string | Jon Leighton | 2012-01-16 | 2 | -6/+6 |
| | |||||
* | automatically add references when we can | Jon Leighton | 2012-01-16 | 1 | -0/+14 |
| | |||||
* | Make referencing an included item trigger eager loading | Jon Leighton | 2012-01-16 | 1 | -0/+11 |
| | |||||
* | Add ActiveRecord::Relation#references (#950) | Jon Leighton | 2012-01-16 | 1 | -1/+14 |
| | |||||
* | Revert "Deprecate implicit eager loading. Closes #950." | Jon Leighton | 2012-01-16 | 21 | -162/+94 |
| | | | | This reverts commit c99d507fccca2e9e4d12e49b4387e007c5481ae9. | ||||
* | moving verbosity tests to the migrator test, removing ddl changes | Aaron Patterson | 2012-01-16 | 2 | -18/+24 |
| | |||||
* | silencing migrator tests, refactoring the migration test helper | Aaron Patterson | 2012-01-16 | 3 | -22/+11 |
| | |||||
* | fix tests on sqlite3 | Aaron Patterson | 2012-01-16 | 1 | -0/+4 |
| | |||||
* | prefer method sensors over actual ddl changes | Aaron Patterson | 2012-01-16 | 2 | -69/+84 |
| | |||||
* | testing the current version method | Aaron Patterson | 2012-01-16 | 1 | -1/+26 |
| | |||||
* | test that migrations have connections, and method missing delegates | Aaron Patterson | 2012-01-16 | 1 | -7/+16 |
| | |||||
* | making sure the temp connection and the real connection are different after dup | Aaron Patterson | 2012-01-16 | 1 | -3/+3 |
| | |||||
* | Merge pull request #4480 from lest/use-rack-body-proxy | José Valim | 2012-01-16 | 3 | -16/+14 |
|\ | | | | | Use Rack::BodyProxy | ||||
| * | use Rack::BodyProxy in activerecord middlewares | Sergey Nartimov | 2012-01-16 | 3 | -16/+14 |
| | | |||||
* | | Try to create schema migrations table in schema dumper test | Piotr Sarnacki | 2012-01-16 | 1 | -0/+5 |
| | | |||||
* | | Fix ActiveRecord mysql tests | Piotr Sarnacki | 2012-01-16 | 1 | -1/+2 |
|/ | | | | | | | | | TL;DR: MySQL sucks. Since it does not support transactions for schema changes, when you run `create_table` in setup block, it will commit current transaction. Now tests want to run `RELEASE SAVEPOINT` after finishing tests which fails since there is no transaction. | ||||
* | make sure the migration table is alive and empty | Aaron Patterson | 2012-01-13 | 1 | -0/+11 |
| | |||||
* | refactor schema migration table creation to the schema migration model | Aaron Patterson | 2012-01-13 | 1 | -0/+1 |
| | |||||
* | stop depending on the filesystem for interleaved migration tests | Aaron Patterson | 2012-01-13 | 8 | -84/+49 |
| | |||||
* | refactor the migrate method to filter migrations before running them | Aaron Patterson | 2012-01-13 | 1 | -1/+1 |
| | |||||
* | move schema dumper tests to the correct class | Aaron Patterson | 2012-01-13 | 2 | -9/+10 |
| | |||||
* | move another migrator test, use schema migration model | Aaron Patterson | 2012-01-13 | 2 | -10/+9 |
| |