aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Raise MissingAttributeError on query methodsErnie Miller2012-09-081-0/+1
| | | | | | | | | | | | | When calling a query method on an attribute that was not selected by an ActiveRecord query, an ActiveModel::MissingAttributeError is not raised. Instead, a nil value is returned, which will return false once cast to boolean. This is undesirable, as we should not give the impression that we know the attribute's boolean value when we haven't loaded the attribute's (possibly) non-boolean value from the database. This issue is present on versions going back as far as 2.3, at least.
* Dump schema using new style hashKonstantin Shabanov2012-09-081-44/+44
|
* Merge pull request #7545 from senny/7518_postgres_type_detectionAaron Patterson2012-09-072-2/+5
|\ | | | | postgres, map scaled intervals to string datatype
| * postgres, map scaled intervals to string datatype (#7518)Yves Senn2012-09-062-2/+5
| |
* | Fix AR tests due to builder change with nil values / empty stringsCarlos Antonio da Silva2012-09-071-6/+6
| | | | | | | | | | Check 0180e090ab6cbe66f7b521a0c03e278a0463accd for more reasoning about that.
* | Merge pull request #4976 from kreynolds/fix_eager_without_pkeyJon Leighton2012-09-071-0/+8
|\ \ | |/ |/| Fix eagerly loading associations without primary keys
| * Change JoinPart test from an integration to a unit testKelley Reynolds2012-07-052-13/+8
| |
| * Fix eagerly loading associations without primary keysKelley Reynolds2012-02-091-0/+13
| |
* | Put the create_table block in a transaction.Rafael Mendonça França2012-09-051-2/+4
| | | | | | | | | | This will solve the issue that abort the connection transaction when we skip the tests.
* | ActiveRecord support to PostgreSQL 9.2 JSON typeDickson S. Guedes2012-09-053-1/+86
| | | | | | | | | | | | | | | | | | This implements the support to encode/decode JSON data to/from database and creating columns of type JSON using a native type [1] supported by PostgreSQL from version 9.2. [1] http://www.postgresql.org/docs/9.2/static/datatype-json.html
* | Merge pull request #7532 from al2o3cr/fix_store_bugsRafael Mendonça França2012-09-052-2/+9
|\ \ | | | | | | correct handling of changes in AR::Store, combine multiple store_accessors
| * | correctly flag changed attributes in AR::Store, combine multiple calls to ↵Matt Jones2012-09-052-2/+9
| | | | | | | | | | | | store_accessor
* | | Merge pull request #7536 from pivotal/fix_pluck_with_reserved_wordsRafael Mendonça França2012-09-053-2/+16
|\ \ \ | | | | | | | | Fix pluck when columns/tables are reserved words.
| * | | Fix pluck when columns/tables are reserved words.Ian Lesperance2012-09-053-2/+16
| | | |
* | | | Merge pull request #7525 from ↵Rafael Mendonça França2012-09-051-5/+2
|\ \ \ \ | |/ / / |/| | | | | | | | | | | seamusabshere/use-mysql-binary-for-rake-db-structure-load Use the 'mysql' binary for 'rake db:structure:load'
| * | | Use the 'mysql' binary for 'rake db:structure:load'.Seamus Abshere2012-09-051-5/+2
| |/ / | | | | | | | | | The previous implementation had the strange requirement that db/structure.sql contain only CREATE TABLE sql statements, one per table, separated by double newlines. SQLite3 and PostgreSQL database tasks, on the other hand, simply spawn 'sqlite3' and 'psql' binaries to load the file directly. The new implementation follows this and attempts to respect all current MySQL configuration settings.
* | | Merge pull request #7337 from adzap/string_to_dummy_timeRafael Mendonça França2012-09-051-0/+12
|\ \ \ | | | | | | | | Fix for time type columns with invalid time value
| * | | Fix for time type columns with invalid timeAdam Meehan2012-09-051-0/+12
| |/ / | | | | | | | | | | | | | | | The string_to_dummy_time method was blindly parsing the dummy time string with Date._parse which returns a hash for the date part regardless of whether the time part is an invalid time string.
* | | Merge pull request #7447 from etehtsea/postgresql-adapterRafael Mendonça França2012-09-051-3/+0
|\ \ \ | |/ / |/| | Modularize postgresql adapter
| * | Modularize postgresql adapterKonstantin Shabanov2012-09-051-3/+0
| | |
* | | test cleanup, remove ruby_type because it's no longer neededYves Senn2012-09-037-16/+5
| | | | | | | | | | | | | | | All tests with a custom inheritance_column use the `Vegtable` model. The field ruby_type on the Company models is no longer needed
* | | rewrite inheritance tests with a custom inheritance_columnYves Senn2012-09-034-49/+61
| | | | | | | | | | | | | | | | | | previously the tests with and without a custom `inheritance_column` used the same models. Since the model then has both fields this can lead to false positives.
* | | set the configured #inheritance_column on #become (#7503)Yves Senn2012-09-034-1/+37
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | I had to create a new table because I needed an STI table, which does not have both a "type" and a "custom_type" the test fails with: 1) Error: test_alt_becomes_works_with_sti(InheritanceTest): NoMethodError: undefined method `type=' for #<Cabbage id: 1, name: "my cucumber", custom_type: "Cucumber"> /Users/username/Projects/rails/activemodel/lib/active_model/attribute_methods.rb:432:in `method_missing' /Users/username/Projects/rails/activerecord/lib/active_record/attribute_methods.rb:100:in `method_missing' /Users/username/Projects/rails/activerecord/lib/active_record/persistence.rb:165:in `becomes' test/cases/inheritance_test.rb:134:in `test_becomes_works_with_sti' test/cases/inheritance_test.rb:140:in `test_alt_becomes_works_with_sti'
* | Key the attributes hash with symbolsJon Leighton2012-08-311-2/+2
| | | | | | | | | | | | | | | | This is a performance/GC optimisation. In theory, this could be optimised by the implementation (last time I checked, this would have no effect on JRuby). But in practise, this make attribute access faster.
* | Cache the connection pool for a given classJon Leighton2012-08-311-0/+2
| |
* | Make connection pool retrieval fasterJon Leighton2012-08-311-9/+4
| | | | | | | | | | | | * Loop rather than recurse in retrieve_connection_pool * Key the hash by class rather than class name. This avoids creating unnecessary strings.
* | Add a test to make sure preloading properly merges association and default ↵Pratik Naik2012-08-283-0/+23
| | | | | | | | scope conditions
* | Merge pull request #7458 from frodsan/fix_orddep_basicsRafael Mendonça França2012-08-281-5/+5
|\ \ | | | | | | fix order dependent test in AR::BasicsTest
| * | fix order dependent test in AR::BasicsTestFrancesco Rodriguez2012-08-271-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | This test https://github.com/rails/rails/blob/master/activerecord/test/cases/base_test.rb#L381 is failing because is not setting `CreditCard.pluralize_table_name` to `false`. In this case, i prefer to change to another model that is not in the `GUESSED_CLASSES` array.
* | | ensures that the test repairs the validation setupFrancesco Rodriguez2012-08-271-7/+9
|/ /
* | fix order dependent test in AggregationsTestFrancesco Rodriguez2012-08-261-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Ensure class variable is set to nil. It prevents the following test to fail: def test_do_not_run_the_converter_when_nil_was_set customers(:david).non_blank_gps_location = nil assert_nil Customer.gps_conversion_was_run end Check https://github.com/rails/rails/blob/master/activerecord/test/models/customer.rb#L7 for more information.
* | Add test to ensure that save will raise SerializationTypeMismatch if theRafael Mendonça França2012-08-261-0/+6
| | | | | | | | serialized attribute value is not from the same class
* | We don't need this reloadRafael Mendonça França2012-08-261-1/+1
| |
* | Use the Topic class in the attribute serialized testsRafael Mendonça França2012-08-261-8/+4
| |
* | Use teardown hook to return the initial state of the objectRafael Mendonça França2012-08-261-16/+5
| |
* | Move the serialized attribute tests to their own fileRafael Mendonça França2012-08-263-207/+214
| |
* | Move test to the correct fileRafael Mendonça França2012-08-263-12/+12
| |
* | Revert "Remove update_attribute."Rafael Mendonça França2012-08-252-1/+51
| | | | | | | | | | | | | | | | | | | | | | This reverts commit a7f4b0a1231bf3c65db2ad4066da78c3da5ffb01. Conflicts: activerecord/lib/active_record/associations/has_one_association.rb activerecord/lib/active_record/persistence.rb activerecord/test/cases/base_test.rb activerecord/test/cases/dirty_test.rb activerecord/test/cases/timestamp_test.rb
* | allow to pass Symbol or Proc into :limit option of ↵Mikhail Dieterle2012-08-262-8/+32
| | | | | | | | #accepts_nested_attributes_for
* | Extract ActiveRecord::SessionStore from RailsPrem Sichanugrist2012-08-242-156/+0
| | | | | | | | | | This functionality will be available from gem `active_record-session_store` instead.
* | Model.select takes a variable list of arguments.Isaac Sanders2012-08-231-0/+8
| | | | | | | | | | | | This is a cleaner version of #6916. Closes #3165.
* | Merge pull request #6606 from amatsuda/ar_relation_model_methodRafael Mendonça França2012-08-211-0/+5
|\ \ | | | | | | AR::Relation#model would be a better API than AR::Relation#klass
| * | AR::Relation#model would be a better API than AR::Relation#klassAkira Matsuda2012-06-031-0/+5
| | |
* | | Use a model without counter cache to test read-only attributesRafael Mendonça França2012-08-211-9/+10
| | |
* | | reset_counters() was crashing when there were multiple belongs_to ↵Dave Desrochers2012-08-216-1/+29
| | | | | | | | | | | | | | | | | | associations with the same foreign key. This closes #5200.
* | | Rename to test_mysql_strict_mode_disabled_dont_override_global_sql_modeYasuo Honda2012-08-222-6/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | Reason since MySQL 5.6.6-m9 the `sql_mode` default value is `NO_ENGINE_SUBSTITUTION`. This default parameter change is out of control from Rails. This test verifies Rails not overriding the default `@@GLOBAL.sql_mode` value by checking if `@@GLOBAL.sql_mode` is the same as `@@SESSION.sql_mode`.
* | | Use instance_accessor: false instead of instance_writer.kennyj2012-08-213-7/+11
| | |
* | | Round usec when writing timestamp attribute.kennyj2012-08-211-0/+15
| | |
* | | removing dead codeAaron Patterson2012-08-201-19/+7
| | |
* | | define singleton methods rather than adding and removing methodsAaron Patterson2012-08-201-45/+32
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 03:53:28 +0000