aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Address ActiveRecord::StatementInvalid: OCIError: ORA-00979Yasuo Honda2013-03-111-2/+2
|
* Change uniq validation with conditions examples to use where with hashesCarlos Antonio da Silva2013-03-091-2/+2
| | | | Take the opportunity to showcase where.not.
* Uniqueness validation uses a proc to specify the `:conditions` option.Yves Senn2013-03-091-1/+7
| | | | | This is a follow up to #5321 and follows the general direction in AR to make things lazy evaluated.
* Deprecate #connection in favour of accessing it via the classBen Moss2013-03-092-7/+6
| | | | | This allows end-users to have a `connection` method on their models without clashing with ActiveRecord internals.
* Preserve magic comments and content encoding of copied migrations.OZAWA Sakuro2013-03-092-0/+32
| | | | | During insertion of "# This migration comes from ... " comment at the beginning of a migration, presence of magic comment was not considered.
* Merge pull request #9497 from route/subclass_from_attrsRafael Mendonça França2013-03-082-0/+13
|\ | | | | | | | | | | | | Fix ActiveRecord `subclass_from_attrs` when eager_load is false. Conflicts: activerecord/CHANGELOG.md
| * Fix ActiveRecord `subclass_from_attrs` when eager_load is false.Dmitry Vorotilin2013-03-062-0/+13
| | | | | | | | | | It cannot find subclass because all classes are loaded automatically when it needs.
* | Refactored test case with standard variable namingAnupam Choudhury2013-03-081-40/+40
| |
* | Merge pull request #8868 from tehgeekmeister/masterRafael Mendonça França2013-03-081-0/+16
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | Use the index name explicitly provided in a migration when reverting. Fixes #8868 Conflicts: activerecord/CHANGELOG.md
| * | If an index can't be found by column, use the index name.Ezekiel Smithburg2013-03-071-0/+16
| | | | | | | | | | | | schema_statements uses the column name by default to construct the index name, and then raises an exception if it doesn't exist, even if the name option is specified, which causes #8858. this commit makes index_name_for_remove fall back to constructing the index name to remove based on the name option.
* | | Merge pull request #8966 from ↵Rafael Mendonça França2013-03-081-0/+7
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | cfabianski/disable_prepared_statement_when_preparing_a_query Unprepared Visitor + unprepared_statement Conflicts: activerecord/CHANGELOG.md
| * | | Unprepared Visitor + unprepared_statementCédric FABIANSKI2013-03-081-0/+7
| |/ /
* | | Update test name to reflect change in how scopes merging worksCarlos Antonio da Silva2013-03-081-2/+2
| | | | | | | | | | | | | | | | | | | | | Introduced in f1082b8588a9144eedb34d511f0074031f692d98. Full changelog in 9f007d7fe5f90257c71baa2c4e7c76fb44512986. [ci skip]
* | | Combine scope conditions using ANDNeeraj Singh and John Leighton2013-03-071-3/+3
|/ / | | | | | | | | | | | | | | | | | | | | | | | | Currently Post.active.inactive will result in Post.inactive since the last where clause wins when scopes are merged. This pull request will merge all scopes ( barring defaul scope) using AND. The default scope will be overridden if another scope acts on the same where clause. closes #7365
* | Merge pull request #9597 from senny/9110_serialized_not_null_defaultRafael Mendonça França2013-03-074-0/+13
|\ \ | | | | | | test case for `serialize` default values.
| * | test case for `serialize` default values.Yves Senn2013-03-074-0/+13
| | | | | | | | | | | | Closes #9110
* | | Merge pull request #9105 from bemurphy/cache_key_updated_onRafael Mendonça França2013-03-072-2/+22
|\ \ \ | |/ / |/| | | | | | | | | | | | | | cache_key consults updated_on timestamp if present Conflicts: activerecord/CHANGELOG.md
| * | cache_key consults updated_on timestamp if presentBrendon Murphy2013-02-262-2/+22
| | | | | | | | | | | | | | | - Extract max timestamp retrieval for cache_key - Update changelog for cache_key changes
* | | Merge pull request #9474 from HonoreDB/masterRafael Mendonça França2013-03-071-0/+14
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | More helpful error message when instantiating an abstract class Conflicts: activerecord/CHANGELOG.md
| * | | More helpful error message when instantiating an abstract classAaron Weiner2013-03-031-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Calling a literal ActiveRecord::Base.new raises NoMethodError, since it ends up calling Class.abstract_class? which does not exist. Similarly, instantiating an actual abstract class hits the database, when conventionally it should immediately throw NotImplementedError. ActiveRecord::Base can't be made abstract without breaking many, many things, so check for it separately.
* | | | Refactored and removed unnecessary lines in the test caseAnupam Choudhury2013-03-071-3/+3
| | | |
* | | | Remove regression test added in 0268b5d8cdc3c5a1337462135f0a326a2654ba1aRafael Mendonça França2013-03-071-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | It was added because a regression caused by a712e08ebe21f6d8653a0e6602df2e0f5d40d9ca Closes #9255
* | | | rake db:structure:dump warns when `mysqldump` is not in PATH.Yves Senn2013-03-061-1/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #9518. The rake task used to fail silently and left an empty `structure.sql`. It's confusing for users to get to the root of the problem. The warning message tells them where to look.
* | | | `Connection#structure_dump` is no longer used. #9518Yves Senn2013-03-063-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | As of ccc6910c we use `mysqldump` to create the `structure.sql`. The old `#structure_dump` code is still in AR but never used. I removed all relevant parts from the code-base.
* | | | Merge pull request #9507 from senny/9483_migrations_without_transactionsRafael Mendonça França2013-03-062-4/+40
|\ \ \ \ | |_|_|/ |/| | | Transactions can be turned off per Migration
| * | | transactions can be turned off per Migration.Yves Senn2013-03-052-1/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #9483. There are SQL Queries that can't run inside a transaction. Since the Migrator used to wrap all Migrations inside a transaction there was no way to run these queries within a migration. This patch adds `self.disable_ddl_transaction!` to the migration to turn transactions off when necessary.
| * | | transactional migration test-case was broken.Yves Senn2013-03-051-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | The cleanup commit a85625d broke the test-case. The schema was no longer modified so there was no way to check that the rollback actually happened.
* | | | Remove unused return value, because collecting_queries_for_explain isn't ↵kennyj2013-03-061-2/+1
|/ / / | | | | | | | | | public API.
* | | assigning '0.0' to a nullable numeric column does not make it dirtyYves Senn2013-03-051-0/+15
| | |
* | | `ActiveRecord::Base.include_root_in_json` is `false` by default.Yves Senn2013-03-041-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #9459. The PR #6597 unified the configuration for `include_root_in_json` in AM and AR to `false`. Later on with the refactoring commit: e030f26 the value in AR was set to `true` but I think this was not on purpose. With this commit both AM and AR will have the same configuration for `include_root_in_json`, which is `false`.
* | | rewrite tests to have no side-effects on `include_root_in_json`.Yves Senn2013-03-041-33/+55
| | |
* | | Created an unscope method for removing relations from a chain ofwangjohn2013-03-031-0/+144
|/ / | | | | | | | | relations. Specific where values can be unscoped, and the unscope method still works when relations are merged or combined.
* | Merge pull request #9431 from troyk/patch-2Andrew White2013-03-021-0/+2
|\ \ | | | | | | | | | Fix PostgreSQL TIMESTAMP WITH TIME ZONE to return ActiveSupport::Time
| * | Fix PostgreSQL TIMESTAMP WITH TIME ZONE to return ActiveSupport::TimeTroy Kruthoff2013-03-011-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In an AR model a timestamptz attribute would return a ruby string and AR tests did not check for any type casting. Previous tests would pass only because an assert_equal was being used on a Time.utc object, which will parse the right side of the eq to a valid Time instance for comparision. switch to test instance of Time instead of ActiveSupport::TimeWithZone
* | | deal with `#append` and `#prepend` on association collections.Yves Senn2013-03-011-1/+13
|/ / | | | | | | | | | | | | | | | | | | | | Closes #7364. Collection associations behave similar to Arrays. However there is no way to prepend records. And to append one should use `<<`. Before this patch `#append` and `#prepend` did not add the record to the loaded association. `#append` now behaves like `<<` and `#prepend` is not defined.
* | Wrong exception is occured when raising no translatable exceptionkennyj2013-03-011-0/+6
| |
* | Support PostgreSQL specific column types when using `change_table`.Yves Senn2013-02-282-0/+30
| | | | | | | | | | | | | | | | Closes #9480. We use `TableDefinition` for `#create_table` and `Table` for `#change_table`. The PostgreSQL sepcifc types were only defined on `TableDefinition` so I also added them to `Table`.
* | Revert "Merge pull request #9207 from dylanahsmith/mysql-quote-numeric"Steve Klabnik2013-02-274-37/+10
| | | | | | | | | | This reverts commit 408227d9c5ed7de26310d72a1a99c1ee02311c63, reversing changes made to dca0b57d03deffc933763482e615c3cf0b9a1d97.
* | Fix default output for postgres network address typesErik Peterson2013-02-262-9/+9
| |
* | Fix touching an invalid parent record for belongs_toOlek Janiszewski2013-02-261-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the parent of a `belongs_to` record fails to be saved due to validation errors, `touch` will be called on a new record, which causes an exception (see https://github.com/rails/rails/pull/9320). Example: class Owner < ActiveRecord::Base validates_presence_of :name end class Pet < ActiveRecord::Base belongs_to :owner, touch: true end pet = Pet.new(owner: Owner.new) # Before, this line would raise ActiveRecord::ActiveRecordError # "can not touch on a new record object" pet.save
* | Merge pull request #9414 from senny/9275_order_with_symbol_and_joinRafael Mendonça França2013-02-262-2/+20
|\ \ | |/ |/| Expand order(:symbol) to "table".symbol to prevent broken queries on PG.
| * Expand order(:symbol) to "table".symbol to prevent broken queries on PG.Yves Senn2013-02-252-3/+21
| | | | | | | | | | | | | | | | | | | | Fixes #9275. When `#order` is called with a Symbol this patch will prepend the quoted_table_name. Before the postgresql adapter failed to build queries containg a join and an order with a symbol. This expansion happens for all adapters.
* | Do not override attributes on `dup` by default scopesHiroshige Umino2013-02-261-0/+9
| |
* | :scissors:Rafael Mendonça França2013-02-251-1/+1
|/
* Merge pull request #9246 from Noemj/update_prepared_statementsAaron Patterson2013-02-241-0/+14
|\ | | | | Changed update to use prepared statements
| * Changed update_record to use prepared statements.Noemj2013-02-111-0/+14
| |
* | Raising an ActiveRecordError when one tries to use .touch(name) on a newwangjohn2013-02-251-0/+7
| | | | | | | | | | object that has not yet been persisted. This behavior follows the precedent set by update_columns.
* | Remove warningRafael Mendonça França2013-02-241-1/+1
| |
* | don't apply invalid ordering when preloading hmt associations.Yves Senn2013-02-241-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | closes #8663. When preloading a hmt association there two possible scenarios: 1.) preload with 2 queries: first hm association, then hmt with id IN () 2.) preload with join: hmt association is loaded with a join on the hm association The bug was happening in scenario 1.) with a normal order clause on the hmt association. The ordering was also applied when loading the hm association, which resulted in the error. This patch only applies the ordering the the hm-relation if we are performing a join (2). Otherwise the order will only appear in the second query (1).
* | Merge pull request #9400 from senny/remove_auto_explain_threshold_in_secondsXavier Noria2013-02-241-68/+4
|\ \ | | | | | | remove config.auto_explain_threshold_in_seconds
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 13:47:51 +0000