aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Use inheritance to avoid special-case code for the 'id' methodJon Leighton2011-11-301-1/+1
|
* ActiveRecord::Relation#pluck methodBogdan Gusiev2011-11-301-0/+25
|
* Automatic closure of connections in threads is deprecated. For exampleAaron Patterson2011-11-292-26/+8
| | | | | | | | | | | | | | | | | the following code is deprecated: Thread.new { Post.find(1) }.join It should be changed to close the database connection at the end of the thread: Thread.new { Post.find(1) Post.connection.close }.join Only people who spawn threads in their application code need to worry about this change.
* AbstractAdapter#close can be called to add the connection back to theAaron Patterson2011-11-291-0/+16
| | | | pool.
* expire will set in_use to falseAaron Patterson2011-11-291-0/+7
|
* last_use is set on connection leaseAaron Patterson2011-11-291-0/+6
|
* Leased connections return false on second leaseAaron Patterson2011-11-291-2/+11
|
* Adapters keep in_use flag when leasedAaron Patterson2011-11-291-0/+16
|
* namespace the adapter testAaron Patterson2011-11-291-121/+123
|
* Deprecated `define_attr_method` in `ActiveModel::AttributeMethods`Jon Leighton2011-11-292-22/+15
| | | | | This only existed to support methods like `set_table_name` in Active Record, which are themselves being deprecated.
* Deprecate set_locking_column in favour of self.locking_column=Jon Leighton2011-11-292-2/+42
|
* Deprecate set_primary_key in favour of self.primary_key=Jon Leighton2011-11-2915-22/+43
|
* Make sure the original_foo accessor still works (but deprecated) if we are ↵Jon Leighton2011-11-291-7/+55
| | | | using self.foo=
* Deprecate set_sequence_name in favour of self.sequence_name=Jon Leighton2011-11-292-3/+7
|
* Add tests for set_sequence_name etcJon Leighton2011-11-291-0/+22
|
* Deprecate set_inheritance_column in favour of self.inheritance_column=Jon Leighton2011-11-293-5/+11
|
* Deprecate set_table_name in favour of self.table_name= or defining your own ↵Jon Leighton2011-11-2916-39/+52
| | | | method.
* respond_to? information of AR is not the responsibility of the specAaron Patterson2011-11-291-1/+1
| | | | resolver.
* Merge pull request #3636 from joshsusser/masterJon Leighton2011-11-295-2/+50
|\ | | | | association methods are now generated in modules
| * don't change class definition in test caseJosh Susser2011-11-292-6/+4
| |
| * use GeneratedFeatureMethods module for associationsJosh Susser2011-11-273-2/+30
| |
| * add test for super-ing to association methodsJosh Susser2011-11-151-2/+12
| |
| * association methods are now generated in modulesJosh Susser2011-11-151-0/+12
| | | | | | | | | | | | | | | | | | | | Instead of generating association methods directly in the model class, they are generated in an anonymous module which is then included in the model class. There is one such module for each association. The only subtlety is that the generated_attributes_methods module (from ActiveModel) must be forced to be included before association methods are created so that attribute methods will not shadow association methods.
* | Fix resolver_test.rb on travis (postgresql isn't setup, so it can't load the ↵Jon Leighton2011-11-291-6/+6
| | | | | | | | connection adapter)
* | Fix schema_cache_test.rb for sqlite3_memJon Leighton2011-11-291-6/+0
| |
* | Move connection resoluion logic to it's own testable class.Aaron Patterson2011-11-282-34/+41
| |
* | pools are 1:1 with spec now rather than 1:1 with classAaron Patterson2011-11-282-3/+0
| |
* | break establish_connection to smaller methodsAaron Patterson2011-11-281-3/+3
| |
* | Merge pull request #3768 from janv/masterAaron Patterson2011-11-281-0/+11
|\ \ | | | | | | Test and fix for Issue 3450
| * | Test case and fix for rails/rails#3450Jan Varwig2011-11-271-0/+11
| | | | | | | | | | | | Asssigning a parent id to a belongs_to association actually updates the object that is validated when the association has :validates => true
* | | Merge pull request #3748 from samsonasu/has_many_custom_pk_new_recordJon Leighton2011-11-271-1/+28
|\ \ \ | |/ / |/| | New records should load has_many relationships with custom primary keys
| * | load has_many associations keyed off a custom primary key if that key is ↵Brian Samson2011-11-251-1/+28
| | | | | | | | | | | | present but the record is unsaved
* | | add the query to AR::Relation#explain outputXavier Noria2011-11-253-0/+9
|/ / | | | | | | | | | | | | Rationale: this is more readable if serveral queries are involved in one call. Also, it will be possible to let AR log EXPLAINs automatically in production mode, where queries are not even around.
* | fixing tests on ruby 1.8Aaron Patterson2011-11-201-1/+3
| |
* | pushing caching and visitors down to the connectionAaron Patterson2011-11-196-120/+62
| |
* | Verify that #3690 has been closed by previous changes to the mysqlJon Leighton2011-11-192-2/+10
| | | | | | | | | | | | | | | | adapters. These tests fail on the v3.1.2 tag. Closes #3690.
* | Revert "Merge pull request #1163 from amatsuda/sexier_migration_31"Aaron Patterson2011-11-171-120/+0
| | | | | | | | | | | | | | | | | | | | This reverts commit 0e407a90413d8a19002b85508d811ccdf2190783, reversing changes made to 533a9f84b035756eedf9fdccf0c494dc9701ba72. Conflicts: activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb activerecord/test/cases/migration_test.rb
* | Revert "Merge pull request #3603 from vijaydev/change_table_without_block_arg"Aaron Patterson2011-11-171-54/+0
| | | | | | | | | | | | | | | | | | This reverts commit 81fad6a270ec3cbbb88553c9f2e8200c34fd4d13, reversing changes made to 23101de283de13517e30c4c3d1ecc65525264886. Conflicts: activerecord/test/cases/migration_test.rb
* | `ActiveRecord::Base#becomes` should retain the errors of the original object.James Adam2011-11-161-0/+8
| | | | | | | | This commit contains a simple failing test that demonstrates the behaviour we expect, and a fix. When using `becomes` to transform the type of an object, it should retain any error information that was present on the original instance.
* | fixing tests on PGAaron Patterson2011-11-161-1/+1
| |
* | Fixes issue #3483, regarding using a mixture of ranges and discrete values ↵Ryan Naughton2011-11-141-1/+1
| | | | | | | | in find conditions. Paired with Joey Schoblaska.
* | Failing test case for issue #3483Gabriel Sobrinho2011-11-141-0/+4
|/
* Merge pull request #3371 from yahonda/fix_ora_00932_errorAaron Patterson2011-11-141-1/+1
|\ | | | | Fix ORA-00932 error when trying to insert 0 to DATE type columns.
| * Fix ORA-00932 error when trying to insert 0 to DATE type columns.Yasuo Honda2011-10-191-1/+1
| |
* | change_table bulk test case should check if the connection supports bulk alterVijay Dev2011-11-111-13/+15
| |
* | Modify change_table to remove the need for the block argument.Vijay Dev2011-11-111-0/+52
| |
* | Checking the arity of the block passed to create_tableVijay Dev2011-11-101-0/+15
| | | | | | | | | | | | A recent change made to create_table does away with the need for the block argument. Checking the arity will prevent the mixing up of the two syntaxes.
* | exclude ORDER BY clause when querying Relation#exists?Akira Matsuda2011-11-091-0/+5
| |
* | revises EXPLAIN tests for SQLite3Xavier Noria2011-11-061-3/+3
| | | | | | | | | | | | | | | | | | | | The output in Travis is a bit different. The SQLite documentation (http://www.sqlite.org/eqp.html) warns output may change dramatically between releases. I do not want to mock the result set because I want a real EXPLAIN to happen. I prefer a test that may fail in future releases than a test that may give false positives in future releases.
* | Merge pull request #3521 from ↵Aaron Patterson2011-11-061-0/+4
| | | | | | | | | | | | nulogy/fix_postgres_adapter_to_handle_spaces_between_schemas Fix postgres adapter to handle spaces between schemas