aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | New records should remain new after yaml serializationSean Griffin2014-06-011-0/+17
| | | | | |
* | | | | | Remove most code related to serialized propertiesSean Griffin2014-06-013-5/+9
| |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Nearly completely implemented in terms of custom properties. `_before_type_cast` now stores the raw serialized string consistently, which removes the need to keep track of "state". The following is now consistently true: - `model.serialized == model.reload.serialized` - A model can be dumped and loaded infinitely without changing - A model can be saved and reloaded infinitely without changing
* | | | | Don't change values in `@raw_attributes` during serializationSean Griffin2014-06-012-21/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | During `init_with`, the attributes given to the coder will be placed into `@raw_attributes`. As such, we should read from `@raw_attributes` when encoding, rather than `@attributes`, which has been type cast.
* | | | | Merge pull request #15434 from sgrif/sg-clear-cachesYves Senn2014-05-311-0/+20
|\ \ \ \ \ | | | | | | | | | | | | Clear all caches calculated based on `@columns` when `@columns` changes
| * | | | | Clear all caches calculated based on `@columns` when `@columns` changesSean Griffin2014-05-311-0/+20
| | | | | |
* | | | | | Add missing test case for writing unknown attributesSean Griffin2014-05-301-0/+2
|/ / / / /
* | | | | Update some bad test cases for serialized columnsSean Griffin2014-05-301-53/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The first case was not testing what the issue mentioned actually was (A subclass of a class with serialized attributes does not serialize when they come from the database). The second case was a bad coder. It would fail if the model was `dup`ed, or if the the model was loaded from the database and then saved again. The third case wasn't testing anything that wasn't covered by the second (and was also a bad coder for the same reasons as the second).
* | | | | Merge pull request #15427 from sgrif/sg-rename-attribute-ivarsRafael Mendonça França2014-05-301-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Rename attribute related instance variables to better express intent
| * | | | | Rename attribute related instance variables to better express intentSean Griffin2014-05-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `@attributes` was actually used for `_before_type_cast` and friends, while `@attributes_cache` is the type cast version (and caching is the wrong word there, but I'm working on removing the conditionals around that). I opted for `@raw_attributes`, because `_before_type_cast` is also semantically misleading. The values in said hash are in the state given by the form builder or database, so raw seemed to be a good word.
* | | | | | Allow specifying a default value in overloaded propertiesSean Griffin2014-05-302-4/+6
|/ / / / /
* | | | | pg, support default values for enum types. Closes #7814.Yves Senn2014-05-301-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | This is an intermediate solution. It is related to the refactoring @sgrif is making and will change in the future.
* | | | | pg, `default_sequence_name` respects schema. Closes #7516.Yves Senn2014-05-301-8/+6
| | | | |
* | | | | Merge pull request #11896 from nkondratyev/fix_pg_columns_for_distinctYves Senn2014-05-301-0/+11
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed #columns_for_distinct of postgresql adapter Conflicts: activerecord/CHANGELOG.md
| * | | | | Fixed `columns_for_distinct` of postgresql adapterNikolay Kondratyev2013-08-151-0/+11
| | | | | |
* | | | | | pg, `reset_pk_sequence!` respects schemas. Closes #14719.Yves Senn2014-05-303-6/+17
| | | | | |
* | | | | | pg, `PostgreSQL::Name` to hold schema qualified names.Yves Senn2014-05-301-2/+43
| | | | | |
* | | | | | Move `type_cast_for_write` behavior over to the serialized type objectSean Griffin2014-05-291-29/+0
| | | | | |
* | | | | | Refactor serialized types to be partially defined as custom propertiesSean Griffin2014-05-292-12/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Many of the methods defined in `AttributeMethods::Serialization` can be refactored onto this type as well, but this is a reasonable small step. Removes the `Type` class, and the need for `decorate_columns` to handle serialized types.
* | | | | | Result sets never override a model's column typeSean Griffin2014-05-292-0/+50
| |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MySQL and PostgreSQL provide a column type override in order to properly type cast computed columns included in a result set. This should never override the known types of full fledged columns. In addition to messing up computed properties, this would have led to inconsistent behavior between a record created with `new`, and a record created with `last` on the mysql adapter in the following cases: - `tinyint(1)` with `emulate_booleans` set to `false` - `text`, `string`, `binary`, and `decimal` columns
* | | | | Maintain column order when overriding existing columnsSean Griffin2014-05-281-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Working towards re-implementing serialized attributes to use the properties API exposed the need for this, as serializing a column shouldn't change the order of the columns.
* | | | | Merge pull request #15389 from sgrif/sg-property-inheritanceRafael Mendonça França2014-05-281-0/+19
|\ \ \ \ \ | | | | | | | | | | | | Ensure custom properties work correctly with inheritance
| * | | | | Ensure custom properties work correctly with inheritanceSean Griffin2014-05-281-0/+19
| | | | | |
* | | | | | Merge pull request #15370 from sgrif/sg-type-namespaceRafael Mendonça França2014-05-283-143/+131
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Move types to the top level `ActiveRecord` namespace
| * | | | | Move types to the top level `ActiveRecord` namespaceSean Griffin2014-05-273-143/+131
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `ActiveRecord::ConnectionAdapters::Type::Value` => `ActiveRecord::Type::Value`
* | | | | | Merge pull request #15387 from sgrif/sg-remove-column-coderSantiago Pastorino2014-05-281-20/+0
|\ \ \ \ \ \ | | | | | | | | | | | | | | Remove unused `Column#coder`
| * | | | | | Remove unused `Column#coder`Sean Griffin2014-05-281-20/+0
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | It appears this property was added, but never actually used. It would be broken if it were, as it only type casts one way.
* / / / / / pg, keep `hstore` and `json` attributes as `Hash` in @attributes.Yves Senn2014-05-282-0/+18
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The solution presented in this patch is not efficient. We should replace it in the near future. The following needs to be worked out: * Is `@attributes` storing the Ruby or SQL representation? * `cacheable_column?` is broken but `hstore` and `json` rely on that behavior Refs #15369. /cc @sgrif @rafaelfranca
* | | | | Add test case for clear mappingsAkshay Vishnoi2014-05-281-0/+10
| | | | |
* | | | | Test Case - Change method nameAkshay Vishnoi2014-05-281-1/+1
| | | | |
* | | | | Merge pull request #15371 from sgrif/sg-silence-deprecation-warningRafael Mendonça França2014-05-271-0/+3
|\ \ \ \ \ | | | | | | | | | | | | Silence deprecation warning in test
| * | | | | Silence deprecation warning in testSean Griffin2014-05-271-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | Missed a case that only occured for mysql/mysql2
* | | | | | Merge pull request #14834 from al2o3cr/issue14155Aaron Patterson2014-05-271-0/+10
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Correctly alias table names when joining more than once
| * | | | | WIP: pass existing joins to construct_join_dependencyMatt Jones2014-05-161-0/+10
| | | | | |
* | | | | | Merge pull request #15295 from sgrif/sg-deprecate-decimalsRafael Mendonça França2014-05-274-1/+13
|\ \ \ \ \ \ | | | | | | | | | | | | | | Deprecate decimal columns being automatically treated as integers
| * | | | | | Deprecate decimal columns being automatically treated as integersSean Griffin2014-05-274-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With ActiveRecord::Properties, we now have a reasonable path for users to continue to keep this behavior if they want it. This is an edge case that has added a lot of complexity to the code base.
* | | | | | | Fix redefine a has_and_belongs_to_many inside inherited classArthur Neves2014-05-271-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After ad7b5efb55bcc2e0ccd3e7f22a81e984df8676d1, which changed how has_an_belongs_to_many used to work, we start raising an error when redefining the same has_an_belongs_to_many association. This commits fix that regression. [Fixes #14983]
* | | | | | | Fix syntax error from 5eae77cZachary Scott2014-05-261-1/+1
| | | | | | |
* | | | | | | Move test to the proper fileRafael Mendonça França2014-05-262-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | All preload tests are in the eager_test file
* | | | | | | Add test case for b13d260Rafael Mendonça França2014-05-261-0/+9
|/ / / / / /
* | | | | | Add a public API to allow users to specify column typesSean Griffin2014-05-262-0/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As a result of all of the refactoring that's been done, it's now possible for us to define a public API to allow users to specify behavior. This is an initial implementation so that I can work off of it in smaller pieces for additional features/refactorings. The current behavior will continue to stay the same, though I'd like to refactor towards the automatic schema detection being built off of this API, and add the ability to opt out of automatic schema detection. Use cases: - We can deprecate a lot of the edge cases around types, now that there is an alternate path for users who wish to maintain the same behavior. - I intend to refactor serialized columns to be built on top of this API. - Gem and library maintainers are able to interact with `ActiveRecord` at a slightly lower level in a more stable way. - Interesting ability to reverse the work flow of adding to the schema. Model can become the single source of truth for the structure. We can compare that to what the database says the schema is, diff them, and generate a migration.
* | | | | | Merge pull request #15300 from arthurnn/refactor_reflectionsRafael Mendonça França2014-05-261-1/+6
|\ \ \ \ \ \ | | | | | | | | | | | | | | Refactor reflections
| * | | | | | Merge pull request #15210 from arthurnn/fix_hbtm_reflectionArthur Neves2014-05-241-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix habtm reflection Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/counter_cache.rb activerecord/lib/active_record/reflection.rb activerecord/test/cases/reflection_test.rb
* | | | | | | Merge pull request #15336 from sgrif/sg-quotingMatthew Draper2014-05-272-20/+12
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Remove checks against `column.type` in abstract adapter quoting
| * | | | | | | Remove checks against `column.type` in abstract adapter quotingSean Griffin2014-05-262-20/+12
| | |_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The intention is to eventually remove `column` from the arguments list both for `quote` and for `type_cast` entirely. This is the first step to that end.
* / | | | | | Add missing test case for quoting behaviorSean Griffin2014-05-262-0/+11
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It appears that the only time that `quote` is called with a column, but without first calling `type_cast` is when where is called with an array. My previous pull request broke this behavior, without failing tests. This adds a test for the only case I can think of that exercises the `if column.type == :integer` branch of `quote` effectively.
* | | | | | Merge pull request #15307 from sgrif/sg-type-cast-for-writeYves Senn2014-05-261-1/+0
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add an interface for type objects to control Ruby => SQL
| * | | | | | Add an interface for type objects to control Ruby => SQLSean Griffin2014-05-261-1/+0
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | Adds the ability to save custom types, which type cast to non-primitive ruby objects.
* / / / / / remove unused variable warningKuldeep Aggarwal2014-05-261-1/+1
|/ / / / / | | | | | | | | | | | | | | | `warning: assigned but unused variable - album`
* | | | | Merge pull request #15290 from sgrif/sg-consolidate-zero-scale-decimalRafael Mendonça França2014-05-231-6/+10
|\ \ \ \ \ | | | | | | | | | | | | Remove special case in schema dumper for decimal without scale
| * | | | | Remove special case in schema dumper for decimal without scaleSean Griffin2014-05-231-6/+10
| | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 05:13:54 +0000