aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge pull request #14390 from huoxito/true-touchRafael Mendonça França2014-03-251-0/+11
|\ \ | | | | | | | | | Still touch associations when theres no timestamp
| * | Still touch associations when theres no timestampWashington Luiz2014-03-141-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | Prior to Rails 4.0.4 when touching a object which doesn't have timestamp attributes (updated_at / updated_on) rails would still touch all associations. After 73ba2c14cd7d7dfb2d132b18c47ade995401736f it updates associations but rollsback because `touch` would return nil since there's no timestamp attribute
* | | Revert "Merge pull request #8313 from alan/only_save_changed_has_one_objects"Rafael Mendonça França2014-03-251-13/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 6e3ab3e15faf782f6a937ccf5574a4fb63e3e353, reversing changes made to 39e07b64ce3f4bb55e60ba0266e677f8e4f4893a. Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/autosave_association_test.rb
* | | do not rely on method_missing hitting arelAaron Patterson2014-03-241-2/+3
| | | | | | | | | | | | arel methods are not supposed to be public API for ActiveRecord
* | | use ARel factory methods for building AST nodesAaron Patterson2014-03-242-17/+17
| | | | | | | | | | | | This abstracts us from the actual construction of the nodes
* | | Clean up tables after each test.Guo Xiang Tan2014-03-222-92/+96
| | | | | | | | | | | | | | | | | | | | | Follow-Up to https://github.com/rails/rails/pull/14400 This ensures that all tables are removed after each test and thereby allowing us to run the tests in a random order.
* | | Extract with_example_table into helper method.Guo Xiang Tan2014-03-202-6/+13
| | | | | | | | | | | | This setups the helper method which other tests can benefit from.
* | | Merge pull request #12955 from joshwilliams/masterYves Senn2014-03-201-0/+45
|\ \ \ | | | | | | | | Postgres schema: Constrain sequence search classid
| * | | Postgres schema: Constrain sequence search classidJosh Williams2014-03-201-0/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The pk_an_sequence_for query previously joined against pg_class's oid for rows in pg_depend, but pg_depend's objid may point to other system tables, such as pg_attrdef. If a row in one of those other tables coincidentally has the same oid as an (unrelated) sequence, that sequence name may be returned instead of the real one. This ensures that only the pg_depend entries pointing to pg_class are considered.
* | | | Remove extra indirection for testing exceptions and messagesCarlos Antonio da Silva2014-03-201-28/+12
| | | | | | | | | | | | | | | | | | | | | | | | assert_raise + assert_equal on the returned exception message work just fine, there is no need for extra work, specially like this overly complicated helper.
* | | | ActiveRecord#touch should accept multiple attributes #14423Thiago Pinto2014-03-191-0/+12
|/ / /
* | | Add counter cache test for class_nameArthur Neves2014-03-171-0/+11
| | | | | | | | | | | | Backport test from #14410
* | | test should only pass if the pool.size+1 checkout failsAaron Patterson2014-03-171-3/+2
| | | | | | | | | | | | | | | Previously, any of the connection checkouts could have failed, and this test would pass.
* | | use a latch to avoid busy loopsAaron Patterson2014-03-171-3/+4
| | |
* | | Reap connections based on owning-thread deathMatthew Draper2014-03-183-22/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | .. not a general timeout. Now, if a thread checks out a connection then dies, we can immediately recover that connection and re-use it. This should alleviate the pool exhaustion discussed in #12867. More importantly, it entirely avoids the potential issues of the reaper attempting to check whether connections are still active: as long as the owning thread is alive, the connection is its business alone. As a no-op reap is now trivial (only entails checking a thread status per connection), we can also perform one in-line any time we decide to sleep for a connection.
* | | Teach PostgreSQLAdapter#reset! to actually resetMatthew Draper2014-03-181-0/+31
| | | | | | | | | | | | It wasn't doing anything beyond clearing the statement cache.
* | | `where.not` adds `references` for `includes`.Yves Senn2014-03-172-0/+18
| | | | | | | | | | | | Closes #14406.
* | | Extend fixture label replacement to allow string interpolationEric Steele2014-03-152-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allows fixtures to use their $LABEL as part of a string instead of limiting use to the entire value. mark: first_name: $LABEL username: $LABEL1973 email: $LABEL@$LABELmail.com users(:mark).first_name # => mark users(:mark).username # => mark1973 users(:mark).email # => mark@markmail.com
* | | Merge pull request #14380 from ↵Yves Senn2014-03-1549-61/+51
|\ \ \ | | | | | | | | | | | | | | | | tgxworld/use_teardown_helper_method_in_activerecord Use teardown helper method.
| * | | Use teardown helper method.Guo Xiang Tan2014-03-1449-61/+51
| |/ / | | | | | | | | | | | | | | | | | | | | | Follow-Up to https://github.com/rails/rails/pull/14348 Ensure that SQLCounter.clear_log is called after each test. This is a step to prevent side effects when running tests. This will allow us to run them in random order.
* | | Obey `validate: false` option for habtmCarlos Antonio da Silva2014-03-143-0/+38
| | | | | | | | | | | | Fixes #14383.
* | | Allow custom JDBC urlsschneems2014-03-141-0/+6
|/ / | | | | | | mitigates #14323
* | Merge pull request #14372 from arthurnn/fix_query_cache_bindsRafael Mendonça França2014-03-131-0/+8
|\ \ | | | | | | Make select_all on query cache accept a Relation without binds.
| * | Make select_all on query cache accept a Relation without binds.Arthur Neves2014-03-131-0/+8
| | | | | | | | | | | | | | | [fixes #14361] [related #13886]
* | | Add test for deprecation warning for passing an AR object to `find`.Lauro Caetano2014-03-131-0/+6
| | |
* | | Test deprecation warning for passing an ActiveRecord object toLauro Caetano2014-03-131-0/+6
|/ / | | | | | | `exists?`
* | passing an instance of an AR object to `find` is deprecatedAaron Patterson2014-03-133-5/+5
| | | | | | | | please pass the id of the AR object by calling `.id` on the model first.
* | passing an ActiveRecord object to `exists?` is deprecated.Aaron Patterson2014-03-132-2/+2
| | | | | | | | | | Pass the id of the object to the method by calling `.id` on the AR object.
* | Change usec to 0 on tests that compare secondsArthur Neves2014-03-121-3/+3
| | | | | | | | | | Avoid rounding problems with `.usec` method rounding the seconds when the field doesn't persist the `.usec` piece.
* | Unit test for mysql quote time usecArthur Neves2014-03-121-0/+7
| |
* | Merge pull request #13040 from kamipo/case_sensitive_comparisonRafael Mendonça França2014-03-122-4/+44
|\ \ | | | | | | | | | | | | | | | | | | Only use BINARY for mysql case sensitive uniqueness check when column has a case insensitive collation. Conflicts: activerecord/CHANGELOG.md
| * | Only use BINARY for mysql case sensitive uniqueness check when column has a ↵Ryuta Kamizono2013-11-262-4/+44
| | | | | | | | | | | | case insensitive collation.
* | | Test microsecond on mysql 5.6Arthur Neves2014-03-123-2/+11
| | |
* | | Remove mocking on save, when not necessaryArthur Neves2014-03-111-3/+1
| | |
* | | Merge pull request #14345 from arthurnn/revert_14052Godfrey Chan2014-03-111-0/+13
|\ \ \ | | | | | | | | Fixes STI when 2+ levels deep.
| * | | Fixes STI when 2+ levels deep.Arthur Neves2014-03-101-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | PR #14052 Added a regression where it was only looking for methods in one level up, So when the method was defined in a 2+ levels up the inheritance chain, the method was not found as defined.
* | | | `change_table` supports `citext`. Follow up to #12523.Yves Senn2014-03-111-8/+27
| | | |
* | | | register OID for PostgreSQL citex datatype [Troy Kruthoff & Lachlan Sylvester]lsylvester2014-03-113-1/+75
|/ / / | | | | | | | | | citext makes it possible to use AR Hash finders for case-insensitive matching as sql UPPER/LOWER functions are not needed.
* | | Merge pull request #8313 from alan/only_save_changed_has_one_objectsRafael Mendonça França2014-03-101-0/+15
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Save has_one associations only if record has changes Conflicts: activerecord/CHANGELOG.md
| * | | Save has_one associations only if record has changesAlan Kennedy2013-10-311-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | Prevents save related callbacks such as `after_commit` being triggered when `has_one` objects are already persisted and have no changes.
* | | | current_adapter? accepts multiple argumentsRafael Mendonça França2014-03-101-2/+2
| | | |
* | | | mysql adapter also fails with a number bigger than intRafael Mendonça França2014-03-101-2/+5
| | | |
* | | | Change the assertions depending in the database adapterRafael Mendonça França2014-03-101-14/+9
| | | | | | | | | | | | | | | | This will avoid the confusing flunk logic
* | | | Do proper adapter checkRafael Mendonça França2014-03-101-2/+2
| | | |
* | | | Cleanup Parrot after each test.Guo Xiang Tan2014-03-091-7/+3
| | | |
* | | | Merge pull request #14262 from sferik/flat_mapAndrew White2014-03-092-3/+3
|\ \ \ \ | | | | | | | | | | Replace additional instances of map.flatten with flat_map
| * | | | Replace map.flatten with flat_map in activerecordErik Michaels-Ober2014-03-032-3/+3
| | | | |
* | | | | we only need to support `asc` and `ASC`. No need for mixed cases. #14263Yves Senn2014-03-051-21/+11
| | | | | | | | | | | | | | | | | | | | This is a result of the discussion at https://github.com/rails/rails/pull/14263/files#r10291489
* | | | | Merge pull request #14263 from robin850/allow_passing_string_to_order_hashYves Senn2014-03-051-2/+36
|\ \ \ \ \ | | | | | | | | | | | | Follow up of #10732 - Allow string hash values on AR order method
| * | | | | Allow string hash values on AR order methodMarcelo Casiraghi2014-03-041-2/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This behavior has almost no performance impact: String not allowed 66.910000 0.030000 66.940000 ( 67.024976) String allowed 69.360000 0.030000 69.390000 ( 69.503096) Benchmarked with http://git.io/Y0YuRw.