Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Create method with known identifier then alias into place. | Jon Leighton | 2011-12-01 | 1 | -0/+2 |
| | | | | | | | | This means we never have to rely on define_method (which is slower and uses more memory), even when we have attributes containing characters that are not allowed in standard method names. (I am mainly changing this because the duplication annoys me, though.) | ||||
* | Add test for read_attribute(:id) with non-standard PK. | Jon Leighton | 2011-12-01 | 1 | -0/+5 |
| | | | | | | | | Also make it actually work. It slows down all read_attribute accesses to map 'id' to whatever the PK actually is, inside read_attribute. So instead make sure the necessary methods are defined and that they redirect wherever they need to go. | ||||
* | Fix up test altering global state that was causing me grief | Jon Leighton | 2011-12-01 | 1 | -2/+4 |
| | |||||
* | Get rid of the underscore versions of attribute methods! | Jon Leighton | 2011-12-01 | 1 | -0/+5 |
| | | | | This makes me happy! | ||||
* | Add hackery to make Syck use encode_with/init_with. Fixes 1.8 after recent ↵ | Jon Leighton | 2011-12-01 | 1 | -0/+5 |
| | | | | changes to attribute serialization. | ||||
* | don't alter global state in test | Jon Leighton | 2011-11-30 | 1 | -2/+3 |
| | |||||
* | If the table behind has no primary key, do not ask again and just return nil. | Julius de Bruijn | 2011-11-30 | 1 | -0/+5 |
| | |||||
* | omg computer science! | Jon Leighton | 2011-11-30 | 1 | -5/+1 |
| | | | | | | | Implement a mini state machine for serialized attributes. This means we do not have to deserialize the values upon initialization, which means that if we never actually access the attribute, we never have to deserialize it. | ||||
* | Fix typo | Jon Leighton | 2011-11-30 | 1 | -2/+2 |
| | |||||
* | Use inheritance to avoid special-case code for the 'id' method | Jon Leighton | 2011-11-30 | 1 | -1/+1 |
| | |||||
* | ActiveRecord::Relation#pluck method | Bogdan Gusiev | 2011-11-30 | 1 | -0/+25 |
| | |||||
* | Automatic closure of connections in threads is deprecated. For example | Aaron Patterson | 2011-11-29 | 2 | -26/+8 |
| | | | | | | | | | | | | | | | | | the following code is deprecated: Thread.new { Post.find(1) }.join It should be changed to close the database connection at the end of the thread: Thread.new { Post.find(1) Post.connection.close }.join Only people who spawn threads in their application code need to worry about this change. | ||||
* | AbstractAdapter#close can be called to add the connection back to the | Aaron Patterson | 2011-11-29 | 1 | -0/+16 |
| | | | | pool. | ||||
* | expire will set in_use to false | Aaron Patterson | 2011-11-29 | 1 | -0/+7 |
| | |||||
* | last_use is set on connection lease | Aaron Patterson | 2011-11-29 | 1 | -0/+6 |
| | |||||
* | Leased connections return false on second lease | Aaron Patterson | 2011-11-29 | 1 | -2/+11 |
| | |||||
* | Adapters keep in_use flag when leased | Aaron Patterson | 2011-11-29 | 1 | -0/+16 |
| | |||||
* | namespace the adapter test | Aaron Patterson | 2011-11-29 | 1 | -121/+123 |
| | |||||
* | Deprecated `define_attr_method` in `ActiveModel::AttributeMethods` | Jon Leighton | 2011-11-29 | 2 | -22/+15 |
| | | | | | This only existed to support methods like `set_table_name` in Active Record, which are themselves being deprecated. | ||||
* | Deprecate set_locking_column in favour of self.locking_column= | Jon Leighton | 2011-11-29 | 2 | -2/+42 |
| | |||||
* | Deprecate set_primary_key in favour of self.primary_key= | Jon Leighton | 2011-11-29 | 15 | -22/+43 |
| | |||||
* | Make sure the original_foo accessor still works (but deprecated) if we are ↵ | Jon Leighton | 2011-11-29 | 1 | -7/+55 |
| | | | | using self.foo= | ||||
* | Deprecate set_sequence_name in favour of self.sequence_name= | Jon Leighton | 2011-11-29 | 2 | -3/+7 |
| | |||||
* | Add tests for set_sequence_name etc | Jon Leighton | 2011-11-29 | 1 | -0/+22 |
| | |||||
* | Deprecate set_inheritance_column in favour of self.inheritance_column= | Jon Leighton | 2011-11-29 | 3 | -5/+11 |
| | |||||
* | Deprecate set_table_name in favour of self.table_name= or defining your own ↵ | Jon Leighton | 2011-11-29 | 16 | -39/+52 |
| | | | | method. | ||||
* | respond_to? information of AR is not the responsibility of the spec | Aaron Patterson | 2011-11-29 | 1 | -1/+1 |
| | | | | resolver. | ||||
* | Merge pull request #3636 from joshsusser/master | Jon Leighton | 2011-11-29 | 5 | -2/+50 |
|\ | | | | | association methods are now generated in modules | ||||
| * | don't change class definition in test case | Josh Susser | 2011-11-29 | 2 | -6/+4 |
| | | |||||
| * | use GeneratedFeatureMethods module for associations | Josh Susser | 2011-11-27 | 3 | -2/+30 |
| | | |||||
| * | add test for super-ing to association methods | Josh Susser | 2011-11-15 | 1 | -2/+12 |
| | | |||||
| * | association methods are now generated in modules | Josh Susser | 2011-11-15 | 1 | -0/+12 |
| | | | | | | | | | | | | | | | | | | | | Instead of generating association methods directly in the model class, they are generated in an anonymous module which is then included in the model class. There is one such module for each association. The only subtlety is that the generated_attributes_methods module (from ActiveModel) must be forced to be included before association methods are created so that attribute methods will not shadow association methods. | ||||
* | | Fix resolver_test.rb on travis (postgresql isn't setup, so it can't load the ↵ | Jon Leighton | 2011-11-29 | 1 | -6/+6 |
| | | | | | | | | connection adapter) | ||||
* | | Fix schema_cache_test.rb for sqlite3_mem | Jon Leighton | 2011-11-29 | 1 | -6/+0 |
| | | |||||
* | | Move connection resoluion logic to it's own testable class. | Aaron Patterson | 2011-11-28 | 2 | -34/+41 |
| | | |||||
* | | pools are 1:1 with spec now rather than 1:1 with class | Aaron Patterson | 2011-11-28 | 2 | -3/+0 |
| | | |||||
* | | break establish_connection to smaller methods | Aaron Patterson | 2011-11-28 | 1 | -3/+3 |
| | | |||||
* | | Merge pull request #3768 from janv/master | Aaron Patterson | 2011-11-28 | 1 | -0/+11 |
|\ \ | | | | | | | Test and fix for Issue 3450 | ||||
| * | | Test case and fix for rails/rails#3450 | Jan Varwig | 2011-11-27 | 1 | -0/+11 |
| | | | | | | | | | | | | Asssigning a parent id to a belongs_to association actually updates the object that is validated when the association has :validates => true | ||||
* | | | Merge pull request #3748 from samsonasu/has_many_custom_pk_new_record | Jon Leighton | 2011-11-27 | 1 | -1/+28 |
|\ \ \ | |/ / |/| | | New records should load has_many relationships with custom primary keys | ||||
| * | | load has_many associations keyed off a custom primary key if that key is ↵ | Brian Samson | 2011-11-25 | 1 | -1/+28 |
| | | | | | | | | | | | | present but the record is unsaved | ||||
* | | | add the query to AR::Relation#explain output | Xavier Noria | 2011-11-25 | 3 | -0/+9 |
|/ / | | | | | | | | | | | | | Rationale: this is more readable if serveral queries are involved in one call. Also, it will be possible to let AR log EXPLAINs automatically in production mode, where queries are not even around. | ||||
* | | fixing tests on ruby 1.8 | Aaron Patterson | 2011-11-20 | 1 | -1/+3 |
| | | |||||
* | | pushing caching and visitors down to the connection | Aaron Patterson | 2011-11-19 | 6 | -120/+62 |
| | | |||||
* | | Verify that #3690 has been closed by previous changes to the mysql | Jon Leighton | 2011-11-19 | 2 | -2/+10 |
| | | | | | | | | | | | | | | | | adapters. These tests fail on the v3.1.2 tag. Closes #3690. | ||||
* | | Revert "Merge pull request #1163 from amatsuda/sexier_migration_31" | Aaron Patterson | 2011-11-17 | 1 | -120/+0 |
| | | | | | | | | | | | | | | | | | | | | This reverts commit 0e407a90413d8a19002b85508d811ccdf2190783, reversing changes made to 533a9f84b035756eedf9fdccf0c494dc9701ba72. Conflicts: activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb activerecord/test/cases/migration_test.rb | ||||
* | | Revert "Merge pull request #3603 from vijaydev/change_table_without_block_arg" | Aaron Patterson | 2011-11-17 | 1 | -54/+0 |
| | | | | | | | | | | | | | | | | | | This reverts commit 81fad6a270ec3cbbb88553c9f2e8200c34fd4d13, reversing changes made to 23101de283de13517e30c4c3d1ecc65525264886. Conflicts: activerecord/test/cases/migration_test.rb | ||||
* | | `ActiveRecord::Base#becomes` should retain the errors of the original object. | James Adam | 2011-11-16 | 1 | -0/+8 |
| | | | | | | | | This commit contains a simple failing test that demonstrates the behaviour we expect, and a fix. When using `becomes` to transform the type of an object, it should retain any error information that was present on the original instance. | ||||
* | | fixing tests on PG | Aaron Patterson | 2011-11-16 | 1 | -1/+1 |
| | | |||||
* | | Fixes issue #3483, regarding using a mixture of ranges and discrete values ↵ | Ryan Naughton | 2011-11-14 | 1 | -1/+1 |
| | | | | | | | | in find conditions. Paired with Joey Schoblaska. |