aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* "warning: assigned but unused variable"Akira Matsuda2014-08-211-1/+1
|
* Merge pull request #16172 from Agis-/hmt_scope_arityRafael Mendonça França2014-08-204-0/+17
|\ | | | | has_many :through with dynamic condition merging
| * Only merge scopes with zero arity in has_many throughAgis-2014-08-204-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with dynamic conditions. Fixes #16128 This bug was introduced in https://github.com/rails/rails/commit/c35e438620f2d56562251571377995359546393d so it's present from 4.1.2-rc1 and after. https://github.com/rails/rails/commit/c35e438620f2d56562251571377995359546393d merges any relation scopes passed as proc objects to the relation, but does *not* take into account the arity of the lambda. To reproduce: https://gist.github.com/Agis-/5f1f0d664d2cd08dfb9b
* | Merge pull request #16145 from phoet/patch-2Rafael Mendonça França2014-08-201-5/+10
|\ \ | | | | | | don't log errors when all is fine
| * | don't log errors when all is finePeter Schröder2014-07-171-5/+10
| | |
* | | Ignore Postgresql "SELECT tablename FROM pg_tables" when counting queriesAkira Matsuda2014-08-201-1/+1
| | |
* | | Drop schema_migrations table only when existsAkira Matsuda2014-08-201-1/+1
| |/ |/|
* | Merge pull request #16349 from jmcnevin/masterRafael Mendonça França2014-08-191-0/+15
|\ \ | | | | | | Correctly determine if migration is needed.
| * | Correctly determine if migration is needed.Jeremy McNevin2014-08-131-0/+15
| | | | | | | | | | | | | | | | | | | | | This method would assume that if last migration in the migrations directory matched the current schema version, that the database was up to date, but this does not account for new migrations with older timestamps that may be pending.
* | | Fixes the `Relation#exists?` to work with polymorphic associations.Kassio Borges2014-08-182-0/+15
| | | | | | | | | | | | Fixes #15821.
* | | Merge pull request #16537 from arthurnn/stop_swallowing_errors_2Godfrey Chan2014-08-182-0/+79
|\ \ \ | | | | | | | | Add option to stop swallowing errors on callbacks.
| * | | Add option to stop swallowing errors on callbacks.Arthur Neves2014-08-182-0/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, Active Record will rescue any errors raised within after_rollback/after_create callbacks and print them to the logs. Next versions of rails will not rescue those errors anymore, and just bubble them up, as the other callbacks. This adds a opt-in flag to enable that behaviour, of not rescuing the errors. Example: # For not swallow errors in after_commit/after_rollback config.active_record.errors_in_transactional_callbacks = true [fixes #13460]
* | | | Check attributes passed to create_with and whereRafael Mendonça França2014-08-181-0/+30
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the request parameters are passed to create_with and where they can be used to do mass assignment when used in combination with Relation#create. Fixes CVE-2014-3514 Conflicts: activerecord/lib/active_record/relation/query_methods.rb
* | | Merge pull request #16528 from ↵Santiago Pastorino2014-08-181-0/+4
|\ \ \ | | | | | | | | | | | | | | | | byroot/add-test-case-for-nested-array-in-where-conditions Add a test case of nested empty array values in conditions
| * | | Add a test case of nested empty array values in conditionsJean Boussier2014-08-171-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Post.where(id: [[]]).to_a Used to fail with a SQL syntax error (until 4.1): SELECT ... WHERE id in (); It now properly generate: SELECT ... WHERE 1=0;
* | | | Merge pull request #16481 from sgrif/sg-change-default-timestampsDavid Heinemeier Hansson2014-08-179-17/+77
|\ \ \ \ | | | | | | | | | | Change the default `null` value for timestamps
| * | | | Change the default `null` value for timestampsSean Griffin2014-08-129-17/+77
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As per discussion, this changes the model generators to specify `null: false` for timestamp columns. A warning is now emitted if `timestamps` is called without a `null` option specified, so we can safely change the behavior when no option is specified in Rails 5.
* | | | | Merge pull request #16458 from chancancode/ar_fix_reserved_inheritanceGodfrey Chan2014-08-171-0/+18
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | Fixed issue w/custom accessors + reserved name + inheritance Conflicts: activerecord/CHANGELOG.md
| * | | | Fixed issue w/custom accessors + reserved name + inheritanceGodfrey Chan2014-08-111-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed an issue where custom accessor methods (such as those generated by `enum`) with the same name as a global method are incorrectly overridden when subclassing. This was partially fixed in 4155431 then broken again by e5f15a8. Fixes #16288.
* | | | | Implement `_was` and `changes` for in-place mutations of AR attributesSean Griffin2014-08-161-0/+21
| | | | |
* | | | | Merge pull request #16517 from sgrif/sg-comparable-attributesRafael Mendonça França2014-08-162-0/+36
|\ \ \ \ \ | | | | | | | | | | | | Implement `==` on `Type::Value` and `Attribute`
| * | | | | Implement `==` on `Type::Value` and `Attribute`Sean Griffin2014-08-152-0/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was a small self contained piece of the refactoring that I am working on, which required these objects to be comparable.
* | | | | | Fix regression on after_commit in nested transactions.Arthur Neves2014-08-151-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | after_commit should not run in nested transactions, however they should run once the outermost transaction gets committed. This patch fixes the problem copying the records from the Savepoint to its parent. So the RealTransaction will have all records that needs to run callbacks on it. [fixes #16425]
* | | | | | Use *_transaction methods in TransactionManagerArthur Neves2014-08-151-0/+24
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | Use `commit_transaction`/`rollback_transaction` on `within_new_transaction` method, so they make sure they `pop` the transaction from the stack before calling the methods `commit`/`rollback`.
* | | | | fix typo in method name (broken build :sweat:)Yves Senn2014-08-151-1/+1
| | | | |
* | | | | prefer `has_attribute?` over `attributes.key?`.Yves Senn2014-08-151-1/+1
| | | | | | | | | | | | | | | | | | | | Follow up to the discussion on #16505.
* | | | | create_table + transactional_fixtures = :bomb:Akira Matsuda2014-08-151-0/+4
| | | | |
* | | | | Ignore MySQL "SHOW VARIABLES" when counting queriesAkira Matsuda2014-08-151-1/+1
| | | | |
* | | | | Be sure to reset PK name renamed in the testAkira Matsuda2014-08-151-0/+3
| | | | |
* | | | | Warm up Symbols with where methodAkira Matsuda2014-08-151-1/+1
| | | | | | | | | | | | | | | | | | | | Looks like #first wasn't warm enough...
* | | | | Merge pull request #16502 from bogdan/where-hash-nested-relationSantiago Pastorino2014-08-141-0/+9
|\ \ \ \ \ | | | | | | | | | | | | [Regression 4.0 -> 4.1] Fixed AR::Relation#where edge case with Hash and other Relation
| * | | | | Fixed AR::Relation#where edge case with Hash and other RelationBogdan Gusiev2014-08-141-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Example: Author.where(posts: { author_id: Author.where(country_id: 1) }).joins(:posts)
* | | | | | Ignore SCHEMA queries in some habtm testsAkira Matsuda2014-08-141-4/+4
| | | | | |
* | | | | | Merge pull request #8813 from ↵Yves Senn2014-08-141-0/+19
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | greyblake/dont_write_timestamps_if_they_are_not_attributes Write timestamps only if there are timestamps columns Conflicts: activerecord/CHANGELOG.md
| * | | | | | Do not try to write timestamps if they are missing #8813Potapov Sergey2014-02-161-0/+22
| | | | | | |
* | | | | | | Make sure that fixtures are loaded before findingAkira Matsuda2014-08-141-0/+4
| | | | | | |
* | | | | | | FormatAkira Matsuda2014-08-141-2/+2
| | | | | | |
* | | | | | | Clear validators before and after each testAkira Matsuda2014-08-142-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Or some tests fail when run in random order
* | | | | | | Finally! None of our tests are order_dependent!Akira Matsuda2014-08-141-5/+0
| |_|_|_|/ / |/| | | | |
* | | | | | Merge pull request #16491 from akshay-vishnoi/doc-changesYves Senn2014-08-132-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | [ci skip] fix spelling of overridden
| * | | | | | [ci skip] fix spelling of overrideAkshay Vishnoi2014-08-132-2/+2
| | |_|_|/ / | |/| | | |
* / | | | | `index_exists?` with `:name` checks specified columns.Yves Senn2014-08-131-0/+6
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Yves Senn & Matthew Draper] The column check was embodied in the defaul index name. If the :name option was used, the specified columns were not verified at all. Given: ``` assert connection.index_exists?(table_name, :foo_id, :name => :index_testings_on_yo_momma) ``` That index could have been defined on any field, not necessarily on `:foo_id`.
* | | | | :bomb:Rafael Mendonça França2014-08-121-1/+1
| | | | |
* | | | | Nobody sucks so nobody should call this awful method nameRafael Mendonça França2014-08-121-1/+1
| | | | |
* | | | | users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent!Akira Matsuda2014-08-121-0/+5
| |_|/ / |/| | | | | | | | | | | | | | | Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes everyone's tests order dependent, which should never be done by the framework.
* | | | Define id_was to get the previous value of the primary keyRafael Mendonça França2014-08-061-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently when we call id_was and we have a custom primary key name Active Record will return the current value of the primary key. This make impossible to correctly do an update operation if you change the id. Fixes #16413
* | | | Merge pull request #16364 from arthurnn/make_transaction_one_classJeremy Kemper2014-08-051-2/+2
|\ \ \ \ | |_|/ / |/| | | Clarify Transaction responsibilities by breaking unneeded inheritance hierarchy.
| * | | Cleanup Transaction inheritance.Arthur Neves2014-08-051-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Transaction class doesnt need to encapsulate the transaction state using inheritance. This removes all Transaction subclasses, and let the Transaction object controls different actions based on its own state. Basically the only actions would behave differently are `being`,`commit`,`rollback` as they could act in a savepoint or in a real transaction.
* | | | Merge pull request #16333 from ↵Yves Senn2014-08-041-0/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | joker1007/fix_decimal_cast_from_float_with_large_precision Fix type casting to Decimal from Float with large precision Conflicts: activerecord/CHANGELOG.md
| * | | | Fix type casting to Decimal from Float with ...joker10072014-08-011-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | When I defines large precision column at RDBMS, I assigns float value, raise ArgumentError (precision too large).
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 10:10:41 +0000