aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Merge pull request #6416 from pmahoney/threadsafe-connection-pool"Rafael Mendonça França2012-05-222-116/+1
| | | | | | | | | | | | This reverts commit d2901f0fc4270a765717ad572d559dc49a56b3a8, reversing changes made to 525839fdd8cc34d6d524f204528d5b6f36fe410c. Conflicts: activerecord/test/cases/connection_pool_test.rb Reason: This change broke the build (http://travis-ci.org/#!/rails/rails/builds/1391490) and we don't have any solution until now. I asked the author to try to fix it and open a new pull request.
* Merge pull request #6368 from Antiarchitect/store-indifferent-accessJeremy Kemper2012-05-221-0/+34
|\ | | | | Support migrating from Hash to HashWithIndifferentAccess for accessing attributes.
| * Convert Hash to HashWithIndifferentAccess in ActiveRecord::Store.Andrey Voronkov2012-05-221-0/+34
| | | | | | | | | | | | | | In order to make migration from 3.x apps easier, we should try to convert Hash instances to HashWithIndifferentAccess, to allow accessing values with both symbol and a string. This is follow up to changes in 3c0bf043.
* | Restore the frozen state on rollback. Fixes #6417.Godfrey Chan2012-05-211-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, when saving a frozen record, an exception would be thrown which causes a rollback. However, there is a bug in active record that "defrost" the record as a side effect: >> t = Topic.new => #<Topic id: nil, ...> >> t.freeze => #<Topic id: nil, ...> >> t.save RuntimeError: can't modify a frozen Hash >> t.frozen? => false >> t.save => true This patch fixes the bug by explictly restoring the frozen state on the attributes Hash after every rollback.
* | Remove not used variables from connection poll testCarlos Antonio da Silva2012-05-211-2/+2
| | | | | | | | These variables were issuing some "not used" warnings.
* | Refactor aggregation writer methodCarlos Antonio da Silva2012-05-211-1/+0
| | | | | | | | Only constantize class_name once.
* | Merge pull request #6416 from pmahoney/threadsafe-connection-poolAaron Patterson2012-05-212-1/+116
|\ \ | | | | | | Make connection pool fair with respect to waiting threads.
| * | Make connection pool fair with respect to waiting threads.Patrick Mahoney2012-05-202-1/+116
| | |
* | | Merge pull request #6143 from senny/composed_of_converter_returns_nilAaron Patterson2012-05-212-0/+23
|\ \ \ | |/ / |/| | allow the :converter Proc form composed_of to return nil
| * | allow the :converter Proc form composed_of to return nilYves Senn2012-05-032-0/+23
| | | | | | | | | | | | | | | | | | | | | This makes it possible to filter invalid input values before they are passed into the value-object (like empty strings). This behaviour is only relevant if the :allow_nil options is set to true. Otherwise you will get the resulting NoMethodError.
* | | fixed typo in word finidingIvan Kukobko2012-05-201-1/+1
| | |
* | | Ensure that CollectionAssociation#replace returns proper targetPiotr Sarnacki2012-05-191-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | The fix commited in e2a070c was returning the `new_target`, as a try to return whatever user replaced association with. The problem is, the resulting association target may be ordered differently. In such case we want to return the target that will be later used for that association.
* | | Merge pull request #6376 from jgaskins/timestamp-microsecondsJeremy Kemper2012-05-181-1/+1
|\ \ \ | | | | | | | | Increase numeric-timestamp precision to nanoseconds
| * | | Increase `AR#cache_key` precision to nanosecondsJamie Gaskins2012-05-191-1/+1
| | | |
* | | | fix #delete_all with habtm with :delete_sqlJon Leighton2012-05-181-0/+6
| | | |
* | | | Perf: Don't load the association for #delete_all.Jon Leighton2012-05-181-0/+12
| | | | | | | | | | | | | | | | Bug #6289
* | | | port some mocha to minitest/mockAaron Patterson2012-05-183-222/+222
| |_|/ |/| |
* | | quarantine more deprecated stuffJon Leighton2012-05-184-36/+36
| | |
* | | quarantine deprecated testsJon Leighton2012-05-1810-578/+605
|/ /
* | Merge pull request #6238 from pwnall/pgsql_bytea_limitAaron Patterson2012-05-171-0/+1
|\ \ | | | | | | Postgresql doesn't accept limits on binary (bytea) columns.
| * | Postgresql doesn't accept limits on binary (bytea) columns.Victor Costan2012-05-091-0/+1
| | |
* | | Merge pull request #6250 from iGEL/dont_destroy_readonly_modelsAaron Patterson2012-05-171-0/+1
|\ \ \ | | | | | | | | Don't allow to destroy readonly models
| * | | Don't destroy readonly modelsJohannes Barre2012-05-171-0/+1
| | | |
* | | | Fix warning: ambiguous first argument.kennyj2012-05-181-1/+1
|/ / /
* | | Merge pull request #6058 from ↵Jon Leighton2012-05-172-1/+13
|\ \ \ | | | | | | | | | | | | | | | | RStankov/relation-from-to-accept-other-relation-objects Relation#from to accept other Relation objects
| * | | Relation#from to accept other Relation objectsRadoslav Stankov2012-05-172-1/+13
| | | | | | | | | | | | | | | | Record.from("(#{sub_query.to_sql})") -> Record.from(sub_query) Record.from("(#{sub_query.to_sql}) a") -> Record.from(sub_query, :a)
* | | | Merge pull request #5453 from ↵Aaron Patterson2012-05-161-0/+6
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | JonRowe/patch_uniq_has_and_belongs_to_many_when_already_loaded When Active Record has already loaded a unique association `.size` returns the wrong number.
| * | | | when using a preloaded array and the uniq flag is set then return the size ↵Jon Rowe2012-03-151-0/+6
| | | | | | | | | | | | | | | | | | | | of the uniq array
* | | | | Merge pull request #6358 from jfirebaugh/schema_defineAaron Patterson2012-05-161-0/+7
|\ \ \ \ \ | | | | | | | | | | | | Call methods on the correct instance in AR::Schema.define
| * | | | | Call methods on the correct instance in AR::Schema.defineJohn Firebaugh2012-05-161-0/+7
| | |/ / / | |/| | | | | | | | | | | | | | | | | | Now that migrations support instance methods, we should use the same instance rather than relying on delegation to a global instance. This allows subclassing AR::Schema.
* | | | | Fix CollectionAssociation#replace to return new target (closes #6231)Piotr Sarnacki2012-05-161-0/+12
| | | | |
* | | | | Merge pull request #6192 from ↵Aaron Patterson2012-05-162-8/+32
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | danmcclain/add_inet_and_cidr_types_to_postgresql_adapter Add support for macaddr, inet, and cidr types to PostgreSQL adapter
| * | | | | Removes NetAddr dependencyDan McClain2012-05-081-3/+4
| | | | | |
| * | | | | Converts inet and cidr columns to NetAddr::CIDRDan Seaver2012-05-071-4/+6
| | | | | |
| * | | | | Adds migration and schema dump support for INET, CIDR, and MACADDRDan Seaver2012-05-052-3/+24
| | | | | |
* | | | | | Merge pull request #5535 from markmcspadden/issue_5527_rollbacksAaron Patterson2012-05-161-0/+37
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Allow manual rollbacks in after_save to reset object correctly
| * | | | | Allow manual rollbacks in after_save to reset object correctlyMark McSpadden2012-03-211-0/+37
| | | | | |
* | | | | | MySQL returns "SUM(DISTINCT(credit_limit))" as the column name unlessAaron Patterson2012-05-161-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | an alias is provided. Without the alias, the column cannot be found and properly typecast.
* | | | | | Merge pull request #6136 from mhfs/sqlbypass_fixesAaron Patterson2012-05-161-0/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | Bring SqlByPassTest to light and fix broken tests
| * | | | | | Rename test file so that the test suite matches it, implement `persisted?` ↵Marcelo Silveira2012-05-161-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | for SqlBypass as expected by tests and convert session_id to string before using on queries to get correct quotes on postgresql (avoid casting error).
* | | | | | | Merge pull request #6349 from erichmenge/patch-raise-type-errorsAaron Patterson2012-05-163-6/+33
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Integer limit out of range should be allowed to raise. Closes #6272
| * | | | | | | Integer limit out of range should be allowed to raise. Closes #6272Erich Menge2012-05-163-6/+33
| |/ / / / / /
* | | | | | | Merge pull request #6336 from erichmenge/patch-pluck-fragmentCarlos Antonio da Silva2012-05-161-0/+3
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fixes issue where SQL fragments prevented type casting based on column
| * | | | | | | Fixes issue where SQL fragments prevented type casting based on column type.Erich Menge2012-05-161-0/+3
| |/ / / / / /
* | | | | | | Remove unneeded testsPiotr Sarnacki2012-05-161-12/+0
| | | | | | |
* | | | | | | SQLite3 doesn't actually support the 'time' type.Erich Menge2012-05-153-3/+15
|/ / / / / /
* | | | | | Merge pull request #6325 from kennyj/fix_5832-3Carlos Antonio da Silva2012-05-151-5/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Remove unnecessary assertions.
| * | | | | | Remove unnecessary assertions. We should only test the before_seq isn't same ↵kennyj2012-05-161-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | to the after_seq when using sequencer.
* | | | | | | Restore support for Model.pluck('sql fragment')Jeremy Kemper2012-05-151-0/+8
|/ / / / / /
* | | | | | Set the primary key during #copy_table if necessary. Fixes [#2312]Sean Scally2012-05-141-0/+8
| | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 08:56:14 +0000