| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Disabling the hstore extension during testing created order dependent
test failures.
|
|
|
|
|
|
|
|
|
|
|
|
| |
I don't think this is testing anything useful, and the test code is
exceedingly brittle. It is broken since
34c7e73c1def1312e59ef1f334586ff2f668246e because the test code makes
assumptions about the implementation of PostgreSQLAdapter#active? which
are incorrect after the commit.
I could fix this test but it would be even more brittle (by stubbing the
underlying @connection.connect_poll) and it doesn't test any complex
logic. I conclude that it's not worth it.
|
| |
|
|\
| |
| | |
Fix copy table index test; Change == to ! on false in travis.rb
|
| | |
|
|/ |
|
| |
|
| |
|
|
|
|
| |
Type a fixo.
|
|
|
|
|
| |
if the association already holds that record in memory before checking
the database for the specified ids.
|
|
|
|
|
|
| |
it only cleared the validations that created :validate callbacks. This
didn't include the validates created by validates_with, so I've added a
method to clear all validations.
|
|
|
|
| |
Introduced in 5dc2e3531babcbdc165884d1a47cbcd13455522d.
|
|\
| |
| | |
Change from each to each_value;drop assignment in habtm
|
| |
| |
| |
| | |
2. drop assignment of value to sum in test
|
|\ \
| | |
| | | |
fix typos in AR. lots of them.
|
| |/ |
|
|\ \
| |/
|/|
| |
| |
| |
| |
| | |
* master-sec:
fix protocol checking in sanitization [CVE-2013-1857]
JDOM XXE Protection [CVE-2013-1856]
fix incorrect ^$ usage leading to XSS in sanitize_css [CVE-2013-1855]
stop calling to_sym when building arel nodes [CVE-2013-1854]
|
| | |
|
|\ \
| | |
| | | |
Remove ancient TODOs [ci skip]
|
| | | |
|
|/ /
| |
| |
| |
| | |
These tests should be in inheritance_test.rb since its testing a
feature which is implemented in inheritance.rb
|
| |
| |
| |
| |
| |
| |
| |
| | |
Closes #8079.
I had to rework some of the tests because the mock allowed any arguments
for `connection.exeucte`. I think this is very dangerous as there could
anything be executed without the tests noticing it.
|
| |
| |
| |
| |
| |
| | |
"utf8mb4"
Please, see rationale in the included CHANGELOG patch.
|
| |
| |
| |
| |
| |
| |
| |
| | |
PR #5210 added a Friendship model to illustrate a bug, but in doing so
created a confusing structure because both belongs_to declarations in
Friendship referred to the same side of the join. The new structure
maintains the integrity of the bug test while changing the follower
relationship to be more useful for other testing.
|
| |
| |
| |
| |
| | |
the primary key on an association will make sure that the corresponding
counter on the association is changed properly. Fixes #9722.
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
senny/9712_option_to_turn_references_deprecation_off
make it possible to disable implicit join references.
|
| | |
| | |
| | |
| | | |
Closes #9712.
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
This reimplements the behaviour of Rails 3, as I couldn't see why we
shouldn't cache the object, and @alindeman had a good use case for
caching it:
https://github.com/rails/rails/commit/c86a32d7451c5d901620ac58630460915292f88b#commitcomment-2784312
|
|\ \
| | |
| | | |
rename `Relation#uniq` to `Relation#distinct`
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We moved more and more away from passing options to finder / calculation
methods. The `:distinct` option in `#count` was one of the remaining places.
Since we can now combine `Relation#distinct` with `Relation#count` the option
is no longer necessary and can be deprecated.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The similarity of `Relation#uniq` to `Array#uniq` is confusing. Since our
Relation API is close to SQL terms I renamed `#uniq` to `#distinct`.
There is no deprecation. `#uniq` and `#uniq!` are aliases and will continue
to work. I also updated the documentation to promote the use of `#distinct`.
|
|\ \ \
| |/ /
|/| | |
Cast number to string in Postgres
|
| | |
| | |
| | |
| | | |
fixes #9170
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Closes #9724.
Raise an `ArgumentError` when the name of the counter does not
match an association name.
|
| | | |
|
| | | |
|
| | | |
|
|/ / |
|
| |
| |
| |
| | |
To make quote escape binary data correctly it needs the column passed in.
|
| |
| |
| |
| |
| |
| | |
assertion for
https://github.com/rails/rails/blob/ad624345e54bd20802de67b2b5c9ef29ecf5
d5f4/activerecord/lib/active_record/inheritance.rb#L32
|
| | |
|
| |
| |
| |
| | |
Take the opportunity to showcase where.not.
|
| |
| |
| |
| |
| | |
This is a follow up to #5321 and follows the general direction in
AR to make things lazy evaluated.
|
| |
| |
| |
| |
| | |
This allows end-users to have a `connection` method on their models
without clashing with ActiveRecord internals.
|
| |
| |
| |
| |
| | |
During insertion of "# This migration comes from ... " comment at the beginning of
a migration, presence of magic comment was not considered.
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Fix ActiveRecord `subclass_from_attrs` when eager_load is false.
Conflicts:
activerecord/CHANGELOG.md
|
| | |
| | |
| | |
| | |
| | | |
It cannot find subclass because all classes are loaded automatically
when it needs.
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Use the index name explicitly provided in a migration when reverting.
Fixes #8868
Conflicts:
activerecord/CHANGELOG.md
|