| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| | |
neerajdotname/make_test_order_independent_by_resetting_timezone
make test order independent by resetting timezone
|
| | |
|
|\ \
| | |
| | | |
reset default timezone and make test order independent
|
| |/ |
|
|\ \
| | |
| | |
| | |
| | | |
neerajdotname/make_order_independent_association_test
make test not depend on order
|
| |/
| |
| |
| |
| |
| |
| | |
`NestedThroughAssociationsTest` adds records to `member_details` table.
When test performs `@member_details[0]` then the order of record
is not guaranteed. Hence it is best to start with a clean slate by
deleting unwanted records.
|
|/
|
|
|
| |
`ReflectionTest` uses column information in tests and those tests break
if tests are run in random order.
|
| |
|
| |
|
|
|
|
|
|
| |
change def self.primary_key to self.primary_key
change def self.primary_key to self.primary_key
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
Some adapters require column information to do their job properly.
By enforcing the provision of the column for this internal method
we ensure that those using adapters that require column information
will always get the proper behavior.
|
|
|
|
|
|
| |
This includes fixing typos in changelog, removing a deprecated
mocha/setup test require, and preferring the `column_for_attribute`
accessor over direct access to the columns_hash in the new code.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When calling quote_value the underlying connection sometimes requires
more information about the column to properly return the correct quoted
value.
I ran into this issue when using optimistic locking in JRuby and the
activerecord-jdbcmssql-adapter. In SQLSever 2000, we aren't allowed to
insert a integer into a NVARCHAR column type so we need to format it as
N'3' if we want to insert into the NVARCHAR type. Unfortuantely, without
the column type being passed the connection adapter cannot properly return
the correct quote value because it doesn't know to return N'3' or '3'.
This patch is fairly straight forward where it just passes in the column
type into the quote_value, as it already has the ability to take in the column,
so it can properly handle at the connection level.
I've added the tests required to make sure that the quote_value method
is being passed the column type so that the underlying connection can
determine how to quote the value.
|
|
|
|
|
|
|
|
|
| |
Fixes #11497
As `ActiveRecord::ConnectionAdapters::ConnectionManagement` middleware does not rescue from Exception (but only from StandardError),
the Connection Pool quickly runs out of connections when multiple erroneous Requests come in right after each other.
Recueing from all exceptions and not just StandardError, fixes this behaviour.
|
|
|
|
|
| |
This reverts commit cb1d07e43926bcec95cb8b4a663ca9889173395a, reversing
changes made to 754a373e301d2df0b12a11083405252722bc8366.
|
| |
|
|
|
|
|
| |
Using the mysql2 adapter, boolean values were sometimes being incorrectly cast
to 't' or 'f'. This changes the cast to match the mysql adapter behavior, ie 1 and 0.
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| | |
jetthoughts/11450_do_not_resave_destroyed_association
Do not re-save destroyed association on saving parent object
|
| |
| |
| |
| | |
Closes #11450
|
|/
|
| |
for attributes that are columns.
|
|\
| |
| | |
Remove extra decrement of transaction level
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
`rollback_active_record_state!` tries to restore model state on `Exception`
by invoking `restore_transaction_record_state` it decrement deep level by `1`.
After restoring it ensure that states to be cleared
and level decremented by invoking `clear_transaction_record_state`,
which cause the bug: because state already reduced in `restore_transaction_record_state`.
Removed double derement of transaction level
and removed duplicated code which clear transaction state for top level.
|
|/
|
|
|
|
| |
Stop special-casing Arel::Nodes as exempt from reference scanning in
order. Instead, only scan order values that are strings for a table
reference.
|
| |
|
|
|
|
|
|
| |
association proxy
Closes #11248.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
Deprecation removed build fixed
|
| |
| |
| |
| | |
see discussion here #11274
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
jetthoughts/11288_remove_extra_queries_for_belongs_to_with_touch
#11288: Removed duplicated touching
Conflicts:
activerecord/CHANGELOG.md
|
| | |
| | |
| | |
| | |
| | |
| | | |
if belongs to model with touch option on touch
Closes #11288
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
arunagw/disable_implicit_join_references_removed"
`disable_implicit_join_references=` was only deprecated on `master`,
not with rails 4.0. We can remove it after 4.1
This reverts commit 3c719ead414ffd29e71efce185698af979052abb, reversing
changes made to d5c3bf9722abd5733a769c8d789de3f74dbfb92d.
|
| |
| |
| |
| | |
simplified logic to calculate number of queries by using assert_queries
|
| | |
|
| | |
|
| |
| |
| |
| | |
Removed tests from deprecated code.
|
|/
|
|
|
| |
in favor of `begin_transaction`
with `:joinable` option.
|
| |
|