aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #11668 from neerajdotname/make_test_order_independent_2Rafael Mendonça França2013-07-302-3/+6
|\ | | | | Make test order independent
| * assert_no_queries should ignore certain sqlsNeeraj Singh2013-07-301-1/+3
| | | | | | | | | | postgresql test if randomly executed then executes "SHOW max_identifier_length". Hence the need to ignore certain predefined sqls that deal with system calls.
| * assert_no_queries should allow to ignore some queriesNeeraj Singh2013-07-301-2/+3
| |
* | Merge branch 'revert-order-prepending'Rafael Mendonça França2013-07-304-15/+15
|\ \ | | | | | | | | | | | | Conflicts: activerecord/CHANGELOG.md
| * | Revert change on ActiveRecord::Relation#order method that prepends newRafael Mendonça França2013-07-294-15/+15
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | order on the old ones The previous behavior added a major backward incompatibility since it impossible to have a upgrade path without major changes on the application code. We are taking the most conservative path to be consistent with the idea of having a smoother upgrade on Rails 4. We are reverting the behavior for what was in Rails 3.x and, if needed, we will implement a new API to prepend the order clauses in Rails 4.1.
* | Merge pull request #10673 from sgrif/masterRafael Mendonça França2013-07-291-0/+14
|\ \ | |/ |/| Add ability to specify how a class is converted to Arel predicate when passed to where
| * Add ability to specify how a class is converted to Arel predicatesgrif2013-07-281-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds the ability for rails apps or gems to have granular control over how a domain object is converted to sql. One simple use case would be to add support for Regexp. Another simple case would be something like the following: class DateRange < Struct.new(:start, :end) def include?(date) (start..end).cover?(date) end end class DateRangePredicate def call(attribute, range) attribute.in(range.start..range.end) end end ActiveRecord::PredicateBuilder.register_handler(DateRange, DateRangePredicate.new) More complex cases might include taking a currency object and converting it from EUR to USD before performing the query. By moving the existing handlers to this format, we were also able to nicely refactor a rather nasty method in PredicateBuilder.
* | Merge pull request #11651 from ↵Carlos Antonio da Silva2013-07-291-1/+1
|\ \ | | | | | | | | | | | | neerajdotname/log_should_mimick_original_log_method interceptor should mimick original method
| * | interceptor should mimick original methodNeeraj Singh2013-07-291-1/+1
| |/ | | | | | | This fix also makes the test order independent.
* | Merge pull request #11649 from ↵Carlos Antonio da Silva2013-07-291-30/+20
|\ \ | | | | | | | | | | | | neerajdotname/use_method_with_active_record_default_timezone use method with_active_record_default_timezone
| * | use method with_active_record_default_timezoneNeeraj Singh2013-07-291-30/+20
| |/
* / remove duplicate methodNeeraj Singh2013-07-291-7/+0
|/ | | | This method is already present in helper.rb
* Revert "fix order dependent test related to migration"Akira Matsuda2013-07-291-4/+0
| | | | | | This reverts commit 10259c3e906da2191ef0d43cd664a3b5504d9f8c. reason: this causes rake test_mysql and test_mysql2 fail
* Properly repair validations when dynamically addedAkira Matsuda2013-07-291-24/+30
|
* Clear class ivar before testingAkira Matsuda2013-07-291-0/+2
|
* Unneeded assertionAkira Matsuda2013-07-291-1/+1
|
* Don't rewrite AR connection#commit_db_transaction method globallyAkira Matsuda2013-07-291-4/+4
|
* Merge pull request #11641 from ankit8898/test_cleanupRafael Mendonça França2013-07-282-2/+2
|\ | | | | Cleanup of class_name
| * Cleanup of class_nameAnkit Gupta2013-07-282-2/+2
| | | | | | | | Don't think class name is needed as by default belongs_to :select will be linked to Select class.
* | Merge pull request #11634 from ↵Rafael Mendonça França2013-07-281-0/+4
|\ \ | | | | | | | | | | | | neerajdotname/fix_order_dependent_test_for_migration fix order dependent test related to migration
| * | fix order dependent test related to migrationNeeraj Singh2013-07-281-0/+4
| | | | | | | | | | | | | | | | | | If the order in which tests are executed is changed then test fails. This commit ensures that all migrations are run before ensuring that there are no pending migration.
* | | Merge pull request #11635 from ↵Rafael Mendonça França2013-07-281-0/+2
|\ \ \ | | | | | | | | | | | | | | | | neerajdotname/make_test_order_independent_by_resetting_timezone make test order independent by resetting timezone
| * | | make test order independent by resetting timezoneNeeraj Singh2013-07-281-0/+2
| |/ /
* | | Merge pull request #11637 from neerajdotname/make_test_not_depend_on_orderRafael Mendonça França2013-07-281-0/+4
|\ \ \ | | | | | | | | reset default timezone and make test order independent
| * | | reset default timezone and make test order independentNeeraj Singh2013-07-281-0/+4
| |/ /
* | | Merge pull request #11638 from ↵Rafael Mendonça França2013-07-281-0/+1
|\ \ \ | |_|/ |/| | | | | | | | neerajdotname/make_order_independent_association_test make test not depend on order
| * | make test not depend on orderNeeraj Singh2013-07-281-0/+1
| |/ | | | | | | | | | | | | `NestedThroughAssociationsTest` adds records to `member_details` table. When test performs `@member_details[0]` then the order of record is not guaranteed. Hence it is best to start with a clean slate by deleting unwanted records.
* / fix order dependent testNeeraj Singh2013-07-281-0/+5
|/ | | | | `ReflectionTest` uses column information in tests and those tests break if tests are run in random order.
* used flat_map instead of map.flattenKarunakar (Ruby)2013-07-251-1/+1
|
* :scissors: [ci skip]Carlos Antonio da Silva2013-07-251-1/+1
|
* change function def self.table_name to self.table_nameRajarshi Das2013-07-252-5/+3
| | | | | | change def self.primary_key to self.primary_key change def self.primary_key to self.primary_key
* More unused associations in AR test modelsAkira Matsuda2013-07-258-13/+0
|
* Clean up unused associations in AR test modelAkira Matsuda2013-07-251-3/+0
|
* acually get the actual source reflection :cry::gun:Aaron Patterson2013-07-231-2/+3
|
* stop relying on side effects of const_missingAaron Patterson2013-07-231-0/+6
|
* Defines the return type of select / select_all method.kennyj2013-07-231-0/+5
|
* Don't allow `quote_value` to be called without a columnBen Woosley2013-07-221-1/+1
| | | | | | | Some adapters require column information to do their job properly. By enforcing the provision of the column for this internal method we ensure that those using adapters that require column information will always get the proper behavior.
* Tidy up the "Specified column type for quote_value" changesBen Woosley2013-07-221-1/+0
| | | | | | This includes fixing typos in changelog, removing a deprecated mocha/setup test require, and preferring the `column_for_attribute` accessor over direct access to the columns_hash in the new code.
* Specified column type for quote_valueAlfred Wong2013-07-221-0/+13
| | | | | | | | | | | | | | | | | | | | | When calling quote_value the underlying connection sometimes requires more information about the column to properly return the correct quoted value. I ran into this issue when using optimistic locking in JRuby and the activerecord-jdbcmssql-adapter. In SQLSever 2000, we aren't allowed to insert a integer into a NVARCHAR column type so we need to format it as N'3' if we want to insert into the NVARCHAR type. Unfortuantely, without the column type being passed the connection adapter cannot properly return the correct quote value because it doesn't know to return N'3' or '3'. This patch is fairly straight forward where it just passes in the column type into the quote_value, as it already has the ability to take in the column, so it can properly handle at the connection level. I've added the tests required to make sure that the quote_value method is being passed the column type so that the underlying connection can determine how to quote the value.
* rescue from all exceptions in `ConnectionManagement#call`Vipul A M2013-07-221-2/+2
| | | | | | | | | Fixes #11497 As `ActiveRecord::ConnectionAdapters::ConnectionManagement` middleware does not rescue from Exception (but only from StandardError), the Connection Pool quickly runs out of connections when multiple erroneous Requests come in right after each other. Recueing from all exceptions and not just StandardError, fixes this behaviour.
* Revert "Merge pull request #11120 from awilliams/ar_mysql2_boolean_quoting"Yves Senn2013-07-171-25/+0
| | | | | This reverts commit cb1d07e43926bcec95cb8b4a663ca9889173395a, reversing changes made to 754a373e301d2df0b12a11083405252722bc8366.
* removes the obsolete private method column_methods_hash [Closes #11406]Xavier Noria2013-07-163-30/+28
|
* Unifies mysql and mysql2 casting of booleansawilliams2013-07-161-0/+25
| | | | | Using the mysql2 adapter, boolean values were sometimes being incorrectly cast to 't' or 'f'. This changes the cast to match the mysql adapter behavior, ie 1 and 0.
* `change_column` for PG adapter respects `:array` option.Yves Senn2013-07-161-0/+12
|
* reorder bind parameters when merging relationsAaron Patterson2013-07-152-1/+25
|
* use arel rather than slapping together SQL stringsAaron Patterson2013-07-151-3/+6
|
* Merge pull request #11451 from ↵Yves Senn2013-07-151-0/+7
|\ | | | | | | | | jetthoughts/11450_do_not_resave_destroyed_association Do not re-save destroyed association on saving parent object
| * Do not re-save destroyed association on saving parent objectPaul Nikitochkin2013-07-151-0/+7
| | | | | | | | Closes #11450
* | Remove deprecation warning from attribute_missing Arun Agrawal2013-07-151-15/+0
|/ | | for attributes that are columns.
* Merge pull request #11434 from jetthoughts/new_save_transaction_bugfixSantiago Pastorino2013-07-141-0/+14
|\ | | | | Remove extra decrement of transaction level
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-07 21:45:15 +0000