Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Return nil from read_attribute(:foo) if 'foo' is not present in the ↵ | Jon Leighton | 2011-04-15 | 1 | -1/+2 |
| | | | | @attributes hash, but the _foo method has been defined. This brings the behaviour into line with the 3-0-stable branch and the master branch before 93641ed6c8c684f6b4db02b6c8a22fa9bc7f0eaf (there were previously no assertions about this which is why the change slipped through). Note that actually calling the 'foo' method will still raise an error if the attribute is not present. | ||||
* | Undo performances regressions I introduced in ↵ | Jon Leighton | 2011-04-15 | 1 | -0/+11 |
| | | | | bbe0a507f287c20ab4ae8a244fbfc810665deda5 and add test for an edge case. Add comments to explain the intent of the code. | ||||
* | Refactor test to avoid hackery | Jon Leighton | 2011-04-15 | 1 | -4/+4 |
| | |||||
* | Remove unnecessary code from define_read_method and add assertion to make ↵ | Jon Leighton | 2011-04-15 | 1 | -0/+1 |
| | | | | sure the underscored version is actually generated | ||||
* | mysql type cast should return integers when typecasting true / false | Aaron Patterson | 2011-04-14 | 2 | -0/+51 |
| | |||||
* | using the database adapter to typecast before executing prepared statement | Aaron Patterson | 2011-04-14 | 2 | -0/+20 |
| | |||||
* | inserting big decimals as strings works consistently among dbs, so use ↵ | Aaron Patterson | 2011-04-14 | 1 | -1/+1 |
| | | | | string form | ||||
* | adding a type cast method for prepared statements | Aaron Patterson | 2011-04-14 | 1 | -0/+93 |
| | |||||
* | do not depend on to_yaml being called, but rather depend on YAML being dumped | Aaron Patterson | 2011-04-13 | 1 | -6/+7 |
| | |||||
* | use index based substitution for bind parameters | Aaron Patterson | 2011-04-13 | 4 | -6/+6 |
| | |||||
* | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 2 | -2/+2 |
| | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | ||||
* | common @jonleighton :bomb: | Aaron Patterson | 2011-04-12 | 1 | -2/+1 |
| | |||||
* | Deprecate defining scopes with a callable (lambda, proc, etc) via the scope ↵ | Jon Leighton | 2011-04-12 | 4 | -21/+38 |
| | | | | class method. Just define a class method yourself instead. | ||||
* | ActiveRecord::Base.scopes hash is not needed | Jon Leighton | 2011-04-12 | 1 | -11/+0 |
| | |||||
* | Evaluate default scopes at the last possible moment in order to avoid ↵ | Jon Leighton | 2011-04-12 | 4 | -17/+16 |
| | | | | problems with default scopes getting included into other scopes and then being unable to remove the default part via unscoped. | ||||
* | Deprecated support for passing hashes and relations to default_scope, in ↵ | Jon Leighton | 2011-04-12 | 13 | -114/+294 |
| | | | | favour of defining a 'default_scope' class method in the model. See the CHANGELOG for more details. | ||||
* | Removing the scope-caching which happens on association proxies, because the ↵ | Jon Leighton | 2011-04-12 | 1 | -10/+15 |
| | | | | query is already cached by the query cacher. For formalised proof see http://www.youtube.com/watch?v=wDefXLb-FDs | ||||
* | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 2 | -2/+2 |
| | | | | suggestion! | ||||
* | wrap the pg_get_serial_sequence function and reuse it for the default ↵ | Aaron Patterson | 2011-04-11 | 1 | -0/+25 |
| | | | | sequence name | ||||
* | adding exec_insert for postgresql | Aaron Patterson | 2011-04-11 | 2 | -1/+39 |
| | |||||
* | fixing variable name in mysql test | Aaron Patterson | 2011-04-11 | 1 | -1/+1 |
| | |||||
* | adding mysql adapter test case | Aaron Patterson | 2011-04-11 | 1 | -0/+69 |
| | |||||
* | adding exec_insert to sqlite3 | Aaron Patterson | 2011-04-11 | 1 | -0/+12 |
| | |||||
* | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 4 | -6/+10 |
| | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | ||||
* | moving sqlite_adapter_tests to sqlite3_adapter_test so that the tests are ↵ | Aaron Patterson | 2011-04-08 | 2 | -229/+215 |
| | | | | actually run. :bomb: | ||||
* | Disable IdentityMap in log tests, it's not important and when running tests ↵ | Emilio Tagua | 2011-04-05 | 1 | -0/+3 |
| | | | | | | rake task it logs more messages in the tested buffer. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Destroying records via nested attributes works independent of reject_if: | Durran Jordan | 2011-04-05 | 1 | -0/+8 |
| | | | | | | | | | | - When a :_destroy truthiness is provided in the attributes hash, the record should get destroyed regardless of the result of the proc or method supplied to :reject_if. (If :allow_destroy is true) [#6006 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Add log message when loading records from Identity Map. | Emilio Tagua | 2011-04-04 | 1 | -0/+9 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Use IM when trying to load records using ID. | Emilio Tagua | 2011-04-04 | 3 | -9/+16 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | test against AR class rather than the relation (thanks Andrew White!) | Aaron Patterson | 2011-03-29 | 1 | -2/+2 |
| | |||||
* | Merge branch 'master' into zomg | Aaron Patterson | 2011-03-29 | 22 | -45/+339 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (51 commits) order is not guaranteed by this select, so add an order and call first! oracle stores this with microseconds, so convert to seconds before comparing make sure that active connections are not cleared during test when an exception happens clearing active connections in the ConnectionManagement middleware if an exception happens proxy body responses so we close database connections after body is flushed Pass the proper method_name instead of hardcoding to action_name. Quote find_in_batches ORDER BY clause [#6620 state:resolved] Delegate first!, last!, any? and many? to scoped Dont call authenticate_or_request_with_http_basic twice Remove 'warning: ambiguous first argument' when running ActionPack tests Change exists? so that it doesn't instantiate records [#6127 state:resolved] Move mapper_test to the appropriate location Update the wildcard route to be non-greedy by default, therefore be able to match the (.:format) segment [#6605 state:resolved] Fix examples Added Base.http_basic_authenticate_with to do simple http basic authentication with a single class method call [DHH] make sure we have an active database connection before running each connection management test adding active_connections? to the connection pool for finding open connections adding active_connection? to the connection pool testing app delegation from the ConnectionManagement middleware namespacing connection management tests. :heart: ... | ||||
| * | order is not guaranteed by this select, so add an order and call first! | Aaron Patterson | 2011-03-29 | 1 | -1/+1 |
| | | |||||
| * | oracle stores this with microseconds, so convert to seconds before comparing | Aaron Patterson | 2011-03-29 | 1 | -1/+1 |
| | | |||||
| * | make sure that active connections are not cleared during test when an ↵ | Aaron Patterson | 2011-03-29 | 1 | -0/+8 |
| | | | | | | | | exception happens | ||||
| * | clearing active connections in the ConnectionManagement middleware if an ↵ | Aaron Patterson | 2011-03-29 | 1 | -0/+7 |
| | | | | | | | | exception happens | ||||
| * | proxy body responses so we close database connections after body is flushed | Aaron Patterson | 2011-03-29 | 1 | -2/+22 |
| | | |||||
| * | Quote find_in_batches ORDER BY clause [#6620 state:resolved] | Andrew White | 2011-03-29 | 2 | -0/+19 |
| | | |||||
| * | Delegate first!, last!, any? and many? to scoped | Andrew White | 2011-03-29 | 2 | -1/+32 |
| | | |||||
| * | Change exists? so that it doesn't instantiate records [#6127 state:resolved] | Andrew White | 2011-03-29 | 1 | -0/+5 |
| | | |||||
| * | make sure we have an active database connection before running each ↵ | Aaron Patterson | 2011-03-28 | 1 | -4/+5 |
| | | | | | | | | connection management test | ||||
| * | adding active_connections? to the connection pool for finding open connections | Aaron Patterson | 2011-03-28 | 1 | -0/+33 |
| | | |||||
| * | adding active_connection? to the connection pool | Aaron Patterson | 2011-03-28 | 1 | -0/+8 |
| | | |||||
| * | testing app delegation from the ConnectionManagement middleware | Aaron Patterson | 2011-03-28 | 1 | -3/+20 |
| | | |||||
| * | namespacing connection management tests. :heart: | Aaron Patterson | 2011-03-28 | 1 | -18/+22 |
| | | |||||
| * | sql logger ignores schema statements | Aaron Patterson | 2011-03-28 | 1 | -0/+27 |
| | | |||||
| * | Bring #reorder back | Sebastian Martinez | 2011-03-28 | 2 | -2/+8 |
| | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
| * | Added new #update_column method. | Sebastian Martinez | 2011-03-27 | 11 | -21/+108 |
| | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
| * | Revert "Removed #update_attribute method. New #update_column method." | Sebastian Martinez | 2011-03-27 | 11 | -68/+69 |
| | | | | | | | | | | | | This reverts commit 45c233ef819dc7b67e259dd73f24721fec28b8c8. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
| * | cleaning up typecast test a little | Aaron Patterson | 2011-03-26 | 1 | -6/+8 |
| | | |||||
| * | refactoring tz to a variable rather than repeating it | Aaron Patterson | 2011-03-26 | 1 | -2/+4 |
| | |