Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Warning removed for ruby-head | Rashmi Yadav | 2013-11-07 | 1 | -1/+1 |
| | |||||
* | bring back constant to expose the enum mapping as HWIA. | Yves Senn | 2013-11-06 | 1 | -0/+6 |
| | |||||
* | store enum mapping using `Strings` instead of `Symbols`. | Yves Senn | 2013-11-05 | 1 | -2/+7 |
| | | | | | This allows to assign both `String` and `Symbol` values to the enum without having to call `to_sym`, which is a security problem. | ||||
* | direct enum assignment rasies ArgumentError for unknown values. | Yves Senn | 2013-11-05 | 1 | -0/+12 |
| | |||||
* | define enum methods inside a `Module` to make them overwritable. | Yves Senn | 2013-11-05 | 2 | -0/+10 |
| | |||||
* | Remove private API test | Rafael Mendonça França | 2013-11-05 | 1 | -10/+0 |
| | |||||
* | Use 1.9 Hash syntax consistently | Pablo Torres | 2013-11-05 | 1 | -1/+1 |
| | |||||
* | The enum value constant isn't used, so rm it for now. | Aaron Patterson | 2013-11-04 | 1 | -10/+0 |
| | |||||
* | fix copy & paste test-case naming. [ci skip] | Yves Senn | 2013-11-04 | 1 | -1/+1 |
| | |||||
* | Convert schema file to ruby 1.9 style hash | Carlos Antonio da Silva | 2013-11-04 | 1 | -214/+214 |
| | |||||
* | Style fixes on test schema file | Carlos Antonio da Silva | 2013-11-04 | 1 | -6/+6 |
| | |||||
* | Respect cache timestamp format when giving timestamps to #cache_key | Carlos Antonio da Silva | 2013-11-04 | 1 | -2/+2 |
| | |||||
* | Add test verifying that you can only sort ARs of the same type | David Heinemeier Hansson | 2013-11-02 | 1 | -1/+7 |
| | |||||
* | Revert "ActiveRecord::Base#<=> has been removed. Primary keys may not be in ↵ | David Heinemeier Hansson | 2013-11-02 | 1 | -0/+7 |
| | | | | | | | | | order," -- will be replaced with a check to ensure that the keys used for comparison are integers, and only fail if they are not. This reverts commit 6256734e2d0bdd89f4b5d11da259d40afa0c95c7. Conflicts: activerecord/CHANGELOG.md | ||||
* | Delegate #rewhere to all on the class like all other relation methods | David Heinemeier Hansson | 2013-11-02 | 1 | -0/+4 |
| | |||||
* | Merge pull request #12747 from yury/explicit-enum-values | David Heinemeier Hansson | 2013-11-02 | 3 | -0/+10 |
|\ | | | | | Explicit mapping for enum | ||||
| * | Explicit mapping for enum | Yury Korolev | 2013-11-02 | 3 | -0/+10 |
| | | |||||
* | | Added ActiveRecord::QueryMethods#rewhere which will overwrite an existing, ↵ | David Heinemeier Hansson | 2013-11-02 | 1 | -0/+30 |
| | | | | | | | | named where condition. | ||||
* | | unscope now works on default_scope after ↵ | Rafael Mendonça França | 2013-11-02 | 1 | -1/+1 |
|/ | | | | 94924dc32baf78f13e289172534c2e71c9c8cade | ||||
* | Add a test case for the scope enum adds | David Heinemeier Hansson | 2013-11-02 | 1 | -0/+4 |
| | |||||
* | Extend ActiveRecord::Base#cache_key to take an optional list of timestamp ↵ | David Heinemeier Hansson | 2013-11-02 | 2 | -1/+8 |
| | | | | attributes of which the highest will be used. | ||||
* | Use an already existing fixture | Carlos Antonio da Silva | 2013-11-02 | 1 | -1/+1 |
| | |||||
* | Fix to work on Ruby 1.9.3, example and changelog improvements | Carlos Antonio da Silva | 2013-11-02 | 2 | -5/+5 |
| | |||||
* | Added ActiveRecord::Base#enum for declaring enum attributes where the values ↵ | David Heinemeier Hansson | 2013-11-02 | 3 | -2/+41 |
| | | | | map to integers in the database, but can be queried by name | ||||
* | Fix wrong behavior where associations with dependent: :destroy options | Rafael Mendonça França | 2013-11-01 | 1 | -4/+3 |
| | | | | | | | | | was using nullify strategy This caused a regression in applications trying to upgrade. Also if the user set the dependent option as destroy he expects to get the records removed from the database. | ||||
* | Test with the right association | Rafael Mendonça França | 2013-11-01 | 1 | -3/+3 |
| | |||||
* | More Warnings removed for ruby trunk | Arun Agrawal | 2013-11-01 | 1 | -1/+1 |
| | | | | Same as 4d4ff531b8807ee88a3fc46875c7e76f613956fb | ||||
* | Warnings removed for ruby trunk | Arun Agrawal | 2013-11-01 | 3 | -23/+23 |
| | | | Same as 4d4ff531b8807ee88a3fc46875c7e76f613956fb | ||||
* | :cut: whitespace | Aaron Patterson | 2013-10-30 | 1 | -2/+2 |
| | |||||
* | fix code typo in `MysqlAdapter` .Closes #12647. | Yves Senn | 2013-10-30 | 1 | -0/+15 |
| | |||||
* | short arrays in inspect | Jan Bernacki | 2013-10-30 | 1 | -0/+5 |
| | |||||
* | Fix broken delete_all test, which will now be failing since #delete_all is ↵ | David Heinemeier Hansson | 2013-10-28 | 1 | -4/+4 |
| | | | | broken | ||||
* | Add failing test for preloading with a polymorphic association and using the ↵ | David Heinemeier Hansson | 2013-10-28 | 1 | -1/+10 |
| | | | | existential predicate | ||||
* | Merge pull request #12578 from ↵ | Rafael Mendonça França | 2013-10-27 | 1 | -1/+10 |
|\ | | | | | | | | | | | | | | | | | jeradphelps/configurable_schema_migrations_table_name Configurable name for schema_migrations table Conflicts: activerecord/CHANGELOG.md | ||||
| * | added schema_migrations_table_name to ActiveRecord::Base in order that the ↵ | Jerad Phelps | 2013-10-27 | 1 | -1/+10 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | name of the schema migrations table can be configured. consolidated test_schema_migrations_table_name tests Added changelog entry edited changelog removed commented lines removed reader ensure the schema migrations table is reset at end of test added entry to configuration guide guides typo and changelog order | ||||
* | | Assert the return value in the test | Rafael Mendonça França | 2013-10-27 | 1 | -1/+1 |
| | | |||||
* | | Skip `include_values` from through associations chains for building target scope | Paul Nikitochkin | 2013-10-27 | 2 | -0/+7 |
| | | | | | | | | Fixes: #12242, #9517, #10240 | ||||
* | | Merge pull request #12643 from severin/pg_cast_json_on_write | Yves Senn | 2013-10-25 | 1 | -0/+7 |
|\ \ | | | | | | | cast json values on write to be consistent with reading from the db. | ||||
| * | | cast json values on write to be consistent with reading from the db. | Severin Schoepke | 2013-10-25 | 1 | -0/+7 |
| | | | | | | | | | | | | See also commit 5ac2341fab689344991b2a4817bd2bc8b3edac9d | ||||
* | | | prevent `time_zone_aware_attributes` test leak. follow-up to #12633. | Yves Senn | 2013-10-25 | 1 | -21/+21 |
| | | | |||||
* | | | only warn on leaked time zone state instead of rasing an error. | Yves Senn | 2013-10-25 | 1 | -3/+6 |
| | | | | | | | | | | | | | | | | | | Raising `RuntimeErrors` skips important cleanup code and leads to a lot of subsequent errors. This clutters the test output with a lot of noise. | ||||
* | | | Merge pull request #12633 from senny/no_more_time_zone_leaks | Yves Senn | 2013-10-25 | 12 | -214/+223 |
|\ \ \ | |/ / |/| | | prevent global timezone state from leaking out of test cases. | ||||
| * | | prevent global timezone state from leaking out of test cases. | Yves Senn | 2013-10-25 | 12 | -214/+223 |
| | | | |||||
* | | | `ActiveRecord::Store` works together with PG `hstore` columns. | Yves Senn | 2013-10-25 | 1 | -0/+21 |
| | | | | | | | | | | | | | | | | | | This is necessary because as of 5ac2341 `hstore` columns are always stored as `Hash` with `String` keys. `ActiveRecord::Store` expected the attribute to be an instance of `HashWithIndifferentAccess`, which led to the bug. | ||||
* | | | `stored_attributes` need to be specific to a subclass. | Yves Senn | 2013-10-25 | 1 | -0/+12 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently they are all stored globally in the same `Hash`. This commit forces the creation of a per-class variable if necessary. The behavior was exposed through the following test-case: ``` 1) Failure: StoreTest#test_all_stored_attributes_are_returned [/Users/senny/Projects/rails/activerecord/test/cases/store_test.rb:151]: --- expected +++ actual @@ -1 +1 @@ -[:color, :homepage, :favorite_food] +[:resolution, :color, :homepage, :favorite_food] ``` | ||||
* | | | test to verify the `ActiveRecord::Store` behavior with PG's json type | Yves Senn | 2013-10-25 | 1 | -0/+18 |
| | | | |||||
* | | | Merge pull request #12621 from ↵ | Rafael Mendonça França | 2013-10-24 | 1 | -0/+11 |
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | laurocaetano/fix_has_one_association_with_primary_key_set Save association when primary key is manually set Conflicts: activerecord/CHANGELOG.md | ||||
| * | | Save association when primary key is manually set | laurocaetano | 2013-10-24 | 1 | -0/+11 |
| | | | |||||
* | | | Fix order dependent tests | Rafael Mendonça França | 2013-10-22 | 1 | -4/+4 |
| | | | |||||
* | | | Merge branch 'master' into joindep | Aaron Patterson | 2013-10-21 | 7 | -10/+80 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (23 commits) Escape the parentheses in the default function regexp Update docs on Tilt::Template in Asset Pipeline guide Fix loading a sql structure file on postgres when the file's path has whitespace in it remove trailing whitespace added with b057765 [ci skip]. Allow unscope to work with `where.not` Raise an exception when model without primary key calls .find_with_ids Process sub-query relation's binding values Instrument the generation of Action Mailer messages Remove extra variable creation and merge. In Relation#empty? use #exists? instead of #count. [ci skip] avoid deprecation warning in sample code Convert Fixnum into String the port number in MySQL Fix some indentation on autosave association Make define_non_cyclic_method simpler Add Sass gobbling info to asset pipeline docs Ensure the state is clean after one failure Fix typo in form_helper.rb add a new local variable to track if digests are being stored, to ensure the cleanup works correctly [ci skip] Fix number of methods added by association. update digestor code based on review ... |