Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix indent and change "or" usage to "||" in schema dumper tests | Carlos Antonio da Silva | 2013-03-30 | 1 | -5/+5 |
| | |||||
* | split relation_scoping_test.rb's default scoping tests into another file | Takehiro Adachi | 2013-03-30 | 2 | -357/+360 |
| | |||||
* | rename named_scope_test.rb to a proper file name | Takehiro Adachi | 2013-03-30 | 1 | -1/+1 |
| | | | | | The file name should be name_scoping_test.rb and the class should be `NamedScopingTest` according to ActiveRecord::Scoping::Name | ||||
* | move tests for NamedScope and DefaultScope under test/cases/scoping/ | Takehiro Adachi | 2013-03-30 | 2 | -0/+0 |
| | | | | | | The scoping/default.rb and scoping/named.rb got moved under scoping/ in commit 2b22564c4efaa63d4bbc006762838c4025c1bdca, but the tests never did. | ||||
* | Merge pull request #9984 from ranjaykrishna/col-prob | Rafael Mendonça França | 2013-03-28 | 1 | -0/+4 |
|\ | | | | | valid_type? added to super class abstract_adapter | ||||
| * | added comments to test_invalid_type in sqlite3 adapter test and added ↵ | Ranjay Krishna | 2013-03-28 | 1 | -0/+4 |
| | | | | | | | | valid_type? method to abstract_adapter.rb and removed unnecessary method from sqlite3 adapter | ||||
* | | anual_salary => annual_salary | Vipul A M | 2013-03-28 | 1 | -3/+3 |
|/ | |||||
* | Merge pull request #9972 from divineforest/fix-overriden-typo | Rafael Mendonça França | 2013-03-28 | 3 | -3/+3 |
|\ | | | | | Fix typo: overriden => overriDDen | ||||
| * | Fix typo: overriden => overriDDen | Alexander Balashov | 2013-03-28 | 3 | -3/+3 |
| | | |||||
* | | Fixed typos in ActiveRecord | Prathamesh Sonpatki | 2013-03-28 | 3 | -5/+5 |
| | | |||||
* | | Merge pull request #9970 from divineforest/fix-typo | Rafael Mendonça França | 2013-03-28 | 1 | -1/+1 |
|\ \ | | | | | | | Fix typo | ||||
| * | | Fix typo | Alexander Balashov | 2013-03-28 | 1 | -1/+1 |
| |/ | |||||
* | | Use snake case variable names, stick with the convention | Carlos Antonio da Silva | 2013-03-28 | 1 | -13/+13 |
| | | |||||
* | | Merge pull request #9963 from obrie/fix/after_create_updates | Carlos Antonio da Silva | 2013-03-28 | 1 | -0/+16 |
|\ \ | |/ |/| | Fix updates not working within after_create hooks | ||||
| * | Fix updates not working within after_create hooks | Aaron Pfeifer | 2013-03-27 | 1 | -0/+16 |
| | | |||||
* | | Add support for FULLTEXT and SPATIAL indexes using the :type flag for MySQL. | Ken Mazaika | 2013-03-27 | 7 | -30/+72 |
| | | |||||
* | | Dump the 'using' options for a SQL index into the schema. | Ken Mazaika | 2013-03-27 | 2 | -2/+9 |
|/ | |||||
* | Fix syntax error | Rafael Mendonça França | 2013-03-27 | 1 | -1/+0 |
| | |||||
* | Merge pull request #9274 from KrzysiekJ/spaces_in_scope_names | Rafael Mendonça França | 2013-03-27 | 1 | -0/+14 |
|\ | | | | | | | Use define_method when method name contains weird characters. | ||||
| * | Use define_method when method name contains weird characters. | Krzysztof Jurewicz | 2013-03-18 | 1 | -0/+14 |
| | | |||||
* | | Fixed typos in activerecord | Prathamesh Sonpatki | 2013-03-27 | 1 | -1/+1 |
| | | |||||
* | | Make connection_handler overridable per thread | Sam Saffron | 2013-03-27 | 1 | -0/+57 |
| | | |||||
* | | Merge pull request #9876 from macksmind/restore_cols_dropped_by_hstore_test | Rafael Mendonça França | 2013-03-26 | 1 | -15/+5 |
|\ \ | | | | | | | Restore columns dropped by hstore test | ||||
| * | | Combine tests and restore columns dropped by hstore testing | Mack Earnhardt | 2013-03-26 | 1 | -15/+5 |
| | | | | | | | | | | | | | | | Disabling the hstore extension during testing created order dependent test failures. | ||||
* | | | Merge pull request #9928 from vipulnsward/fix_rename_auto_increment_mysql | Rafael Mendonça França | 2013-03-26 | 1 | -0/+7 |
|\ \ \ | | | | | | | | | respect auto_increment in rename_column for mysql | ||||
| * | | | respect auto_increment in rename_column for mysql | Vipul A M | 2013-03-27 | 1 | -0/+7 |
| | | | | |||||
* | | | | Checks :algorithm argument for valid values | Dan McClain | 2013-03-26 | 3 | -0/+11 |
| | | | | |||||
* | | | | Adds support for concurrent indexing in PostgreSQL adapter | Dan McClain | 2013-03-25 | 3 | -21/+33 |
|/ / / | | | | | | | | | | | | | | | | | | | | | | Adds support for algorithm option in MySQL indexes Moves USING and algorithm options upstream The syntax is still specific to the Adapter, so the actual executed string happens in the corresponding adapter | ||||
* | | | Make Postgres point type correspond to ruby array with two floats inside | Martin Schürrer | 2013-03-25 | 1 | -2/+25 |
| | | | |||||
* | | | Created a layer of abstraction for the valid type checking in schema dumper. ↵ | Ranjay Krishna | 2013-03-25 | 3 | -0/+27 |
| | | | | | | | | | | | | Now, connection handles the check for valid types so that each database can handle the changes individually. | ||||
* | | | Merge pull request #9864 from vipulnsward/fix_test_AR_v2 | Rafael Mendonça França | 2013-03-25 | 2 | -2/+2 |
|\ \ \ | | | | | | | | | Introduce test on Error#full_message for attribute with underscores; Fix... | ||||
| * | | | Add Error#full_message test; Fix typos | Vipul A M | 2013-03-22 | 2 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | Introduce test on Error#full_message for attribute with underscores; Fix some typos | ||||
* | | | | Merge pull request #9489 from obrie/fix/overridden_defaults_changed_attributes | Jeremy Kemper | 2013-03-24 | 1 | -0/+8 |
|\ \ \ \ | | | | | | | | | | | Fix ActiveRecord locking column defaults not getting persisted | ||||
| * | | | | Fix ActiveRecord locking column defaults not getting persisted | Aaron Pfeifer | 2013-03-18 | 1 | -0/+8 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When partial inserts are enabled, overridden db defaults are ignored. This results in locking columns having a nil value for new records if the db default is null. This happens because the list of changed attributes for new records is always assumed to be empty. Solution: When a new record's default attributes are set, also initialize the list of changed attributes by comparing current values against what's stored as the column defaults in the database. | ||||
* | | | | | Merge branch 'jlxw-patch-2' | Rafael Mendonça França | 2013-03-23 | 1 | -0/+4 |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | Closes #9184 | ||||
| * | | | | | Fix regex to strip quotations from hstore values | jlxw | 2013-03-23 | 1 | -0/+4 |
| | | | | | | | | | | | | | | | | | | | | | | | | Previously regex did not strip quotation marks where hstore values were multi-line strings. | ||||
* | | | | | | Merge pull request #9891 from doabit/additional_index_support | Rafael Mendonça França | 2013-03-23 | 6 | -5/+87 |
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | Custom index type support with :using. Closes #9451 | ||||
| * | | | | | Custom index type support with :using. | doabit | 2013-03-24 | 6 | -5/+87 |
| | | | | | | |||||
* | | | | | | enhance unscoped tests | Neeraj Singh | 2013-03-23 | 1 | -0/+4 |
|/ / / / / | | | | | | | | | | | | | | | | | | | | | Make it obvious that using unscoped with another scope without the block works | ||||
* | | | | | Merge branch 'schema' | Aaron Patterson | 2013-03-22 | 2 | -6/+17 |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * schema: add uuid primary key support separate primary key from column type push the mysql add_column up to the abstract adapter allow multiple add columns pull add_column_options! off the pg connection class add a pg visitor for dealing with schema modification push alter table add column sql in to the schema modification visitor there is no reason to check for an already defined column push column initialization down to the factory method @columns list is no longer necessary keep ivars private, do not manipulate them outside their owner object factory methods should not alter object state push SQL generation inside the schema creation object mostly decouple TableDefinition from the database connection remove to_sql from TableDefinition decouple column definition from the database connection stop depending on sql_type in pg remove knowledge of SQL from the column definition object | ||||
| * | | | | | add uuid primary key support | Aaron Patterson | 2013-03-22 | 1 | -0/+10 |
| | | | | | | |||||
| * | | | | | decouple column definition from the database connection | Aaron Patterson | 2013-03-22 | 1 | -3/+3 |
| | | | | | | |||||
| * | | | | | remove knowledge of SQL from the column definition object | Aaron Patterson | 2013-03-22 | 1 | -3/+4 |
| | | | | | | |||||
* | | | | | | squelch an unused variable warning | Aaron Patterson | 2013-03-22 | 1 | -0/+1 |
|/ / / / / | |||||
* | | | | | Merge pull request #9866 from choudhuryanupam/fix_connection_test | Carlos Antonio da Silva | 2013-03-22 | 1 | -1/+1 |
|\ \ \ \ \ | | | | | | | | | | | | | Removed unused loop variable | ||||
| * | | | | | Removed unused loop variable | Anupam Choudhury | 2013-03-22 | 1 | -1/+1 |
| | |/ / / | |/| | | | |||||
* | | | | | Merge pull request #9867 from choudhuryanupam/fix_mysql2_active_schema_test | Carlos Antonio da Silva | 2013-03-22 | 1 | -2/+1 |
|\ \ \ \ \ | | | | | | | | | | | | | Removed unnecessary block | ||||
| * | | | | | Removed unnecessary block | Anupam Choudhury | 2013-03-22 | 1 | -2/+1 |
| | |_|/ / | |/| | | | |||||
* | | | | | test-case to prevent resetting associations when preloading twice. | Yves Senn | 2013-03-22 | 1 | -0/+7 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/associations/preloader/through_association.rb activerecord/test/cases/associations/eager_test.rb | ||||
* | | | | | When we pass id to update_attributes it will try to set new id for that record | Dmitry Vorotilin | 2013-03-22 | 1 | -0/+9 |
|/ / / / |