aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Add failing tests according to #479.José Valim2011-05-101-0/+15
|
* Add failing tests, according to #480.José Valim2011-05-101-0/+14
|
* Ensure assign_attributes and update_attributes do not fail on nil, closes #478.José Valim2011-05-102-0/+8
|
* use a null byte as a bind parameter substitute as it is not allowed in ↵Aaron Patterson2011-05-091-0/+50
| | | | normal SQL. fixes #411, #417
* Merge pull request #451 from baroquebobcat/fixing_last_for_issue_371Jon Leighton2011-05-081-0/+21
|\
| * Fix for #371Nick Howard2011-05-081-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | if a query contains a limit or an offset, ActiveRecord::FinderMethods#find_last had inconsistent behavior. If the records were loaded, it returned the last record in the cached list. If they were not, it reversed the order of the query and changed the limit to one. If the earlier limit was less than the total matching the query in the db, it would return a different record than if the records had been cached. This commit changes find_last so that it loads the records when getting the last record on a query containing a limit or an offset, which makes the behavior consistent.
* | Ensure that ORDER BY clauses from default scopes are not included in ↵Jon Leighton2011-05-081-0/+4
| | | | | | | | calculation queries. Fixes #406.
* | Don't quote ID's as Arel will quote them -- follow same conventions as the ↵Christopher Meiklejohn2011-05-084-1/+51
| | | | | | | | delete method.
* | renamed mass-assignment scopes to roles, updated code, tests, docs and ↵Josh Kalderimis2011-05-081-27/+27
|/ | | | security guide
* Namespace Fixtures in ActiveRecordJason Noble2011-05-076-30/+30
| | | [Fixes #439]
* Revert "Revert the merge because tests did not pass."José Valim2011-05-071-0/+35
| | | | This reverts commit 886818d2bab40585c0cea763002ffc16917dd0b3.
* fix yield not working from around filter of observers, fixes Github#329Hemant Kumar2011-05-071-0/+25
|
* Merge pull request #396 from asanghi/lh_4346Xavier Noria2011-05-061-0/+135
|\ | | | | Multiparameter POLA (principle of least authority) with respect to time_select fixes. See LH4346
| * Multiparameter POLA, time_select fixes. See LH4346Aditya Sanghi2011-05-051-0/+135
| |
* | Merge pull request #399 from ernie/join_conditions_on_joinJon Leighton2011-05-051-0/+11
|\ \ | | | | | | Add association join conditions to JOIN clause, not WHERE
| * | Add a test for outer joins with conditions where value IS NULLErnie Miller2011-05-051-0/+5
| | |
| * | Add join conditions to JOIN clause, not WHEREErnie Miller2011-05-051-0/+6
| |/
* | Merge pull request #358 from baroquebobcat/fix_find_or_create_masterAaron Patterson2011-05-051-0/+24
|\ \ | |/ |/| Fix for lighthouse #6741
| * Fix for lighthouse #6741Nick Howard2011-05-011-0/+24
| | | | | | | | | | | | | | - adds tests for find_or_create_by and find_or_initialize_by on has_many associations - changes the behavior of ActiveRecord::Associations::CollectionProxy#method_missing to differ to ActiveRecord::FinderMethods#find_or_instantiator_by_attributes for arg processing and saving so find_or_create_by's api on associations will be consistent w/ the api for model classes.
* | ensure query cache is cleared when Rack body is closed, fixes bug reported ↵Aaron Patterson2011-05-041-0/+11
| | | | | | | | on 951e18abea9c116fc5d6b330ca1dcd2890abe006
* | added the mysql schema test to mysql2 adapter, and fixed the corresponding ↵Josh Kalderimis2011-05-032-1/+37
| | | | | | | | failures
* | make sure IM repository is cleared after body is closedAaron Patterson2011-05-031-0/+11
| |
* | proxying the body in the IM middleware so that IM is available for streaming ERbAaron Patterson2011-05-031-0/+26
| |
* | adding a test case for the identity map middlewareAaron Patterson2011-05-031-0/+34
| |
* | introduce a body proxy to ensure that query cache is enabled during streamingAaron Patterson2011-05-021-0/+26
| |
* | more tests around cachingAaron Patterson2011-05-021-1/+10
| |
* | add a couple test cases surrounding query cache middlewareAaron Patterson2011-05-021-0/+18
| |
* | Fix failing AR test.José Valim2011-05-022-17/+12
| |
* | Make the identity map use the instrumentation infrastructure so we can style ↵David Heinemeier Hansson2011-05-011-4/+13
| | | | | | | | the messages nicely with colors (FIXME: Can someone look into why the test is not working?)
* | Merge pull request #357 from joshk/assign_attributes.David Heinemeier Hansson2011-05-013-39/+416
|\ \ | | | | | | Assign protected attributes with create/new and control the role.
| * | singular and collection relations in AR can now specify mass-assignment ↵Josh Kalderimis2011-05-013-39/+326
| | | | | | | | | | | | security options (:as and :without_protection) in build, create and create! methods.
| * | Added mass-assignment security :as and :without_protection support to AR.new ↵Josh Kalderimis2011-05-011-24/+114
| |/ | | | | | | and AR.create
* | Merge pull request #340 from joshk/default_scope_changes.David Heinemeier Hansson2011-05-012-20/+24
|\ \ | |/ |/| removed the default_scope deprecations and updated the docs and tests to
| * removed the default_scope deprecations and updated the docs and tests to ↵Josh Kalderimis2011-04-282-20/+24
| | | | | | | | reflect its use cases
* | assert_difference can take a callable piece of code rather than just evaling ↵Aaron Patterson2011-05-011-4/+4
| | | | | | | | a string
* | fixing more test warnings in 1.9.3Aaron Patterson2011-04-303-6/+6
| |
* | fixing test warningsAaron Patterson2011-04-301-7/+1
| |
* | making sure the `create_fixtures` method works to prevent regressionsAaron Patterson2011-04-291-0/+5
| |
* | supporting nil when passed in as an IN clauseAaron Patterson2011-04-291-3/+4
| |
* | Test that passing nil member of array in conditions retrieves records with nilgmile2011-04-291-0/+22
|/ | | | value on a selected field.
* some test renaming to avoid collisions, and some annoying issues between dbsJosh Kalderimis2011-04-271-7/+7
|
* final corrections to the mass-assignment security testsJosh Kalderimis2011-04-271-4/+4
|
* fix mass-assignment security tests, this was due to a string column limit ↵Josh Kalderimis2011-04-272-15/+15
| | | | which doesn't cause issues on sqlite
* AR update_attributes api is updated to reflect the addition of assign_attributesJosh Kalderimis2011-04-261-0/+40
|
* Merged pull request #310 from beanieboi/master.Aaron Patterson2011-04-263-1/+41
|\ | | | | Added support for tsvector datatype in postgres
| * Added tsvector Datatype SupportBenjamin Fritsch2011-04-263-1/+41
| | | | | | Applied Patch from https://rails.lighthouseapp.com/projects/8994/tickets/5577-suport-from-tsvector-data-type-in-postgresql
* | Merged pull request #308 from joshk/assign_attributes.José Valim2011-04-251-0/+6
|\ \ | | | | | | deprecated the use of guard_protected_attributes with attributes= in AR
| * | deprecated the use of the guard_protected_attributes argument with ↵Josh Kalderimis2011-04-251-0/+6
| | | | | | | | | | | | attributes= in AR in favor of assign_attributes(attrs, :without_protection => true)
* | | Do not use SQL LIKE operator for case insensitive uniqueness validationRaimonds Simanovskis2011-04-251-0/+26
|/ / | | | | It can result in wrong results if values contain special % or _ characters. It is safer to use SQL LOWER function and compare for equality.
* | Added assign_attributes to Active Record which accepts a mass-assignment ↵Josh Kalderimis2011-04-245-26/+92
| | | | | | | | security scope using the :as option, while also allowing mass-assignment security to be bypassed using :with_protected