Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Methods that return nil should not be considered YAML | Joshua Wehner | 2011-05-10 | 1 | -4/+1 |
| | |||||
* | Puts ActiveRecord::SessionStore attributes in white list, fixes #483 | slainer68 | 2011-05-10 | 1 | -0/+6 |
| | |||||
* | Add failing tests according to #479. | José Valim | 2011-05-10 | 1 | -0/+15 |
| | |||||
* | Add failing tests, according to #480. | José Valim | 2011-05-10 | 1 | -0/+14 |
| | |||||
* | Ensure assign_attributes and update_attributes do not fail on nil, closes #478. | José Valim | 2011-05-10 | 2 | -0/+8 |
| | |||||
* | use a null byte as a bind parameter substitute as it is not allowed in ↵ | Aaron Patterson | 2011-05-09 | 1 | -0/+50 |
| | | | | normal SQL. fixes #411, #417 | ||||
* | Merge pull request #451 from baroquebobcat/fixing_last_for_issue_371 | Jon Leighton | 2011-05-08 | 1 | -0/+21 |
|\ | |||||
| * | Fix for #371 | Nick Howard | 2011-05-08 | 1 | -0/+21 |
| | | | | | | | | | | | | | | | | | | | | | | | | if a query contains a limit or an offset, ActiveRecord::FinderMethods#find_last had inconsistent behavior. If the records were loaded, it returned the last record in the cached list. If they were not, it reversed the order of the query and changed the limit to one. If the earlier limit was less than the total matching the query in the db, it would return a different record than if the records had been cached. This commit changes find_last so that it loads the records when getting the last record on a query containing a limit or an offset, which makes the behavior consistent. | ||||
* | | Ensure that ORDER BY clauses from default scopes are not included in ↵ | Jon Leighton | 2011-05-08 | 1 | -0/+4 |
| | | | | | | | | calculation queries. Fixes #406. | ||||
* | | Don't quote ID's as Arel will quote them -- follow same conventions as the ↵ | Christopher Meiklejohn | 2011-05-08 | 4 | -1/+51 |
| | | | | | | | | delete method. | ||||
* | | renamed mass-assignment scopes to roles, updated code, tests, docs and ↵ | Josh Kalderimis | 2011-05-08 | 1 | -27/+27 |
|/ | | | | security guide | ||||
* | Namespace Fixtures in ActiveRecord | Jason Noble | 2011-05-07 | 6 | -30/+30 |
| | | | [Fixes #439] | ||||
* | Revert "Revert the merge because tests did not pass." | José Valim | 2011-05-07 | 1 | -0/+35 |
| | | | | This reverts commit 886818d2bab40585c0cea763002ffc16917dd0b3. | ||||
* | fix yield not working from around filter of observers, fixes Github#329 | Hemant Kumar | 2011-05-07 | 1 | -0/+25 |
| | |||||
* | Merge pull request #396 from asanghi/lh_4346 | Xavier Noria | 2011-05-06 | 1 | -0/+135 |
|\ | | | | | Multiparameter POLA (principle of least authority) with respect to time_select fixes. See LH4346 | ||||
| * | Multiparameter POLA, time_select fixes. See LH4346 | Aditya Sanghi | 2011-05-05 | 1 | -0/+135 |
| | | |||||
* | | Merge pull request #399 from ernie/join_conditions_on_join | Jon Leighton | 2011-05-05 | 1 | -0/+11 |
|\ \ | | | | | | | Add association join conditions to JOIN clause, not WHERE | ||||
| * | | Add a test for outer joins with conditions where value IS NULL | Ernie Miller | 2011-05-05 | 1 | -0/+5 |
| | | | |||||
| * | | Add join conditions to JOIN clause, not WHERE | Ernie Miller | 2011-05-05 | 1 | -0/+6 |
| |/ | |||||
* | | Merge pull request #358 from baroquebobcat/fix_find_or_create_master | Aaron Patterson | 2011-05-05 | 1 | -0/+24 |
|\ \ | |/ |/| | Fix for lighthouse #6741 | ||||
| * | Fix for lighthouse #6741 | Nick Howard | 2011-05-01 | 1 | -0/+24 |
| | | | | | | | | | | | | | | - adds tests for find_or_create_by and find_or_initialize_by on has_many associations - changes the behavior of ActiveRecord::Associations::CollectionProxy#method_missing to differ to ActiveRecord::FinderMethods#find_or_instantiator_by_attributes for arg processing and saving so find_or_create_by's api on associations will be consistent w/ the api for model classes. | ||||
* | | ensure query cache is cleared when Rack body is closed, fixes bug reported ↵ | Aaron Patterson | 2011-05-04 | 1 | -0/+11 |
| | | | | | | | | on 951e18abea9c116fc5d6b330ca1dcd2890abe006 | ||||
* | | added the mysql schema test to mysql2 adapter, and fixed the corresponding ↵ | Josh Kalderimis | 2011-05-03 | 2 | -1/+37 |
| | | | | | | | | failures | ||||
* | | make sure IM repository is cleared after body is closed | Aaron Patterson | 2011-05-03 | 1 | -0/+11 |
| | | |||||
* | | proxying the body in the IM middleware so that IM is available for streaming ERb | Aaron Patterson | 2011-05-03 | 1 | -0/+26 |
| | | |||||
* | | adding a test case for the identity map middleware | Aaron Patterson | 2011-05-03 | 1 | -0/+34 |
| | | |||||
* | | introduce a body proxy to ensure that query cache is enabled during streaming | Aaron Patterson | 2011-05-02 | 1 | -0/+26 |
| | | |||||
* | | more tests around caching | Aaron Patterson | 2011-05-02 | 1 | -1/+10 |
| | | |||||
* | | add a couple test cases surrounding query cache middleware | Aaron Patterson | 2011-05-02 | 1 | -0/+18 |
| | | |||||
* | | Fix failing AR test. | José Valim | 2011-05-02 | 2 | -17/+12 |
| | | |||||
* | | Make the identity map use the instrumentation infrastructure so we can style ↵ | David Heinemeier Hansson | 2011-05-01 | 1 | -4/+13 |
| | | | | | | | | the messages nicely with colors (FIXME: Can someone look into why the test is not working?) | ||||
* | | Merge pull request #357 from joshk/assign_attributes. | David Heinemeier Hansson | 2011-05-01 | 3 | -39/+416 |
|\ \ | | | | | | | Assign protected attributes with create/new and control the role. | ||||
| * | | singular and collection relations in AR can now specify mass-assignment ↵ | Josh Kalderimis | 2011-05-01 | 3 | -39/+326 |
| | | | | | | | | | | | | security options (:as and :without_protection) in build, create and create! methods. | ||||
| * | | Added mass-assignment security :as and :without_protection support to AR.new ↵ | Josh Kalderimis | 2011-05-01 | 1 | -24/+114 |
| |/ | | | | | | | and AR.create | ||||
* | | Merge pull request #340 from joshk/default_scope_changes. | David Heinemeier Hansson | 2011-05-01 | 2 | -20/+24 |
|\ \ | |/ |/| | removed the default_scope deprecations and updated the docs and tests to | ||||
| * | removed the default_scope deprecations and updated the docs and tests to ↵ | Josh Kalderimis | 2011-04-28 | 2 | -20/+24 |
| | | | | | | | | reflect its use cases | ||||
* | | assert_difference can take a callable piece of code rather than just evaling ↵ | Aaron Patterson | 2011-05-01 | 1 | -4/+4 |
| | | | | | | | | a string | ||||
* | | fixing more test warnings in 1.9.3 | Aaron Patterson | 2011-04-30 | 3 | -6/+6 |
| | | |||||
* | | fixing test warnings | Aaron Patterson | 2011-04-30 | 1 | -7/+1 |
| | | |||||
* | | making sure the `create_fixtures` method works to prevent regressions | Aaron Patterson | 2011-04-29 | 1 | -0/+5 |
| | | |||||
* | | supporting nil when passed in as an IN clause | Aaron Patterson | 2011-04-29 | 1 | -3/+4 |
| | | |||||
* | | Test that passing nil member of array in conditions retrieves records with nil | gmile | 2011-04-29 | 1 | -0/+22 |
|/ | | | | value on a selected field. | ||||
* | some test renaming to avoid collisions, and some annoying issues between dbs | Josh Kalderimis | 2011-04-27 | 1 | -7/+7 |
| | |||||
* | final corrections to the mass-assignment security tests | Josh Kalderimis | 2011-04-27 | 1 | -4/+4 |
| | |||||
* | fix mass-assignment security tests, this was due to a string column limit ↵ | Josh Kalderimis | 2011-04-27 | 2 | -15/+15 |
| | | | | which doesn't cause issues on sqlite | ||||
* | AR update_attributes api is updated to reflect the addition of assign_attributes | Josh Kalderimis | 2011-04-26 | 1 | -0/+40 |
| | |||||
* | Merged pull request #310 from beanieboi/master. | Aaron Patterson | 2011-04-26 | 3 | -1/+41 |
|\ | | | | | Added support for tsvector datatype in postgres | ||||
| * | Added tsvector Datatype Support | Benjamin Fritsch | 2011-04-26 | 3 | -1/+41 |
| | | | | | | Applied Patch from https://rails.lighthouseapp.com/projects/8994/tickets/5577-suport-from-tsvector-data-type-in-postgresql | ||||
* | | Merged pull request #308 from joshk/assign_attributes. | José Valim | 2011-04-25 | 1 | -0/+6 |
|\ \ | | | | | | | deprecated the use of guard_protected_attributes with attributes= in AR | ||||
| * | | deprecated the use of the guard_protected_attributes argument with ↵ | Josh Kalderimis | 2011-04-25 | 1 | -0/+6 |
| | | | | | | | | | | | | attributes= in AR in favor of assign_attributes(attrs, :without_protection => true) |