aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Add `after_save_commit` callback as shortcut for `after_commit :hook, on: [ ↵David Heinemeier Hansson2019-04-021-0/+12
| | | | :create, :update ]`. (#35804)
* Revert unused code and re-using query annotation for `update_all` and ↵Ryuta Kamizono2019-04-017-112/+0
| | | | | | | | | | | | | | | | `delete_all` This partly reverts #35617. #35617 includes unused code (for `InsertStatement`) and re-using query annotation for `update_all` and `delete_all`, which has not been discussed yet. If a relation has any annotation, I think it is mostly for SELECT query, so re-using annotation by default is not always desired behavior for me. We should discuss about desired behavior before publishing the implementation.
* Extract insert test case from #35686Kasper Timm Hansen2019-03-311-0/+14
|
* Merge pull request #19333 from palkan/dirty-storeKasper Timm Hansen2019-03-312-0/+84
|\ | | | | Add dirty methods for store accessors
| * Add saved changes helpers for store accessorsVladimir Dementyev2019-03-251-0/+11
| |
| * Add dirty methods for store accessorspalkan2019-03-252-0/+73
| |
* | Fix callbacks on has_many :through associations (#33249)Ryan Kerr2019-03-301-0/+18
| | | | | | | | | | | | | | | | | | | | | | When adding a child record via a has_many :through association, build_through_record would previously build the join record, and then assign the child record and source_type option to it. Because the before_add and after_add callbacks are called as part of build, however, this caused the callbacks to receive incomplete records, specifically without the other end of the has_many :through association. Collecting all attributes before building the join record ensures the callbacks receive the fully constructed record.
* | Add `ActiveRecord::Relation#extract_associated` for extracting associated ↵David Heinemeier Hansson2019-03-291-0/+7
| | | | | | | | | | record (#35784) * Add `ActiveRecord::Relation#extract_associated` for extracting associated records from a relation
* | Type cast falsy boolean symbols on boolean attribute as falseRyuta Kamizono2019-03-301-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before 34cc301, type casting by boolean attribute when querying is a no-op, so finding by truthy boolean string (i.e. `where(value: "true") # => value = 'true'`) didn't work as expected (matches it to FALSE in MySQL #32624). By type casting is ensured, a value on boolean attribute is always serialized to TRUE or FALSE. In PostgreSQL, `where(value: :false) # => value = 'false'` was a valid SQL, so 34cc301 is a regresson for PostgreSQL since all symbol values are serialized as TRUE. I'd say using `:false` is mostly a developer's mistake (user's input basically comes as a string), but `:false` on boolean attribute is serialized as TRUE is not a desirable behavior for anybody. This allows falsy boolean symbols as false, i.e. `klass.create(value: :false).value? # => false` and `where(value: :false) # => value = FALSE`. Fixes #35676.
* | Merge pull request #35496 from bogdan/right-preloadingRyuta Kamizono2019-03-281-0/+9
|\ \ | | | | | | Fix preloader to never reset associations in case they are already loaded
| * | Fix preloader to never reset associations in case they are already loadedBogdan Gusiev2019-03-071-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes the issue when association is preloaded with a custom preload scope which disposes the already preloaded target of the association by reseting it. When custom preload scope is used, the preloading is now performed into a separated Hash - #records_by_owner instead of the association. It removes the necessaty the reset the association after the preloading is complete so that reset of the preloaded association never happens. Preloading is still happening to the association when the preload scope is empty.
* | | Don't change `collation_connection` in the current connectionRyuta Kamizono2019-03-271-1/+1
| | | | | | | | | | | | | | | | | | | | | We have a test case for `collation_connection` session variable, so it should not be changed in any other test. Fixes #35458.
* | | Fix CI failure due to remaining tagging recordsRyuta Kamizono2019-03-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | `TRUNCATE TABLE posts` also resets `AUTO_INCREMENT`. If newly created a post, it is wrongly associated with remaining tagging records. To un-associate remaining tagging record, use `post.create_tagging!` instead. Fixes #35751.
* | | Use `assert_queries(0)` instead of `assert_no_queries` to ignore metadata ↵Yasuo Honda2019-03-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | queries Fix #35665 ```ruby $ ARCONN=mysql2 bin/test test/cases/scoping/named_scoping_test.rb test/cases/tasks/database_tasks_test.rb test/cases/associations/cascaded_eager_loading_test.rb test/cases/associations/eager_singularization_test.rb -n "/^(?:NamedScopingTest#(?:test_many_should_not_fire_query_if_scope_loaded)|ActiveRecord::DatabaseTasksDumpSchemaCacheTest#(?:test_dump_schema_cache)|CascadedEagerLoadingTest#(?:test_eager_association_loading_with_has_many_sti_and_subclasses)|EagerSingularizationTest#(?:test_eager_no_extra_singularization_has_many_through_belongs_to))$/" --seed 16818 Using mysql2 Run options: -n "/^(?:NamedScopingTest#(?:test_many_should_not_fire_query_if_scope_loaded)|ActiveRecord::DatabaseTasksDumpSchemaCacheTest#(?:test_dump_schema_cache)|CascadedEagerLoadingTest#(?:test_eager_association_loading_with_has_many_sti_and_subclasses)|EagerSingularizationTest#(?:test_eager_no_extra_singularization_has_many_through_belongs_to))$/" --seed 16818 ...F Failure: CascadedEagerLoadingTest#test_eager_association_loading_with_has_many_sti_and_subclasses [/home/yahonda/git/rails/activerecord/test/cases/associations/cascaded_eager_loading_test.rb:124]: 1 instead of 0 queries were executed. Queries: SHOW FULL FIELDS FROM `topics`. Expected: 0 Actual: 1 bin/test test/cases/associations/cascaded_eager_loading_test.rb:119 Finished in 6.894609s, 0.5802 runs/s, 1.0153 assertions/s. 4 runs, 7 assertions, 1 failures, 0 errors, 0 skips $ ```
* | | Merge pull request #35683 from Kukunin/masterRyuta Kamizono2019-03-231-6/+31
|\ \ \ | | | | | | | | Bugfix: Fix false autosave for has_one :through association
| * | | Fix unintended autosave on has_one through associationSergiy Kukunin2019-03-221-6/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #35680 The problem occurred, when a `has one through` association contains a foreign key (it belongs to the intermediate association). For example, Comment belongs to Post, Post belongs to Author, and Author `has_one :first_comment, through: :first_post`. In this case, the value of the foreign key is comparing with the original record, and since they are likely different, the association is marked as changed. So it updates every time when the origin record updates.
* | | | Add Relation#annotate for SQL commentingMatt Yoho2019-03-2121-0/+513
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch has two main portions: 1. Add SQL comment support to Arel via Arel::Nodes::Comment. 2. Implement a Relation#annotate method on top of that. == Adding SQL comment support Adds a new Arel::Nodes::Comment node that represents an optional SQL comment and teachers the relevant visitors how to handle it. Comment nodes may be added to the basic CRUD statement nodes and set through any of the four (Select|Insert|Update|Delete)Manager objects. For example: manager = Arel::UpdateManager.new manager.table table manager.comment("annotation") manager.to_sql # UPDATE "users" /* annotation */ This new node type will be used by ActiveRecord::Relation to enable query annotation via SQL comments. == Implementing the Relation#annotate method Implements `ActiveRecord::Relation#annotate`, which accepts a comment string that will be appeneded to any queries generated by the relation. Some examples: relation = Post.where(id: 123).annotate("metadata string") relation.first # SELECT "posts".* FROM "posts" WHERE "posts"."id" = 123 # LIMIT 1 /* metadata string */ class Tag < ActiveRecord::Base scope :foo_annotated, -> { annotate("foo") } end Tag.foo_annotated.annotate("bar").first # SELECT "tags".* FROM "tags" LIMIT 1 /* foo */ /* bar */ Also wires up the plumbing so this works with `#update_all` and `#delete_all` as well. This feature is useful for instrumentation and general analysis of queries generated at runtime.
* | | | Merge pull request #35685 from XrXr/attribute-forwardingGannon McGibbon2019-03-201-0/+11
|\ \ \ \ | |_|_|/ |/| | | Document option forwarding in ActiveRecord::Base.attribute
| * | | Document option forwarding in ActiveRecord::Base.attributeAlan Wu2019-03-201-0/+11
| |/ / | | | | | | | | | | | | This has been supported for a while but we didn't have documentation for it.
* / / Bulk Insert: Reuse indexes for unique_byKasper Timm Hansen2019-03-201-3/+33
|/ / | | | | | | | | | | | | | | | | | | | | I found `:unique_by` with `:columns` and `:where` inside it tough to grasp. The documentation only mentioned indexes and partial indexes. So why duplicate a model's indexes in an insert_all/upsert_all call when we can just look it up? This has the added benefit of raising if no index is found, such that people can't insert thousands of records without relying on an index of some form.
* | Merge pull request #35595 from ↵Rafael França2019-03-191-1/+1
|\ \ | | | | | | | | | | | | shioyama/generated_attribute_methods_namespaced_constant Give GeneratedAttributeMethods module a name
| * | Give GeneratedAttributeMethods module a nameChris Salzberg2019-03-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently GeneratedAttributeMethods is a module builder class, an instance of which is included in every AR class. OTOH, GeneratedAssociatedMethods is assigned to a constant under the model namespace. This is inconsistent and looks strange in the list of ancestors. There is no particular reason *not* to assign a constant for this (very important) module under the model namespace, so that's what this commit does. Previous to this change, ancestors for an AR class looked like this: ``` => [User (call 'User.connection' to establish a connection), User::GeneratedAssociationMethods, #<ActiveRecord::AttributeMethods::GeneratedAttributeMethods:0x000055ace0f05b08>, ApplicationRecord(abstract), ApplicationRecord::GeneratedAssociationMethods, #<ActiveRecord::AttributeMethods::GeneratedAttributeMethods:0x000055ace093c460>, ActiveRecord::Base, ... ``` With this change, they look like this: ``` => [User (call 'User.connection' to establish a connection), User::GeneratedAssociationMethods, User::GeneratedAttributeMethods, ApplicationRecord(abstract), ApplicationRecord::GeneratedAssociationMethods, ApplicationRecord::GeneratedAttributeMethods, ActiveRecord::Base, ... ``` The previously named `GeneratedAttributeMethods` module builder class is renamed `GeneratedAttributeMethodsBuilder` to emphasize that this is not a module but a class.
* | | Don't expose internal `type_casted_binds` methodRyuta Kamizono2019-03-191-1/+1
| | | | | | | | | | | | Internal usage for the method as public has removed at #29623.
* | | Merge pull request #35653 from kamipo/remove_arel_nodes_valuesRyuta Kamizono2019-03-184-14/+13
|\ \ \ | | | | | | | | Get rid of `Arel::Nodes::Values`
| * | | Get rid of `Arel::Nodes::Values`Ryuta Kamizono2019-03-184-14/+13
| | | | | | | | | | | | | | | | | | | | | | | | That is completely covered by `Arel::Nodes::ValuesList`. Related https://github.com/rails/arel/pull/484.
* | | | Add test case to prevent possible SQL injectionRyuta Kamizono2019-03-182-0/+20
|/ / /
* | | Add test case for unscoping `:optimizer_hints`Ryuta Kamizono2019-03-182-0/+12
| | |
* | | SQLite3: Make fixture loading to bulk statementsRyuta Kamizono2019-03-171-6/+2
| | |
* | | Make `truncate_tables` to bulk statementsRyuta Kamizono2019-03-172-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before: ``` (16.4ms) TRUNCATE TABLE `author_addresses` (20.5ms) TRUNCATE TABLE `authors` (19.4ms) TRUNCATE TABLE `posts` ``` After: ``` Truncate Tables (19.5ms) TRUNCATE TABLE `author_addresses`; TRUNCATE TABLE `authors`; TRUNCATE TABLE `posts` ```
* | | Extract `truncate` and `truncate_tables` into database statementsRyuta Kamizono2019-03-174-37/+22
| | | | | | | | | | | | This is to easier make `truncate_tables` to bulk statements.
* | | Merge pull request #35615 from kamipo/optimizer_hintsRyuta Kamizono2019-03-174-0/+55
|\ \ \ | | | | | | | | Support Optimizer Hints
| * | | Support Optimizer HintsRyuta Kamizono2019-03-164-0/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We as Arm Treasure Data are using Optimizer Hints with a monkey patch (https://gist.github.com/kamipo/4c8539f0ce4acf85075cf5a6b0d9712e), especially in order to use `MAX_EXECUTION_TIME` (refer #31129). Example: ```ruby class Job < ApplicationRecord default_scope { optimizer_hints("MAX_EXECUTION_TIME(50000) NO_INDEX_MERGE(jobs)") } end ``` Optimizer Hints is supported not only for MySQL but also for most databases (PostgreSQL on RDS, Oracle, SQL Server, etc), it is really helpful to turn heavy queries for large scale applications.
* | | | Raise UnknownAttributeError when unknown column is passed to insert_all and ↵Josef Šimánek2019-03-161-0/+6
|/ / / | | | | | | | | | friends.
* / / Revert "Remove Marshal support from SchemaCache"Rafael Mendonça França2019-03-131-0/+18
|/ / | | | | | | This reverts commit 65f2eeaaf5774f0891fff700f4defb0b90a05789.
* | Schema Cache: cache table indexesKasper Timm Hansen2019-03-131-9/+28
| | | | | | | | | | | | Useful to not query for indexes when an application uses schema cache. Ref https://github.com/rails/rails/pull/35546
* | Remove Marshal support from SchemaCacheKasper Timm Hansen2019-03-121-16/+0
| | | | | | | | | | YAML has been used to serialize the schema cache ever since 2016 with Rails 5.1: 4c00c6ed
* | Merge pull request #35424 from Korri/validation-rules-locale-fallbackRafael França2019-03-111-2/+18
|\ \ | | | | | | Fall back to parent locale before falling back to the :errors namespace
| * | Fall back to parent locale before it falls back to the :errors namespaceHugo Vacher2019-03-041-2/+18
| | |
* | | Merge pull request #35565 from ↵Kasper Timm Hansen2019-03-111-33/+0
|\ \ \ | | | | | | | | | | | | | | | | yahonda/rm_test_create_table_with_custom_sequence_name Remove `MigrationTest#test_create_table_with_custom_sequence_name`
| * | | Remove `MigrationTest#test_create_table_with_custom_sequence_name`Yasuo Honda2019-03-111-33/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This test is only executed for OracleAdapter. https://github.com/rsim/oracle-enhanced/pull/1846 adds an equivalent spec for Oracle enhanced adapter.
* | | | Fix random CI failure due to non-deterministic sorting orderRyuta Kamizono2019-03-111-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | An `author` has a lots of `posts` in the fixtures, so the result of `author.post` and finding a `post` by `author_id` is non-deterministic. https://travis-ci.org/rails/rails/jobs/504332292#L1202-L1208
* | | | Merge pull request #35320 from ↵Ryuta Kamizono2019-03-111-0/+63
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | kamille-gz/fix_query_method_when_given_Date_data_type Fix ActiveRecord query attribute method when given value does't respond to to_i method
| * | | | Fix query attribute method on user-defined attribute to be aware of ↵kamille-3212019-03-111-0/+63
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | typecasted value change the line to check an attribute has user-defined type ref: https://github.com/rails/rails/pull/35320#discussion_r257924552 check query attribute method is working when given value does not respond to to_i method
* | | | Merge pull request #35449 from pjrebsch/quoting-empty-rangeRyuta Kamizono2019-03-111-0/+13
|\ \ \ \ | | | | | | | | | | Quote empty ranges like other empty enumerables
| * | | | Quote empty ranges like other empty enumerablesPatrick Rebsch2019-03-071-0/+13
| |/ / /
* | | | Don't test `disconnect!` if in memory dbRyuta Kamizono2019-03-101-8/+8
| | | | | | | | | | | | | | | | `disconnect!` will lose all tables and fixtures if in memory db.
* | | | Fix `reconnect!` to work after `disconnect!`Ryuta Kamizono2019-03-101-7/+9
| | | |
* | | | Fixed autosave association test typoShailesh Kalamkar2019-03-091-1/+1
|/ / /
* | | Merge pull request #35512 from kamipo/delegate_onlyRyuta Kamizono2019-03-072-1/+5
|\ \ \ | | | | | | | | Delegate `only` query method to relation as with `except`
| * | | Delegate `only` query method to relation as with `except`Ryuta Kamizono2019-03-072-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've found the skewness of delegation methods between `except` and `only` in a88b6f2. The `only` method is closely similar with `except` as `SpawnMethods`. https://github.com/rails/rails/blob/e056b9bfb07c4eb3bcc6672d885aadd72bec574f/activerecord/lib/active_record/relation/spawn_methods.rb#L53-L67 It is preferable both behaves the same way.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-12 19:03:51 +0000