aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Merge pull request #32075 from eileencodes/delete-default-configuration"eileencodes2018-02-221-0/+16
| | | | | | | | | | This reverts commit 16f279ebd474626577ced858e3626ac4535a33df, reversing changes made to 6c6a30a7c357ce1eafa093d77d2b08684fe50887. The config can be named anything, not just default (although all generated apps will be named default). We can't just delete configs that don't have a database because that will break three-tier configs. Oh well.
* Properly escape column name embedded into regexpAndreas Bühmann2018-02-221-1/+1
| | | | | | | | | SQLServerAdapter (gem `activerecord-sqlserver-adapter`) uses square brackets for quoting column names (e.g. `[id]`). Those brackets must not be misinterpreted in regular expressions. Failure: Expected /SELECT [developers].[id].* FROM developers/ to match "SELECT [developers].[id], [developers].[name], [developers].[salary], [developers].[firm_id], [developers].[mentor_id], [developers].[created_at], [developers].[updated_at], [developers].[created_on], [developers].[updated_on] FROM developers".
* Add cop for preferring 'Foo.method' over 'Foo::method'Andrew White2018-02-221-1/+1
|
* Merge pull request #32075 from eileencodes/delete-default-configurationEileen M. Uchitelle2018-02-211-16/+0
|\ | | | | Delete default configuration
| * Delete default configurationeileencodes2018-02-211-16/+0
| | | | | | | | | | | | | | Because of this default configuration we're constantly checking if the database exists when looping through configurations. This is unnecessary and we should just delete it before we need to loop through configurations.
* | Use the query cache when connection is already connectedyuuji.yaginuma2018-02-191-0/+11
| | | | | | | | Fixes #32021.
* | Association scope's own order should be prioritized over through scope's orderRyuta Kamizono2018-02-182-1/+9
| | | | | | | | | | | | | | | | | | | | 3acc5d6 was changed the order of scope evaluation from through scope to the association's own scope to be prioritized over the through scope. But the sorting order will be prioritized that is evaluated first. It is unintentional effect, association scope's sorting order should be prioritized as well. Fixes #32008.
* | Clean up and consolidate .gitignoresbogdanvlviv2018-02-172-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Global ignores at toplevel .gitignore * Component-specific ignores in each toplevel directory * Remove `actionview/test/tmp/.keep` for JRuby ``` rm actionview/test/tmp/ -fr cd actionview/ bundle exec jruby -Itest test/template/digestor_test.rb ``` Related to #11743, #30392. Closes #29978.
* | Deprecate update_attributes and update_attributes!Eddie Lebow2018-02-1713-60/+37
| | | | | | | | Closes #31998
* | Add chop removed in 89bcca5Rafael Mendonça França2018-02-161-1/+1
| |
* | Remove usage of strip_heredoc in the framework in favor of <<~Rafael Mendonça França2018-02-164-45/+43
|/ | | | | Some places we can't remove because Ruby still don't have a method equivalent to strip_heredoc to be called in an already existent string.
* Add #create_or_find_by to lean on unique constraints (#31989)David Heinemeier Hansson2018-02-141-0/+29
| | | Add #create_or_find_by to lean on unique constraints
* Add test to make sure pick works in a NullRelationRafael Mendonça França2018-02-121-0/+2
|
* Merge pull request #31133 from ↵Matthew Draper2018-02-111-0/+15
|\ | | | | | | | | mohsen-alizadeh/sanitize_empty_and_nil_parameters_passed_to_select sanitize empty and nil parameters to select #31059
| * add test case to relation selectMohsen Alizadeh2017-12-031-0/+15
| |
* | Add Relation#pick as short-hand for single-value plucks (#31941)David Heinemeier Hansson2018-02-091-0/+10
| | | | | | * Add Relation#pick as short-hand for single-value plucks
* | Merge pull request #31934 from fatkodima/fix-has_many_through-dumpingRyuta Kamizono2018-02-091-0/+5
|\ \ | | | | | | | | | Fix marshaling of models with `has_many :through` associations
| * | Fix marshaling of models with `has_many :through` associationsfatkodima2018-02-081-0/+6
| | |
* | | Fix `test_counter_cache_with_touch_and_lock_version` failurebogdanvlviv2018-02-071-1/+3
|/ / | | | | | | | | | | https://travis-ci.org/rails/rails/jobs/338338927#L1043 Related to daf15f58b943d85d8fb726590ae94f77ca0a5d5f
* | Invoke `load_schema` in `_default_attributes`Ryuta Kamizono2018-02-061-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | Currently `_default_attributes` doesn't work unless `load_schema` is called before. The `MissingAttributeError` is caused by `reload_schema_from_cache` is invoked by `serialize`. I added `load_schema` in `_default_attributes` to `_default_attributes` works without any dependency like `attribute_types` etc. Closes #31905.
* | Merge pull request #31814 from fatkodima/index-nulls-orderRafael França2018-01-292-0/+34
|\ \ | | | | | | Dump correctly index nulls order for PostgreSQL
| * | Dump correctly index nulls order for postgresqlfatkodima2018-01-282-0/+34
| | |
* | | Deprecate `expand_hash_conditions_for_aggregates`Ryuta Kamizono2018-01-291-0/+7
| | | | | | | | | | | | | | | This can not expand an array of aggregated objects correctly, and is no longer used internally since 159b21b5.
* | | Remove unused/missing `to_money` converter in the test/docRyuta Kamizono2018-01-291-1/+1
| | |
* | | Merge pull request #31615 from cben/type_for_attribute-symbolRyuta Kamizono2018-01-291-0/+14
|\ \ \ | | | | | | | | Allow type_for_attribute(:symbol)
| * | | Allow type_for_attribute(:symbol)Beni Cherniavsky-Paskin2018-01-011-0/+14
| | | | | | | | | | | | | | | | Closes #31611.
* | | | Fix expanding an array of `composed_of` objects which have multiple mappingsRyuta Kamizono2018-01-292-5/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up of #31724. If `composed_of` objects have multiple mappings, array predicate handler can not correctly handle the expanded condition. We need to handle it like polymorphic association objects.
* | | | Merge pull request #31724 from orekyuu/fix-expand-composed-object-arrayRyuta Kamizono2018-01-291-0/+18
|\ \ \ \ | |_|/ / |/| | | | | | | Fix not expanded problem when passing an Array object as argument to the where method using composed_of column.
| * | | Allow expanding an array of `composed_of` objectsRyuta Kamizono2018-01-291-3/+2
| | | |
| * | | Fix not expanded problem when passing an Array object as argument to the ↵orekyuu2018-01-261-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | where method using composed_of column. Fixes #31723 ``` david_balance = customers(:david).balance Customer.where(balance: [david_balance]).to_sql # Before: WHERE `customers`.`balance` = NULL # After : WHERE `customers`.`balance` = 50 ```
* | | | Remove extra whitespaceDaniel Colson2018-01-258-46/+46
| | | |
* | | | Use assert_empty and assert_not_emptyDaniel Colson2018-01-2527-127/+127
| | | |
* | | | Use assert_predicate and assert_not_predicateDaniel Colson2018-01-2596-1142/+1142
| | | |
* | | | Change refute to assert_notDaniel Colson2018-01-2512-32/+32
| | | |
* | | | Use respond_to test helpersDaniel Colson2018-01-2515-74/+74
| | | |
* | | | Bring back ability to insert zero value on primary key for fixtures (#31795)Ryuta Kamizono2018-01-262-20/+14
|/ / / | | | | | | | | | | | | | | | Since #29504, mysql2 adapter lost ability to insert zero value on primary key due to enforce `NO_AUTO_VALUE_ON_ZERO` disabled. That is for using `DEFAULT` on auto increment column, but we can use `NULL` instead in that case.
* | | Add test case for deprecated `insert_fixtures`Ryuta Kamizono2018-01-261-2/+16
| | | | | | | | | | | | Since #31422, `insert_fixtures` is deprecated.
* | | Remove unused `test/fixtures/teapots.yml`Ryuta Kamizono2018-01-251-3/+0
| | | | | | | | | | | | It was unused since 9e4c41c903e8e58721f2c41776a8c60ddba7a0a9.
* | | Fix `count(:all)` with eager loading and having an order other than the ↵Ryuta Kamizono2018-01-252-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | driving table This is a regression caused by 6beb4de. In PostgreSQL, ORDER BY expressions must appear in SELECT list when using DISTINCT. When using `count(:all)` with eager loading, Active Record enforces DISTINCT to count the driving table records only. 6beb4de was caused the regression because `count(:all)` with DISTINCT path no longer removes ORDER BY. We need to ignore ORDER BY when DISTINCT is enforced, otherwise not always generated valid SQL for PostgreSQL. Fixes #31783.
* | | Clear the transaction state when AR object is dupedYuriy Ustushenko2018-01-251-0/+16
| | |
* | | Merge pull request #31784 from composerinteralia/relation-signatureRafael França2018-01-246-29/+49
|\ \ \ | | | | | | | | Avoid passing unnecessary arguments to relation
| * | | Avoid passing unnecessary arguments to relationDaniel Colson2018-01-246-29/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most of the time the table and predicate_builder passed to Relation.new are exactly the arel_table and predicate builder of the given klass. This uses klass.arel_table and klass.predicate_builder as the defaults, so we don't have to pass them in most cases. This does change the signaure of both Relation and AssocationRelation. Are we ok with that?
* | | | Skip test that use fork in the memory store dbRafael Mendonça França2018-01-241-32/+34
|/ / /
* | | Make discard safe when it follows a manual disconnectMatthew Draper2018-01-251-0/+40
| | | | | | | | | | | | | | | | | | It doesn't have to do anything, but it shouldn't fail. Fixes #31766.
* | | Merge pull request #31773 from dinahshi/postgresql_bulk_patchMatthew Draper2018-01-241-2/+3
|\ \ \ | | | | | | | | Postgresql bulk_change_table should flatten procs array
| * | | Use concat to join procs arrays in bulk_change_tableDinah Shi2018-01-231-2/+3
| | | |
* | | | Merge pull request #31422 from Edouard-chin/multistatement-fixturesMatthew Draper2018-01-242-1/+121
|\ \ \ \ | | | | | | | | | | Build a multi-statement query when inserting fixtures
| * | | | Allow a 2 bytes margin:Edouard CHIN2018-01-231-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | - mysql will add a 2 bytes margin to the statement, so given a `max_allowed_packet` set to 1024 bytes, a 1024 bytes fixtures will no be inserted (mysql will throw an error) - Preventing this by decreasing the max_allowed_packet by 2 bytes when doing the comparison with the actual statement size
| * | | | Build a multi-statement query when inserting fixtures:Edouard CHIN2018-01-222-1/+119
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - The `insert_fixtures` method can be optimized by making a single multi statement query for all fixtures having the same connection instead of doing a single query per table - The previous code was bulk inserting fixtures for a single table, making X query for X fixture files - This patch builds a single **multi statement query** for every tables. Given a set of 3 fixtures (authors, dogs, computers): ```ruby # before %w(authors dogs computers).each do |table| sql = build_sql(table) connection.query(sql) end # after sql = build_sql(authors, dogs, computers) connection.query(sql) ``` - `insert_fixtures` is now deprecated, `insert_fixtures_set` is the new way to go with performance improvement - My tests were done with an app having more than 700 fixtures, the time it takes to insert all of them was around 15s. Using a single multi statement query, it took on average of 8 seconds - In order for a multi statement to be executed, mysql needs to be connected with the `MULTI_STATEMENTS` [flag](https://dev.mysql.com/doc/refman/5.7/en/c-api-multiple-queries.html), which is done before inserting the fixtures by reconnecting to da the database with the flag declared. Reconnecting to the database creates some caveats: 1. We loose all open transactions; Inside the original code, when inserting fixtures, a transaction is open. Multple delete statements are [executed](https://github.com/rails/rails/blob/a681eaf22955734c142609961a6d71746cfa0583/activerecord/lib/active_record/fixtures.rb#L566) and finally the fixtures are inserted. The problem with this patch is that we need to open the transaction only after we reconnect to the DB otherwise reconnecting drops the open transaction which doesn't commit all delete statements and inserting fixtures doesn't work since we duplicated them (Primary key duplicate exception)... - In order to fix this problem, the transaction is now open directly inside the `insert_fixtures` method, right after we reconnect to the db - As an effect, since the transaction is open inside the `insert_fixtures` method, the DELETE statements need to be executed here since the transaction is open later 2. The same problem happens for the `disable_referential_integrity` since we reconnect, the `FOREIGN_KEY_CHECKS` is reset to the original value - Same solution as 1. , the disable_referential_integrity can be called after we reconnect to the transaction 3. When the multi statement query is executed, no other queries can be performed until we paginate over the set of results, otherwise mysql throws a "Commands out of sync" [Ref](https://dev.mysql.com/doc/refman/5.7/en/commands-out-of-sync.html) - Iterating over the set of results until `mysql_client.next_result` is false. [Ref](https://github.com/brianmario/mysql2#multiple-result-sets) - Removed the `active_record.sql "Fixture delete"` notification, the delete statements are now inside the INSERT's one - On mysql the `max_allowed_packet` is looked up: 1. Before executing the multi-statements query, we check the packet length of each statements, if the packet is bigger than the max_allowed_packet config, an `ActiveRecordError` is raised 2. Otherwise we concatenate the current sql statement into the previous and so on until the packet is `< max_allowed_packet`
* | | | | Merge pull request #31549 from fatkodima/foreign_tablesRyuta Kamizono2018-01-231-0/+109
|\ \ \ \ \ | | | | | | | | | | | | Support for PostgreSQL foreign tables
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 18:53:08 +0000