Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix find_by_last when order is given [#2127 state:committed] | Jan De Poorter | 2009-03-09 | 3 | -2/+7 |
| | | | | Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | ||||
* | Ruby 1.9 compat: rename deprecated assert_raises to assert_raise. | Jeremy Kemper | 2009-03-08 | 18 | -104/+104 |
| | | | | [#1617 state:resolved] | ||||
* | Add ActiveRecord::Base#invalid? as the opposite of #valid? [#2159 ↵ | Jeffrey Hardy | 2009-03-08 | 1 | -1/+12 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fix calculation tests to work on sqlite | Pratik Naik | 2009-03-07 | 1 | -5/+7 |
| | |||||
* | Ensure calculations respect scoped :select [#1334 state:resolved] | stopdropandrew | 2009-03-07 | 1 | -0/+11 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure validates_uniqueness_of considers limit on the field. [#1042 ↵ | Arthur Klepchukov | 2009-03-07 | 3 | -0/+16 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fix RDoc grammar and ensure hm:t tests can run in isolation. [#1644 ↵ | Adam Milligan | 2009-03-07 | 1 | -0/+2 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | DRY with_kcode in Active Record tests | Pratik Naik | 2009-03-07 | 2 | -28/+0 |
| | |||||
* | Fixed broken migrations tests: added assert_equal. [#1704 state:resolved] | Marcello Nuccio | 2009-03-07 | 1 | -7/+7 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Allow :having conditions to be sanitized like regular :condition. [#2158 ↵ | Will Bryant | 2009-03-06 | 2 | -0/+15 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure belongs_to association with a counter cache in name spaced model ↵ | Adam Cooper | 2009-03-06 | 3 | -0/+29 |
| | | | | | | works [#1678 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure replacing has_one associations respects the supplied :dependent ↵ | Dimitri Krassovski | 2009-03-06 | 3 | -2/+22 |
| | | | | | | option. [#1305 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure supplie :from has precedence over scoped :from [#1370 state:resolved] | Pratik Naik | 2009-03-06 | 1 | -0/+8 |
| | |||||
* | Ensure self referential HABTM associations raise an exception if ↵ | Tom Lea | 2009-03-06 | 1 | -0/+8 |
| | | | | | | association_foreign_key is missing. [#1252 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Methods invoked within named scope Procs should respect the scope stack. ↵ | jvoorhis | 2009-03-06 | 2 | -0/+6 |
| | | | | | | [#1267 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fix that scoped find with :group and :having [#2006 state:resolved] | Mike Gunderloy | 2009-02-28 | 1 | -0/+7 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Don't validate records of an :autosave association if they're marked for ↵ | Eloy Duran | 2009-02-27 | 1 | -3/+27 |
| | | | | | | destruction. [#2064 status:resolved] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | ||||
* | Fixed that autosave should validate associations even if master is invalid ↵ | David Heinemeier Hansson | 2009-02-27 | 4 | -353/+442 |
| | | | | [#1930 status:committed] | ||||
* | Add test case for ActiveRecord::ConnectionAdapters::ConnectionManagement. | Manfred Stienstra | 2009-02-25 | 1 | -0/+25 |
| | | | | | | - Make sure ConnectionManagement clears connections after each call, except in tests Signed-off-by: Joshua Peek <josh@joshpeek.com> | ||||
* | update the default scope test to take the model's default scope into account | rick | 2009-02-25 | 1 | -1/+1 |
| | |||||
* | Fixed bug that makes named_scopes _forgot_ current scope | Diego Algorta | 2009-02-25 | 2 | -0/+15 |
| | |||||
* | Added ActiveRecord::Base.each and ActiveRecord::Base.find_in_batches for ↵ | David Heinemeier Hansson | 2009-02-23 | 1 | -0/+49 |
| | | | | batch processing [DHH/Jamis Buck] | ||||
* | Revert "Wrap calls to update_attributes in a transaction." | Michael Koziarski | 2009-02-22 | 1 | -34/+0 |
| | | | | | | | This caused failures on sqlite, sqlite3 and postgresql This reverts commit fc09ebc669bd58f415f7d3ef932ef02dab821ab5. [#922 state:reopened] | ||||
* | Wrap calls to update_attributes in a transaction. | Xavier Noria | 2009-02-22 | 1 | -0/+34 |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#922 state:committed] | ||||
* | Changed API of NestedAttributes to take an array, or hash with index keys, ↵ | Lance Ivy | 2009-02-13 | 3 | -79/+215 |
| | | | | | | | | of hashes that have the id on the inside of the attributes hash and updated the FormBuilder to produce such hashes. Also fixed NestedAttributes with composite ids. Signed-off-by: Michael Koziarski <michael@koziarski.com> Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com> [#1892 state:committed] | ||||
* | support end-exclusive ... Ranges in SQL hash condition sanitization properly | Will Bryant | 2009-02-06 | 1 | -0/+6 |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1865 state:committed] | ||||
* | Support true/false in query_attribute for calculated columns | Max Lapshin | 2009-02-06 | 1 | -0/+12 |
| | | | | | Signed-off-by: Tarmo Tänav <tarmo@itech.ee> Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Fixed tests of postgresql money insertion when non-C locale | Max Lapshin | 2009-02-06 | 1 | -0/+1 |
| | | | | | Signed-off-by: Tarmo Tänav <tarmo@itech.ee> Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Also save :autosave enabled associations when #save! is used. | Eloy Duran | 2009-02-06 | 1 | -1/+23 |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1877 state:committed] | ||||
* | Nested attribute accessors should ignore new records with truthy _delete key. | Pascal Ehlert | 2009-02-06 | 1 | -0/+14 |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1861 state:committed] | ||||
* | Add ActiveRecord::Base.exists? with no args [#1817 state:committed] | Scott Taylor | 2009-02-05 | 1 | -1/+10 |
| | | | | Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | ||||
* | Bump mocha requirement for Ruby 1.9 compat. Remove uses_mocha. | Jeremy Kemper | 2009-02-03 | 12 | -613/+570 |
| | |||||
* | Don't rely on the order in these tests | Michael Koziarski | 2009-02-01 | 1 | -2/+2 |
| | |||||
* | validate_length_of should use custom message if given when using in or within. | miloops | 2009-02-01 | 1 | -0/+13 |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1057 state:committed] | ||||
* | Add support for nested object forms to ActiveRecord and the helpers in ↵ | Eloy Duran | 2009-02-01 | 10 | -1/+790 |
| | | | | | | | | ActionPack Signed-Off-By: Michael Koziarski <michael@koziarski.com> [#1202 state:committed] | ||||
* | Sqlite adapter's copy_table incorrectly attempts to recreate a primary key ↵ | Jacob Dunphy | 2009-01-29 | 2 | -0/+16 |
| | | | | | | | | | id (:id => true in the create_table) if an :id column is present, even if it isn't a primary_key. This fix sets :id => false if there is an :id column, but it's not the primary_key. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1766 state:committed] | ||||
* | Ensure whitespaces are stripped when merging string joins. [#1297 ↵ | Filip H.F. "FiXato" Slagter | 2009-01-28 | 1 | -0/+10 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Add array id support to Model.update_counters. [#1254 state:resolved] ↵ | Pratik Naik | 2009-01-28 | 1 | -0/+7 |
| | | | | [Carlos Júnior] | ||||
* | Mysql#reconnect is set according to the 'reconnect' key in the connection spec. | Dov Murik | 2009-01-27 | 1 | -0/+26 |
| | | | | | | | | | | | | The 'reconenct' boolean option is read from the connection specification and is used to set the reconnect attribute of Mysql. The default is false in order not to change existing application behaviour. Also, reconnect is set AFTER real_connect is called, so its value sticks (the mysql gem sets reconnect to false inside real_connect). Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1797 state:committed] | ||||
* | Adding AR tests for JDBC connections | Stephen Bannasch | 2009-01-26 | 6 | -0/+131 |
| | | | | | | | | | | | | | | | | | New connections: jdbcmysql jdbcpostgresql jdbcsqlite3 jdbcderby jdbch2 jdbchsqldb jdbcpostgresql To test you will need the native database installed (if one is required), activerecord-jdbc-adapter and the specific activerecord-jdbc<database>-adapter for the database you are testing. Run the tests like this: jruby -S rake test_jdbcmysql Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1685 state:committed] | ||||
* | Make sure inner scope conditions get a preference over the outer ones | Pratik Naik | 2009-01-24 | 3 | -0/+28 |
| | |||||
* | Fix has_and_belongs_to_many_associations tests. #1738 | Pratik Naik | 2009-01-18 | 2 | -3/+3 |
| | |||||
* | Cache columns for has_and_belongs_to_many associations | lukeludwig | 2009-01-17 | 1 | -0/+11 |
| | | | | | This avoids repeatedly calling SHOW COLUMNS when the association is queried [#1738 state:committed] | ||||
* | Fix dirty handling of nullable non-integer numeric columns [#1692 ↵ | Carlos Kozuszko | 2009-01-16 | 2 | -0/+25 |
| | | | | | | state:resolved] Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | ||||
* | Make belongs_to :dependent => :destroy destroy self before associated ↵ | Ben VandenBos | 2009-01-16 | 1 | -1/+2 |
| | | | | | | | | object [#1079 state:resolved] If foreign key constraints are in place then deleteing the associated object first will cause a foreign key violation Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | ||||
* | Fix the AR json serialization tests to comply with the earlier change to ↵ | Michael Koziarski | 2009-01-16 | 1 | -1/+1 |
| | | | | quote keys correctly | ||||
* | Fixed broken after_save callback; was being called when before_create was ↵ | Michael Lovitt | 2009-01-16 | 1 | -3/+41 |
| | | | | | | | canceled or before_update was canceled Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1735 state:committed] | ||||
* | Fixing bug on ActiveRecord::Dirty#field_changed? for nullable numeric ↵ | Carlos Kozuszko | 2009-01-16 | 1 | -1/+1 |
| | | | | | | | columns, NULL gets stored in database for blank (i.e. '') values. Only integer columns were considered. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1692 state:committed] | ||||
* | Fix PostgreSQL unit test failures that only occur when using the old ↵ | Hongli Lai (Phusion) | 2009-01-13 | 1 | -2/+1 |
| | | | | | | | | 'postgres' driver. [#1748 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Introduce transaction_joinable flag to mark that the fixtures transaction ↵ | Jeremy Kemper | 2009-01-10 | 1 | -4/+4 |
| | | | | | | can't joined, a new savepoint is required even if :requires_new is not set. Use :requires_new option instead of :nest. Update changelog. [#383 state:committed] |