Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | Rails 4 is just around the corner. Stuck with 1.8 until then. | Jeremy Kemper | 2011-10-13 | 1 | -3/+3 | |
| | | | ||||||
| * | | Tests gotta run in 1.8 too | Jeremy Kemper | 2011-10-13 | 1 | -2/+2 | |
| | | | ||||||
* | | | Fix that changing a store should mark the store attribute as changed | David Heinemeier Hansson | 2011-10-25 | 1 | -0/+5 | |
|/ / | ||||||
* | | Added ActiveRecord::Base.store for declaring simple single-column key/value ↵ | David Heinemeier Hansson | 2011-10-13 | 3 | -0/+31 | |
| | | | | | | | | stores [DHH] | |||||
* | | ambiguous first argument; put parentheses or even spaces Warning removed! | Arun Agrawal | 2011-10-10 | 1 | -2/+2 | |
| | | ||||||
* | | Use broken YAML that will fail with Syck as well as Psych. Fixes ↵ | Jon Leighton | 2011-10-09 | 1 | -2/+2 | |
| | | | | | | | | | | | | test_broken_yaml_exception in fixtures_test.rb on Ruby 1.8.7. Cherry-pick from 3-1-stable: b8d46924e70e0847e92e1d2dbaaec8c11381072c | |||||
* | | Remove stray whitespace | Jeremy Kemper | 2011-10-09 | 1 | -4/+1 | |
| | | ||||||
* | | Only use LOWER for mysql case insensitive uniqueness check when column has a ↵ | Joseph Palermo | 2011-10-09 | 4 | -1/+96 | |
| | | | | | | | | case sensitive collation. | |||||
* | | Fixed BodyProxy.new for tests! for wrong argument | Arun Agrawal | 2011-10-08 | 1 | -1/+1 | |
| | | ||||||
* | | Merge pull request #3232 from Juanmcuello/pg_prepared_statements | Aaron Patterson | 2011-10-06 | 1 | -0/+19 | |
|\ \ | | | | | | | Use the schema_search_path in prepared statements. | |||||
| * | | refs #3232. Prepared statements and postgreSQL schemas. | Juan M. Cuello | 2011-10-05 | 1 | -0/+19 | |
| | | | | | | | | | | | | | | | Add tests for prepared statements with multiple schemas in postgreSQL. | |||||
* | | | Transactional fixtures enlist all active database connections. | Jeremy Kemper | 2011-10-05 | 5 | -4/+38 | |
| | | | | | | | | | | | | You can use multiple databases in your tests without disabling transactional fixtures. | |||||
* | | | Raise an exception on unknown primary key inside AssociationReflection. | Jon Leighton | 2011-10-05 | 1 | -0/+15 | |
| | | | | | | | | | | | | | | | An association between two models cannot be made if a relevant key is unknown, so fail fast rather than generating invalid SQL. Fixes #3207. | |||||
* | | | Revert "Raise error on unknown primary key." | Jon Leighton | 2011-10-05 | 3 | -18/+4 | |
|/ / | | | | | | | This reverts commit ee2be435b1e5c0e94a4ee93a1a310e0471a77d07. | |||||
* | | Raise error on unknown primary key. | Jon Leighton | 2011-10-05 | 3 | -4/+18 | |
| | | | | | | | | | | If we don't have a primary key when we ask for it, it's better to fail fast. Fixes GH #2307. | |||||
* | | To support ActiveRecord unit tests for IBM DB2 | Yasuo Honda | 2011-10-02 | 1 | -0/+2 | |
| | | ||||||
* | | Don't call self.class unless necessary. Closes #3171. | Jon Leighton | 2011-09-29 | 1 | -0/+1 | |
| | | ||||||
* | | Fixed failed test under 1.8.7 as map.keys order in indeterminable | Rocky Jaiswal | 2011-09-28 | 2 | -2/+2 | |
| | | ||||||
* | | Don't require a DB connection when setting primary key. | Jon Leighton | 2011-09-26 | 1 | -0/+16 | |
| | | | | | | | | Closes #2807. | |||||
* | | Merge pull request #3030 from htanata/fix_habtm_select_query_method | Jon Leighton | 2011-09-26 | 2 | -0/+16 | |
| | | | | | | | | Fix: habtm doesn't respect select query method | |||||
* | | Fix belongs_to polymorphic with custom primary key on target. | Jon Leighton | 2011-09-26 | 2 | -1/+8 | |
| | | | | | | | | Closes #3104. | |||||
* | | CollectionProxy#replace should change the DB records rather than just ↵ | Jon Leighton | 2011-09-26 | 1 | -0/+11 | |
| | | | | | | | | mutating the array. Fixes #3020. | |||||
* | | fix test error when running with postgresql. | Arun Agrawal | 2011-09-18 | 1 | -2/+4 | |
| | | | | | | | | | | This Sqlite3 should be in if block. Was giving error because sqlite3 is not loaded | |||||
* | | Fixed test for JRuby. | Arun Agrawal | 2011-09-18 | 1 | -1/+2 | |
| | | | | | | for Sqlite3 in AR-JDBC.It's Jdbc::SQLite3::VERSION | |||||
* | | Stop trying to be clever about when to define attribute methods. | Jon Leighton | 2011-09-14 | 1 | -24/+0 | |
| | | | | | | | | | | | | | | | | | | There is no meaningful performance penalty in defining attribute methods, since it only happens once. There is also no reason *not* to define them, since they get thrown in an included module, so they will not 'overwrite' anything. In fact, this is desirable, since it allows us to call super. | |||||
* | | Rename first_or_new to first_or_initialize. | Jon Leighton | 2011-09-13 | 2 | -22/+8 | |
| | | | | | | | | | | For consistency with find_or_initialize_by. Also remove first_or_build alias. | |||||
* | | Deprecate using method_missing for attributes that are columns. | Jon Leighton | 2011-09-13 | 1 | -0/+15 | |
| | | | | | | | | | | | | This shouldn't ever happen unless people are doing something particularly weird, but adding a deprecation in case there are bugs not caught by our tests. | |||||
* | | Let Ruby deal with method visibility. | Jon Leighton | 2011-09-13 | 1 | -3/+3 | |
| | | | | | | | | | | | | Check respond_to_without_attributes? in method_missing. If there is any method that responds (even private), let super handle it and raise NoMethodError if necessary. | |||||
* | | Reset column info when messing with columns. | Jon Leighton | 2011-09-13 | 1 | -0/+2 | |
| | | | | | | | | | | | | | | We are subclassing Session here, but messing with the columns will affect the attribute methods defined on the Session superclass, and therefore other tests, unless we properly isolate it by resetting column info before and after the test run. | |||||
* | | Always generate attribute methods on the base class. | Jon Leighton | 2011-09-13 | 2 | -0/+17 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a situation I encountered where a subclass would cache the name of a generated attribute method in @_defined_class_methods. Then, when the superclass has it's attribute methods undefined, the subclass would always have to dispatch through method_missing, because the presence of the attribute in @_defined_class_methods would mean that it is never generated again, even if undefine_attribute_methods is called on the subclass. There various other confusing edge cases like this. STI classes share columns, so let's just keep all the attribute method generation state isolated to the base class. | |||||
* | | Raise error when using write_attribute with a non-existent attribute. | Jon Leighton | 2011-09-13 | 4 | -19/+32 | |
| | | | | | | | | | | | | | | | | | | Previously we would just silently write the attribute. This can lead to subtle bugs (for example, see the change in AutosaveAssociation where a through association would wrongly gain an attribute. Also, ensuring that we never gain any new attributes after initialization will allow me to reduce our dependence on method_missing. | |||||
* | | Make protected method public so we avoid method_missing. | Jon Leighton | 2011-09-13 | 1 | -4/+5 | |
| | | ||||||
* | | Not used variables removed. Warnings removed. | Arun Agrawal | 2011-09-10 | 1 | -1/+1 | |
| | | ||||||
* | | Add missing require in base_test.rb, fixes isolated test | Guillermo Iguaran | 2011-09-09 | 1 | -0/+1 | |
| | | ||||||
* | | Merge pull request #2757 from andmej/first_or_create_pull_request | Jon Leighton | 2011-09-08 | 2 | -0/+159 | |
|\ \ | | | | | | | Add first_or_create family of methods to Active Record | |||||
| * | | Adding first_or_create, first_or_create!, first_or_new and first_or_build to ↵ | Andrés Mejía | 2011-08-30 | 2 | -0/+159 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Active Record. This let's you write things like: User.where(:first_name => "Scarlett").first_or_create!(:last_name => "Johansson", :hot => true) Related to #2420. | |||||
* | | | LRU cache in mysql and sqlite are now per-process caches. | Aaron Patterson | 2011-09-07 | 2 | -0/+47 | |
| | | | ||||||
* | | | fixing file name | Aaron Patterson | 2011-09-07 | 1 | -0/+0 | |
| | | | ||||||
* | | | LRU should cache per process in postgresql. fixes #1339 | Aaron Patterson | 2011-09-07 | 1 | -0/+23 | |
| | | | ||||||
* | | | Merge commit 'refs/pull/2909/head' of https://github.com/rails/rails into rawr | Aaron Patterson | 2011-09-07 | 1 | -0/+6 | |
| | | | | | | | | | | | | | | | | | | * https://github.com/rails/rails: Postgresql adapter: added current_schema check for table_exists? Postgresql adapter: added current_schema check for table_exists? | |||||
* | | | Add ROWNUM to test first and last to support Oracle. | Yasuo Honda | 2011-09-07 | 1 | -2/+2 | |
| | | | ||||||
* | | | Don't include any of includes, preload, joins, eager_load in the through ↵ | Jon Leighton | 2011-09-07 | 1 | -3/+5 | |
| | | | | | | | | | | | | association scope. | |||||
* | | | Merge pull request #2485 from akaspick/exists_fix | Jon Leighton | 2011-09-07 | 1 | -0/+9 | |
|\ \ \ | | | | | | | | | fix exists? to return false if passed nil (which may come from a missing | |||||
| * | | | fix exists? to return false if passed nil (which may come from a missing URL ↵ | Andrew Kaspick | 2011-08-10 | 1 | -0/+9 | |
| | | | | | | | | | | | | | | | | param) | |||||
* | | | | Merge pull request #2897 from rsutphin/ar31-remove_connection | Aaron Patterson | 2011-09-06 | 1 | -1/+20 | |
| | | | | | | | | | | | | | | | | Patch for issue #2820 | |||||
* | | | | Nested through associations: preloads from the default scope of a through ↵ | Jon Leighton | 2011-09-06 | 1 | -0/+9 | |
| | | | | | | | | | | | | | | | | model should not be included in the association scope. (We're already excluding includes.) Fixes #2834. | |||||
* | | | | Ensure we are not comparing a string with a symbol in ↵ | Jon Leighton | 2011-09-06 | 2 | -1/+11 | |
| | | | | | | | | | | | | | | | | HasManyAssociation#inverse_updates_counter_cache?. Fixes #2755, where a counter cache could be decremented twice as far as it was supposed to be. | |||||
* | | | | Disable active record marshalling tests on Ruby 1.8.7 on Travis CI, as they ↵ | Jon Leighton | 2011-09-06 | 2 | -0/+25 | |
| | | | | | | | | | | | | | | | | have been failing intermittently for a long while due to what appears to be a Ruby bug. If anyone has the skills/expertise/time to debug this, please speak to the Travis guys. | |||||
* | | | | #first doesn't take an order in this test | Damien Mathieu | 2011-09-06 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Merge pull request #2877 from dmathieu/fix_tests_pg_18 | Santiago Pastorino | 2011-09-05 | 1 | -2/+2 | |
|\ \ \ \ | | | | | | | | | | | Last orders the records by id |