aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Fix `OID::Bit#cast_value`Ryuta Kamizono2016-08-201-2/+3
| | | | Fixes #26137.
* Remove unused `blob_or_text_column?` methodRyuta Kamizono2016-08-191-5/+0
|
* Merge pull request #25675 from TimPetricola/schema-no-standardized-column-widthsRafael Mendonça França2016-08-191-0/+78
|\ | | | | | | Option not to line up column attributes in schema.rb
| * Option not to line up column types and attributes in schema.rbTim Petricola2016-08-171-0/+78
| |
* | Merge pull request #26154 from ↵Rafael Mendonça França2016-08-192-60/+33
|\ \ | | | | | | | | | | | | | | | kamipo/remove_text_default_treated_as_empty_string Remove text default treated as an empty string in non-strict mode
| * | Remove text default treated as an empty string in non-strict modeRyuta Kamizono2016-08-192-60/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Strict mode controls how MySQL handles invalid or missing values in data-change statements such as INSERT or UPDATE. If strict mode is not in effect, MySQL inserts adjusted values for invalid or missing values and produces warnings. ```ruby def test_mysql_not_null_defaults_non_strict using_strict(false) do with_mysql_not_null_table do |klass| record = klass.new assert_nil record.non_null_integer assert_nil record.non_null_string assert_nil record.non_null_text assert_nil record.non_null_blob record.save! record.reload assert_equal 0, record.non_null_integer assert_equal "", record.non_null_string assert_equal "", record.non_null_text assert_equal "", record.non_null_blob end end end ``` It is inconsistent with other types that only text/blob defaults treated as an empty string. This commit fixes the inconsistency.
* | | Merge pull request #26089 from travisoneill/sqlite_rollback_fixRafael Mendonça França2016-08-191-0/+17
|\ \ \ | |/ / |/| | | | | Sqlite3 Migration Error Fixed (issue #26087)
| * | Added nil case handling to allow rollback migration in case oftravis.h.oneill@gmail.com2016-08-171-0/+17
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | invalid column type /activerecord/lib/active_record/connection_adapters /abstract/schema_definitions.rb:306 type = type.to_sym Changed to the following to handle nil case: type = type.to_sym if type Added regression test for this case: /activerecord/test/cases/migration_test.rb:554 if current_adapter?(:SQLite3Adapter) def test_allows_sqlite3_rollback_on_invalid_column_type Person.connection.create_table :something, force: true do |t| t.column :number, :integer t.column :name, :string t.column :foo, :bar end assert Person.connection.column_exists?(:something, :foo) assert_nothing_raised { Person.connection.remove_column :something, :foo, :bar } assert !Person.connection.column_exists?(:something, :foo) assert Person.connection.column_exists?(:something, :name) assert Person.connection.column_exists?(:something, :number) ensure Person.connection.drop_table :something, if_exists: true end end
* | Merge pull request #24099 from k0kubun/preserve-readonlyRafael Mendonça França2016-08-182-2/+21
|\ \ | | | | | | | | | Preserve readonly flag only for readonly association
| * | Preserve readonly flag only for readonly associationTakashi Kokubun2016-07-302-2/+21
| | | | | | | | | | | | Fixes #24093
* | | Remove unnecessary `test_sql_for_insert_with_returning_disabled`Ryuta Kamizono2016-08-181-6/+0
| |/ |/| | | | | | | Because `sql_for_insert` is only called in `use_insert_returning?` is true since #26002.
* | Merge pull request #25976 from kamipo/pluck_uses_loaded_targetRafael França2016-08-171-0/+7
|\ \ | | | | | | `pluck` should use `records` (`load_target`) when `loaded?` is true
| * | `pluck` should use `records` (`load_target`) when `loaded?` is trueRyuta Kamizono2016-08-041-0/+7
| | |
* | | Merge pull request #25987 from aquajach/masterRafael Mendonça França2016-08-171-0/+9
|\ \ \ | | | | | | | | | | | | Fix does_not_support_reverse? to find sql functions with commas in nested brackets
| * | | have does_not_support_reverse? support sql functions with commas in nested ↵Jack2016-07-291-0/+9
| | |/ | |/| | | | | | | brackets
* | | Merge pull request #26002 from ↵Rafael França2016-08-171-0/+7
|\ \ \ | | | | | | | | | | | | | | | | kamipo/sql_for_insert_should_be_called_inside_exec_insert `sql_for_insert` should be called inside `exec_insert`
| * | | `sql_for_insert` should be called inside `exec_insert`Ryuta Kamizono2016-08-061-0/+7
| | | | | | | | | | | | | | | | | | | | `exec_insert` cannot return last inserted id if `use_insert_returning?` is true. `sql_for_insert` should be called inside `exec_insert`.
* | | | Merge pull request #26009 from kamipo/fix_inconsistent_finder_methods_signatureRafael França2016-08-171-9/+0
|\ \ \ \ | | | | | | | | | | Fix inconsistent the signature of finder methods for collection association
| * | | | Fix inconsistent the signature of finder methods for collection associationRyuta Kamizono2016-08-161-9/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `#second`, `#third`, etc finder methods was added in 03855e790de2224519f55382e3c32118be31eeff. But the signature of these methods is inconsistent with the original finder methods. And also the signature of `#first` and `#last` methods is different from the original. This commit fixes the inconsistency.
* | | | | Merge pull request #26021 from ↵Rafael França2016-08-171-0/+40
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | kamipo/finder_bang_method_should_call_non_bang_method Finder bang method should call non bang method
| * | | | | Finder bang method should call non bang methodRyuta Kamizono2016-08-161-0/+40
| |/ / / / | | | | | | | | | | | | | | | Otherwise CollectionProxy's bang methdos cannot respect dirty target.
* | | | | Merge pull request #26121 from MaxLap/fix_count_with_left_joinsRafael Mendonça França2016-08-162-10/+19
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Fix count which would sometimes force a DISTINCT
| * | | | | Fix count which would sometimes force a DISTINCTMaxime Lapointe2016-08-162-10/+19
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current behaviour of checking if there is a LEFT OUTER JOIN arel node to detect if we are doing eager_loading is wrong. This problem wasn't frequent before as only some pretty specific cases would add a LEFT OUTER JOIN arel node. However, the recent new feature left_outer_joins also add this node and made this problem happen frequently. Since in the perform_calculation function, we don't have access to eager_loading information, I had to extract the logic for the distinct out to the calculate method. As I was in the file for left_outer_join tests, I fixed a few that had bugs and I replaced some that were really weak with something that will catch more issues. In relation tests, the first test I changed would have failed if it had validated the hash returned by count instead of just checking how many pairs were in it. This is because this merge of join currently transforms the join node into an outer join node, which then made count do a distinct. So before this change, the return was {1=>1, 4=>1, 5=>1}.
* | | | | Merge pull request #25671 from ↵Rafael França2016-08-163-3/+10
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | kamipo/dont_handle_as_associated_predicate_if_table_has_column Do not handle as an associated predicate if a table has the column
| * | | | | Do not handle as an associated predicate if a table has the columnRyuta Kamizono2016-08-163-3/+10
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | If handled as an associated predicate even though a table has the column, will generate invalid SQL by valid column name treated as a table name.
* | | | | Merge pull request #26000 from kamipo/remove_sanitizeRafael França2016-08-161-5/+0
|\ \ \ \ \ | | | | | | | | | | | | Remove internal `sanitize` method
| * | | | | Remove internal `sanitize` methodRyuta Kamizono2016-07-311-5/+0
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | Currently internal `sanitize`/`quote_value` method is only used for `quoted_id`. Simply it is enough to use `connection.quote` public API instead.
* | | | | Merge pull request #26183 from Shopify/fix-no-touching-touch-laterRafael França2016-08-161-0/+9
|\ \ \ \ \ | |_|/ / / |/| | | | Makes touch_later respects no_touching policy
| * | | | Makes touch_later respects no_touching policyJean Boussier2016-08-161-0/+9
| | | | |
* | | | | Merge pull request #26074 from kamipo/where_by_attribute_with_array_or_rangeRafael França2016-08-162-0/+12
|\ \ \ \ \ | | | | | | | | | | | | `where` by `array|range` attribute with array or range value
| * | | | | `where` by `array|range` attribute with array or range valueRyuta Kamizono2016-08-112-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently predicate builder cannot build a predicate for `array|range` attribute. This commit fixes the issue. Related #25671.
* | | | | | Merge pull request #26097 from Dagnan/fix_recordnotfound_args_rebasedRafael França2016-08-162-0/+22
|\ \ \ \ \ \ | | | | | | | | | | | | | | When calling association.find RecordNotFound is now raised with the s…
| * | | | | | When calling association.find RecordNotFound is now raised with the same ↵Michel Pigassou2016-08-132-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | argument as when we do it in Record.find (primary_key, id and model).
* | | | | | | Merge pull request #26151 from kamipo/avoid_to_allow_unused_splat_argsRafael França2016-08-161-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Avoid to allow unused splat args for `t.timestamps` in `create_table`
| * | | | | | | Avoid to allow unused splat args for `t.timestamps` in `create_table`Ryuta Kamizono2016-08-141-1/+1
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Unfortunately `t.timestamps` in `create_table` allows unused splat args. But the same one in `change_table` does not allow them. This commit fixes the inconsistent behavior.
* | | | | | | Merge pull request #26162 from kamipo/take_respects_dirty_targetRafael França2016-08-161-4/+8
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | `CollectionProxy#take` should respect dirty target
| * | | | | | | `CollectionProxy#take` should respect dirty targetRyuta Kamizono2016-08-141-4/+8
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | `#first`, `#second`, ..., `#last` methods respects dirty target. But `#take` doesn't respect it. This commit fixes the inconsistent behavior.
* | | | | | | Merge pull request #26019 from agrobbin/schema-load-unique-column-indicesRafael França2016-08-161-0/+16
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Support multiple indexes on the same column when loading the schema
| * | | | | | | support multiple indexes on the same column when loading the schemaAlex Robbin2016-08-021-0/+16
| | |_|_|/ / / | |/| | | | |
* | | | | | | Add three new rubocop rulesRafael Mendonça França2016-08-1693-512/+512
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* | | | | | | Merge pull request #26150 from kamipo/consolidate_ar_test_case_and_as_test_caseSean Griffin2016-08-142-17/+16
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Consolidate `ActiveRecord::TestCase` and `ActiveSupport::TestCase` in AR test cases
| * | | | | | | Consolidate `ActiveRecord::TestCase` and `ActiveSupport::TestCase` in AR ↵Ryuta Kamizono2016-08-142-17/+16
| | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | test cases
* / | | | | | Pass along original attribute to save later recursionAaron Patterson2016-08-141-0/+7
|/ / / / / / | | | | | | | | | | | | | | | | | | Fixes #26122
* | | | | | Merge pull request #26113 from kamipo/use_ar_test_case_instead_of_as_test_caseRafael França2016-08-122-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Use `ActiveRecord::TestCase` rather than `ActiveSupport::TestCase` in AR test cases
| * | | | | | Use `ActiveRecord::TestCase` rather than `ActiveSupport::TestCase` in AR ↵Ryuta Kamizono2016-08-112-2/+2
| | |/ / / / | |/| | | | | | | | | | | | | | | | test cases
* | | | | | Merge pull request #26124 from yahonda/diag26099Sean Griffin2016-08-111-4/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Creating a new Topic class instead of class_eval for the existing one
| * | | | | | Creating a new Topic class instead of class_eval for the existing oneYasuo Honda2016-08-111-4/+2
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | since it affects another test `ReflectionTest#test_read_attribute_names` Address #26099
* / / / / / Fix warning: ambiguous first argumentRyuta Kamizono2016-08-121-1/+1
|/ / / / /
* | | | | Fix a NoMethodError schema_statements.rbGenadi Samokovarov2016-08-101-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you call `remove_index` with wrong options, say a type, like I did, you get: ``` == 20160810072541 RemoveUniqueIndexOnGoals: migrating ========================= -- remove_index(:goal, {:coulmn=>:kid_id, :unique=>true}) rails aborted! StandardError: An error has occurred, this and all later migrations canceled: undefined method `ArgumentError' for #<ActiveRecord::ConnectionAdapters::PostgreSQLAdapter:0x007fb7dec91b28> ``` What happened is that I mistyped column (coulmn) and got a `NoMethodError`, because of a missing comma during the raise. This made Ruby think we're calling the method `ArgumentError`.
* | | | | Fix broken alignments caused by auto-correct commit 411ccbdRyuta Kamizono2016-08-104-4/+8
| | | | | | | | | | | | | | | | | | | | Hash syntax auto-correcting breaks alignments. 411ccbdab2608c62aabdb320d52cb02d446bb39c
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-04 10:03:20 +0000