aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #15868 from sgrif/sg-uninitialized-attributesRafael Mendonça França2014-06-261-0/+56
|\ | | | | | | | | | | | | | | Move behavior of `read_attribute` to `AttributeSet` Conflicts: activerecord/lib/active_record/attribute_set.rb activerecord/test/cases/attribute_set_test.rb
| * Move behavior of `read_attribute` to `AttributeSet`Sean Griffin2014-06-251-0/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Moved `Builder` to its own file, as it started looking very weird once I added private methods to the `AttributeSet` class and the `Builder` class started to grow. Would like to refactor `fetch_value` to change to ```ruby self[name].value(&block) ``` But that requires the attributes to know about their name, which they currently do not.
* | Merge pull request #15847 from sgrif/sg-encapsulate-result-typesRafael Mendonça França2014-06-261-4/+40
|\ \ | | | | | | Encapsulate knowledge of type objects on `ActiveRecord::Result`
| * | Encapsulate knowledge of type objects on `ActiveRecord::Result`Sean Griffin2014-06-221-4/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Attempting to reduce the number of places that care about the details of how type casting occurs. We remove the type casting of the primary key in `JoinDependecy`, rather than encapsulating it. It was originally added for consistency with https://github.com/rails/rails/commit/40898c8c19fa04442fc5f8fb5daf3a8bdb9a1e03#diff-06059df8d3dee3101718fb2c01151ad0R211, but that conditional was later removed in https://github.com/rails/rails/commit/d7ddaa530fd1b94e22d745cbaf2e8a5a34ee9734. What is important is that the same row twice will have the same value for the primary key, which it will.
* | | Merge pull request #15846 from sgrif/sg-attributes-before-type-castRafael Mendonça França2014-06-261-0/+7
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move `attributes_before_type_cast` to `AttributeSet` Conflicts: activerecord/lib/active_record/attribute_set.rb activerecord/test/cases/attribute_set_test.rb
| * | | Move `attributes_before_type_cast` to `AttributeSet`Sean Griffin2014-06-211-0/+7
| | | |
* | | | `preload` preserves readonly flag on associations. #15853Yves Senn2014-06-251-0/+29
| | | | | | | | | | | | | | | | | | | | | | | | This is a partial fix for #15853. It only works when a `preload` is issued and not an `eager_load`. I've added a skipped failing test-case to keep in mind that we need to deal with `eager_load`.
* | | | Always assume strings with non-numeric characters change numeric typesSean Griffin2014-06-241-0/+18
| |_|/ |/| | | | | | | | | | | | | | | | | | | | We previously only did this if the old value was zero, to make sure numericality validations run and failed if the user gave 'wibble' as the value, which would be type cast to 0. However, numericality validations will fail if there are any non-numeric characters in the string, so 5 -> '5wibble' should also be marked as changed.
* | | Add a deprecation cycle for `NullColumn` from `column_for_attribute`Sean Griffin2014-06-231-18/+4
| | | | | | | | | | | | | | | | | | This is public API, and `simple_form` depends on the `nil` return value. We need to go through a deprecation cycle to return a null object. If people want hash access, they can access the hash.
* | | Merge pull request #15865 from sgrif/sg-missing-testYves Senn2014-06-221-0/+20
|\ \ \ | | | | | | | | Add missing test cases for `attribute_names` instance method
| * | | Add missing test cases for `attribute_names` instance methodSean Griffin2014-06-221-0/+20
| | |/ | |/| | | | | | | | | | There is a class method with the same name that is tested, but not the instance method.
* / | `reload` should fully reload attributesSean Griffin2014-06-221-0/+7
|/ / | | | | | | | | | | `reload` is meant to put a record in the same state it would be if you were to do `Post.find(post.id)`. This means we should fully replace the attributes hash.
* | Merge pull request #15839 from sgrif/sg-attr-set-nullYves Senn2014-06-221-0/+8
|\ \ | | | | | | Return a null object from `AttributeSet#[]`
| * | Return a null object from `AttributeSet#[]`Sean Griffin2014-06-201-0/+8
| |/
* | Merge pull request #15849 from sgrif/sg-move-attributesYves Senn2014-06-221-0/+8
|\ \ | | | | | | Move `attributes` to the `AttributeSet` object.
| * | Move `attributes` to the `AttributeSet` object.Sean Griffin2014-06-211-0/+8
| |/
* / Add missing test cases for `attribute_method?`Sean Griffin2014-06-211-0/+11
|/
* Merge pull request #15728 from sgrif/sg-double-save-hm-tRafael Mendonça França2014-06-191-1/+20
|\ | | | | | | | | | | | | | | Don't save through records twice Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/associations/has_many_through_associations_test.rb
| * Don't save through records twiceSean Griffin2014-06-171-0/+19
| | | | | | | | | | | | | | If the through record gets created in an `after_create` hook that is defined before the association is defined (therefore after its `after_create` hook) get saved twice. This ensures that the through records are created only once, regardless of the order of the hooks.
* | Merge pull request #15747 from sgrif/sg-trolololol-this-is-so-brokenRafael Mendonça França2014-06-191-0/+30
|\ \ | | | | | | Always update counter caches in memory when adding records
| * | Always update counter caches in memory when adding recordsSean Griffin2014-06-161-0/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before, calling `size` would only work if it skipped the cache, and would return a different result from the cache, but only if: - The association was previously loaded - Or you called size previously - But only if the size was 0 when you called it This ensures that the counter is appropriately updated in memory.
* | | Merge pull request #15800 from sgrif/sg-column-in-calculationRafael Mendonça França2014-06-191-5/+0
|\ \ \ | | | | | | | | Don't use `Column` for type casting in Relation calculations
| * | | Don't use `Column` for type casting in Relation calculationsSean Griffin2014-06-181-5/+0
| | | |
* | | | Merge pull request #15802 from sgrif/sg-column-quotingRafael Mendonça França2014-06-191-25/+0
|\ \ \ \ | | | | | | | | | | Don't use column object for type casting in `quoting`
| * | | | Don't use column object for type casting in `quoting`Sean Griffin2014-06-181-25/+0
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're never going to be able to use the attribute object here, however, so let's just accept the ugly demeter violation here for now. Remove test cases which were either redundant with other tests in the file, or were actually testing the type objects (which are tested elsewhere)
* | | | Merge pull request #15818 from sgrif/sg-attribute-setRafael Mendonça França2014-06-191-0/+49
|\ \ \ \ | | | | | | | | | | Introduce an object to aid in creation and management of `@attributes`
| * | | | Introduce an object to aid in creation and management of `@attributes`Sean Griffin2014-06-191-0/+49
| |/ / / | | | | | | | | | | | | | | | | Mostly delegation to start, but we can start moving a lot of behavior in bulk to this object.
* | | | Merge pull request #15772 from nbudin/sti_through_bugRafael Mendonça França2014-06-192-0/+15
|\ \ \ \ | | | | | | | | | | | | | | | Don't include inheritance column in the through_scope_attributes
| * | | | Don't include inheritance column in the through_scope_attributesNat Budin2014-06-172-1/+16
| | |_|/ | |/| |
* | | | Use a better test descriptionRafael Mendonça França2014-06-191-1/+1
| | | |
* | | | Fix has_and_belongs_to_many in a namespaced model pointing to a non ↵Rafael Mendonça França2014-06-193-0/+15
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | namespaced model Now the following case will work fine class Tag < ActiveRecord::Base end class Publisher::Article < ActiveRecord::Base has_and_belongs_to_many :tags end Fixes #15761
* | | Reconnect after possibly enabling hstoreMatthew Draper2014-06-181-0/+2
| | |
* | | Merge pull request #15782 from sgrif/sg-column-defaultsMatthew Draper2014-06-1813-49/+35
|\ \ \ | | | | | | | | Don't type cast the default on the column
| * | | Don't type cast the default on the columnSean Griffin2014-06-1713-49/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | If we want to have type decorators mess with the attribute, but not the column, we need to stop type casting on the column. Where possible, we changed the tests to test the value of `column_defaults`, which is public API. `Column#default` is not.
* | | | Detect in-place changes on point typesSean Griffin2014-06-171-0/+11
| | | |
* | | | Enable hstore in array testsSean Griffin2014-06-171-0/+6
| | | |
* | | | Detect mutations of arrays and array membersSean Griffin2014-06-171-0/+23
| | | |
* | | | Ensure `OID::Array#type_cast_for_database` matches PG's quoting behaviorSean Griffin2014-06-172-0/+33
| | | | | | | | | | | | | | | | | | | | | | | | Also takes a step towards supporting types which use a character other than ',' for the delimiter (`box` is the only built in type for which this is the case)
* | | | Merge pull request #15727 from aditya-kapoor/add-tests-for-migrationMatthew Draper2014-06-181-0/+17
|\ \ \ \ | |/ / / |/| | | Add test cases for Migration#inverse_of
| * | | Add test cases for Migration#inverse_ofAditya Kapoor2014-06-171-0/+17
| | |/ | |/|
* | | Don't assume that Hstore columns have always changedSean Griffin2014-06-172-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | HStore columns come back from the database separated by a comma and a space, not just a comma. We need to mirror that behavior since we compare the two values. Also adds a regression test against JSON to ensure we don't have the same bug there.
* | | Don't mess with `column_defaults` when optimistic locking is enabledSean Griffin2014-06-171-0/+7
| |/ |/|
* | add `bin/rake db:purge` task to empty the current database.Yves Senn2014-06-171-0/+28
| |
* | fix typo in test method names. [ci skip]Yves Senn2014-06-171-4/+4
| |
* | Promote time zone aware attributes to a first class type decoratorSean Griffin2014-06-162-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | This refactoring revealed the need for another form of decoration, which takes a proc to select which it applies to (There's a *lot* of cases where this form can be used). To avoid duplication, we can re-implement the old decoration in terms of the proc-based decoration. The reason we're `instance_exec`ing the matcher is for cases such as time zone aware attributes, where a decorator is defined in a parent class, and a method called in the matcher is overridden by a child class. The matcher will close over the parent, and evaluate in its context, which is not the behavior we want.
* | Merge pull request #13963 from lucas-clemente/pending_migrationsRafael Mendonça França2014-06-161-0/+50
|\ \ | | | | | | Skip migration check if adapter doesn't support it
| * | skip migration check if adapter doesn't support itLucas Clemente2014-04-191-0/+50
| | |
* | | Merge pull request #15722 from akshay-vishnoi/spell-correctZachary Scott2014-06-153-3/+3
|\ \ \ | |_|/ |/| | [ci skip] /mysql/i -> MySQL, Spell correct in continuation to #15555
| * | /mysql/i -> MySQL, Spell correct in continuation to #15555Akshay Vishnoi2014-06-143-3/+3
| | |
* | | Deprecate `serialized_attributes` without replacementSean Griffin2014-06-141-2/+4
|/ / | | | | | | | | We've stopped using it internally, in favor of polymorphism. So should you!
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-14 06:11:01 +0000