Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | | CommandRecorder should delegate in method_missing where possible. Fixes some ↵ | Jon Leighton | 2011-06-30 | 1 | -1/+6 | |
| | | | | | | | | | | | | | | | | | | | | tests in migration_test.rb under mysql. The problem was introduced in c278a2c5e109204ec8a47fcbfdfc327aad7996ce. | |||||
* | | | | | Merge pull request #1574 from ↵ | Aaron Patterson | 2011-06-28 | 1 | -0/+12 | |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | oriolgual/1571_ar_relation_order_no_longer_works_with_arel_nodes Fix #1571 ActiveRecord::Relation#order no longer works with arel ordering nodes | |||||
| * | | | | | Add more test cases | Oriol Gual | 2011-06-28 | 1 | -0/+8 | |
| | | | | | | ||||||
| * | | | | | Add failing test | Oriol Gual | 2011-06-28 | 1 | -0/+4 | |
| | | | | | | ||||||
* | | | | | | Fix test_finding_with_cross_table_order_and_limit for Oracle | Raimonds Simanovskis | 2011-06-28 | 1 | -3/+3 | |
|/ / / / / | | | | | | | | | | | Use latest Arel syntax and pass each order by expression as separate argument to order method as otherwise invalid Oracle SQL is generated. | |||||
* | | | | | Merge pull request #1857 from vijaydev/irreversible-migration | Aaron Patterson | 2011-06-28 | 1 | -3/+5 | |
|\ \ \ \ \ | | | | | | | | | | | | | IrreversibleMigration is not raised when a method not supported by reversible migrations is called in the change method of a migration | |||||
| * | | | | | record unsupported methods in CommandRecorder instead of letting the ↵ | Vijay Dev | 2011-06-25 | 1 | -3/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | unsupported methods go through to the underlying db causing errors like duplicate columns to occur when rolling back migrations | |||||
* | | | | | | Merge pull request #1860 from dmathieu/comparison | Aaron Patterson | 2011-06-28 | 1 | -0/+13 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Allow comparison on model objects - Closes #1858 | |||||
| * | | | | | | comparing different classes returns nil | Damien Mathieu | 2011-06-26 | 1 | -0/+6 | |
| | | | | | | | ||||||
| * | | | | | | allow comparison on model objects - Closes #1858 | Damien Mathieu | 2011-06-26 | 1 | -0/+7 | |
| |/ / / / / | ||||||
* | | | | | | oops! remove debugging codes | Aaron Patterson | 2011-06-27 | 1 | -1/+0 | |
| | | | | | | ||||||
* | | | | | | default create_with_value to a hash so we can eliminate conditionals, add ↵ | Aaron Patterson | 2011-06-27 | 2 | -1/+9 | |
|/ / / / / | | | | | | | | | | | | | | | | test surrounding create_with(nil) behavior | |||||
* | | | | | Merge pull request #1848 from raviolicode/postgresql_order_multiple_params | Santiago Pastorino | 2011-06-24 | 1 | -0/+7 | |
|\ \ \ \ \ | | | | | | | | | | | | | Fix for complex ordering of multiple columns on postgresql | |||||
| * | | | | | Improve ordering of multiple columns on postgresql | Lucia Escanellas | 2011-06-24 | 1 | -0/+7 | |
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | * Only on postgresql, order("first asc, second asc") was invalid * Closes #1720 | |||||
* / | | | | Apply the default scope earlier when doing calculations. Fixes #1682. | Jon Leighton | 2011-06-23 | 2 | -0/+13 | |
|/ / / / | ||||||
* | | | | Merge pull request #1790 from ernie/reverse_sql_order_fix | Aaron Patterson | 2011-06-22 | 1 | -0/+12 | |
|\ \ \ \ | | | | | | | | | | | Support reversal of ARel orderings in reverse_sql_order | |||||
| * | | | | Support reversal of ARel orderings in reverse_sql_order | Ernie Miller | 2011-06-20 | 1 | -0/+12 | |
| | | | | | ||||||
* | | | | | Merge pull request #1632 from tardate/pg_schema_fu | Aaron Patterson | 2011-06-21 | 3 | -3/+213 | |
|\ \ \ \ \ | |/ / / / |/| | | | | Improving PostgreSQL adapter schema-awareness | |||||
| * | | | | Merge remote branch 'rails/master' into pg_schema_fu | Paul Gallagher | 2011-06-19 | 7 | -43/+372 | |
| |\ \ \ \ | ||||||
| * | | | | | Make PostgreSQL adapter view-compatible | Paul Gallagher | 2011-06-19 | 2 | -1/+49 | |
| | | | | | | | | | | | | | | | | | | * amongst other things, allows meta_search to run against view-backed models | |||||
| * | | | | | make extract_schema_and_table a private method | Paul Gallagher | 2011-06-11 | 1 | -7/+7 | |
| | | | | | | ||||||
| * | | | | | remove table quoting in primary_key method | Paul Gallagher | 2011-06-11 | 2 | -5/+47 | |
| | | | | | | | | | | | | | | | | | | * add/cleanup tests | |||||
| * | | | | | apply private method indentation convention | Paul Gallagher | 2011-06-10 | 2 | -3/+3 | |
| | | | | | | | | | | | | | | | | | | * tidy test code and fix my typo | |||||
| * | | | | | Improve PostgreSQL adapter schema-awareness | Paul Gallagher | 2011-06-10 | 2 | -2/+122 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * table_exists? scoped by schema search path unless schema is explicitly named. Added tests and doc to clarify the behaviour * extract_schema_and_table tests and implementation extended to cover all cases * primary_key does not ignore schema information * add current_schema and schema_exists? methods * more robust table referencing in insert_sql and sql_for_insert methods | |||||
* | | | | | | Merge pull request #1763 from grantneufeld/schema_column_exists_options_hash | José Valim | 2011-06-18 | 1 | -0/+12 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Fix default options argument on ActiveRecord::ConnectionAdaptors::Table#column_exists? | |||||
| * | | | | | | Changed the default value for the options argument on ↵ | Grant Neufeld | 2011-06-18 | 1 | -0/+12 | |
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord::ConnectionAdapters::Table#column_exists? from nil to an empty Hash {}. That method calls through to ActiveRecord::ConnectionAdapters::SchemaStatements##column_exists? expects options to be a Hash. When options was nil, an error would occur in cases where the column did exist because the called method attempted to perform a key lookup on options. | |||||
* / | | | | | Fix inconsistencies by being polite to the wrapped body. Needed for ↵ | Steve Hodgkiss | 2011-06-18 | 2 | -0/+18 | |
|/ / / / / | | | | | | | | | | | | | | | | Rack::Sendfile to function properly. See issue #1761. | |||||
* | | | | | Add require 'pathname' as it has not already been required in some circumstances | Jon Leighton | 2011-06-17 | 1 | -0/+1 | |
| | | | | | ||||||
* | | | | | Pass mass-assignment options to nested models - closes #1673. | Andrew White | 2011-06-13 | 2 | -2/+251 | |
| | | | | | ||||||
* | | | | | Rename tests to reflect associations | Andrew White | 2011-06-13 | 1 | -30/+30 | |
| | | | | | ||||||
* | | | | | Add support for using an ARCONFIG environment variable to specify the ↵ | Jon Leighton | 2011-06-12 | 1 | -4/+7 | |
| | | | | | | | | | | | | | | | | | | | | location of the config.yml file for running the tests | |||||
* | | | | | Oops, this should have been in the last commit :zap: | Jon Leighton | 2011-06-12 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | Make assert_no_queries literally enforce that there are no queries. As in, ↵ | Jon Leighton | 2011-06-12 | 1 | -15/+0 | |
| | | | | | | | | | | | | | | | | | | | | not a single line of SQL should be sent to the database, not even stuff that is ignored by assert_queries. The argument being that if you write assert_no_queries, you really do not want there to be any queries. | |||||
* | | | | | If we're going to use a global variable, let's at least namespace it | Jon Leighton | 2011-06-12 | 1 | -4/+4 | |
| | | | | | ||||||
* | | | | | Refactor tests to be less brittle | Jon Leighton | 2011-06-12 | 3 | -28/+74 | |
| | | | | | ||||||
* | | | | | Move BEGIN and COMMIT into IGNORED_SQL rather than having them as a special ↵ | Jon Leighton | 2011-06-12 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | case in assert_queries | |||||
* | | | | | Don't wrap operations on collection associations in transactions when they ↵ | benedikt | 2011-06-12 | 1 | -0/+45 | |
|/ / / / | | | | | | | | | | | | | are not needed, so the connection adapter does not send empty BEGIN COMMIT transactions blocks to the database. | |||||
* | | | | Print out information about whether the identity map is on or off when ↵ | Jon Leighton | 2011-06-09 | 2 | -6/+7 | |
| | | | | | | | | | | | | | | | | running unit tests | |||||
* | | | | Remove unused 'y' variable. | Sebastian Martinez | 2011-06-08 | 1 | -2/+2 | |
| | | | | ||||||
* | | | | Do not hardcode :id as it was ignored by mass assignment filter | Raimonds Simanovskis | 2011-06-08 | 1 | -2/+2 | |
| | | | | | | | | | | | | As a result test was failing on Oracle where ids are assigned by default from 1000 | |||||
* | | | | Allow polymorphic has_one to work when the association is set before the ↵ | Jon Leighton | 2011-06-08 | 1 | -0/+11 | |
| | | | | | | | | | | | | | | | | owner has been saved. Fixes #1524. | |||||
* | | | | When you add a record to a polymorphic has_one, you should be able to access ↵ | Jon Leighton | 2011-06-08 | 1 | -1/+4 | |
| | | | | | | | | | | | | | | | | the owner from the associated record | |||||
* | | | | fix typo | Alexandr Zykov | 2011-06-08 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | This way asserting that updated_at was changed in touch look more obvious. | Dmitriy Kiriyenko | 2011-06-07 | 1 | -0/+1 | |
| | | | | ||||||
* | | | | Do not use default_scope in ActiveRecord::Persistence#touch. | Dmitriy Kiriyenko | 2011-06-07 | 1 | -0/+9 | |
| | | | | ||||||
* | | | | Fix a couple of helper requires that were missed. This was causing the tests ↵ | Jon Leighton | 2011-06-07 | 2 | -2/+2 | |
| | | | | | | | | | | | | | | | | to fail to run on 1.8.7. | |||||
* | | | | Merge pull request #1474 from ganeshkumar/update_column_changes | José Valim | 2011-06-07 | 1 | -0/+9 | |
|\ \ \ \ | | | | | | | | | | | added tests for update_column | |||||
| * | | | | added more tests for update_column | ganesh | 2011-06-04 | 1 | -0/+9 | |
| |/ / / | ||||||
* | | | | set the environment variable from the rake file | Aaron Patterson | 2011-06-06 | 17 | -17/+0 | |
| | | | | ||||||
* | | | | more oracle fixes | Aaron Patterson | 2011-06-06 | 1 | -1/+1 | |
| | | | |