aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #32727 from utilum/assert_dont_expectsRafael França2018-04-277-147/+248
|\ | | | | Use MethodCallAssertions instead of mocha expects
| * assert_called_withutilum2018-04-264-85/+170
| |
| * assert_calledutilum2018-04-264-28/+31
| |
| * assert_not_calledutilum2018-04-263-34/+47
| |
* | Ensure that `ids_reader` respects dirty target whether target is loaded or notRyuta Kamizono2018-04-271-2/+2
| | | | | | | | | | | | | | Currently `ids_reader` doesn't respect dirty target when the target is not loaded yet unlike `collection.size`. I believe the inconsistency is a bug, fixes the `ids_reader` to behave consistently regardless of whether target is loaded or not.
* | Merge pull request #32617 from tgturner/size-should-use-available-associationRyuta Kamizono2018-04-271-0/+74
|\ \ | | | | | | Loaded associations should not run a new query when size is called
| * | Loaded associations should not run a new query when size is calledGraham Turner2018-04-261-0/+74
| |/ | | | | | | | | | | | | Already loaded associations were running an extra query when `size` was called on the association. This fix ensures that an extra query is no longer run. Update tests to use proper methods
* / Add test case that assigning belongs_to on destroyed object raises frozen errorRyuta Kamizono2018-04-271-0/+7
|/ | | | | This is to ensure that the behavior has not changed before and after #31575.
* `get_value` needs to be a public methodGraham Turner2018-04-252-0/+10
| | | | | | Adds test case for failing issue Moves set_value back to protected
* Address `NameError: uninitialized constant Arel::Collectors::Bind`Yasuo Honda2018-04-251-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when tested with Ruby 2.5 or higher ```ruby $ ruby -v ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux] $ bundle exec ruby -w -Itest test/cases/arel/collectors/bind_test.rb -n test_compile_gathers_all_bind_params Run options: -n test_compile_gathers_all_bind_params --seed 24420 E Error: Arel::Collectors::TestBind#test_compile_gathers_all_bind_params: NameError: uninitialized constant Arel::Collectors::Bind Did you mean? Binding test/cases/arel/collectors/bind_test.rb:15:in `collect' test/cases/arel/collectors/bind_test.rb:19:in `compile' test/cases/arel/collectors/bind_test.rb:31:in `test_compile_gathers_all_bind_params' bin/rails test test/cases/arel/collectors/bind_test.rb:30 Finished in 0.002343s, 426.8559 runs/s, 0.0000 assertions/s. 1 runs, 0 assertions, 0 failures, 1 errors, 0 skips $ ``` It is likely due to Ruby 2.5 does not look up top level constant. https://www.ruby-lang.org/en/news/2017/12/25/ruby-2-5-0-released/ "Top-level constant look-up is no longer available."
* Merge pull request #32097 from matthewd/arelMatthew Draper2018-04-2560-0/+6767
|\ | | | | Merge Arel
| * Arel: rubocop -aMatthew Draper2018-02-2460-1218/+1263
| |
| * Merge Arel into Active RecordMatthew Draper2018-02-2460-0/+6722
| |
* | Using existing models for building multiple has_one through testsRyuta Kamizono2018-04-227-54/+15
| | | | | | | | Follow up of #32514.
* | Merge pull request #32514 from ↵Ryuta Kamizono2018-04-226-0/+59
|\ \ | | | | | | | | | | | | samdec/multiple-has-one-through-associations-build-bug Fix .new with multiple through associations
| * | Fix .new with multiple through associationsSam DeCesare2018-04-096-0/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a bug with building an object that has multiple `has_many :through` associations through the same object. Previously, when building the object via .new, the intermediate object would be created instead of just being built. Here's an example: Given a GameBoard, that has_one Owner and Collection through Game. The following line would cause a game object to be created in the database. GameBoard.new(owner: some_owner, collection: some_collection) Whereas, if passing only one of those associations into `.new` would cause the Game object to be built and not created in the database. Now the above code will only build the Game object, and not save it.
* | | Add test case for `collection.size` with dirty targetRyuta Kamizono2018-04-211-0/+10
| | |
* | | Merge pull request #32674 from composerinteralia/relax-assertionRyuta Kamizono2018-04-211-2/+2
|\ \ \ | | | | | | | | Relax assertions in connection config tests
| * | | Relax assertions in connection config testsDaniel Colson2018-04-201-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At the moment these two ActiveRecord tests pass with `rake test:sqlite3`, but fail with `ARCONN=sqlite3 bin/test`. `Rails.root` is defined when running `bin/test`, but not when running the rake task. When `Rails.root` is defined, `config[:database]` will look something like `vagrant/rails/activerecord/db/primary.sqlite3` instead of just `db/primary.sqlite3`. (See https://github.com/rails/rails/blob/00caf95e14b90782ab17fbd6d2b930844df99980/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L27) Relaxing `assert_equal` to `assert_match` will allow these tests to pass regardless of how they are run. I do have a question why we need both ways to run tests. I have been using `bin/test` lately, but I see from #32426 that this is not the preferred method.
* | | | Can preload associations through polymorphic associationsDana Sherson2018-04-202-0/+32
| | | |
* | | | Merge pull request #31513 from fatkodima/relation-touch_allRafael França2018-04-201-1/+46
|\ \ \ \ | |/ / / |/| | | Add `touch_all` method to `ActiveRecord::Relation`
| * | | Add `touch_all` method to `ActiveRecord::Relation`fatkodima2018-04-131-1/+46
| | | |
* | | | Use assert_no_match for test_order_to_unscope_reorderingYasuo Honda2018-04-201-1/+1
| | | |
* | | | Merge pull request #32645 from maneframe/skip_query_cache_mergeRafael Mendonça França2018-04-191-0/+4
|\ \ \ \ | | | | | | | | | | | | | | | Fix relation merging with skip_query_cache!
| * | | | Fix relation merging with skip_query_cache!James Williams2018-04-191-0/+4
| |/ / /
* / / / Replace `assert !` with `assert_not`Daniel Colson2018-04-1935-144/+144
|/ / / | | | | | | | | | | | | This autocorrects the violations after adding a custom cop in 3305c78dcd.
* | | don't check for immutability when setting skip_preloading as it doesn't ↵Lachlan Sylvester2018-04-122-1/+9
| | | | | | | | | | | | effect the arel and the arel may already be generated by fresh_when
* | | Prevent changes_to_save from mutating attributesEugene Kenny2018-04-081-0/+8
|/ / | | | | | | | | | | | | | | | | | | | | | | When an array of hashes is added to a `HashWithIndifferentAccess`, the hashes are replaced with HWIAs by mutating the array in place. If an attribute's value is an array of hashes, `changes_to_save` will convert it to an array of HWIAs as a side-effect of adding it to the changes hash. Using `merge!` instead of `[]=` fixes the problem, as `merge!` copies any array values in the provided hash instead of mutating them.
* | Make Mocha setup explcitly Minitest-specificJames Mead2018-04-071-1/+1
| | | | | | | | | | This has been possible since Mocha v1.0 and makes it clear that we want Mocha to integrate with Minitest, not Test::Unit.
* | Merge pull request #32355 from kamipo/delegate_to_klass_in_a_scopeRafael França2018-04-062-0/+15
|\ \ | | | | | | Bring back private class methods accessibility in named scope
| * | Deprecate accessibility of private/protected class methods in named scopeRyuta Kamizono2018-03-302-2/+10
| | |
| * | Bring back private class methods accessibility in named scopeRyuta Kamizono2018-03-271-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The receiver in a scope was changed from `klass` to `relation` itself for all scopes (named scope, default_scope, and association scope) behaves consistently. In addition. Before 5.2, if both an AR model class and a Relation instance have same named methods (e.g. `arel_attribute`, `predicate_builder`, etc), named scope doesn't respect relation instance information. For example: ```ruby class Post < ActiveRecord::Base has_many :comments1, class_name: "RecentComment1" has_many :comments2, class_name: "RecentComment2" end class RecentComment1 < ActiveRecord::Base self.table_name = "comments" default_scope { where(arel_attribute(:created_at).gteq(2.weeks.ago)) } end class RecentComment2 < ActiveRecord::Base self.table_name = "comments" default_scope { recent_updated } scope :recent_updated, -> { where(arel_attribute(:updated_at).gteq(2.weeks.ago)) } end ``` If eager loading `Post.eager_load(:comments1, :comments2).to_a`, `:comments1` (default_scope) respects aliased table name, but `:comments2` (using named scope) may not work correctly since named scope doesn't respect relation instance information. See also 801ccab. But this is a breaking change between releases without deprecation. I decided to bring back private class methods accessibility in named scope. Fixes #31740. Fixes #32331.
* | | Merge pull request #32441 from composerinteralia/refute-notRafael França2018-04-049-16/+16
|\ \ \ | | | | | | | | Add custom RuboCop for `assert_not` over `refute`
| * | | Autocorrect `refute` RuboCop violationsDaniel Colson2018-04-039-16/+16
| | | | | | | | | | | | | | | | | | | | | | | | 73e7aab behaved as expected on codeship, failing the build with exactly these RuboCop violations. Hopefully `rubocop -a` will have been enough to get a passing build!
* | | | Merge pull request #32414 from bogdan/query-cache-optimizationRafael França2018-04-041-1/+2
|\ \ \ \ | | | | | | | | | | Optimize the code inside AR::QueryCache middleware
| * | | | Optimize the code inside AR::QueryCache middlewareBogdan Gusiev2018-04-041-1/+2
| | | | |
* | | | | Add AR::Base.base_class? predicateBogdan Gusiev2018-04-022-1/+10
| |/ / / |/| | |
* | | | Remove leftover blank sqlite3 file after in memory handler tests.utilum2018-04-011-0/+2
| | | |
* | | | Fix two-level database configurations with URLsEugene Kenny2018-03-311-10/+52
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | An entry in `ActiveRecord::Base.configurations` can either be a connection spec ("two-level") or a hash of specs ("three-level"). We were detecting two-level configurations by looking for the `database` key, but the database can also be specified as part of the `url` key, which meant we incorrectly treated those configurations as three-level.
* | | Fix intermittent CI failure due to setting explicit `person.id = 10`Ryuta Kamizono2018-03-301-4/+0
| | | | | | | | | | | | https://travis-ci.org/rails/rails/jobs/360109429
* | | Merge pull request #32338 from eugeneius/dont_clobber_foreign_keyRyuta Kamizono2018-03-301-0/+2
|\ \ \ | | | | | | | | Don't unset foreign key when preloading missing record
| * | | Don't unset foreign key when preloading missing recordEugene Kenny2018-03-241-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a belongs to association's target is set, its foreign key is now updated to match the new target. This is the correct behaviour when a new record is assigned, but not when the existing record is preloaded. As long as we mark the association as loaded, we can skip setting the target when the record is missing and avoid clobbering the foreign key.
* | | | Merge pull request #30956 from CJStadler/with-lock-changed-deprecationRafael França2018-03-283-0/+23
| | | | | | | | | | | | | | | | Fix deprecation warnings from with_lock
* | | | Merge pull request #32299 from davidstosik/expose-fk-ignore-patternGuillermo Iguaran2018-03-271-0/+11
|\ \ \ \ | |_|/ / |/| | | Expose foreign key name ignore pattern in configuration
| * | | Move fk_ignore_pattern from config.active_record to SchemaDumperDavid Stosik2018-03-221-1/+4
| | | | | | | | | | | | | | | | | | | | This makes more sense, as the foreign key ignore pattern is only used by the schema dumper.
| * | | Test config.active_record.fk_ignore_patternDavid Stosik2018-03-201-0/+8
| | | |
* | | | Merge pull request #32274 from eileencodes/part-1-add-rake-tasks-for-multi-dbEileen M. Uchitelle2018-03-261-1/+128
|\ \ \ \ | |_|/ / |/| | | Part 1 Easy Multi db in Rails: Add basic rake tasks for multi db setup
| * | | Add tests for new rake taskseileencodes2018-03-211-1/+128
| |/ /
* | | Merge pull request #32306 from danhuynhdev/feature/store-accessor-prefixAndrew White2018-03-243-1/+26
|\ \ \ | | | | | | | | Add custom prefix to ActiveRecord::Store accessors
| * | | Add custom prefix to ActiveRecord::Store accessorsTan Huynh2018-03-233-1/+26
| | | | | | | | | | | | | | | | | | | | | | | | Add a prefix option to ActiveRecord::Store.store_accessor and ActiveRecord::Store.store. This option allows stores to have identical keys with different accessors.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-17 17:23:02 +0000