aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #14532 from thedarkone/polymorphic-preload-fixAaron Patterson2014-03-311-4/+15
|\ | | | | Fix polymorphic preloads on NOT NULL _type columns
| * Simplify Preloader#grouped_records code.thedarkone2014-03-301-4/+4
| | | | | | | | | | | | The new method relies on AR::Associations::Association knowing about both reflection and a model class. AR::Base#association now raises a descriptive error when trying to access non-existent associations. Previously it would blow up with a confusing NoMethodError: undefined method `association_class' for nil:NilClass.
| * Fix polymorphic preloads on NOT NULL _type columns.thedarkone2014-03-301-0/+11
| | | | | | | | Defer to Association#klass instead of having a custom/duplicate code.
* | fix bug on non empty defaults for pg array columnsLuke Steensen2014-03-301-0/+11
|/ | | | fixes #10613
* Refactor test to use DdlHelper.Guo Xiang Tan2014-03-292-167/+198
| | | | | | | Follow-Up to https://github.com/rails/rails/pull/14400 This ensures that all tables are removed after each test and thereby allowing us to run the tests in a random order.
* Merge pull request #14524 from tgxworld/fix_unsubscribe_from_notificationsYves Senn2014-03-294-12/+12
|\ | | | | | | Fix tests not unsubscribing from Notifications.
| * Fix tests not unsubscribing from Notifications.Guo Xiang Tan2014-03-284-8/+8
| | | | | | | | See https://github.com/rails/rails/blob/master/activesupport/lib/active_support/notifications.rb#L131
* | Ensure we are returning either `true` or `false` for `#==`Godfrey Chan2014-03-291-6/+7
|/ | | | | | 460eb83d cused `ActiveRecord::Base#==` to sometimes return `nil` in some cases, this ensures we always return a boolean value. Also fixed a similar problem in AR reflections.
* PostgreSQL, use `PostgreSQLColumn` in PG specific tests.Yves Senn2014-03-281-8/+8
|
* PostgreSQL, test-cases to lock down column default values.Yves Senn2014-03-283-0/+33
|
* PostgreSQL, test cases to lock the current column types.Yves Senn2014-03-288-15/+68
|
* Merge pull request #14154 from al2o3cr/issue12770Aaron Patterson2014-03-272-0/+10
|\ | | | | Pass a base relation to build_default_scope when joining
| * Pass a base relation to build_default_scope when joiningMatt Jones2014-02-212-0/+10
| | | | | | | | | | This allows the default scope to be built using the current table alias. Resolves #12770
* | Merge pull request #14469 from tiegz/timestamp_inheritance_fixRafael Mendonça França2014-03-271-0/+18
| | | | | | | | Swap Timestamp/Callbacks order in ActiveRecord::Base
* | AR .persisted? throws SystemStackError for an unsaved model with achrisfinne2014-03-272-0/+8
| | | | | | | | custom primary_key that didn't save due to validation error
* | ActiveRecord/ActiveModel '#validate' alias for 'valid?'Henrik Nyh2014-03-271-0/+15
| | | | | | | | | | | | | | | | It's unintuitive to call '#valid?' when you want to run validations but don't care about the return value. The alias in ActiveRecord isn't strictly necessary (the ActiveModel alias is still in effect), but it clarifies.
* | require dependency to execute a single test from xml_serialization_testYves Senn2014-03-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the tests are executed in order, the dependency is loaded at the right time. However this makes it impossible to execute a single test later down the line. Let's require the dependecy at the beginning to get them working independent of the order. This resolves the following error: ``` $ ARCONN=postgresql ruby -Itest /Users/senny/Projects/rails/activerecord/test/cases/xml_serialization_test.rb -n test_to_xml Using postgresql Run options: -n test_to_xml --seed 51819 E Finished in 0.081320s, 12.2971 runs/s, 0.0000 assertions/s. 1) Error: DatabaseConnectedXmlSerializationTest#test_to_xml: NameError: uninitialized constant DatabaseConnectedXmlSerializationTest::REXML /Users/senny/Projects/rails/activerecord/test/cases/xml_serialization_test.rb:226:in `test_to_xml' ``` /cc @tgxworld fyi
* | only run citext_test if the connection supports_extensions?.Yves Senn2014-03-271-52/+54
| | | | | | | | This will keep the test suite passing with older PG installations.
* | Add a test case for save(validate:false) with invalid foreign key.Lauro Caetano2014-03-271-1/+15
| | | | | | | | | | It is supposed to raise ActiveRecord::InvalidForeignKey when the database has a fk constraint.
* | No need to use begin/end blocksRafael Mendonça França2014-03-262-16/+16
| |
* | No need to gsub the stringRafael Mendonça França2014-03-262-2/+2
| |
* | Fixes bugs for using indexes in CREATE TABLE by adding checks for table ↵Steve Rice2014-03-252-4/+8
| | | | | | | | | | | | | | | | existence Also: - updates tests by stubbing table_exists? method - adds entry for creating indexes in CREATE TABLE to changelog
* | create indexes inline in CREATE TABLE for MySQLCody Cutrer2014-03-252-0/+22
| | | | | | | | | | | | | | | | This is important, because adding an index on a temporary table after it has been created would commit the transaction Conflicts: activerecord/CHANGELOG.md
* | Use rails convetionsRafael Mendonça França2014-03-251-2/+2
| |
* | Merge pull request #14390 from huoxito/true-touchRafael Mendonça França2014-03-251-0/+11
|\ \ | | | | | | | | | Still touch associations when theres no timestamp
| * | Still touch associations when theres no timestampWashington Luiz2014-03-141-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | Prior to Rails 4.0.4 when touching a object which doesn't have timestamp attributes (updated_at / updated_on) rails would still touch all associations. After 73ba2c14cd7d7dfb2d132b18c47ade995401736f it updates associations but rollsback because `touch` would return nil since there's no timestamp attribute
* | | Revert "Merge pull request #8313 from alan/only_save_changed_has_one_objects"Rafael Mendonça França2014-03-251-13/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 6e3ab3e15faf782f6a937ccf5574a4fb63e3e353, reversing changes made to 39e07b64ce3f4bb55e60ba0266e677f8e4f4893a. Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/autosave_association_test.rb
* | | do not rely on method_missing hitting arelAaron Patterson2014-03-241-2/+3
| | | | | | | | | | | | arel methods are not supposed to be public API for ActiveRecord
* | | use ARel factory methods for building AST nodesAaron Patterson2014-03-242-17/+17
| | | | | | | | | | | | This abstracts us from the actual construction of the nodes
* | | Clean up tables after each test.Guo Xiang Tan2014-03-222-92/+96
| | | | | | | | | | | | | | | | | | | | | Follow-Up to https://github.com/rails/rails/pull/14400 This ensures that all tables are removed after each test and thereby allowing us to run the tests in a random order.
* | | Extract with_example_table into helper method.Guo Xiang Tan2014-03-202-6/+13
| | | | | | | | | | | | This setups the helper method which other tests can benefit from.
* | | Merge pull request #12955 from joshwilliams/masterYves Senn2014-03-201-0/+45
|\ \ \ | | | | | | | | Postgres schema: Constrain sequence search classid
| * | | Postgres schema: Constrain sequence search classidJosh Williams2014-03-201-0/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The pk_an_sequence_for query previously joined against pg_class's oid for rows in pg_depend, but pg_depend's objid may point to other system tables, such as pg_attrdef. If a row in one of those other tables coincidentally has the same oid as an (unrelated) sequence, that sequence name may be returned instead of the real one. This ensures that only the pg_depend entries pointing to pg_class are considered.
* | | | Remove extra indirection for testing exceptions and messagesCarlos Antonio da Silva2014-03-201-28/+12
| | | | | | | | | | | | | | | | | | | | | | | | assert_raise + assert_equal on the returned exception message work just fine, there is no need for extra work, specially like this overly complicated helper.
* | | | ActiveRecord#touch should accept multiple attributes #14423Thiago Pinto2014-03-191-0/+12
|/ / /
* | | Add counter cache test for class_nameArthur Neves2014-03-171-0/+11
| | | | | | | | | | | | Backport test from #14410
* | | test should only pass if the pool.size+1 checkout failsAaron Patterson2014-03-171-3/+2
| | | | | | | | | | | | | | | Previously, any of the connection checkouts could have failed, and this test would pass.
* | | use a latch to avoid busy loopsAaron Patterson2014-03-171-3/+4
| | |
* | | Reap connections based on owning-thread deathMatthew Draper2014-03-183-22/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | .. not a general timeout. Now, if a thread checks out a connection then dies, we can immediately recover that connection and re-use it. This should alleviate the pool exhaustion discussed in #12867. More importantly, it entirely avoids the potential issues of the reaper attempting to check whether connections are still active: as long as the owning thread is alive, the connection is its business alone. As a no-op reap is now trivial (only entails checking a thread status per connection), we can also perform one in-line any time we decide to sleep for a connection.
* | | Teach PostgreSQLAdapter#reset! to actually resetMatthew Draper2014-03-181-0/+31
| | | | | | | | | | | | It wasn't doing anything beyond clearing the statement cache.
* | | `where.not` adds `references` for `includes`.Yves Senn2014-03-172-0/+18
| | | | | | | | | | | | Closes #14406.
* | | Extend fixture label replacement to allow string interpolationEric Steele2014-03-152-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allows fixtures to use their $LABEL as part of a string instead of limiting use to the entire value. mark: first_name: $LABEL username: $LABEL1973 email: $LABEL@$LABELmail.com users(:mark).first_name # => mark users(:mark).username # => mark1973 users(:mark).email # => mark@markmail.com
* | | Merge pull request #14380 from ↵Yves Senn2014-03-1549-61/+51
|\ \ \ | | | | | | | | | | | | | | | | tgxworld/use_teardown_helper_method_in_activerecord Use teardown helper method.
| * | | Use teardown helper method.Guo Xiang Tan2014-03-1449-61/+51
| |/ / | | | | | | | | | | | | | | | | | | | | | Follow-Up to https://github.com/rails/rails/pull/14348 Ensure that SQLCounter.clear_log is called after each test. This is a step to prevent side effects when running tests. This will allow us to run them in random order.
* | | Obey `validate: false` option for habtmCarlos Antonio da Silva2014-03-143-0/+38
| | | | | | | | | | | | Fixes #14383.
* | | Allow custom JDBC urlsschneems2014-03-141-0/+6
|/ / | | | | | | mitigates #14323
* | Merge pull request #14372 from arthurnn/fix_query_cache_bindsRafael Mendonça França2014-03-131-0/+8
|\ \ | | | | | | Make select_all on query cache accept a Relation without binds.
| * | Make select_all on query cache accept a Relation without binds.Arthur Neves2014-03-131-0/+8
| | | | | | | | | | | | | | | [fixes #14361] [related #13886]
* | | Add test for deprecation warning for passing an AR object to `find`.Lauro Caetano2014-03-131-0/+6
| | |
* | | Test deprecation warning for passing an ActiveRecord object toLauro Caetano2014-03-131-0/+6
|/ / | | | | | | `exists?`
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-28 16:05:26 +0000