| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
Closes #13444
|
| | |
|
| |\
| |
| | |
quoting: Check if id is a valid method before using it
|
| | |
| |
| |
| |
| | |
Need to check if valud also respond_to :id before calling it, otherwise
things could explode.
|
| |/ |
|
| |
|
|
| |
[ci skip]
|
| |\
| |
| | |
modified regex for finding table_name from a multiline sql query in postgresql
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously, executing an insert SQL in PostgreSQL with a command like this:
insert into articles(
number)
values(
5152
)
would not work because the adapter was unable to extract the correct articles table name.
|
| | |
| |
| |
| |
| |
| | |
Change most tests to make use of assert_raise returning the raised
exception rather than relying on a combination of flunk + rescue to
check for exception types/messages.
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Fix PostgreSQL range tests on fresh DB
Correcting the name of the table we're creating is self-explanatory.
But we must also move away from the low IDs, because we're not touching the freshly-created primary key sequence; when the time comes, @new_range will be assigned an ID of 1.
|
| | | |
| | |
| | |
| | | |
The changes in c4044b2 meant the tests would error on a fresh DB.
|
| | | | |
|
| |\ \ \
| |/ /
|/| | |
Change all `MiniTest` to `Minitest`
|
| | |/
| |
| |
| |
| |
| | |
renamed to `Minitest`
Ref: https://github.com/seattlerb/minitest/blob/master/History.txt
|
| |/ |
|
| |
|
|
| |
nullifying its _type column
|
| |\
| |
| |
| |
| |
| |
| | |
Create a blacklist to disallow mutator methods to be delegated to Array
Conflicts:
guides/source/upgrading_ruby_on_rails.md
|
| | |
| |
| |
| |
| |
| |
| |
| | |
This change was necessary because the whitelist wouldn't work.
It would be painful for users trying to update their applications.
This blacklist intent to prevent odd bugs and confusion in code that call mutator
methods directely on the `Relation`.
|
| |\ \
| |/
|/|
| |
| |
| |
| | |
Default I18n.enforce_available_locales to true
We will default this option to true from now on to ensure users properly handle their list of available locales whenever necessary. This option was added as a security measure and thus Rails will follow it defaulting to secure option.
Also improve the handling of I18n config options in its railtie, taking the new enforce_available_locales option into account, by setting it as the last one in the process. This ensures no other configuration will trigger a deprecation warning due to that setting.
|
| | | |
|
| |\ \
| |/
|/| |
test case for #limit added - picking latest value from limit
|
| | | |
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using the name of an association in `where` previously worked only
if the value was a single `ActiveRecrd::Base` object. e.g.
Post.where(author: Author.first)
Any other values, including `nil`, would cause invalid SQL to be
generated. This change supports arguments in the `where` query
conditions where the key is a `belongs_to` association name and the
value is `nil`, an `Array` of `ActiveRecord::Base` objects, or an
`ActiveRecord::Relation` object.
# Given the Post model
class Post < ActiveRecord::Base
belongs_to :author
end
# nil value finds records where the association is not set
Post.where(author: nil)
# SELECT "posts".* FROM "posts" WHERE "posts"."author_id" IS NULL
# Array values find records where the association foreign key
# matches the ids of the passed ActiveRecord models, resulting
# in the same query as Post.where(author_id: [1,2])
authors_array = [Author.find(1), Author.find(2)]
Post.where(author: authors_array)
# ActiveRecord::Relation values find records using the same
# query as Post.where(author_id: Author.where(last_name: "Emde"))
Post.where(author: Author.where(last_name: "Emde"))
Polymorphic `belongs_to` associations will continue to be handled
appropriately, with the polymorphic `association_type` field added
to the query to match the base class of the value. This feature
previously only worked when the value was a single `ActveRecord::Base`.
class Post < ActiveRecord::Base
belongs_to :author, polymorphic: true
end
Post.where(author: Author.where(last_name: "Emde"))
# Generates a query similar to:
Post.where(author_id: Author.where(last_name: "Emde"), author_type: "Author")
|
| |
|
|
|
| |
also override drop_table in AbstractMySQLAdapter to properly drop
temporary tables without committing the transaction
|
| |\
| |
| | |
Fix mysql to support duplicated column names
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This will fix the [broken
test](https://github.com/rails/rails/commit/4a2650836680f51490e999c3c8441a2f9adff96e)
`test_with_limiting_with_custom_select`.
The query's result was built in a hash with column name as key, if the
result have a duplicated column name the last value was
overriding the first one.
|
| | | |
|
| |/ |
|
| |
|
|
| |
won't last - aim to switch back to a blacklist for mutator methods.
|
| | |
|
| | |
|
| |
|
|
|
| |
This test was removed, since Relation will not delegate class
methods to Array.
|
| | |
|
| |
|
|
|
| |
We can now make use of the existent #travel/#travel_to helper methods
added to AS test case and available in all tests.
|
| |\
| |
| |
| |
| | |
laurocaetano/fix_dynamic_finder_with_reserved_words
Prevent invalid code when using dynamic finders with reserved ruby word.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The dynamic finder was creating the method signature with the parameters name,
which may have reserved words and this way creating invalid Ruby code.
Closes: #13261
Example:
# Before
Dog.find_by_alias('dog name')
# Was creating this method
def self.find_by_alias(alias, options = {})
# After
Dog.find_by_alias('dog name')
# Will create this method
def self.find_by_alias(_alias, options = {})
|
| | |
| |
| |
| | |
This is to get activerecord-deprecated_finders work again
|
| |/
|
|
|
|
|
| |
It is needed for activerecord-depecated_finders
This reverts commit dcff027a5242b20c0c90eb062dddb22ccf51aed9, reversing
changes made to 3a2093984ff49d86db1efeff0c7581e788ecfb9f.
|
| |\
| |
| | |
Fix type cast on group sum with custom expression
|
| | |
| |
| |
| |
| |
| |
| |
| | |
For PG adapters with custom expression and grouped result
of aggregate functions have not found correct column type
for it. Extract column type from query result.
Closes: #13230
|
| | | |
|
| |\ \
| | |
| | | |
Support MySQL 5.7 explain
|
| | |/ |
|
| |/
|
|
| |
Since MySQL 5.7.3 m13 does now allow primary key column is null.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
Example: Given you have a comments model with a polymorphic commentable
association (e.g. books and songs) with the touch option set.
Every time you update a comment its commentable should be touched.
This was working when you changed attributes on the comment or when you
moved the comment from one book to another. However, it was not working
when moving a comment from a book to a song. This is now fixed.
|
| |\
| |
| |
| |
| |
| |
| | |
Fix AR#method_missing re-dispatching into overwritten attribute methods
Conflicts:
activerecord/lib/active_record/attribute_methods.rb
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This was happening when a `super` call in an overwritten attribute method
was triggering a method_missing fallback, because attribute methods
haven't been generated yet.
class Topic < ActiveRecord::Base
def title
# `super` would re-invoke this method if define_attribute_methods
# hasn't been called yet resulting in double '!' appending
super + '!'
end
end
|
| | |
| |
| |
| | |
Closes #7441
|
