aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* move AR length validation tests into separate test-case.Yves Senn2014-04-242-42/+48
| | | | | Conflicts: activerecord/test/cases/validations/association_validation_test.rb
* No need for trailing slash on migration path.Jeremy Kemper2014-04-241-1/+1
| | | | | | | Causes a double // in Dir.glob that breaks Ruby 2.2-trunk. Not really a bug, but not relevant to this test either. Originally added in ed21f0c50270139ddb6993acfdaea4586ffd09a3
* `ActiveRecord::Base.no_touching` no longer triggers callbacks or start empty ↵Lucas Mazza2014-04-231-1/+20
| | | | | | transactions. Closes #14841.
* Perfer to define methods instead of calling testRafael Mendonça França2014-04-221-4/+4
| | | | This file is using this pattern already
* Fix syntax errorRafael Mendonça França2014-04-221-0/+1
|
* Merge pull request #14757 from estsauver/14752Rafael Mendonça França2014-04-221-1/+6
|\ | | | | Fix behavior of select! to be consistent with select #14752
| * select! renamed to avoid name collision Array#select!Earl J St Sauver2014-04-211-1/+6
| | | | | | | | | | | | | | | | Fixes #14752 Select mimics the block interface of arrays, but does not mock the block interface for select!. This change moves the api to be a private method, _select!.
* | Merge pull request #14573 from habermann24/has_many_through_fixRafael Mendonça França2014-04-223-0/+17
|\ \ | | | | | | | | | | | | | | | | | | | | | Properly handle scoping with has_many :through. Fixes #14537. Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/associations/has_many_through_associations_test.rb
| * | Properly handle scoping with has_many :through. Fixes #14537.Jan Habermann2014-04-033-0/+18
| | |
* | | Rearrange deck chairs on the titanic. Organize connection handling test cases.Jeremy Kemper2014-04-214-249/+246
| | |
* | | `@destroyed` should always be set to `false` when an object is duped.Kuldeep Aggarwal2014-04-191-0/+16
| | |
* | | remove warningKuldeep Aggarwal2014-04-181-1/+1
| | | | | | | | | | | | `warning: ambiguous first argument; put parentheses or even spaces`
* | | Regression test for irregular inflection on has_manyArthur Neves2014-04-181-0/+8
| | | | | | | | | | | | | | | | | | | | | Also add a Changelog entry [related #9702] [fixes #8928]
* | | Merge pull request #14773 from eric-chahin/null_relation_fixYves Senn2014-04-161-0/+11
|\ \ \ | | | | | | | | Changed the NullRelation so that when count is called with #group it wil...
| * | | Changed the NullRelation so that when count is called with #group it will ↵Eric Chahin2014-04-161-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | properly return an empty hash instead of zero. Fixes issue #14721 Conflicts: activerecord/CHANGELOG.md
* | | | `sanitize_sql_like` escapes `escape_character` not only backslash.Yves Senn2014-04-161-4/+5
|/ / / | | | | | | | | | | | | | | | * This is a follow up to: fe4b0eee05f59831e1468ed50f55fbad0ce11e1d * The originating PR is #14222 * It should fix the build
* | | SQL Like escaping helper method. [Rob Gilson & Yves Senn]Rob Gilson2014-04-161-0/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #14222. This is a follow up to #6104 This does not have the backwards compatibility issues brought up in implementation to break.
* | | Changed change_column in PG schema_statements.rb to make sure that the ↵Eric Chahin2014-04-151-0/+13
| | | | | | | | | | | | uuid_generate function was not being quoted.
* | | The Association Relation should use `empty?` and `size` from Relation.Lauro Caetano2014-04-141-0/+11
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 968c581ea34b5236af14805e6a77913b1cb36238 have introduced this bug #14744 on Association Relation when the method `empty?` or `size` was called. Example: # Given an author that does have 3 posts, but none of them with the # title 'Some Title' Author.last.posts.where(title: 'Some Title').size # => 3 It was occurring, because the Association Relation had implemented these methods based on `@association`, this way giving wrong results. To fix it, was necessary to remove the methods `empty?` and `size` from Association Relation. It just have to use these methods from Relation. Example: # Given an author that does have 3 posts, but none of them with the # title 'Some Title' Author.last.posts.where(title: 'Some Title').size # => 0 # Now it will return the correct value. Fixes #14744.
* | Remove outdated commentRafael Mendonça França2014-04-141-1/+0
| |
* | Merge pull request #14735 from byroot/idempotent-counter-cachesAaron Patterson2014-04-141-0/+21
|\ \ | | | | | | Idempotent counter caches, fix concurrency issues with counter caches
| * | Write the failing test case for concurrent counter cacheJean Boussier2014-04-131-0/+21
| | |
* | | Just call read_attribute, no need to use `send`.Lauro Caetano2014-04-142-7/+7
|/ / | | | | | | Follow up to af549a1ad6692d7e2c756750651f0e1b293f5185
* | Ensure that the comparison between 'CollectionProxy' and ↵Lauro Caetano2014-04-121-0/+9
| | | | | | | | 'AssociationRelation' is consistent.
* | Make the comparison between 'Relation' and 'AssociationRelation'Lauro Caetano2014-04-121-0/+9
| | | | | | | | consistent.
* | The comparison between `Relation` and `CollectionProxy` should be consistent.Lauro Caetano2014-04-111-0/+17
| | | | | | | | | | | | | | | | | | | | | | Example: author.posts == Post.where(author_id: author.id) # => true Post.where(author_id: author.id) == author.posts # => true Fixes #13506
* | Use assert_notRafael Mendonça França2014-04-111-1/+1
| |
* | :scissors:Rafael Mendonça França2014-04-112-5/+5
| |
* | Merge pull request #14711 from ↵Rafael Mendonça França2014-04-112-0/+18
|\ \ | | | | | | | | | | | | | | | swoker/activerecord_fix_aggregate_methods_with_select Activerecord fix aggregate methods with select
| * | fix exception on polymorphic associations with predicatesSimon Woker2014-04-111-0/+8
| | |
| * | Fix error for aggregate methods with select, see issue #13648Simon Woker2014-04-101-0/+10
| | |
* | | PostgreSQL, warn once per connection per missing OID. Closes #14275.Yves Senn2014-04-111-0/+11
| | | | | | | | | | | | [Yves Senn & Matthew Draper]
* | | PostgreSQL, adapter automatically reloads it's type map. Closes #14678.Yves Senn2014-04-114-6/+28
| | | | | | | | | | | | [Yves Senn & Matthew Draper]
* | | Merge pull request #12829 from iantropov/issue_insert_via_hmt_scope_3548Rafael Mendonça França2014-04-103-1/+19
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fix insertion of records for hmt association with scope Conflicts: activerecord/CHANGELOG.md
| * | | Fix insertion of records for hmt association with scope, fix #3548Ivan Antropov2013-11-173-1/+19
| | | |
* | | | Remove warning of unused variableRafael Mendonça França2014-04-101-1/+1
| | | |
* | | | Merge branch 'master' into rm-uuid-fixturesRafael Mendonça França2014-04-1015-35/+178
|\ \ \ \ | | |/ / | |/| | | | | | | | | | | | | | Conflicts: activerecord/CHANGELOG.md activesupport/CHANGELOG.md
| * | | Make sure the reflection test is passing a String to the reflectionLauro Caetano2014-04-091-1/+1
| | | | | | | | | | | | | | | | cache.
| * | | The `source` option for `has_many => through` should accept StringLauro Caetano2014-04-091-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | values. With the changes introduced by 16b70fddd4dc7e7fb7be108add88bae6e3c2509b it was expecting the value to be a Symbol, while it could be also a String value.
| * | | Drop in @jeremy's new database.yml template textMatthew Draper2014-04-091-0/+8
| | | | | | | | | | | | | | | | | | | | In passing, allow multi-word adapters to be referenced in a URL: underscored_name must become hyphened-name.
| * | | Don't deprecate after allMatthew Draper2014-04-091-11/+9
| | | |
| * | | Less ambition, more deprecationMatthew Draper2014-04-091-59/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The "DATABASE_URL_*" idea was moving in the wrong direction. Instead, let's deprecate the situation where we end up using ENV['DATABASE_URL'] at all: the Right Way is to explicitly include it in database.yml with ERB.
| * | | Ensure we correctly and immediately load all ENV entriesMatthew Draper2014-04-081-0/+21
| | | | | | | | | | | | | | | | .. even when the supplied config made no hint that name was relevant.
| * | | Give a deprecation message even when the lookup failsMatthew Draper2014-04-081-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the supplied string doesn't contain a colon, it clearly cannot be a database URL. They must have intended to do a key lookup, so even though it failed, give the explanatory deprecation warning, and raise the exception that lists the known configs. Conveniently, this also simplifies our logical behaviour: if the string matches a known configuration, or doesn't contain a colon (and is therefore clearly not a URL), then we output a deprecation warning, and behave exactly as we would if it were a symbol.
| * | | Test DATABASE_URL has precendance over DATABASE_URL_#{environment}Rafael Mendonça França2014-04-081-0/+9
| | | |
| * | | Make sure DEFAULT_URL only override current environment databaseRafael Mendonça França2014-04-081-9/+29
| | | | | | | | | | | | | | | | configuration
| * | | Only apply DATABASE_URL for Rails.envMatthew Draper2014-04-081-17/+26
| | | | | | | | | | | | | | | | | | | | As we like ENV vars, also support DATABASE_URL_#{env}, for more obscure use cases.
| * | | Follow up to bbe7fe41 to fix enum leakage across classes.Godfrey Chan2014-04-071-7/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The original attempt didn't really fix the problem and wasn't testing the problematic area. This commit corrected those issues in the original commit. Also removed the private `enum_mapping_for` method. As `defined_enums` is now a method, this method doesn't provide much value anymore.
| * | | Build the reverse_order on its proper method.Lauro Caetano2014-04-072-3/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The reverse_order method was using a flag to control if the order should be reversed or not. Instead of using this variable just build the reverse order inside its proper method. This implementation was leading to an unexpected behavior when using reverse_order and then applying reorder(nil). Example: Before Post.order(:name).reverse_order.reorder(nil) # => SELECT "posts".* FROM "posts" ORDER BY "posts"."id" DESC After Post.order(:name).reverse_order.reorder(nil) # => SELECT "posts".* FROM "posts"
| * | | Merge pull request #14632 from matthewd/escape_byteaRafael Mendonça França2014-04-071-0/+17
| |\ \ \ | | | | | | | | | | Use connection-specific bytea escaping
generated by cgit v1.2.3 (git 2.25.1) at 2024-08-16 21:18:06 +0000