| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
invalid column type
/activerecord/lib/active_record/connection_adapters
/abstract/schema_definitions.rb:306
type = type.to_sym
Changed to the following to handle nil case:
type = type.to_sym if type
Added regression test for this case:
/activerecord/test/cases/migration_test.rb:554
if current_adapter?(:SQLite3Adapter)
def test_allows_sqlite3_rollback_on_invalid_column_type
Person.connection.create_table :something, force: true do |t|
t.column :number, :integer
t.column :name, :string
t.column :foo, :bar
end
assert Person.connection.column_exists?(:something, :foo)
assert_nothing_raised { Person.connection.remove_column :something, :foo, :bar }
assert !Person.connection.column_exists?(:something, :foo)
assert Person.connection.column_exists?(:something, :name)
assert Person.connection.column_exists?(:something, :number)
ensure
Person.connection.drop_table :something, if_exists: true
end
end
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
Preserve readonly flag only for readonly association
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Fixes #24093
|
| | |/ / /
|/| | |
| | | |
| | | |
| | | | |
Because `sql_for_insert` is only called in `use_insert_returning?` is
true since #26002.
|
| |\ \ \ \
| | | | |
| | | | | |
`pluck` should use `records` (`load_target`) when `loaded?` is true
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Fix does_not_support_reverse? to find sql functions with commas in nested brackets
|
| | | |/ / /
| |/| | |
| | | | |
| | | | | |
brackets
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
kamipo/sql_for_insert_should_be_called_inside_exec_insert
`sql_for_insert` should be called inside `exec_insert`
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`exec_insert` cannot return last inserted id if `use_insert_returning?`
is true. `sql_for_insert` should be called inside `exec_insert`.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix inconsistent the signature of finder methods for collection association
|
| | | |_|_|/ /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`#second`, `#third`, etc finder methods was added in 03855e790de2224519f55382e3c32118be31eeff.
But the signature of these methods is inconsistent with the original
finder methods. And also the signature of `#first` and `#last` methods
is different from the original. This commit fixes the inconsistency.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
kamipo/finder_bang_method_should_call_non_bang_method
Finder bang method should call non bang method
|
| | |/ / / / /
| | | | | |
| | | | | |
| | | | | | |
Otherwise CollectionProxy's bang methdos cannot respect dirty target.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | | |
Fix count which would sometimes force a DISTINCT
|
| | |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current behaviour of checking if there is a LEFT OUTER JOIN arel
node to detect if we are doing eager_loading is wrong. This problem
wasn't frequent before as only some pretty specific cases would add
a LEFT OUTER JOIN arel node. However, the recent new feature
left_outer_joins also add this node and made this problem happen
frequently.
Since in the perform_calculation function, we don't have access to
eager_loading information, I had to extract the logic for the distinct
out to the calculate method.
As I was in the file for left_outer_join tests, I fixed a few that had
bugs and I replaced some that were really weak with something that
will catch more issues.
In relation tests, the first test I changed would have failed if it
had validated the hash returned by count instead of just checking how
many pairs were in it. This is because this merge of join currently
transforms the join node into an outer join node, which then made
count do a distinct. So before this change, the return was
{1=>1, 4=>1, 5=>1}.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
kamipo/dont_handle_as_associated_predicate_if_table_has_column
Do not handle as an associated predicate if a table has the column
|
| | |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
If handled as an associated predicate even though a table has the
column, will generate invalid SQL by valid column name treated as a
table name.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove internal `sanitize` method
|
| | | |_|/ / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | | |
Currently internal `sanitize`/`quote_value` method is only used for `quoted_id`.
Simply it is enough to use `connection.quote` public API instead.
|
| |\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Makes touch_later respects no_touching policy
|
| | | | | | | |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
`where` by `array|range` attribute with array or range value
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Currently predicate builder cannot build a predicate for `array|range`
attribute. This commit fixes the issue.
Related #25671.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
When calling association.find RecordNotFound is now raised with the s…
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
argument as when we do it in Record.find (primary_key, id and model).
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Avoid to allow unused splat args for `t.timestamps` in `create_table`
|
| | |/ / / / / / /
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Unfortunately `t.timestamps` in `create_table` allows unused splat args.
But the same one in `change_table` does not allow them.
This commit fixes the inconsistent behavior.
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
`CollectionProxy#take` should respect dirty target
|
| | |/ / / / / / /
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
`#first`, `#second`, ..., `#last` methods respects dirty target. But
`#take` doesn't respect it. This commit fixes the inconsistent behavior.
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Support multiple indexes on the same column when loading the schema
|
| | | |_|_|/ / / /
| |/| | | | | | |
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Style/SpaceBeforeBlockBraces
Style/SpaceInsideBlockBraces
Style/SpaceInsideHashLiteralBraces
Fix all violations in the repository.
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Consolidate `ActiveRecord::TestCase` and `ActiveSupport::TestCase` in AR test cases
|
| | | |/ / / / / /
| |/| | | | | |
| | | | | | | |
| | | | | | | | |
test cases
|
| |/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
Fixes #26122
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Use `ActiveRecord::TestCase` rather than `ActiveSupport::TestCase` in AR test cases
|
| | | |/ / / / /
| |/| | | | |
| | | | | | |
| | | | | | | |
test cases
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Creating a new Topic class instead of class_eval for the existing one
|
| | |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
since it affects another test `ReflectionTest#test_read_attribute_names`
Address #26099
|
| |/ / / / / / |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
If you call `remove_index` with wrong options, say a type, like I did,
you get:
```
== 20160810072541 RemoveUniqueIndexOnGoals: migrating =========================
-- remove_index(:goal, {:coulmn=>:kid_id, :unique=>true})
rails aborted!
StandardError: An error has occurred, this and all later migrations canceled:
undefined method `ArgumentError' for #<ActiveRecord::ConnectionAdapters::PostgreSQLAdapter:0x007fb7dec91b28>
```
What happened is that I mistyped column (coulmn) and got a
`NoMethodError`, because of a missing comma during the raise. This made
Ruby think we're calling the method `ArgumentError`.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
Hash syntax auto-correcting breaks alignments. 411ccbdab2608c62aabdb320d52cb02d446bb39c
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
also test `ROWNUM <=` for Oracle 11g or older version of Oracle and Oracle visitor
Oracle 12c database and Arel Oracle12 visitor supports better top N query.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
A few have been left for aesthetic reasons, but have made a pass
and removed most of them.
Note that if the method `foo` returns an array, `foo << 1`
is a regular push, nothing to do with assignments, so
no self required.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
Some case expressions remain, need to think about those ones.
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
