aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Ensure we don't write virtual attributes on update, tooSean Griffin2018-02-261-1/+4
| | | | | | | | | | | | See 948b931925febac3c965ab13470065ced68f7b53 for context
* | | Never attempt to write virtual attributes to the databaseSean Griffin2018-02-261-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently the place where we limit what gets sent to the database is in the implementation for `partial_writes`. We should also be restricting it to column names when partial writes are turned off. Note that we're using `&` instead of just defaulting to `self.class.column_names`, as the instance version of `attribute_names` does not include attributes which are uninitialized (were not included in the select clause)
* | | Fix "NameError: uninitialized constant Categorization::Category"yuuji.yaginuma2018-02-261-0/+1
| |/ |/| | | | | | | | | | | | | Since #31895, build of 2.5 and AR combination failed. https://travis-ci.org/rails/rails/jobs/346064349#L1638 It seems to be the reason that model is not loading properly, so I added require. But I'm not sure if this is correct
* | Merge pull request #31895 from ↵Ryuta Kamizono2018-02-265-0/+17
|\ \ | | | | | | | | | | | | kamipo/do_not_attempt_to_find_inverse_of_polymorphic Make `reflection.klass` raise if `polymorphic?` not to be misused
| * | Make `reflection.klass` raise if `polymorphic?` not to be misusedRyuta Kamizono2018-02-195-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an alternative of #31877 to fix #31876 caused by #28808. This issue was caused by a combination of several loose implementation. * finding automatic inverse association of polymorphic without context (caused by #28808) * returning `klass` even if `polymorphic?` (exists before #28808) * loose verification by `valid_inverse_reflection?` (exists before #28808) This makes `klass` raise if `polymorphic?` not to be misused. This issue will not happen unless polymorphic `klass` is misused. Fixes #31876. Closes #31877.
* | | Association creation and finding should work consistently (#32048)Ryuta Kamizono2018-02-261-5/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an alternative of #29722, and revert of #29601 and a1fcbd9. Currently, association creation and normal association finding doesn't respect `store_full_sti_class`. But eager loading and preloading respect the setting. This means that if set `store_full_sti_class = false` (`true` by default), eager loading and preloading can not find created polymorphic records. Association creation and finding should work consistently.
* | | More exercise range predicate builderRyuta Kamizono2018-02-231-0/+9
| | | | | | | | | | | | | | | * Add test case for open-ended range. * Add test case for numeric range for string column.
* | | PostgreSQL: Allow BC dates like datetime consistentlyRyuta Kamizono2018-02-231-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | BC dates are supported by both date and datetime types. https://www.postgresql.org/docs/current/static/datatype-datetime.html Since #1097, new datetime allows year zero as 1 BC, but new date does not. It should be allowed even in new date consistently.
* | | PostgreSQL: Treat infinite values in date like datetime consistentlyRyuta Kamizono2018-02-232-0/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The values infinity and -infinity are supported by both date and timestamp types. https://www.postgresql.org/docs/current/static/datatype-datetime.html#DATATYPE-DATETIME-SPECIAL-TABLE And also, it can not be known whether a value is infinity correctly unless cast a value. I've added `QueryAttribute#infinity?` to handle that case. Closes #27585.
* | | Revert "Merge pull request #32075 from eileencodes/delete-default-configuration"eileencodes2018-02-221-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 16f279ebd474626577ced858e3626ac4535a33df, reversing changes made to 6c6a30a7c357ce1eafa093d77d2b08684fe50887. The config can be named anything, not just default (although all generated apps will be named default). We can't just delete configs that don't have a database because that will break three-tier configs. Oh well.
* | | Properly escape column name embedded into regexpAndreas Bühmann2018-02-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | SQLServerAdapter (gem `activerecord-sqlserver-adapter`) uses square brackets for quoting column names (e.g. `[id]`). Those brackets must not be misinterpreted in regular expressions. Failure: Expected /SELECT [developers].[id].* FROM developers/ to match "SELECT [developers].[id], [developers].[name], [developers].[salary], [developers].[firm_id], [developers].[mentor_id], [developers].[created_at], [developers].[updated_at], [developers].[created_on], [developers].[updated_on] FROM developers".
* | | Add cop for preferring 'Foo.method' over 'Foo::method'Andrew White2018-02-221-1/+1
| | |
* | | Merge pull request #32075 from eileencodes/delete-default-configurationEileen M. Uchitelle2018-02-211-16/+0
|\ \ \ | | | | | | | | Delete default configuration
| * | | Delete default configurationeileencodes2018-02-211-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Because of this default configuration we're constantly checking if the database exists when looping through configurations. This is unnecessary and we should just delete it before we need to loop through configurations.
* | | | Use the query cache when connection is already connectedyuuji.yaginuma2018-02-191-0/+11
| |/ / |/| | | | | | | | Fixes #32021.
* | | Association scope's own order should be prioritized over through scope's orderRyuta Kamizono2018-02-182-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3acc5d6 was changed the order of scope evaluation from through scope to the association's own scope to be prioritized over the through scope. But the sorting order will be prioritized that is evaluated first. It is unintentional effect, association scope's sorting order should be prioritized as well. Fixes #32008.
* | | Clean up and consolidate .gitignoresbogdanvlviv2018-02-172-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Global ignores at toplevel .gitignore * Component-specific ignores in each toplevel directory * Remove `actionview/test/tmp/.keep` for JRuby ``` rm actionview/test/tmp/ -fr cd actionview/ bundle exec jruby -Itest test/template/digestor_test.rb ``` Related to #11743, #30392. Closes #29978.
* | | Deprecate update_attributes and update_attributes!Eddie Lebow2018-02-1713-60/+37
| | | | | | | | | | | | Closes #31998
* | | Add chop removed in 89bcca5Rafael Mendonça França2018-02-161-1/+1
| | |
* | | Remove usage of strip_heredoc in the framework in favor of <<~Rafael Mendonça França2018-02-164-45/+43
|/ / | | | | | | | | Some places we can't remove because Ruby still don't have a method equivalent to strip_heredoc to be called in an already existent string.
* | Add #create_or_find_by to lean on unique constraints (#31989)David Heinemeier Hansson2018-02-141-0/+29
| | | | | | Add #create_or_find_by to lean on unique constraints
* | Add test to make sure pick works in a NullRelationRafael Mendonça França2018-02-121-0/+2
| |
* | Merge pull request #31133 from ↵Matthew Draper2018-02-111-0/+15
|\ \ | | | | | | | | | | | | mohsen-alizadeh/sanitize_empty_and_nil_parameters_passed_to_select sanitize empty and nil parameters to select #31059
| * | add test case to relation selectMohsen Alizadeh2017-12-031-0/+15
| | |
* | | Add Relation#pick as short-hand for single-value plucks (#31941)David Heinemeier Hansson2018-02-091-0/+10
| | | | | | | | | * Add Relation#pick as short-hand for single-value plucks
* | | Merge pull request #31934 from fatkodima/fix-has_many_through-dumpingRyuta Kamizono2018-02-091-0/+5
|\ \ \ | | | | | | | | | | | | Fix marshaling of models with `has_many :through` associations
| * | | Fix marshaling of models with `has_many :through` associationsfatkodima2018-02-081-0/+6
| | | |
* | | | Fix `test_counter_cache_with_touch_and_lock_version` failurebogdanvlviv2018-02-071-1/+3
|/ / / | | | | | | | | | | | | | | | https://travis-ci.org/rails/rails/jobs/338338927#L1043 Related to daf15f58b943d85d8fb726590ae94f77ca0a5d5f
* | | Invoke `load_schema` in `_default_attributes`Ryuta Kamizono2018-02-061-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently `_default_attributes` doesn't work unless `load_schema` is called before. The `MissingAttributeError` is caused by `reload_schema_from_cache` is invoked by `serialize`. I added `load_schema` in `_default_attributes` to `_default_attributes` works without any dependency like `attribute_types` etc. Closes #31905.
* | | Merge pull request #31814 from fatkodima/index-nulls-orderRafael França2018-01-292-0/+34
|\ \ \ | | | | | | | | Dump correctly index nulls order for PostgreSQL
| * | | Dump correctly index nulls order for postgresqlfatkodima2018-01-282-0/+34
| | | |
* | | | Deprecate `expand_hash_conditions_for_aggregates`Ryuta Kamizono2018-01-291-0/+7
| | | | | | | | | | | | | | | | | | | | This can not expand an array of aggregated objects correctly, and is no longer used internally since 159b21b5.
* | | | Remove unused/missing `to_money` converter in the test/docRyuta Kamizono2018-01-291-1/+1
| | | |
* | | | Merge pull request #31615 from cben/type_for_attribute-symbolRyuta Kamizono2018-01-291-0/+14
|\ \ \ \ | | | | | | | | | | Allow type_for_attribute(:symbol)
| * | | | Allow type_for_attribute(:symbol)Beni Cherniavsky-Paskin2018-01-011-0/+14
| | | | | | | | | | | | | | | | | | | | Closes #31611.
* | | | | Fix expanding an array of `composed_of` objects which have multiple mappingsRyuta Kamizono2018-01-292-5/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up of #31724. If `composed_of` objects have multiple mappings, array predicate handler can not correctly handle the expanded condition. We need to handle it like polymorphic association objects.
* | | | | Merge pull request #31724 from orekyuu/fix-expand-composed-object-arrayRyuta Kamizono2018-01-291-0/+18
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | Fix not expanded problem when passing an Array object as argument to the where method using composed_of column.
| * | | | Allow expanding an array of `composed_of` objectsRyuta Kamizono2018-01-291-3/+2
| | | | |
| * | | | Fix not expanded problem when passing an Array object as argument to the ↵orekyuu2018-01-261-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | where method using composed_of column. Fixes #31723 ``` david_balance = customers(:david).balance Customer.where(balance: [david_balance]).to_sql # Before: WHERE `customers`.`balance` = NULL # After : WHERE `customers`.`balance` = 50 ```
* | | | | Remove extra whitespaceDaniel Colson2018-01-258-46/+46
| | | | |
* | | | | Use assert_empty and assert_not_emptyDaniel Colson2018-01-2527-127/+127
| | | | |
* | | | | Use assert_predicate and assert_not_predicateDaniel Colson2018-01-2596-1142/+1142
| | | | |
* | | | | Change refute to assert_notDaniel Colson2018-01-2512-32/+32
| | | | |
* | | | | Use respond_to test helpersDaniel Colson2018-01-2515-74/+74
| | | | |
* | | | | Bring back ability to insert zero value on primary key for fixtures (#31795)Ryuta Kamizono2018-01-262-20/+14
|/ / / / | | | | | | | | | | | | | | | | | | | | Since #29504, mysql2 adapter lost ability to insert zero value on primary key due to enforce `NO_AUTO_VALUE_ON_ZERO` disabled. That is for using `DEFAULT` on auto increment column, but we can use `NULL` instead in that case.
* | | | Add test case for deprecated `insert_fixtures`Ryuta Kamizono2018-01-261-2/+16
| | | | | | | | | | | | | | | | Since #31422, `insert_fixtures` is deprecated.
* | | | Remove unused `test/fixtures/teapots.yml`Ryuta Kamizono2018-01-251-3/+0
| | | | | | | | | | | | | | | | It was unused since 9e4c41c903e8e58721f2c41776a8c60ddba7a0a9.
* | | | Fix `count(:all)` with eager loading and having an order other than the ↵Ryuta Kamizono2018-01-252-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | driving table This is a regression caused by 6beb4de. In PostgreSQL, ORDER BY expressions must appear in SELECT list when using DISTINCT. When using `count(:all)` with eager loading, Active Record enforces DISTINCT to count the driving table records only. 6beb4de was caused the regression because `count(:all)` with DISTINCT path no longer removes ORDER BY. We need to ignore ORDER BY when DISTINCT is enforced, otherwise not always generated valid SQL for PostgreSQL. Fixes #31783.
* | | | Clear the transaction state when AR object is dupedYuriy Ustushenko2018-01-251-0/+16
| | | |
* | | | Merge pull request #31784 from composerinteralia/relation-signatureRafael França2018-01-246-29/+49
|\ \ \ \ | | | | | | | | | | Avoid passing unnecessary arguments to relation
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 05:45:08 +0000