Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fixed test_find_last_by_one_attribute_caches_dynamic_finder for postgresql 8.3 | Tarmo Tänav | 2008-09-10 | 1 | -1/+1 |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Added find_last_by dynamic finder [status:committed #762] | miloops | 2008-09-09 | 1 | -4/+36 |
| | | | | Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | ||||
* | Revert "Revert "Raise UnknownAttributeError when unknown attributes are ↵ | Jeremy Kemper | 2008-09-08 | 1 | -0/+8 |
| | | | | | | supplied via mass assignment"" This reverts commit 41efd73887c00ffd228b05d9346ec47a1f3759b9. | ||||
* | Revert "Raise UnknownAttributeError when unknown attributes are supplied via ↵ | Jeremy Kemper | 2008-09-06 | 1 | -8/+0 |
| | | | | | | mass assignment" This reverts commit 108db00aa90fe266564483ab301cf0669cae600f. | ||||
* | Rescue spurious failures in case dummy postgresql user or schema already exists | Jeremy Kemper | 2008-09-04 | 1 | -2/+2 |
| | |||||
* | Default connection allow_concurrency to false (for PostgreSQL) | Nick Sieger | 2008-09-04 | 2 | -0/+4 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Deprecate verification_timeout and verify before reset | Nick Sieger | 2008-09-04 | 2 | -2/+2 |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Fix transaction exception test | Jeremy Kemper | 2008-09-04 | 1 | -0/+1 |
| | |||||
* | Database connections are now pooled, one pool per #establish_connection call. | Jeremy Kemper | 2008-09-02 | 5 | -16/+116 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pools start out empty and grow as necessary to a maximum size (default is 5, configure size with key 'pool' in your database configuration). If no connections are available, a thread will wait up to a 'wait_timeout' time (default is 5 seconds). Connections are verified and reset when checked out from the pool (usually upon first access to ActiveRecord::Base.connection), and returned back to the pool after each request. If you would like to use connection pools outside of ActionPack, there is an ActiveRecord::Base.connection_pool method that gives you access to the pool, and you can manually checkout/checkin connections, or supply a block to ActiveRecord::Base.connection_pool.with_connection which takes care of the checkout/checkin for you. [#936 state:resolved] | ||||
| * | translates when a message symbol has been set on builtin validations | Iain Hecker | 2008-08-31 | 1 | -0/+33 |
| | | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
| * | Fix tests that assumed implicit order by id | Jeremy Kemper | 2008-08-30 | 1 | -2/+2 |
| | | |||||
| * | Performance: Better query for ASSOCIATION_ids. Select only ids if the ↵ | miloops | 2008-08-30 | 3 | -16/+68 |
| | | | | | | | | | | | | association hasn't been loaded. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
| * | Make NamedScope#size behave identically to AssociationCollection#size. [#933 ↵ | Tom Stuart | 2008-08-29 | 1 | -0/+15 |
| | | | | | | | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | | Make clear_active_connections! also return stale connections back to the pool | Nick Sieger | 2008-08-29 | 4 | -96/+87 |
| | | | | | | | | - also clean up some cruft remaining from per-thread connection cache | ||||
* | | Remove CachedConnectionPerThread per-thread pooling mechanism in favor of a ↵ | Nick Sieger | 2008-08-29 | 3 | -0/+7 |
| | | | | | | | | fixed pool with default maximum of 5 connections | ||||
* | | Deprecate allow_concurrency and make it have no effect | Nick Sieger | 2008-08-29 | 4 | -55/+7 |
| | | |||||
* | | Fix typo: was using brackets instead of parens. Must need more sleep. | Nick Sieger | 2008-08-29 | 1 | -0/+10 |
| | | |||||
* | | Fix checkin method, add a couple more tests | Nick Sieger | 2008-08-29 | 1 | -4/+34 |
| | | |||||
* | | Nearing the finish line. Initial fixed-size connection pool implemented, ↵ | Nick Sieger | 2008-08-29 | 1 | -0/+36 |
| | | | | | | | | more docs | ||||
* | | Introduce synchronization around connection pool access | Nick | 2008-08-29 | 1 | -0/+4 |
| | | | | | | | | | | | | - use new active support Module#synchronize - allow_concurrency now switches between a null monitor and a regular monitor (defaulting to null monitor to avoid overhead) | ||||
* | | Rename defined_connections to connection_pools | Nick | 2008-08-29 | 1 | -1/+1 |
| | | | | | | | | | | - Distinguis meaning of "active_connections" to always mean connections associated with the current thread | ||||
* | | Initial conversion to connection pool | Nick | 2008-08-29 | 1 | -24/+15 |
|/ | | | | | | So far so good, tests still run clean. Next steps: synchronize connection pool access and modification, and change allow_concurrency to simply switch a real lock for a null lock. | ||||
* | Make case insensitive validates_uniqueness_of use unicode aware downcase method. | Eugene Pimenov | 2008-08-29 | 1 | -0/+12 |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Fix parentheses warnings | Michael Koziarski | 2008-08-29 | 1 | -1/+1 |
| | |||||
* | Fix NamedScope regex so methods containing "an" get delegated to ↵ | Jan De Poorter | 2008-08-29 | 1 | -0/+4 |
| | | | | | | proxy_found. [#901 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Merge scoped :joins together instead of overwriting them. May expose scoping ↵ | Andrew White | 2008-08-28 | 1 | -2/+79 |
| | | | | | | | | bugs in your code! [#501 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Refactored AssociationCollection#count for uniformity and Ruby 1.8.7 support. | Ernie Miller | 2008-08-28 | 1 | -0/+7 |
| | | | | | | [#831 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Implement count limit/offset support for has_many associations | Tarmo Tänav | 2008-08-27 | 1 | -0/+6 |
| | | | | | | [#348 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Alias included associations if needed when doing a count | Tarmo Tänav | 2008-08-27 | 1 | -0/+4 |
| | | | | | | [#302 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Dirty: treat two changes resulting in the original value as being unchanged. | Tom Lea | 2008-08-27 | 1 | -0/+36 |
| | | | | | | [#798 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Merge commit 'sven/i18n' | Jeremy Kemper | 2008-08-27 | 1 | -12/+7 |
|\ | | | | | | | | | Conflicts: activesupport/lib/active_support.rb | ||||
| * | i18n: fixed failing tests after removing #populate and #store_translations | Marko Seppae | 2008-08-27 | 1 | -12/+7 |
| | | |||||
* | | Fix two has_one :through errors | pivotal | 2008-08-27 | 1 | -0/+9 |
|/ | | | | | | | | * Set the association target on assignment; * Reset target to nil on reset, rather than empty array. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#895 state:committed] | ||||
* | Fix yet another implicit order dependant test | Tarmo Tänav | 2008-08-26 | 1 | -3/+3 |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Just look at sql_type when testing that the correct database-specific type ↵ | Tarmo Tänav | 2008-08-26 | 1 | -4/+1 |
| | | | | | | was used Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Include people and readers fixtures to fix test isolation error | Jeremy Kemper | 2008-08-26 | 1 | -2/+2 |
| | |||||
* | fix tests relying on implicit ordering | Jeremy Kemper | 2008-08-26 | 1 | -2/+3 |
| | |||||
* | Create mysql binary_fields table with latin1 character set as with utf8 all ↵ | Tarmo Tänav | 2008-08-26 | 1 | -2/+2 |
| | | | | | | the limits would have to be divided by 3 to get the expected text types Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Include mysql older than 5.1.23 in the 5.1 series in the list of those that ↵ | Tarmo Tänav | 2008-08-26 | 1 | -1/+1 |
| | | | | | | can't handle NULL defaults Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | um.. yeah | Jeremy Kemper | 2008-08-26 | 1 | -2/+2 |
| | |||||
* | typo | Jeremy Kemper | 2008-08-26 | 1 | -2/+2 |
| | |||||
* | fix another ordering failure | Jeremy Kemper | 2008-08-26 | 1 | -1/+1 |
| | |||||
* | fix tests relying on implicit ordering | Jeremy Kemper | 2008-08-25 | 1 | -4/+2 |
| | |||||
* | add dynamic finder bang version to raise RecordNotFound | Josh Susser | 2008-08-25 | 1 | -0/+14 |
| | | | | | | [#905 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | refactor dynamic finder name matching into its own class | Josh Susser | 2008-08-25 | 1 | -0/+42 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | ensure tests load sibling Active Support instead of a gem | Jeremy Kemper | 2008-08-25 | 1 | -0/+1 |
| | |||||
* | Load the first and not the last has_one result when doing join-based eager ↵ | Tarmo Tänav | 2008-08-25 | 2 | -0/+16 |
| | | | | | | | | | | | loading This matters when the has_one is defined with an order in which case there is an expectation that the first one will be loaded. [#904 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Implement old-skool eagerloading for has_one :through | Frederick Cheung | 2008-08-25 | 1 | -0/+16 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Fix preloading of has_one through associations | Frederick Cheung | 2008-08-25 | 1 | -5/+9 |
| | | | | | | [#903 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | strip trailing whitespace | Jeremy Kemper | 2008-08-25 | 1 | -157/+157 |
| |