aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | Handle nil in add_index :length option in MySQLPaul Sadauskas2012-01-241-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Our schema.rb is being generated with an `add_index` line similar to this: add_index "foo", ["foo", "bar"], :name => "xxx", :length => {"foo"=>8, "bar=>nil} This is the same as it was on Rails 3.1.3, however, now when that schema.rb is evaluated, its generating bad SQL in MySQL: Mysql::Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '))' at line 1: CREATE UNIQUE INDEX `xxx` ON `foo` (`foo`(8), `bar`()) This commit adds a check for nil on the length attribute to prevent the empty parens from being output.
* | | | | Moving AR::TestCase in to the AR tests directoryAaron Patterson2012-01-242-1/+64
| | | | |
* | | | | Merge pull request #4558 from stephencelis/type-cast-unknown-should-failAaron Patterson2012-01-232-7/+5
|\ \ \ \ \ | | | | | | | | | | | | Don't type-cast unknown types to YAML.
| * | | | | Don't type-cast unknown types to YAML.Stephen Celis2012-01-202-7/+5
| | | | | |
* | | | | | Fix typoJari Jokinen2012-01-221-1/+1
| | | | | |
* | | | | | change AR default_timezone to :utc since it's the default for AR::RailtieAkira Matsuda2012-01-211-2/+2
|/ / / / /
* | | | | Fix another race condition.Jon Leighton2012-01-201-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | From 2c667f69aa2daac5ee6c29ca9679616e2a71532a. Thanks @pwnall for the heads-up.
* | | | | adding tests for previous_changes hashAaron Patterson2012-01-191-0/+25
| | | | |
* | | | | Add ActiveRecord::Base#with_lockOlek Janiszewski2012-01-181-0/+20
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a `with_lock` method to ActiveRecord objects, which starts a transaction, locks the object (pessimistically) and yields to the block. The method takes one (optional) parameter and passes it to `lock!`. Before: class Order < ActiveRecord::Base def cancel! transaction do lock! # ... cancelling logic end end end After: class Order < ActiveRecord::Base def cancel! with_lock do # ... cancelling logic end end end
* | | | Merge pull request #4487 from sarenji/fix-reset-countersAaron Patterson2012-01-176-2/+43
|\ \ \ \ | | | | | | | | | | Fix bug where reset_counters resets the wrong counter cache.
| * | | | Fix bug where reset_counters resets the wrong counter cache.David Peter2012-01-166-2/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a model belongs_to two associations with the same class, then reset_counters will reset the wrong counter cache. Finding the right reflection should use the foreign_key instead, which should be unique.
* | | | | disable transactions for this testAaron Patterson2012-01-171-1/+4
| | | | |
* | | | | validate related records in the same validation context as parent.Emmanuel Oga2012-01-171-0/+17
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | E.G.: ```ruby class Parent < ActiveRecord::Base has_one :child validates_presence_of :name, :on => "custom_context" validates_associated :child end class Child < ActiveRecord::Base belongs_to :parent validates_presence_of :name, :on => "custom_context" end p = Parent.new(:name => "Montoto", :child => Child.new) p.valid?(:custom_context) # => Returns true, even though the child is not valid under the same context. ```
* | | | stop more ddl changesAaron Patterson2012-01-162-14/+16
| | | |
* | | | stop ddl modifications for another testAaron Patterson2012-01-162-12/+10
| | | |
* | | | use one based indexes for the mock migrationsAaron Patterson2012-01-161-16/+16
| | | |
* | | | stop making ddl changes for migrator testsAaron Patterson2012-01-162-67/+78
| | | |
* | | | actually use the variable I created. :bomb: thanks @exvivaAaron Patterson2012-01-161-1/+1
| | | |
* | | | move another migrator to use sensorsAaron Patterson2012-01-162-12/+18
| | | |
* | | | Deprecate inferred JOINs with includes + SQL snippets.Jon Leighton2012-01-1618-59/+157
| | | | | | | | | | | | | | | | | | | | | | | | See the CHANGELOG for details. Fixes #950.
* | | | infer references from Relation#orderJon Leighton2012-01-161-1/+21
| | | |
* | | | store references as a stringJon Leighton2012-01-162-6/+6
| | | |
* | | | automatically add references when we canJon Leighton2012-01-161-0/+14
| | | |
* | | | Make referencing an included item trigger eager loadingJon Leighton2012-01-161-0/+11
| | | |
* | | | Add ActiveRecord::Relation#references (#950)Jon Leighton2012-01-161-1/+14
| | | |
* | | | Revert "Deprecate implicit eager loading. Closes #950."Jon Leighton2012-01-1621-162/+94
| | | | | | | | | | | | | | | | This reverts commit c99d507fccca2e9e4d12e49b4387e007c5481ae9.
* | | | moving verbosity tests to the migrator test, removing ddl changesAaron Patterson2012-01-162-18/+24
| | | |
* | | | silencing migrator tests, refactoring the migration test helperAaron Patterson2012-01-163-22/+11
| | | |
* | | | fix tests on sqlite3Aaron Patterson2012-01-161-0/+4
| | | |
* | | | prefer method sensors over actual ddl changesAaron Patterson2012-01-162-69/+84
| | | |
* | | | testing the current version methodAaron Patterson2012-01-161-1/+26
| | | |
* | | | test that migrations have connections, and method missing delegatesAaron Patterson2012-01-161-7/+16
| | | |
* | | | making sure the temp connection and the real connection are different after dupAaron Patterson2012-01-161-3/+3
| | | |
* | | | Merge pull request #4480 from lest/use-rack-body-proxyJosé Valim2012-01-163-16/+14
|\ \ \ \ | | | | | | | | | | Use Rack::BodyProxy
| * | | | use Rack::BodyProxy in activerecord middlewaresSergey Nartimov2012-01-163-16/+14
| | | | |
* | | | | Try to create schema migrations table in schema dumper testPiotr Sarnacki2012-01-161-0/+5
| | | | |
* | | | | Fix ActiveRecord mysql testsPiotr Sarnacki2012-01-161-1/+2
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | TL;DR: MySQL sucks. Since it does not support transactions for schema changes, when you run `create_table` in setup block, it will commit current transaction. Now tests want to run `RELEASE SAVEPOINT` after finishing tests which fails since there is no transaction.
* | | | make sure the migration table is alive and emptyAaron Patterson2012-01-131-0/+11
| | | |
* | | | refactor schema migration table creation to the schema migration modelAaron Patterson2012-01-131-0/+1
| | | |
* | | | stop depending on the filesystem for interleaved migration testsAaron Patterson2012-01-138-84/+49
| | | |
* | | | refactor the migrate method to filter migrations before running themAaron Patterson2012-01-131-1/+1
| | | |
* | | | move schema dumper tests to the correct classAaron Patterson2012-01-132-9/+10
| | | |
* | | | move another migrator test, use schema migration modelAaron Patterson2012-01-132-10/+9
| | | |
* | | | move another migrator test to the correct classAaron Patterson2012-01-132-11/+11
| | | |
* | | | moving more migrator tests to the right test caseAaron Patterson2012-01-132-40/+38
| | | |
* | | | test code that finds migrationsAaron Patterson2012-01-132-6/+5
| | | |
* | | | removing migration files as they are no longer neededAaron Patterson2012-01-137-56/+2
| | | |
* | | | moving migrator tests to a migrator test classAaron Patterson2012-01-132-18/+26
| | | |
* | | | fixing test class nameAaron Patterson2012-01-132-2/+2
| | | |
* | | | adding a test class for table renamingAaron Patterson2012-01-133-70/+78
| | | |