| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|\
| |
| | |
Test and fix for Issue 3450
|
| |
| |
| |
| | |
Asssigning a parent id to a belongs_to association actually updates the object that is validated when the association has :validates => true
|
|\ \
| |/
|/| |
New records should load has_many relationships with custom primary keys
|
| |
| |
| |
| | |
present but the record is unsaved
|
|/
|
|
|
|
|
| |
Rationale: this is more readable if serveral queries
are involved in one call. Also, it will be possible
to let AR log EXPLAINs automatically in production
mode, where queries are not even around.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
adapters.
These tests fail on the v3.1.2 tag.
Closes #3690.
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 0e407a90413d8a19002b85508d811ccdf2190783, reversing
changes made to 533a9f84b035756eedf9fdccf0c494dc9701ba72.
Conflicts:
activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
activerecord/test/cases/migration_test.rb
|
|
|
|
|
|
|
|
|
| |
This reverts commit 81fad6a270ec3cbbb88553c9f2e8200c34fd4d13, reversing
changes made to 23101de283de13517e30c4c3d1ecc65525264886.
Conflicts:
activerecord/test/cases/migration_test.rb
|
|
|
|
| |
This commit contains a simple failing test that demonstrates the behaviour we expect, and a fix. When using `becomes` to transform the type of an object, it should retain any error information that was present on the original instance.
|
| |
|
|
|
|
| |
in find conditions. Paired with Joey Schoblaska.
|
| |
|
|\
| |
| | |
Fix ORA-00932 error when trying to insert 0 to DATE type columns.
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
A recent change made to create_table does away with the
need for the block argument. Checking the arity will prevent the
mixing up of the two syntaxes.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The output in Travis is a bit different. The SQLite
documentation (http://www.sqlite.org/eqp.html) warns
output may change dramatically between releases. I
do not want to mock the result set because I want a
real EXPLAIN to happen. I prefer a test that may fail
in future releases than a test that may give false
positives in future releases.
|
| |
| |
| |
| |
| |
| | |
nulogy/fix_postgres_adapter_to_handle_spaces_between_schemas
Fix postgres adapter to handle spaces between schemas
|
| |
| |
| |
| |
| |
| |
| | |
"Returns true if the specified attribute has been set by the user or by
a database load and is neither nil nor empty?"
Fixes #1613
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is a first implementation, EXPLAIN is highly
dependent on the database and I have made some
compromises.
On one hand, the method allows you to run the most
common EXPLAIN and that's it. If you want EXPLAIN
ANALYZE in PostgreSQL you need to do it by hand.
On the other hand, I've tried to construct a string
as close as possible to the ones built by the
respective shells. The rationale is that IMO the
user should feel at home with the output and
recognize it at first sight. Per database.
I don't know whether this implementation is going
to work well. Let's see whether people like it.
|
|\ \
| | |
| | | |
Fixed an issue id false option is ignored on mysql/mysql2 (fix #3440)
|
| | | |
|
| | | |
|
|/ / |
|
| | |
|
| |
| |
| |
| |
| | |
This is to avoid confusing newbies, and to be consistent with the fact
that other options like :foreign_key already allow a symbol or a string.
|
|\ \
| | |
| | | |
Sexier migrations
|
| | | |
|
| | |
| | |
| | |
| | | |
Preserve SELECT columns on the COUNT for finder_sql when possible
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Building the conditions of a nested through association could
potentially modify the conditions of the through and/or source
association.
This is a Bad Thing.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If a record is removed from a has_many :through, all of the join records
relating to that record should also be removed from the through
association's target.
(Previously the records were removed in the database, but only one was
removed from the in-memory target array.)
|
| | |
| | |
| | |
| | | |
Fixes #3425.
|
| | |
| | |
| | |
| | |
| | | |
Fixes creating records in a through association with a polymorphic source
type.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This change reduces churn in the db/development_structure.sql file when using :sql as
active_record.schema_format, and makes comparing diffs much easier.
Test ensures the output SQL-statements are lexically ordered by version.
|
| | |
| | |
| | |
| | | |
prepared statement cache
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
Removed here 0d0176c4ffe5c58fd1002efbd8f7bd45a8872e33
|
| | | |
|
|\ \ \ |
|
| | | | |
|
| | |/
| |/|
| | |
| | | |
Postgres: Do not attempt to deallocate a statement if the connection is no longer active.
|
| | | |
|