| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | |
| | |
| | | |
English to
American English(according to Weber)
|
|\ \ \
| |/ /
|/| | |
convert multiple Date parameters into a nil if any of its bits were blank
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
1.9 [Closes #2106]
Children attributes can be either String's or Symbol's, so let's check if the object responds to to_i.
|
| | |
| | |
| | |
| | |
| | |
| | | |
are in a timezone which is ahead of UTC but UTC is in the previous day still."
This reverts commit f92cefa95f44bcd550c402a7f5ba914f3bd783cc.
|
| | | |
|
| | |
| | |
| | |
| | | |
timezone which is ahead of UTC but UTC is in the previous day still.
|
| | |
| | |
| | |
| | | |
generates valid SQL
|
|\ \ \
| | | |
| | | | |
ActiveModel support for the :include serialization option
|
| |/ /
| | |
| | |
| | |
| | | |
One duplicate was eliminated: test_to_xml_including_methods/
test_methods_are_called_on_object.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
dynamic finder
The previous behavior was unintentional, and some people was relying on it. Now the dynamic finder will always expecting the number of arguments to be equal or greater (so you can still pass the options to it.)
So if you were doing this and expecting the second argument to be nil:
User.find_by_username_and_group("sikachu")
You'll now get `ArgumentError: wrong number of arguments (1 for 2).` You'll then have to do this:
User.find_by_username_and_group("sikachu", nil)
|
|/ /
| |
| |
| |
| |
| | |
test/cases/fixtures_test.rb when UTC and local time occur on different dates." I am pretty sure this was an incorrect fix, and it still failed in certain circumstances anyway. I am now unable to reproduce the original failure I was experiencing so will leave it for now and see if this pops up again.
This reverts commit e4479b2f1bc54edf155408d51dd3236955150ce1.
|
|\ \
| | |
| | | |
Patch for https://github.com/rails/rails/issues/2059
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Cache key was incorrectly using timezone-dependent record#updated_at when it should be using a timezone-independent value to generate the cache key
Minor refactoring to cache_key timezone test
Closes #2059
Adds a test to validate the format of the cache_key for nil and present updated_at values
Correctly handles updated_at == nil
|
|\ \ \
| |/ /
|/| | |
Bugfix by stopping find_in_batches using the records after yielding.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Currently if the code that calls .find_in_batches modifies the yielded array in place then .find_in_batches can enter an infinite loop searching with ruby object ids in the database instead of the primary key of records in the database. This happens because it naively assumes the yielded array hasn't been modified before calling #id on the last object in the array. And ruby (1.8 at least) alias' #id to #object_id so an integer is still returned no matter what the last object is.
By moving finding the #id of the last object before yielding the array it means the calling code can do whatever it wants to the array in terms of modifying it in place, and .find_in_batches doesn't care.
|
| | |
| | |
| | |
| | | |
test/cases/fixtures_test.rb when UTC and local time occur on different dates.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Create a test case for disable_referential_integrity
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Log instrumentation name for exists? queries
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | | |
respond to empty?
having raises NoMethodError: undefined method `empty?' when a Fixnum or Date/Time were passed via varargs
|
| | | |
| | | |
| | | |
| | | | |
a join. Related: #1873.
|
|\ \ \ \
| | | | |
| | | | | |
ActiveRecord::Base subclasses should pass ActiveModel::Lint.
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
issue #402.
|
| | | | |
| | | | |
| | | | |
| | | | | |
record.create_association. Fixes #1960.
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
Move the private method #extract_schema_and_table into a separate
Utils module so that it can be tested without resorting to #send.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
This caused that `find_each` was producing extra db call taking all the records from db, and was less efficient than `ActiveRecord::Base#all`.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
conditions and includes,
when condtions references tables from includes.
Test fail because of invalid sql:
ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: comments.id:
SELECT "posts".id FROM "posts" INNER JOIN "readers" ON "posts"."id" = "readers"."post_id"
WHERE "readers"."person_id" = 1 AND (comments.id is null)
Bug described in github#925
This commit will revert fix from https://github.com/rails/rails/commit/3436fdfc12d58925e3d981e0afa61084ea34736c , but tests is ok.
Bug described in #6569 ticket.
|
|\ \ \ \
| | | | |
| | | | | |
Addresses an inconsistency in the ActiveRecord::Base.method_missing handl
|
| | | | |
| | | | |
| | | | |
| | | | | |
of dynamic finder methods and the passing of the &block parameter for :find_by_attributes.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix failing test because of Timezone difference.
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fixed AR::Relation#sum compatibility with Array#sum
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
In order make Relation behavior closer to Array
Made Relation#sum to accept block and delegate it to Array#sum
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Fixed CollectionAssociation#find to be compatible with Array#find
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
In order to make CollectionAssociation behave closer to Array
Add the ability to pass block to #find method just like Array#find does.
|
|/ / / / / / |
|