Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Returning nil from named scope lambda is equivalent to an empty hash [#1773 ↵ | Elijah Miller | 2009-03-12 | 2 | -1/+9 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure NoMethodError isn't raised when some of the nested eager loaded ↵ | Murray Steele | 2009-03-12 | 1 | -0/+29 |
| | | | | | | associations are empty [#1696 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fixed autosave checks on objects with hm:t in :include [#2213 state:resolved] | Will Bryant | 2009-03-12 | 3 | -0/+48 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure ActiveRecord::Base.find_in_batches fires doesnt fire an extra query ↵ | Pratik Naik | 2009-03-11 | 2 | -1/+13 |
| | | | | unless needed | ||||
* | Add tests for AssociationCollection#find_each and ↵ | Pratik Naik | 2009-03-11 | 1 | -0/+39 |
| | | | | AssociationCollection#find_in_batches | ||||
* | Add NamedScope#find_each tests [#2201 state:resolved] | Pratik Naik | 2009-03-11 | 1 | -1/+15 |
| | |||||
* | Rename ActiveRecord::Base.each to ActiveRecord::Base.find_each | Pratik Naik | 2009-03-11 | 1 | -3/+3 |
| | |||||
* | Don't duplicate :order from scope and options, it makes mysql do extra work | Jeremy Kemper | 2009-03-10 | 1 | -2/+4 |
| | |||||
* | Ensure nested with_scope merges conditions inside out [#2193 state:resolved] | Manfred Stienstra | 2009-03-10 | 2 | -13/+47 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure ActiveRecord#to_xml respects :skip_types for included associations ↵ | Bruce Krysiak | 2009-03-10 | 1 | -1/+12 |
| | | | | | | [#1632 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure Model#destroy respects optimistic locking [#1966 state:resolved] | Curtis Hawthorne | 2009-03-09 | 1 | -0/+18 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure has_many :through works with changed primary keys [#736 state:resolved] | Jim Remsik and Tim Pope | 2009-03-09 | 6 | -3/+25 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Allow find(:last) :order be a symbol [#2024 state:resolved] | Rob Anderton | 2009-03-09 | 1 | -0/+5 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fix find_by_last when order is given [#2127 state:committed] | Jan De Poorter | 2009-03-09 | 3 | -2/+7 |
| | | | | Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | ||||
* | Ruby 1.9 compat: rename deprecated assert_raises to assert_raise. | Jeremy Kemper | 2009-03-08 | 18 | -104/+104 |
| | | | | [#1617 state:resolved] | ||||
* | Add ActiveRecord::Base#invalid? as the opposite of #valid? [#2159 ↵ | Jeffrey Hardy | 2009-03-08 | 1 | -1/+12 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fix calculation tests to work on sqlite | Pratik Naik | 2009-03-07 | 1 | -5/+7 |
| | |||||
* | Ensure calculations respect scoped :select [#1334 state:resolved] | stopdropandrew | 2009-03-07 | 1 | -0/+11 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure validates_uniqueness_of considers limit on the field. [#1042 ↵ | Arthur Klepchukov | 2009-03-07 | 3 | -0/+16 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fix RDoc grammar and ensure hm:t tests can run in isolation. [#1644 ↵ | Adam Milligan | 2009-03-07 | 1 | -0/+2 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | DRY with_kcode in Active Record tests | Pratik Naik | 2009-03-07 | 2 | -28/+0 |
| | |||||
* | Fixed broken migrations tests: added assert_equal. [#1704 state:resolved] | Marcello Nuccio | 2009-03-07 | 1 | -7/+7 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Allow :having conditions to be sanitized like regular :condition. [#2158 ↵ | Will Bryant | 2009-03-06 | 2 | -0/+15 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure belongs_to association with a counter cache in name spaced model ↵ | Adam Cooper | 2009-03-06 | 3 | -0/+29 |
| | | | | | | works [#1678 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure replacing has_one associations respects the supplied :dependent ↵ | Dimitri Krassovski | 2009-03-06 | 3 | -2/+22 |
| | | | | | | option. [#1305 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure supplie :from has precedence over scoped :from [#1370 state:resolved] | Pratik Naik | 2009-03-06 | 1 | -0/+8 |
| | |||||
* | Ensure self referential HABTM associations raise an exception if ↵ | Tom Lea | 2009-03-06 | 1 | -0/+8 |
| | | | | | | association_foreign_key is missing. [#1252 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Methods invoked within named scope Procs should respect the scope stack. ↵ | jvoorhis | 2009-03-06 | 2 | -0/+6 |
| | | | | | | [#1267 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fix that scoped find with :group and :having [#2006 state:resolved] | Mike Gunderloy | 2009-02-28 | 1 | -0/+7 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Don't validate records of an :autosave association if they're marked for ↵ | Eloy Duran | 2009-02-27 | 1 | -3/+27 |
| | | | | | | destruction. [#2064 status:resolved] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | ||||
* | Fixed that autosave should validate associations even if master is invalid ↵ | David Heinemeier Hansson | 2009-02-27 | 4 | -353/+442 |
| | | | | [#1930 status:committed] | ||||
* | Add test case for ActiveRecord::ConnectionAdapters::ConnectionManagement. | Manfred Stienstra | 2009-02-25 | 1 | -0/+25 |
| | | | | | | - Make sure ConnectionManagement clears connections after each call, except in tests Signed-off-by: Joshua Peek <josh@joshpeek.com> | ||||
* | update the default scope test to take the model's default scope into account | rick | 2009-02-25 | 1 | -1/+1 |
| | |||||
* | Fixed bug that makes named_scopes _forgot_ current scope | Diego Algorta | 2009-02-25 | 2 | -0/+15 |
| | |||||
* | Added ActiveRecord::Base.each and ActiveRecord::Base.find_in_batches for ↵ | David Heinemeier Hansson | 2009-02-23 | 1 | -0/+49 |
| | | | | batch processing [DHH/Jamis Buck] | ||||
* | Revert "Wrap calls to update_attributes in a transaction." | Michael Koziarski | 2009-02-22 | 1 | -34/+0 |
| | | | | | | | This caused failures on sqlite, sqlite3 and postgresql This reverts commit fc09ebc669bd58f415f7d3ef932ef02dab821ab5. [#922 state:reopened] | ||||
* | Wrap calls to update_attributes in a transaction. | Xavier Noria | 2009-02-22 | 1 | -0/+34 |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#922 state:committed] | ||||
* | Changed API of NestedAttributes to take an array, or hash with index keys, ↵ | Lance Ivy | 2009-02-13 | 3 | -79/+215 |
| | | | | | | | | of hashes that have the id on the inside of the attributes hash and updated the FormBuilder to produce such hashes. Also fixed NestedAttributes with composite ids. Signed-off-by: Michael Koziarski <michael@koziarski.com> Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com> [#1892 state:committed] | ||||
* | support end-exclusive ... Ranges in SQL hash condition sanitization properly | Will Bryant | 2009-02-06 | 1 | -0/+6 |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1865 state:committed] | ||||
* | Support true/false in query_attribute for calculated columns | Max Lapshin | 2009-02-06 | 1 | -0/+12 |
| | | | | | Signed-off-by: Tarmo Tänav <tarmo@itech.ee> Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Fixed tests of postgresql money insertion when non-C locale | Max Lapshin | 2009-02-06 | 1 | -0/+1 |
| | | | | | Signed-off-by: Tarmo Tänav <tarmo@itech.ee> Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Also save :autosave enabled associations when #save! is used. | Eloy Duran | 2009-02-06 | 1 | -1/+23 |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1877 state:committed] | ||||
* | Nested attribute accessors should ignore new records with truthy _delete key. | Pascal Ehlert | 2009-02-06 | 1 | -0/+14 |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1861 state:committed] | ||||
* | Add ActiveRecord::Base.exists? with no args [#1817 state:committed] | Scott Taylor | 2009-02-05 | 1 | -1/+10 |
| | | | | Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | ||||
* | Bump mocha requirement for Ruby 1.9 compat. Remove uses_mocha. | Jeremy Kemper | 2009-02-03 | 12 | -613/+570 |
| | |||||
* | Don't rely on the order in these tests | Michael Koziarski | 2009-02-01 | 1 | -2/+2 |
| | |||||
* | validate_length_of should use custom message if given when using in or within. | miloops | 2009-02-01 | 1 | -0/+13 |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1057 state:committed] | ||||
* | Add support for nested object forms to ActiveRecord and the helpers in ↵ | Eloy Duran | 2009-02-01 | 10 | -1/+790 |
| | | | | | | | | ActionPack Signed-Off-By: Michael Koziarski <michael@koziarski.com> [#1202 state:committed] | ||||
* | Sqlite adapter's copy_table incorrectly attempts to recreate a primary key ↵ | Jacob Dunphy | 2009-01-29 | 2 | -0/+16 |
| | | | | | | | | | id (:id => true in the create_table) if an :id column is present, even if it isn't a primary_key. This fix sets :id => false if there is an :id column, but it's not the primary_key. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1766 state:committed] | ||||
* | Ensure whitespaces are stripped when merging string joins. [#1297 ↵ | Filip H.F. "FiXato" Slagter | 2009-01-28 | 1 | -0/+10 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> |