Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | don't change class definition in test case | Josh Susser | 2011-11-29 | 1 | -0/+4 | |
| | | | ||||||
| * | | use GeneratedFeatureMethods module for associations | Josh Susser | 2011-11-27 | 1 | -1/+0 | |
| | | | ||||||
| * | | Allow the :class_name option for associations to take a symbol. | Jon Leighton | 2011-11-04 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | This is to avoid confusing newbies, and to be consistent with the fact that other options like :foreign_key already allow a symbol or a string. | |||||
| * | | Tests gotta run in 1.8 too | Jeremy Kemper | 2011-10-13 | 1 | -2/+2 | |
| | | | ||||||
| * | | Added ActiveRecord::Base.store for declaring simple single-column key/value ↵ | David Heinemeier Hansson | 2011-10-13 | 1 | -0/+1 | |
| | | | | | | | | | | | | stores [DHH] | |||||
* | | | Merge branch 'master' of git://github.com/rails/rails | Dmitry Polushkin | 2011-09-15 | 2 | -10/+12 | |
|\| | | ||||||
| * | | Raise error when using write_attribute with a non-existent attribute. | Jon Leighton | 2011-09-13 | 1 | -6/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously we would just silently write the attribute. This can lead to subtle bugs (for example, see the change in AutosaveAssociation where a through association would wrongly gain an attribute. Also, ensuring that we never gain any new attributes after initialization will allow me to reduce our dependence on method_missing. | |||||
| * | | Make protected method public so we avoid method_missing. | Jon Leighton | 2011-09-13 | 1 | -4/+5 | |
| | | | ||||||
* | | | Test polymorphic record with optimistic locking and counter cache should be ↵ | Dmitry Polushkin | 2011-09-09 | 1 | -1/+1 | |
|/ / | | | | | | | destoyed without catching the ActiveRecord::StaleObjectError. | |||||
* | | Ensure we are not comparing a string with a symbol in ↵ | Jon Leighton | 2011-09-06 | 1 | -1/+1 | |
| | | | | | | | | HasManyAssociation#inverse_updates_counter_cache?. Fixes #2755, where a counter cache could be decremented twice as far as it was supposed to be. | |||||
* | | We need to recorder here. Need to drop the order from default scope. | Arun Agrawal | 2011-09-05 | 1 | -0/+10 | |
| | | | | | | Fixes #2832 | |||||
* | | The join_nodes must be passed to the JoinDependency initializer and ↵ | Jon Leighton | 2011-08-29 | 1 | -0/+2 | |
| | | | | | | | | therefore counted by the alias tracker. This is because the association_joins are aliased on initialization and then the tables are cached, so it is no use to alias the join_nodes later. Fixes #2556. | |||||
* | | Fix default scope thread safety. Thanks @thedarkone for reporting. | Jon Leighton | 2011-08-13 | 1 | -0/+9 | |
| | | ||||||
* | | use existing model for testing Base.create with #after_initialize | Gabriel Horner | 2011-07-24 | 2 | -9/+5 | |
| | | ||||||
* | | simplify and be more explicit about create and after_initialize tests | Gabriel Horner | 2011-07-24 | 1 | -6/+2 | |
| | | ||||||
* | | fix after_initialize edge case (close #2074 and close #2175) | Les Fletcher | 2011-07-24 | 1 | -0/+13 | |
| | | | | | | | | fix behavior when after_initialize is defined and a block is passed to Base.create | |||||
* | | Fix exception if old and new targets are both nil. Fixes #1471. | Jon Leighton | 2011-07-12 | 1 | -1/+4 | |
| | | ||||||
* | | Assign the association attributes to the associated record before the ↵ | Jon Leighton | 2011-06-30 | 1 | -2/+7 | |
| | | | | | | | | before_initialize callback of the record runs. Fixes #1842. | |||||
* | | Apply the default scope earlier when doing calculations. Fixes #1682. | Jon Leighton | 2011-06-23 | 1 | -0/+6 | |
| | | ||||||
* | | Pass mass-assignment options to nested models - closes #1673. | Andrew White | 2011-06-13 | 1 | -2/+6 | |
| | | ||||||
* | | Refactor tests to be less brittle | Jon Leighton | 2011-06-12 | 1 | -0/+12 | |
| | | ||||||
* | | Test added for namedscope target. | Arun Agrawal | 2011-06-03 | 2 | -1/+6 | |
| | | ||||||
* | | Failing test for aggregating on default_scope with select | Erik Fonselius | 2011-05-31 | 1 | -0/+5 | |
| | | ||||||
* | | Tests for issue #1360 | Farley Knight | 2011-05-31 | 1 | -0/+15 | |
| | | ||||||
* | | Fix infinite recursion where a lazy default scope references a scope. Fixes ↵ | Jon Leighton | 2011-05-25 | 1 | -0/+15 | |
| | | | | | | | | #1264. | |||||
* | | Merge pull request #1254 from pixeltrix/ignore-includes-in-through-scope | Jon Leighton | 2011-05-24 | 2 | -0/+9 | |
|\ \ | | | | | | | Ignore :includes on through associations | |||||
| * | | Ignore :includes on through associations | Andrew White | 2011-05-24 | 2 | -0/+9 | |
| | | | ||||||
* | | | Failing tests for #1233. | Andrew White | 2011-05-24 | 1 | -0/+35 | |
|/ / | ||||||
* / | Refactoring test_has_many_with_pluralize_table_names_false test | Guillermo Iguaran | 2011-05-20 | 1 | -0/+1 | |
|/ | ||||||
* | Pass the attribute and option hashes to build_association | Andrew White | 2011-05-17 | 1 | -0/+13 | |
| | | | | | | | The build_association method was added as an API for plugins to hook into in 1398db0. This commit restores this API and the ability to override class.new to return a subclass based on a virtual attribute in the attributes hash. | |||||
* | Merge pull request #560 from guilleiguaran/fix_pluralize_table_names_false | Jon Leighton | 2011-05-16 | 1 | -0/+3 | |
|\ | | | | | Fixing has_many when ActiveRecord::Base.pluralize_table_names is false | |||||
| * | Fixing has_many association when ActiveRecord::Base.pluralize_table_names is ↵ | Guillermo Iguaran | 2011-05-15 | 1 | -0/+3 | |
| | | | | | | | | false. fixes #557 | |||||
* | | CollectionAssociation#merge_target_lists should write to the underlying ↵ | Jon Leighton | 2011-05-14 | 1 | -0/+4 | |
|/ | | | | attributes when copying, rather than using the assignment method | |||||
* | Don't use mass-assignment protection when setting foreign keys or ↵ | Jon Leighton | 2011-05-12 | 1 | -0/+3 | |
| | | | | association conditions on singular associations. Fixes #481 (again). | |||||
* | Don't use select() values from the join model of a through association. ↵ | Jon Leighton | 2011-05-11 | 2 | -0/+8 | |
| | | | | Fixes #508. | |||||
* | Add test to specify that attributes from an association's conditions should ↵ | Jon Leighton | 2011-05-10 | 2 | -0/+4 | |
| | | | | be assigned without mass-assignment protection when a record is built on the association. | |||||
* | Don't quote ID's as Arel will quote them -- follow same conventions as the ↵ | Christopher Meiklejohn | 2011-05-08 | 1 | -0/+3 | |
| | | | | delete method. | |||||
* | Merge pull request #357 from joshk/assign_attributes. | David Heinemeier Hansson | 2011-05-01 | 1 | -6/+17 | |
|\ | | | | | Assign protected attributes with create/new and control the role. | |||||
| * | singular and collection relations in AR can now specify mass-assignment ↵ | Josh Kalderimis | 2011-05-01 | 1 | -6/+17 | |
| | | | | | | | | security options (:as and :without_protection) in build, create and create! methods. | |||||
* | | removed the default_scope deprecations and updated the docs and tests to ↵ | Josh Kalderimis | 2011-04-28 | 1 | -6/+18 | |
|/ | | | | reflect its use cases | |||||
* | Added assign_attributes to Active Record which accepts a mass-assignment ↵ | Josh Kalderimis | 2011-04-24 | 2 | -24/+19 | |
| | | | | security scope using the :as option, while also allowing mass-assignment security to be bypassed using :with_protected | |||||
* | Bring back support for passing a callable object to the default_scope macro. ↵ | Jon Leighton | 2011-04-18 | 1 | -0/+17 | |
| | | | | You can also just use a block. | |||||
* | Un-deprecate using 'default_scope' as a macro, but if you are calling the ↵ | Jon Leighton | 2011-04-18 | 7 | -77/+23 | |
| | | | | macro multiple times that will give deprecation warnings, and in 3.2 we will simply overwrite the default scope when you call the macro multiple times. | |||||
* | Revert "Deprecate defining scopes with a callable (lambda, proc, etc) via ↵ | Jon Leighton | 2011-04-17 | 3 | -30/+21 | |
| | | | | | | | | | | the scope class method. Just define a class method yourself instead." This reverts commit f0e198bfa1e3f9689e0cde1d194a44027fc90b3c. Conflicts: activerecord/test/models/post.rb | |||||
* | common @jonleighton :bomb: | Aaron Patterson | 2011-04-12 | 1 | -2/+1 | |
| | ||||||
* | Deprecate defining scopes with a callable (lambda, proc, etc) via the scope ↵ | Jon Leighton | 2011-04-12 | 3 | -21/+32 | |
| | | | | class method. Just define a class method yourself instead. | |||||
* | Evaluate default scopes at the last possible moment in order to avoid ↵ | Jon Leighton | 2011-04-12 | 1 | -0/+2 | |
| | | | | problems with default scopes getting included into other scopes and then being unable to remove the default part via unscoped. | |||||
* | Deprecated support for passing hashes and relations to default_scope, in ↵ | Jon Leighton | 2011-04-12 | 8 | -23/+102 | |
| | | | | favour of defining a 'default_scope' class method in the model. See the CHANGELOG for more details. | |||||
* | oracle, y u defy me | Jon Leighton | 2011-03-16 | 3 | -7/+9 | |
| | ||||||
* | Add a test for STI on the through where the through is nested, and change ↵ | Jon Leighton | 2011-03-05 | 2 | -0/+2 | |
| | | | | the code which support this |