Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | fix warnings, stop using global variables | Aaron Patterson | 2010-11-30 | 1 | -1/+5 |
| | |||||
* | If a nested_attribute is being marked for destruction and at the same time ↵ | Neeraj Singh | 2010-11-24 | 1 | -0/+8 |
| | | | | | | | | an attr_accessor value is being assigned then the value being assigned is being ignored. This patch is a fix for that issue. [#5939 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | use persisted? instead of new_record? wherever possible | David Chelimsky | 2010-11-09 | 4 | -4/+4 |
| | | | | | | | | | | | - persisted? is the API defined in ActiveModel - makes it easier for extension libraries to conform to ActiveModel APIs without concern for whether the extended object is specifically ActiveRecord [#5927 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Convert :primary_key in association to a string before comparing to column ↵ | Denis Odorcic | 2010-10-30 | 1 | -0/+1 |
| | | | | names, so that for example :primary_key => :another_pk works as well [#5605 state:resolved] | ||||
* | has_one maintains the association with separate after_create/after_update | Xavier Noria | 2010-10-22 | 1 | -0/+37 |
| | | | | | This way parent models can get their own after_create and after_update callbacks fired after has_one has done its job. | ||||
* | scopes can take an object that responds to `call` | Aaron Patterson | 2010-10-19 | 1 | -0/+7 |
| | |||||
* | Allow default_scope to accept a Proc. | Tim Morgan | 2010-10-19 | 1 | -0/+6 |
| | |||||
* | Add some tests for functionality in JoinAssociation which already exists but ↵ | Jon Leighton | 2010-10-13 | 1 | -0/+3 |
| | | | | was previously untested | ||||
* | reorder removed in favor of except(:order).order | Santiago Pastorino | 2010-10-11 | 1 | -1/+0 |
| | |||||
* | expanding the test to include both type of order declaration | Neeraj Singh | 2010-09-18 | 2 | -2/+10 |
| | | | | | | | | | while declaring default_scope Also added test for unscoped using block style with four different combinations Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | fixed Subject model after_initialize callback for test_oracle_synonym test | Raimonds Simanovskis | 2010-09-09 | 1 | -3/+7 |
| | |||||
* | failing test for reorder overriding default_scope | Nick Ragaz | 2010-09-05 | 1 | -1/+1 |
| | | | | | | [5528] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | order should always be concatenated. | Neeraj Singh | 2010-09-05 | 1 | -0/+5 |
| | | | | | | | | | | | | | | | | | | | | | | order that is declared first has highest priority in all cases. Here are some examples. Car.order('name desc').find(:first, :order => 'id').name Car.named_scope_with_order.named_scope_with_another_order Car.order('id DESC').scoping do Car.find(:first, :order => 'id asc') end No special treatment to with_scope or scoping. Also note that if default_scope declares an order then the order declared in default_scope has the highest priority unless with_exclusive_scope is used. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Change relation merging to always append select, group and order values | Pratik Naik | 2010-08-31 | 1 | -1/+1 |
| | |||||
* | While creating a new record using has_many create method default scope of ↵ | Neeraj Singh | 2010-08-19 | 2 | -0/+8 |
| | | | | | | | | | | | child should be respected. author.posts.create should take into account default_scope defined on post. [#3939: state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Add missing model | Santiago Pastorino | 2010-08-14 | 1 | -0/+2 |
| | |||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 5 | -6/+6 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | Ensure we can nest include calls [#5285 state:resolved] | Neeraj Singh | 2010-08-12 | 3 | -0/+11 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Eager loading an association should not change the count of children | Neeraj Singh | 2010-08-02 | 3 | -0/+12 |
| | | | | | | [#4971 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | test and fix collection_singular_ids= with string primary keys [#5125 ↵ | Robert Pankowecki | 2010-08-02 | 1 | -0/+3 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Object#returning removed | Santiago Pastorino | 2010-07-25 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Ensure default_scope can be overwriten by association conditions. | José Valim | 2010-07-21 | 1 | -0/+1 |
| | |||||
* | eagerly loaded association records should respect default_scope [#2931 ↵ | Subba Rao Pasupuleti | 2010-07-21 | 2 | -0/+6 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | update_attribute should not update readonly attributes | Neeraj Singh | 2010-07-21 | 1 | -1/+4 |
| | | | | | | [#5106 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Ensure that primary_keys of HABTM records is not double quoted | Neeraj Singh | 2010-07-20 | 2 | -0/+14 |
| | | | | [#5152 state:reslved] | ||||
* | update_attributes and update_attributes! are now wrapped in a transaction | Neeraj Singh | 2010-07-13 | 1 | -0/+2 |
| | | | | | | [#922 state:resovled] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Added reorder delegation for ActiveRecord::Base(to be able to overwrite the ↵ | Vitalii Khustochka | 2010-07-13 | 1 | -0/+1 |
| | | | | | | default_scope ordering in the named scope [#5093 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | string IDs are now quoted correctly [#5064 state:resolved] | Will St. Clair + Neeraj Singh | 2010-07-13 | 3 | -0/+13 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | reset_counter should work with non-traditional belongs_to and polymorphic ↵ | Neeraj Singh | 2010-07-08 | 3 | -0/+10 |
| | | | | | | | | belongs_to [#4984 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Eager loading :through associations will join the :source model if there are ↵ | Grant Ammons | 2010-07-08 | 1 | -0/+1 |
| | | | | | | :conditions. [#2362 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | mass_assignment_security moved from AR to AMo, and minor test cleanup | Josh Kalderimis | 2010-07-08 | 1 | -9/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | minor changes to mass assignment security patch to bring it in line with ↵ | Josh Kalderimis | 2010-07-08 | 1 | -0/+32 |
| | | | | | | rails standards Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fixed gruoped_by_title spelling [#5063 state:committed] | Ben Somers | 2010-07-08 | 1 | -1/+1 |
| | | | | Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
* | Push a failing test for issues [#4994] and [#5003]. | José Valim | 2010-06-29 | 1 | -0/+3 |
| | |||||
* | with_exclusive_scope does not work properly if ARel is passed. It does work ↵ | Neeraj Singh | 2010-06-29 | 1 | -1/+7 |
| | | | | | | | | nicely if hash is passed. Blow up if user is attempting it pass ARel to with_exclusive_scope. [#3838 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Don't overwrite unsaved updates when loading an association but preserve the ↵ | James Le Cuirot | 2010-06-20 | 1 | -2/+2 |
| | | | | | | | | order of the loaded records. Reapplied from before but now allows already-saved records to be refreshed. [#4830 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Revert "Don't overwrite unsaved updates when loading an association but ↵ | José Valim | 2010-06-11 | 1 | -2/+2 |
| | | | | | | | | preserve the order of the loaded records. [#4642 state:open]" This commit introduced a regression described in ticket [#4830]. This reverts commit 0265c708b9696c3943518ad5f3dabdc22c5eba11. | ||||
* | Don't overwrite unsaved updates when loading an association but preserve the ↵ | James Le Cuirot | 2010-06-09 | 1 | -2/+2 |
| | | | | | | order of the loaded records. [#4642 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Explicitly set Topic model last_read attribute as Date value when Oracle ↵ | Raimonds Simanovskis | 2010-06-04 | 1 | -0/+6 |
| | | | | | | enhanced adapter is used (otherwise some tests are failing which assume that this attribute will have Date value) | ||||
* | Properly cache association_collection#scopes calls having arguments | Pratik Naik | 2010-06-04 | 1 | -0/+1 |
| | |||||
* | Fix failing test. | José Valim | 2010-05-21 | 1 | -3/+3 |
| | |||||
* | Nested records (re: autosave) are now updated even when the intermediate ↵ | Ian White | 2010-05-18 | 2 | -1/+4 |
| | | | | | | parent record is unchanged [#4242 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fix for get_ids when including a belongs_to association on a has_many ↵ | Diego Algorta | 2010-05-15 | 1 | -0/+1 |
| | | | | | | association [#2896 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Make sure valid? preceives the context as in ActiveModel API (ht: Carlos ↵ | José Valim | 2010-05-10 | 1 | -0/+5 |
| | | | | Antonio) | ||||
* | to_xml with :include should skip_instruct on the included records [#4506 ↵ | Lawrence Pit | 2010-04-30 | 1 | -1/+3 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | test cases for record.to_xml [#458 state:resolved] | Neeraj Singh | 2010-04-30 | 1 | -0/+4 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Support fixtures for namespaced models [#2965 state:resolved] | Andrew White | 2010-04-25 | 3 | -0/+11 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Refactor compute_type to handle situations where the correct class is ↵ | Andrew White | 2010-04-12 | 1 | -0/+12 |
| | | | | | | already loaded Signed-off-by: wycats <wycats@gmail.com> | ||||
* | Add Relation extensions | Pratik Naik | 2010-04-02 | 1 | -0/+6 |
| | |||||
* | Add the ability to specify table_name_prefix on individual modules | Andrew White | 2010-03-28 | 1 | -0/+17 |
| | | | | Signed-off-by: wycats <wycats@gmail.com> |