Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix numericality validator not to be affected by custom getter | Ryuta Kamizono | 2018-08-13 | 1 | -0/+8 |
| | | | | | | | | | | | | | | | | | | | | Since fe9547b6, numericality validator would parse raw value only when a value came from user to work type casting to a value from database. But that was caused a regression that the validator would work against getter value instead of parsed raw value, a getter is sometimes customized by people. #33550 There we never guarantees that the value before type cast was going to the used in this validation (actually here is only place that getter value might not be used), but we should not change the behavior unless there is some particular reason. The purpose of fe9547b6 is to work type casting to a value from database. We could achieve the purpose by using `read_attribute`, without using getter value. Fixes #33550. | ||||
* | Use frozen-string-literal in ActiveRecord | Kir Shatrov | 2017-07-19 | 1 | -0/+2 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | modernizes hash syntax in activerecord | Xavier Noria | 2016-08-06 | 1 | -1/+1 |
| | |||||
* | Fix nested association references | Jon Leighton | 2012-09-12 | 1 | -0/+1 |
| | | | | | Previously the reflection would be looked up on the wrong class. However the test passed because the examples referred back to themselves. | ||||
* | Fix has_many :through a polymorphic has_many. Closes #10529 [Aleksey ↵ | Jeremy Kemper | 2008-02-02 | 1 | -0/+3 |
Kondratenko] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8776 5ecf4fe2-1ee6-0310-87b1-e25e094e27de |