aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
Commit message (Collapse)AuthorAgeFilesLines
* * Psych errors with poor yaml formatting are proxied. Fixes #2645, #2731Aaron Patterson2011-09-011-0/+16
|
* Fixes bug in ActiveRecord::QueryMethods, #1697Joshua Wehner2011-08-311-0/+5
| | | Replace split on comma with a regexp that will reverse all ASC/DESC specifically
* Ensure correct ordering of results in ↵Raimonds Simanovskis2011-08-301-1/+1
| | | | | | test_update_all_with_joins_and_offset_and_order Last two asserts in this test assume that all_comments are ordered by posts.id and then by comments.id therefore additional ordering is added. Without it test was failing on Oracle which returned results in different order.
* Merge pull request #2750 from rsim/fix_test_column_names_are_escaped_for_oracleJon Leighton2011-08-301-1/+7
| | | | Fix test column names are escaped for oracle
* Merge pull request #2021 from dasch/more_postgres_utilsAaron Patterson2011-08-292-15/+18
|\ | | | | Make #extract_schema_and_table an instance method in Utils
| * Make #extract_schema_and_table an instance method in UtilsDaniel Schierbeck2011-07-092-15/+18
| | | | | | | | Also, move the utils test into its own test case.
* | The join_nodes must be passed to the JoinDependency initializer and ↵Jon Leighton2011-08-291-0/+4
| | | | | | | | therefore counted by the alias tracker. This is because the association_joins are aliased on initialization and then the tables are cached, so it is no use to alias the join_nodes later. Fixes #2556.
* | Create an AbstractMysqlAdapter to abstract the common code between ↵Jon Leighton2011-08-292-20/+20
| | | | | | | | MysqlAdapter and Mysql2Adapter.
* | fixing typoAaron Patterson2011-08-281-1/+1
| |
* | clear and disable query cache when an exception is raised from called middlewareAaron Patterson2011-08-281-1/+27
| |
* | Force binary data inserted for a string data type to utf-8 and log anAaron Patterson2011-08-251-0/+16
| | | | | | | | | | | | | | | | error. Strings tagged as binary will be stored in sqlite3 as blobs. It is an error to insert binary data to a string column, so an error is emitted in the log file. People are highly encouraged to track down the source of the binary strings and make sure that the encoding is set correctly before inserting to the database.
* | do not compute table names for abstract classesAkira Matsuda2011-08-241-0/+4
| |
* | Fix PredicateBuilder clobbering select_values in subquery.Ernie Miller2011-08-201-0/+13
| |
* | Fix assumption of primary key name in PredicateBuilder subquery.Ernie Miller2011-08-201-0/+10
| |
* | prevent sql injection attacks by escaping quotes in column namesAaron Patterson2011-08-161-0/+17
| |
* | Revert "Merge pull request #2543 from htanata/unused_require_in_ar_test"Santiago Pastorino2011-08-161-0/+1
| | | | | | | | | | This reverts commit 87152f2604e73b218df90befda576f0acfed0bbf, reversing changes made to 0d3615f04c79f6e90d8ab33fdfc920b8faac9cb8.
* | Remove unused require.Hendy Tanata2011-08-161-1/+0
| |
* | Support for multi-table updates with limits, offsets and ordersJon Leighton2011-08-151-0/+30
| |
* | Support updates with joins. Fixes #522.Jon Leighton2011-08-151-0/+8
| |
* | Ensure empty has_many :through association preloaded via joins is marked as ↵Jon Leighton2011-08-151-0/+8
| | | | | | | | loaded. Fixes #2054.
* | Fix default scope thread safety. Thanks @thedarkone for reporting.Jon Leighton2011-08-131-0/+18
| |
* | Merge pull request #2514 from myronmarston/fix_active_record_observer_disablingJosé Valim2011-08-131-0/+12
|\ \ | | | | | | Allow ActiveRecord observers to be disabled.
| * | Allow ActiveRecord observers to be disabled.Myron Marston2011-08-121-0/+12
| | | | | | | | | We have to use Observer#update rather than Observer#send since the enabled state is checked in #update before forwarding the method call on.
* | | Work around for lolruby bug. (Read on for explanation.)Jon Leighton2011-08-132-5/+14
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were experiencing CI test failures, for example: * 3-1-stable: http://travis-ci.org/#!/rails/rails/builds/79473/L407 * master: http://travis-ci.org/#!/rails/rails/builds/79507/L80 These failures only happened on 1.8.7-p352, and we were only able to reproduce on the Travis CI VM worker. We even tried creating a new 32 bit Ubuntu VM and running the tests on that, and it all worked fine. After some epic trial and error, we discovered that replacing the following: fuu = Marshal.load(Marshal.dump(fuu)) with: marshalled = Marshal.dump(fuu) fuu = Marshal.load(marshalled) seemed to prevent the failure. We have NO IDEA why this is. If anyone has some great insight to contribute then that is welcome. Otherwise, hopefully this will just help us get the CI green again. Many thanks to @joshk for help with sorting this out.
* | Fully marshal AR::Base objects. Fixes #2431.Jon Leighton2011-08-081-0/+13
| |
* | Make it the responsibility of the connection to hold onto an ARel visitor ↵Jon Leighton2011-08-085-24/+19
| | | | | | | | for generating SQL. This improves the code architecture generally, and solves some problems with marshalling. Adapter authors please take note: you now need to define an Adapter.visitor_for method, but it degrades gracefully with a deprecation warning for now.
* | Fixed test_disable_referential_integrity on OracleRaimonds Simanovskis2011-08-081-0/+3
| | | | | | On Oracle disable_referential_integrity before execution of block will disable foreign key constraints and after block will enable them but when constraints are enabled then they are validated. Therefore created record with invalid foreign key should be deleted before enabling foreign key constraints.
* | Revert "to_key on a destroyed model should return nil". Closes #2440Santiago Pastorino2011-08-051-1/+1
| | | | | | | | This reverts commit c5448721b5054b8a467958d60427fdee15eac604.
* | Fix test for RubiniusSantiago Pastorino2011-08-051-1/+1
| |
* | pg does not allow aliases in the having clause, but functions are fineAaron Patterson2011-08-051-1/+1
| |
* | Quote these dates to prevent intermittent test failure. Suppose local time ↵Jon Leighton2011-08-041-2/+2
| | | | | | | | is 00:50 GMT+1. Without the quoting, the YAML parser would parse this as 00:50 UTC, into the local time of 01:50 GMT+1. Then, it would get written into the database in local time as 01:50. When it came back out the UTC date from the database and the UTC date of two weeks ago would be compared. The former would be 23:50, and the latter would be 00:50, so the two dates would differ, causing the assertion to fail. Quoting it prevents the YAML parser from getting involved.
* | Ensure that .up and .down work as well.Christopher Meiklejohn2011-08-021-2/+13
| |
* | Support backwards compatible interface for migration down/up with rails 3.0.x.Christopher Meiklejohn2011-08-021-0/+24
| |
* | remove extra require for 'stringio' as it is required in helper.rbVishnu Atrai2011-07-311-1/+0
| |
* | Merge pull request #2358 from arunagw/test_fix_187_skipJosé Valim2011-07-311-3/+4
|\ \ | | | | | | skiping magic comment test for < 1.9
| * | magic comment test only if encoding_aware?.Arun Agrawal2011-07-301-3/+4
| | |
* | | Resolve warnings by instantizing @attrubtes as nilBrian Cardarella2011-07-301-0/+1
|/ /
* | dump IO encoding value along with schema.rb so the file can be reloaded. ↵Aaron Patterson2011-07-291-3/+12
| | | | | | | | fixes #1592
* | Revert "Merge pull request #2309 from smasry/master"Jon Leighton2011-07-281-5/+0
| | | | | | | | | | | | | | This reverts commit 9d396ee8195e31f646e0b89158ed96f4db4ab38f, reversing changes made to fa2bfd832c1d1e997d93c2269a485cc74782c86d. Reason: the change broke the build.
* | Reverse order fix when using function for ActiveRecord::QueryMethods Fixes #1697Samer Masry2011-07-271-0/+5
| |
* | Fixed failing query when performing calculation with having based on select.Dmitriy Kiriyenko2011-07-271-0/+7
| |
* | Add a proxy_association method to association proxies, which can be called ↵Jon Leighton2011-07-271-0/+5
| | | | | | | | by association extensions to access information about the association. This replaces proxy_owner etc with proxy_association.owner.
* | remove deprication warning: ambiguous first argument; put parentheses or ↵Vishnu Atrai2011-07-261-1/+1
| | | | | | | | even spaces
* | Revert "allow select to have multiple arguments"Piotr Sarnacki2011-07-261-5/+0
| | | | | | | | | | | | | | This reverts commit 04cc446d178653d362510e79a22db5300d463161. I reverted it because apparently we want to use: select([:a, :b]) instead of select(:a, :b), but there was no tests for that form.
* | Merge pull request #2271 from slawosz/enhance_select_method_apiPiotr Sarnacki2011-07-261-0/+5
|\ \ | | | | | | allow select to have multiple arguments ie. Post.select(:id,:name,:author)
| * | allow select to have multiple argumentsSławosz Sławiński2011-07-261-0/+5
| | |
* | | Simplify the test by using id and name. `id` will be the only real sort ↵Franck Verrot2011-07-261-1/+1
|/ / | | | | | | criteria in any case as it's unique.
* | Merge pull request #2236 from cldwalker/after_initializeSantiago Pastorino2011-07-251-0/+13
|\ \ | | | | | | Fix after_initialize and Base.create edge case
| * | use existing model for testing Base.create with #after_initializeGabriel Horner2011-07-241-9/+7
| | |
| * | simplify and be more explicit about create and after_initialize testsGabriel Horner2011-07-241-18/+10
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-30 01:11:59 +0000