Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove a redundant test assertion | Koichi ITO | 2017-05-29 | 1 | -6/+0 |
| | |||||
* | Merge pull request #29208 from ↵ | Guillermo Iguaran | 2017-05-28 | 1 | -0/+11 |
|\ | | | | | | | | | kamipo/default_env_fall_back_to_default_env_when_rails_env_or_rack_env_is_empty_string `DEFAULT_ENV` falls back to `default_env` when `RAILS_ENV` or `RACK_ENV` is an empty string | ||||
| * | `DEFAULT_ENV` falls back to `default_env` when `RAILS_ENV` or `RACK_ENV` is ↵ | Ryuta Kamizono | 2017-05-25 | 1 | -0/+11 |
| | | | | | | | | | | | | an empty string Follow up of #27399. | ||||
* | | Deprecate passing arguments and block at the same time to `count` and `sum` ↵ | Ryuta Kamizono | 2017-05-29 | 1 | -0/+12 |
| | | | | | | | | | | | | | | | | in `ActiveRecord::Calculations` `select`, `count`, and `sum` in `Relation` are also `Enumerable` method that can be passed block. `select` with block already doesn't take arguments since 4fc3366. This is follow up of that. | ||||
* | | Merge pull request #29258 from koic/remove_redundant_command_recorder_test | Matthew Draper | 2017-05-29 | 1 | -5/+0 |
|\ \ | | | | | | | Remove a redundant test case of command_recorder_test | ||||
| * | | Remove a redundant test case of command_recorder_test | Koichi ITO | 2017-05-29 | 1 | -5/+0 |
| | | | |||||
* | | | Merge pull request #29253 from kamipo/prevent_extra_query | Matthew Draper | 2017-05-29 | 1 | -3/+9 |
|\ \ \ | | | | | | | | | Prevent extra `current_database` query for `encoding`/`collation`/`ctype` | ||||
| * | | | Prevent extra `current_database` query for `encoding`/`collation`/`ctype` | Ryuta Kamizono | 2017-05-28 | 1 | -3/+9 |
| | | | | |||||
* | | | | Merge pull request #28969 from ↵ | Matthew Draper | 2017-05-28 | 1 | -2/+2 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | kamipo/refactor_enum_to_use_value_instead_of_label Refactor enum to use `value` instead of `label` in the scope | ||||
| * | | | | Refactor enum to use `value` instead of `label` in the scope | Ryuta Kamizono | 2017-05-07 | 1 | -2/+2 |
| | | | | | |||||
* | | | | | Merge pull request #29003 from kamipo/delegate_ast_and_locked_to_arel_explicitly | Matthew Draper | 2017-05-28 | 1 | -1/+1 |
|\ \ \ \ \ | |_|/ / / |/| | | | | Delegate `ast` and `locked` to `arel` explicitly | ||||
| * | | | | Delegate `ast` and `locked` to `arel` explicitly | Ryuta Kamizono | 2017-05-06 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently `ast` and `locked` are used in the internal but delegating to `arel` is depend on `method_missing`. If a model class is defined these methods, `select_all` will be broken. It should be delegated to `arel` explicitly. | ||||
* | | | | | Fix regression in Numericality validator where extra decimal places on | Bradley Priest | 2017-05-27 | 1 | -0/+14 |
| |_|/ / |/| | | | | | | | a user input for a decimal column were ignored by numerically validations | ||||
* | | | | Remove a redundant test assertion | Koichi ITO | 2017-05-27 | 1 | -1/+0 |
| | | | | |||||
* | | | | Merge pull request #29176 from bogdanvlviv/define-path-with__dir__ | Matthew Draper | 2017-05-26 | 5 | -6/+6 |
|\ \ \ \ | | | | | | | | | | | Define path with __dir__ | ||||
| * | | | | Define path with __dir__ | bogdanvlviv | 2017-05-23 | 5 | -6/+6 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ".. with __dir__ we can restore order in the Universe." - by @fxn Related to 5b8738c2df003a96f0e490c43559747618d10f5f | ||||
* | | | | | Merge pull request #29221 from koic/remove_duplicate_migration_test | Matthew Draper | 2017-05-26 | 1 | -27/+0 |
|\ \ \ \ \ | | | | | | | | | | | | | Remove a duplicate test of migration_test in AR | ||||
| * | | | | | Remove a duplicate test of migration_test in AR | Koichi ITO | 2017-05-25 | 1 | -27/+0 |
| | | | | | | |||||
* | | | | | | Merge pull request #29230 from koic/remove_duplicate_schema_authorization_test | Matthew Draper | 2017-05-26 | 1 | -11/+0 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Remove a duplicate test of schema_authorization_test in AR | ||||
| * | | | | | | Remove a duplicate test of schema_authorization_test in AR | Koichi ITO | 2017-05-25 | 1 | -11/+0 |
| | | | | | | | |||||
* | | | | | | | Merge pull request #29226 from koic/remove_duplicate_mysql_rake_test | Matthew Draper | 2017-05-26 | 1 | -7/+0 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Remove a duplicate test of mysql_rake_test | ||||
| * | | | | | | | Remove a duplicate test of mysql_rake_test | Koichi ITO | 2017-05-26 | 1 | -7/+0 |
| |/ / / / / / | |||||
* | | | | | | | Merge pull request #29216 from matthewd/threadsafe-load-schema | Matthew Draper | 2017-05-26 | 1 | -0/+28 |
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | Add a Monitor to ModelSchema#load_schema | ||||
| * | | | | | | Add a Monitor to ModelSchema#load_schema | Matthew Draper | 2017-05-25 | 1 | -0/+28 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Vikrant Chaudhary, David Abdemoulaie, Matthew Draper] | ||||
* | | | | | | | Merge pull request #29175 from kamipo/extract_json_shared_tests | Matthew Draper | 2017-05-25 | 3 | -351/+184 |
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | Extract `JSONSharedTestCases` | ||||
| * | | | | | | Extract `JSONSharedTestCases` | Ryuta Kamizono | 2017-05-22 | 3 | -351/+184 |
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | Both `mysql2/json_test.rb` and `postgresql/json_test.rb` have same test cases. | ||||
* | | | | | | Merge pull request #29181 from kamipo/fix_circular_left_joins_with_scoping | Matthew Draper | 2017-05-25 | 1 | -2/+9 |
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | Fix crashing on circular left join references with scoping | ||||
| * | | | | | Fix crashing on circular left join references with scoping | Ryuta Kamizono | 2017-05-24 | 1 | -2/+9 |
| | |_|_|/ | |/| | | | | | | | | | | | | | Follow up of #25702. | ||||
* / | | | | Fix a RuboCop offences using `rubocop -a` | Koichi ITO | 2017-05-24 | 1 | -1/+1 |
|/ / / / | |||||
* | | | | Merge pull request #29141 from kamipo/make_helper_methods_to_private | Matthew Draper | 2017-05-24 | 1 | -18/+19 |
|\ \ \ \ | | | | | | | | | | | Make helper methods in tests to private | ||||
| * | | | | Make helper methods in tests to private | Ryuta Kamizono | 2017-05-19 | 1 | -18/+19 |
| | | | | | | | | | | | | | | | | | | | | | | | | | `make_model` and `make_no_pk_hm_t` in `HasManyThroughAssociationsTest` are not a test case. it should be private. | ||||
* | | | | | Merge pull request #29145 from kamipo/reference_type_should_be_not_null | Matthew Draper | 2017-05-24 | 1 | -0/+8 |
|\ \ \ \ \ | | | | | | | | | | | | | Both reference id and type should be `NOT NULL` if `null: false` is specified | ||||
| * | | | | | Both reference id and type should be `NOT NULL` if `null: false` is specified | Ryuta Kamizono | 2017-05-19 | 1 | -0/+8 |
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | This is a regression due to #28282. Fixes #29136. | ||||
* | | | | | Merge pull request #29167 from koic/remove_duplicate_inverse_associations_test | Matthew Draper | 2017-05-24 | 1 | -14/+0 |
|\ \ \ \ \ | | | | | | | | | | | | | Remove a duplicate test of inverse_associations_test in AR | ||||
| * | | | | | Remove a duplicate test of inverse_associations_test in AR | Koichi ITO | 2017-05-21 | 1 | -14/+0 |
| | |/ / / | |/| | | | |||||
* | | | | | Merge pull request #29182 from kamipo/remove_unused_left_joins_values_generation | Matthew Draper | 2017-05-24 | 1 | -1/+1 |
|\ \ \ \ \ | | | | | | | | | | | | | Remove unused `left_joins_values` generation | ||||
| * | | | | | Remove unused `left_joins_values` generation | Ryuta Kamizono | 2017-05-23 | 1 | -1/+1 |
| |/ / / / | | | | | | | | | | | | | | | | This was added at #22125 but `left_joins_values` is never used. | ||||
* / / / / | More friendly exception in nested attributes | Kir Shatrov | 2017-05-22 | 1 | -1/+1 |
|/ / / / | |||||
* / / / | Add cache_key_with_version and use it in ActiveSupport::Cache.expand_cache_key | David Heinemeier Hansson | 2017-05-19 | 2 | -7/+19 |
|/ / / | | | | | | | | | | | | | | | | This retains the existing behavior of ActiveSupport::Cache.expand_cache_key (as used by etaging) where the cache key includes the version. | ||||
* | | | Use recyclable cache keys (#29092) | David Heinemeier Hansson | 2017-05-18 | 2 | -2/+68 |
| | | | |||||
* | | | Set non 0 value to logger not to be affected by Ruby versions | Yasuo Honda | 2017-05-17 | 1 | -23/+23 |
| | | | | | | | | | | | | Addresses #29021 | ||||
* | | | Respect 'ignore_tables' in SQLite structure dump | Guillermo Iguaran | 2017-05-15 | 1 | -0/+20 |
| | | | |||||
* | | | Respect 'ignore_tables' in MySQL structure dump | Guillermo Iguaran | 2017-05-15 | 1 | -0/+16 |
| | | | |||||
* | | | Respect `ignore_tables` in Postgres structure dump | Rusty Geldmacher | 2017-05-15 | 1 | -0/+8 |
| | | | | | | | | | | | | | | | | | | When using `sql` as the schema format, or even just doing `rake db:structure:dump`, it would be good to respect the list of ignored tables that has been configured. | ||||
* | | | Don't eager loading if unneeded for `FinderMethods#exists?` | Ryuta Kamizono | 2017-05-11 | 1 | -0/+1 |
| | | | | | | | | | | | | Fixes #29025. | ||||
* | | | Should escape meta characters in regexp | Ryuta Kamizono | 2017-05-07 | 10 | -26/+26 |
| |/ |/| | |||||
* | | Fix `warning: ambiguous first argument` | Ryuta Kamizono | 2017-05-06 | 1 | -2/+2 |
|/ | | | | | | | | | | | | | | | | ``` % ARCONN=sqlite3 be ruby -w -Itest test/cases/quoting_test.rb test/cases/quoting_test.rb:92: warning: ambiguous first argument; put parentheses or a space even after `/' operator test/cases/quoting_test.rb:96: warning: ambiguous first argument; put parentheses or a space even after `/' operator Using sqlite3 Run options: --seed 9495 ..................................... Finished in 0.046403s, 797.3622 runs/s, 1120.6172 assertions/s. 37 runs, 52 assertions, 0 failures, 0 errors, 0 skips ``` | ||||
* | Merge pull request #28989 from matthewd/quoted_id-deprecation | Matthew Draper | 2017-05-06 | 1 | -1/+14 |
|\ | | | | | Clarify deprecation message for #quoted_id | ||||
| * | Clarify deprecation message for #quoted_id | Matthew Draper | 2017-05-05 | 1 | -1/+14 |
| | | | | | | | | | | In this case, it's the method definition that's more at fault, rather than the current caller. | ||||
* | | Remove unused `DelegationTest#call_method` | Ryuta Kamizono | 2017-05-06 | 1 | -27/+7 |
|/ | | | | `DelegationTest#call_method` is no longer used since 9d79334a. |