aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
Commit message (Collapse)AuthorAgeFilesLines
* Avoid PostgreSQL and MySQL tests warnings.Emilio Tagua2010-06-082-3/+6
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix ActiveRecord::Base.compute_type swallowing NoMethodError. [#4751 ↵Andrew Bloomgarden2010-06-081-0/+17
| | | | | | state:resolved] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
* Add parentheses to avoid warnings when running AR tests.Emilio Tagua2010-06-081-4/+4
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Temporarily revert "Update after_commit and after_rollback docs and tests to ↵Jeremy Kemper2010-06-082-273/+0
| | | | | | | | | | | | | | use new style API with an :on options instead of on_* suffix." and "Add after_commit and after_rollback callbacks to ActiveRecord that are called after transactions either commit or rollback on all records saved or destroyed in the transaction." This reverts commits d2a49e4b1f30c5997e169110eed94a55aee53f56 and da840d13da865331297d5287391231b1ed39721b. [#2991] Conflicts: activerecord/CHANGELOG activerecord/lib/active_record/transactions.rb activerecord/test/cases/transaction_callbacks_test.rb
* Fix multiple self-referencing eager loads failing to join multiple timesErnie Miller2010-06-081-1/+9
| | | | | | [#4679 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Merge remote branch 'rsim/oracle_enhanced_rails3'wycats2010-06-077-37/+34
|\
| * compare sorted arrays in relations_testRaimonds Simanovskis2010-06-041-1/+1
| | | | | | Oracle does not guarantee that SELECT will return records ordered by primary key
| * fix test_belongs_to_with_primary_key_joins_on_correct_column test on OracleRaimonds Simanovskis2010-06-041-0/+4
| |
| * Fixed adapter tests not to assert LIMIT and OFFSET in SQL stringsRaimonds Simanovskis2010-06-041-13/+4
| | | | | | | | Fixed adapter test cases that were failing in oracle because the asserts were looking for the presence of offset and limit which are not available in oracle. Changed the tests to check that the sql injection is not present in the output so that the tests are database adapter agnostic.
| * assert log output match in case insensitive mode to avoid failure when ↵Raimonds Simanovskis2010-06-041-2/+2
| | | | | | | | quoted table name is in uppercase (when using Oracle)
| * test fixes for Oracle enhanced adapter:Raimonds Simanovskis2010-06-041-2/+2
| | | | | | | | | | latest oracle_enhanced adapter does automatic shortening of index names ignore select from all_triggers table in assert_queries
| * do order by id when finding first fixture to ensure that it is correct oneRaimonds Simanovskis2010-06-041-1/+1
| | | | | | | | (as otherwise was failing under JRuby and oracle_enhanced adapter)
| * Oracle enhanced adapter now supports shortening of default generated index ↵Raimonds Simanovskis2010-06-041-12/+10
| | | | | | | | names, some additional tests now pass
| * Reduced size of table name prefix and suffix in migrations test as in Oracle ↵Raimonds Simanovskis2010-06-041-3/+4
| | | | | | | | identifier name cannot be larger than 30 characters
| * Explicitly set Topic model last_read attribute as Date value when Oracle ↵Raimonds Simanovskis2010-06-041-3/+4
| | | | | | | | | | | | enhanced adapter is used (otherwise some tests are failing which assume that this attribute will have Date value)
| * create DateTime value with local offset as later it is compared to Time ↵Raimonds Simanovskis2010-06-041-1/+3
| | | | | | | | | | | | value with local offset (otherwise test is failing for oracle_enhanced JDBC adapter)
* | This test shouldn't rely on the order of the data returned by selectSantiago Pastorino2010-06-071-1/+1
| | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* | Really make include_root_in_json default to true [#3770 state:resolved]José Valim2010-06-081-11/+8
| |
* | Fixing test class names and refactor line in autosave associationCarlos Antonio da Silva2010-06-072-6/+6
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | removes Array#random_element and backports Array#sample from Ruby 1.9, ↵Xavier Noria2010-06-052-8/+8
|/ | | | thanks to Marc-Andre Lafortune
* Properly cache association_collection#scopes calls having argumentsPratik Naik2010-06-041-0/+13
|
* Special treatement for Relation#select { with block }Pratik Naik2010-06-021-0/+5
|
* Merge commit 'mislav/counter_cache'Michael Koziarski2010-05-292-49/+83
|\
| * fix `reset_counters` to work even with complex class namesMislav Marohnić2010-05-241-0/+25
| | | | | | | | | | | | e.g. it guesses that a belongs_to association to Namespace::MyModel is named "my_model", unlike before where it would look up an association named "namespace::mymodel" and fail.
| * move counter_cache tests to a separate file and refactorMislav Marohnić2010-05-242-49/+58
| |
* | Refactor calculation test to remove unneeded SQLite special case.Santiago Pastorino2010-05-241-4/+1
|/ | | | | | [#4633] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Fix failing test.José Valim2010-05-211-6/+6
|
* Replace assert with assert_equal in some test casesNeeraj Singh2010-05-211-2/+2
| | | | | | [#4654 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Final iteration of use better testing methodsNeeraj Singh2010-05-199-25/+25
| | | | | | [#4652 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Fixes a test on transaction_callbacks_test.rbSantiago Pastorino2010-05-191-2/+2
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Use better assertion methods for testingNeeraj Singh2010-05-1916-89/+82
| | | | | | [#4645 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Revert "Don't carry default value when changing column for a binary type on ↵Jeremy Kemper2010-05-181-12/+0
| | | | | | | | | | | | | | MySQL" Broke mysql tests. This reverts commit edec1afe25014749f0e2df86d27477b45586a9e3. Conflicts: activerecord/test/cases/migration_test.rb [#3234 state:open]
* make add_index and remove_index more resilient; new rename_index method; ↵Étienne Barrié2010-05-183-2/+41
| | | | | | | | track database limits [#3452 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Fixes transaction callbacks testsSantiago Pastorino2010-05-181-23/+19
| | | | | | [#4640 state:committed] Signed-off-by: wycats <wycats@gmail.com>
* Nested records (re: autosave) are now updated even when the intermediate ↵Ian White2010-05-181-0/+80
| | | | | | parent record is unchanged [#4242 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* assert_equal should be used instead of assertNeeraj Singh2010-05-181-1/+1
| | | | | | [#4629 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* expected value should come first in assert_equalNeeraj Singh2010-05-181-3/+3
| | | | | | [#4630 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Remove Model.clear_default_scopePratik Naik2010-05-181-12/+0
|
* Use assert_equal correctly in transaction callback tests (exposing some of ↵Paco Guzman2010-05-171-17/+17
| | | | | | | | them as broken) [#4612] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* AR::Base#clone fixed to set dirty bits for cloned objectpleax2010-05-161-0/+50
| | | | | | [#2919 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* a cloned object no longer mimics changed flags from creator , plus a test ↵Federico Brubacher2010-05-161-0/+9
| | | | | | case [#4614 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Change on Array extension from rand => random_element [#4555 state:committed]Santiago Pastorino2010-05-162-8/+8
| | | | Signed-off-by: Xavier Noria <fxn@hashref.com>
* prevent to run fixture accessor (e.g. test_foos for TestFoo model) as a test ↵Nobuhiro IMAI2010-05-161-0/+5
| | | | | | | case [#2992 state:resolved] Signed-off-by: Wijnand Wiersma <wijnand@videre.net> Signed-off-by: José Valim <jose.valim@gmail.com>
* Make use of assert_equal to test equallity between object assert expects and ↵Santiago Pastorino2010-05-163-5/+5
| | | | | | | | object and a message of error [#4611 state:committed] Signed-off-by: José Valim <jose.valim@gmail.com>
* Postgresql doesn't allow to change a string type column to a binary type. ↵Wijnand Wiersma2010-05-161-7/+9
| | | | | | Skip this test for postgresql for now. [#4616 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Don't carry default value when changing column for a binary type on MySQL ↵Elomar França2010-05-161-0/+10
| | | | | | [#3234 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Revert "Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an ↵José Valim2010-05-152-10/+10
| | | | | | | | options hash and make various Validators pass their (filtered) options." Having a huge array to whitelist options is not the proper way to handle this case. This means that the ActiveModel::Errors object should know about the options given in *all* validators and break the extensibility added by the validators itself. If the intent is to whitelist options before sending them to I18n, each validator should clean its respective options instead of throwing the responsibility to the Errors object. This reverts commit bc1c8d58ec45593acba614d1d0fecb49adef08ff.
* Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options ↵Jeroen van Dijk2010-05-152-10/+10
| | | | | | | | | | | | | | | | | | | | hash and make various Validators pass their (filtered) options. This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format". Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation. Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options). Original patch by Sven Fuchs, some minor changes and has been changed to be applicable to master again [#4057 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Reset quoted_table_name after set_table_name [#4568 state:resolved]Santiago Pastorino2010-05-151-0/+12
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fix for get_ids when including a belongs_to association on a has_many ↵Diego Algorta2010-05-151-0/+4
| | | | | | association [#2896 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>