| Commit message (Collapse) | Author | Age | Files | Lines |
|\ |
|
| |\
| | |
| | | |
`rename_table` should rename primary key index name
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Formerly, `rename_table` only renamed primary key index name if the
column's data type was sequential (serial, etc in PostgreSQL). The
problem with that is tables whose primary keys had other data types
(e.g. UUID) maintained the old primary key name. So for example,
if the `cats` table has a UUID primary key, and the table is renamed to
`felines`, the primary key index will still be called `cats_pkey`
instead of `felines_pkey`. This PR corrects it.
|
| |/ |
|
| |\
| | |
| | |
| | |
| | | |
kamipo/default_env_fall_back_to_default_env_when_rails_env_or_rack_env_is_empty_string
`DEFAULT_ENV` falls back to `default_env` when `RAILS_ENV` or `RACK_ENV` is an empty string
|
| | |
| | |
| | |
| | |
| | |
| | | |
an empty string
Follow up of #27399.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
in `ActiveRecord::Calculations`
`select`, `count`, and `sum` in `Relation` are also `Enumerable` method
that can be passed block. `select` with block already doesn't take
arguments since 4fc3366. This is follow up of that.
|
| |\ \
| | | |
| | | | |
Remove a redundant test case of command_recorder_test
|
| | | | |
|
| |\ \ \
| | | | |
| | | | | |
Prevent extra `current_database` query for `encoding`/`collation`/`ctype`
|
| | | | | |
|
| |\ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
kamipo/refactor_enum_to_use_value_instead_of_label
Refactor enum to use `value` instead of `label` in the scope
|
| | | | | | |
|
| |\ \ \ \ \
| | |_|/ / /
| |/| | | | |
Delegate `ast` and `locked` to `arel` explicitly
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Currently `ast` and `locked` are used in the internal but delegating to
`arel` is depend on `method_missing`. If a model class is defined these
methods, `select_all` will be broken.
It should be delegated to `arel` explicitly.
|
| | |_|/ /
| |/| | |
| | | | | |
a user input for a decimal column were ignored by numerically validations
|
| | | | | |
|
| |\ \ \ \
| | | | | |
| | | | | | |
Define path with __dir__
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
".. with __dir__ we can restore order in the Universe." - by @fxn
Related to 5b8738c2df003a96f0e490c43559747618d10f5f
|
| |\ \ \ \ \
| | | | | | |
| | | | | | | |
Remove a duplicate test of migration_test in AR
|
| | | | | | | |
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Remove a duplicate test of schema_authorization_test in AR
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Remove a duplicate test of mysql_rake_test
|
| | |/ / / / / / |
|
| |\ \ \ \ \ \ \
| | |/ / / / / /
| |/| | | | | | |
Add a Monitor to ModelSchema#load_schema
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
[Vikrant Chaudhary, David Abdemoulaie, Matthew Draper]
|
| |\ \ \ \ \ \ \
| | |_|/ / / / /
| |/| | | | | | |
Extract `JSONSharedTestCases`
|
| | | |/ / / /
| | |/| | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Both `mysql2/json_test.rb` and `postgresql/json_test.rb` have same test
cases.
|
| |\ \ \ \ \ \
| | |_|/ / / /
| |/| | | | | |
Fix crashing on circular left join references with scoping
|
| | | |_|_|/
| | |/| | |
| | | | | |
| | | | | | |
Follow up of #25702.
|
| |/ / / / |
|
| |\ \ \ \
| | | | | |
| | | | | | |
Make helper methods in tests to private
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`make_model` and `make_no_pk_hm_t` in `HasManyThroughAssociationsTest`
are not a test case. it should be private.
|
| |\ \ \ \ \
| | | | | | |
| | | | | | | |
Both reference id and type should be `NOT NULL` if `null: false` is specified
|
| | |/ / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This is a regression due to #28282.
Fixes #29136.
|
| |\ \ \ \ \
| | | | | | |
| | | | | | | |
Remove a duplicate test of inverse_associations_test in AR
|
| | | |/ / /
| | |/| | | |
|
| |\ \ \ \ \
| | | | | | |
| | | | | | | |
Remove unused `left_joins_values` generation
|
| | |/ / / /
| | | | | |
| | | | | |
| | | | | | |
This was added at #22125 but `left_joins_values` is never used.
|
| |/ / / / |
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | | |
This retains the existing behavior of
ActiveSupport::Cache.expand_cache_key (as used by etaging) where the
cache key includes the version.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Addresses #29021
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When using `sql` as the schema format, or even just doing `rake
db:structure:dump`, it would be good to respect the list of ignored
tables that has been configured.
|
| | | |
| | | |
| | | |
| | | | |
Fixes #29025.
|
| | |/
| |/| |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
```
% ARCONN=sqlite3 be ruby -w -Itest test/cases/quoting_test.rb
test/cases/quoting_test.rb:92: warning: ambiguous first argument; put parentheses or a space even after `/' operator
test/cases/quoting_test.rb:96: warning: ambiguous first argument; put parentheses or a space even after `/' operator
Using sqlite3
Run options: --seed 9495
.....................................
Finished in 0.046403s, 797.3622 runs/s, 1120.6172 assertions/s.
37 runs, 52 assertions, 0 failures, 0 errors, 0 skips
```
|