| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Clear all caches calculated based on `@columns` when `@columns` changes
|
| | |
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first case was not testing what the issue mentioned actually was (A
subclass of a class with serialized attributes does not serialize when
they come from the database).
The second case was a bad coder. It would fail if the model was `dup`ed,
or if the the model was loaded from the database and then saved again.
The third case wasn't testing anything that wasn't covered by the second
(and was also a bad coder for the same reasons as the second).
|
|\
| |
| | |
Rename attribute related instance variables to better express intent
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
`@attributes` was actually used for `_before_type_cast` and friends,
while `@attributes_cache` is the type cast version (and caching is the
wrong word there, but I'm working on removing the conditionals around
that). I opted for `@raw_attributes`, because `_before_type_cast` is
also semantically misleading. The values in said hash are in the state
given by the form builder or database, so raw seemed to be a good word.
|
|/ |
|
|
|
|
|
| |
This is an intermediate solution. It is related to the refactoring @sgrif
is making and will change in the future.
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Fixed #columns_for_distinct of postgresql adapter
Conflicts:
activerecord/CHANGELOG.md
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Many of the methods defined in `AttributeMethods::Serialization` can be
refactored onto this type as well, but this is a reasonable small step.
Removes the `Type` class, and the need for `decorate_columns` to handle
serialized types.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
MySQL and PostgreSQL provide a column type override in order to properly
type cast computed columns included in a result set. This should never
override the known types of full fledged columns. In addition to messing
up computed properties, this would have led to inconsistent behavior
between a record created with `new`, and a record created with `last` on
the mysql adapter in the following cases:
- `tinyint(1)` with `emulate_booleans` set to `false`
- `text`, `string`, `binary`, and `decimal` columns
|
| |
| |
| |
| |
| |
| | |
Working towards re-implementing serialized attributes to use the
properties API exposed the need for this, as serializing a column
shouldn't change the order of the columns.
|
|\ \
| | |
| | | |
Ensure custom properties work correctly with inheritance
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Move types to the top level `ActiveRecord` namespace
|
| | |
| | |
| | |
| | |
| | | |
`ActiveRecord::ConnectionAdapters::Type::Value` =>
`ActiveRecord::Type::Value`
|
|\ \ \
| | | |
| | | | |
Remove unused `Column#coder`
|
| |/ /
| | |
| | |
| | |
| | | |
It appears this property was added, but never actually used. It would be
broken if it were, as it only type casts one way.
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The solution presented in this patch is not efficient. We should replace it
in the near future. The following needs to be worked out:
* Is `@attributes` storing the Ruby or SQL representation?
* `cacheable_column?` is broken but `hstore` and `json` rely on that behavior
Refs #15369.
/cc @sgrif @rafaelfranca
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Silence deprecation warning in test
|
| | |
| | |
| | |
| | | |
Missed a case that only occured for mysql/mysql2
|
|\ \ \
| |/ /
|/| | |
Correctly alias table names when joining more than once
|
| | | |
|
|\ \ \
| | | |
| | | | |
Deprecate decimal columns being automatically treated as integers
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
With ActiveRecord::Properties, we now have a reasonable path for users
to continue to keep this behavior if they want it. This is an edge case
that has added a lot of complexity to the code base.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
After ad7b5efb55bcc2e0ccd3e7f22a81e984df8676d1, which changed how
has_an_belongs_to_many used to work, we start raising an error when
redefining the same has_an_belongs_to_many association. This commits fix
that regression.
[Fixes #14983]
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
All preload tests are in the eager_test file
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As a result of all of the refactoring that's been done, it's now
possible for us to define a public API to allow users to specify
behavior. This is an initial implementation so that I can work off of it
in smaller pieces for additional features/refactorings.
The current behavior will continue to stay the same, though I'd like to
refactor towards the automatic schema detection being built off of this
API, and add the ability to opt out of automatic schema detection.
Use cases:
- We can deprecate a lot of the edge cases around types, now that there
is an alternate path for users who wish to maintain the same behavior.
- I intend to refactor serialized columns to be built on top of this
API.
- Gem and library maintainers are able to interact with `ActiveRecord`
at a slightly lower level in a more stable way.
- Interesting ability to reverse the work flow of adding to the schema.
Model can become the single source of truth for the structure. We can
compare that to what the database says the schema is, diff them, and
generate a migration.
|
|\ \ \
| | | |
| | | | |
Refactor reflections
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix habtm reflection
Conflicts:
activerecord/CHANGELOG.md
activerecord/lib/active_record/counter_cache.rb
activerecord/lib/active_record/reflection.rb
activerecord/test/cases/reflection_test.rb
|
|\ \ \ \
| | | | |
| | | | | |
Remove checks against `column.type` in abstract adapter quoting
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The intention is to eventually remove `column` from the arguments list
both for `quote` and for `type_cast` entirely. This is the first step
to that end.
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It appears that the only time that `quote` is called with a column,
but without first calling `type_cast` is when where is called with an
array. My previous pull request broke this behavior, without failing
tests. This adds a test for the only case I can think of that exercises
the `if column.type == :integer` branch of `quote` effectively.
|
|\ \ \ \
| | | | |
| | | | | |
Add an interface for type objects to control Ruby => SQL
|
| |/ / /
| | | |
| | | |
| | | |
| | | | |
Adds the ability to save custom types, which type cast to non-primitive
ruby objects.
|
|/ / /
| | |
| | |
| | | |
`warning: assigned but unused variable - album`
|
|\ \ \
| | | |
| | | | |
Remove special case in schema dumper for decimal without scale
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It seems that #where! is not designed to be used as a chained where.
See initial implementation at 8c2c60511beaad05a218e73c4918ab89fb1804f0.
So, no need to check twice.
We should not test #where!
https://github.com/rails/rails/pull/15285#discussion_r13018316
|
|\ \ \
| | | |
| | | | |
Remove `Column#primary`
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It appears to have been used at some point in the past, but is no longer
used in any meaningful way. Whether a column is considered primary is
a property of the model, not the schema/column. This also removes the
need for yet another layer of caching of the model's schema, and we can
leave that to the schema cache.
|