Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | | | Fixes problem with replacing has_one association record with itself | Denis Redozubov | 2013-11-11 | 1 | -2/+16 | |
| |/ / / / | ||||||
* | | | | | A tiny grammatical fix | Akira Matsuda | 2013-11-11 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | [ci skip] | |||||
* | | | | | Merge pull request #12749 from iantropov/issue_5303 | Rafael Mendonça França | 2013-11-10 | 1 | -0/+4 | |
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | Add test for ActiveRecord::Relation YAML serialization, for #5303 issue | |||||
| * | | | | Add test for ActiveRecord::Relation YAML serialization, for #5303 issue | Ivan Antropov | 2013-11-03 | 1 | -0/+4 | |
| | | | | | ||||||
* | | | | | use complete Relation API and not only `Model.all.merge!`. | Yves Senn | 2013-11-09 | 1 | -88/+83 | |
| | | | | | ||||||
* | | | | | Changed message for Model.inspect | Arun Agrawal | 2013-11-09 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (No database connection) sounds not be able to connect database. see more #12804 | |||||
* | | | | | log bind variables after they were type casted. | Yves Senn | 2013-11-09 | 1 | -0/+11 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The log output used to be confusing in situation where type casting has "unexpected" effects. For example when finding records with a `String`. BEFORE: irb(main):002:0> Event.find("im-no-integer") D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", "im-no-integer"]] AFTER: irb(main):002:0> Event.find("im-no-integer") D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", 0]] | |||||
* | | | | | Mark broken test as pending | Rafael Mendonça França | 2013-11-08 | 2 | -0/+4 | |
| | | | | | | | | | | | | | | | | | | | | This will avoid the broken window effect in our test suite | |||||
* | | | | | Remove more skip | Rafael Mendonça França | 2013-11-08 | 4 | -13/+7 | |
| | | | | | ||||||
* | | | | | Don't skip tests if we don't need to. | Rafael Mendonça França | 2013-11-08 | 30 | -1023/+966 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can conditional define the tests depending on the adapter or connection. Lets keep the skip for fail tests that need to be fixed. | |||||
* | | | | | Warning removed for ruby-head | Rashmi Yadav | 2013-11-07 | 1 | -1/+1 | |
| |_|_|/ |/| | | | ||||||
* | | | | bring back constant to expose the enum mapping as HWIA. | Yves Senn | 2013-11-06 | 1 | -0/+6 | |
| |_|/ |/| | | ||||||
* | | | store enum mapping using `Strings` instead of `Symbols`. | Yves Senn | 2013-11-05 | 1 | -2/+7 | |
| | | | | | | | | | | | | | | | This allows to assign both `String` and `Symbol` values to the enum without having to call `to_sym`, which is a security problem. | |||||
* | | | direct enum assignment rasies ArgumentError for unknown values. | Yves Senn | 2013-11-05 | 1 | -0/+12 | |
| | | | ||||||
* | | | define enum methods inside a `Module` to make them overwritable. | Yves Senn | 2013-11-05 | 1 | -0/+5 | |
| | | | ||||||
* | | | Remove private API test | Rafael Mendonça França | 2013-11-05 | 1 | -10/+0 | |
| | | | ||||||
* | | | The enum value constant isn't used, so rm it for now. | Aaron Patterson | 2013-11-04 | 1 | -10/+0 | |
| | | | ||||||
* | | | fix copy & paste test-case naming. [ci skip] | Yves Senn | 2013-11-04 | 1 | -1/+1 | |
| | | | ||||||
* | | | Respect cache timestamp format when giving timestamps to #cache_key | Carlos Antonio da Silva | 2013-11-04 | 1 | -2/+2 | |
| | | | ||||||
* | | | Add test verifying that you can only sort ARs of the same type | David Heinemeier Hansson | 2013-11-02 | 1 | -1/+7 | |
| | | | ||||||
* | | | Revert "ActiveRecord::Base#<=> has been removed. Primary keys may not be in ↵ | David Heinemeier Hansson | 2013-11-02 | 1 | -0/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | order," -- will be replaced with a check to ensure that the keys used for comparison are integers, and only fail if they are not. This reverts commit 6256734e2d0bdd89f4b5d11da259d40afa0c95c7. Conflicts: activerecord/CHANGELOG.md | |||||
* | | | Delegate #rewhere to all on the class like all other relation methods | David Heinemeier Hansson | 2013-11-02 | 1 | -0/+4 | |
| | | | ||||||
* | | | Merge pull request #12747 from yury/explicit-enum-values | David Heinemeier Hansson | 2013-11-02 | 1 | -0/+8 | |
|\ \ \ | | | | | | | | | Explicit mapping for enum | |||||
| * | | | Explicit mapping for enum | Yury Korolev | 2013-11-02 | 1 | -0/+8 | |
| | | | | ||||||
* | | | | Added ActiveRecord::QueryMethods#rewhere which will overwrite an existing, ↵ | David Heinemeier Hansson | 2013-11-02 | 1 | -0/+30 | |
| | | | | | | | | | | | | | | | | named where condition. | |||||
* | | | | unscope now works on default_scope after ↵ | Rafael Mendonça França | 2013-11-02 | 1 | -1/+1 | |
|/ / / | | | | | | | | | | 94924dc32baf78f13e289172534c2e71c9c8cade | |||||
* | | | Add a test case for the scope enum adds | David Heinemeier Hansson | 2013-11-02 | 1 | -0/+4 | |
| | | | ||||||
* | | | Extend ActiveRecord::Base#cache_key to take an optional list of timestamp ↵ | David Heinemeier Hansson | 2013-11-02 | 1 | -1/+7 | |
| | | | | | | | | | | | | attributes of which the highest will be used. | |||||
* | | | Use an already existing fixture | Carlos Antonio da Silva | 2013-11-02 | 1 | -1/+1 | |
| | | | ||||||
* | | | Fix to work on Ruby 1.9.3, example and changelog improvements | Carlos Antonio da Silva | 2013-11-02 | 1 | -3/+3 | |
| | | | ||||||
* | | | Added ActiveRecord::Base#enum for declaring enum attributes where the values ↵ | David Heinemeier Hansson | 2013-11-02 | 1 | -0/+36 | |
| | | | | | | | | | | | | map to integers in the database, but can be queried by name | |||||
* | | | Fix wrong behavior where associations with dependent: :destroy options | Rafael Mendonça França | 2013-11-01 | 1 | -4/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | was using nullify strategy This caused a regression in applications trying to upgrade. Also if the user set the dependent option as destroy he expects to get the records removed from the database. | |||||
* | | | Test with the right association | Rafael Mendonça França | 2013-11-01 | 1 | -3/+3 | |
| | | | ||||||
* | | | More Warnings removed for ruby trunk | Arun Agrawal | 2013-11-01 | 1 | -1/+1 | |
| | | | | | | | | | | | | Same as 4d4ff531b8807ee88a3fc46875c7e76f613956fb | |||||
* | | | Warnings removed for ruby trunk | Arun Agrawal | 2013-11-01 | 3 | -23/+23 | |
| | | | | | | | | | Same as 4d4ff531b8807ee88a3fc46875c7e76f613956fb | |||||
* | | | :cut: whitespace | Aaron Patterson | 2013-10-30 | 1 | -2/+2 | |
| | | | ||||||
* | | | fix code typo in `MysqlAdapter` .Closes #12647. | Yves Senn | 2013-10-30 | 1 | -0/+15 | |
| | | | ||||||
* | | | short arrays in inspect | Jan Bernacki | 2013-10-30 | 1 | -0/+5 | |
| | | | ||||||
* | | | Fix broken delete_all test, which will now be failing since #delete_all is ↵ | David Heinemeier Hansson | 2013-10-28 | 1 | -4/+4 | |
| | | | | | | | | | | | | broken | |||||
* | | | Add failing test for preloading with a polymorphic association and using the ↵ | David Heinemeier Hansson | 2013-10-28 | 1 | -1/+10 | |
|/ / | | | | | | | existential predicate | |||||
* | | Merge pull request #12578 from ↵ | Rafael Mendonça França | 2013-10-27 | 1 | -1/+10 | |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | jeradphelps/configurable_schema_migrations_table_name Configurable name for schema_migrations table Conflicts: activerecord/CHANGELOG.md | |||||
| * | | added schema_migrations_table_name to ActiveRecord::Base in order that the ↵ | Jerad Phelps | 2013-10-27 | 1 | -1/+10 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | name of the schema migrations table can be configured. consolidated test_schema_migrations_table_name tests Added changelog entry edited changelog removed commented lines removed reader ensure the schema migrations table is reset at end of test added entry to configuration guide guides typo and changelog order | |||||
* | | | Assert the return value in the test | Rafael Mendonça França | 2013-10-27 | 1 | -1/+1 | |
| | | | ||||||
* | | | Skip `include_values` from through associations chains for building target scope | Paul Nikitochkin | 2013-10-27 | 1 | -0/+4 | |
| | | | | | | | | | | | | Fixes: #12242, #9517, #10240 | |||||
* | | | Merge pull request #12643 from severin/pg_cast_json_on_write | Yves Senn | 2013-10-25 | 1 | -0/+7 | |
|\ \ \ | | | | | | | | | cast json values on write to be consistent with reading from the db. | |||||
| * | | | cast json values on write to be consistent with reading from the db. | Severin Schoepke | 2013-10-25 | 1 | -0/+7 | |
| | | | | | | | | | | | | | | | | See also commit 5ac2341fab689344991b2a4817bd2bc8b3edac9d | |||||
* | | | | prevent `time_zone_aware_attributes` test leak. follow-up to #12633. | Yves Senn | 2013-10-25 | 1 | -21/+21 | |
| | | | | ||||||
* | | | | only warn on leaked time zone state instead of rasing an error. | Yves Senn | 2013-10-25 | 1 | -3/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Raising `RuntimeErrors` skips important cleanup code and leads to a lot of subsequent errors. This clutters the test output with a lot of noise. | |||||
* | | | | Merge pull request #12633 from senny/no_more_time_zone_leaks | Yves Senn | 2013-10-25 | 12 | -214/+223 | |
|\ \ \ \ | |/ / / |/| | | | prevent global timezone state from leaking out of test cases. | |||||
| * | | | prevent global timezone state from leaking out of test cases. | Yves Senn | 2013-10-25 | 12 | -214/+223 | |
| | | | |