Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | don't change class definition in test case | Josh Susser | 2011-11-29 | 1 | -6/+0 |
| | |||||
* | use GeneratedFeatureMethods module for associations | Josh Susser | 2011-11-27 | 2 | -1/+30 |
| | |||||
* | add test for super-ing to association methods | Josh Susser | 2011-11-15 | 1 | -2/+12 |
| | |||||
* | association methods are now generated in modules | Josh Susser | 2011-11-15 | 1 | -0/+12 |
| | | | | | | | | | | Instead of generating association methods directly in the model class, they are generated in an anonymous module which is then included in the model class. There is one such module for each association. The only subtlety is that the generated_attributes_methods module (from ActiveModel) must be forced to be included before association methods are created so that attribute methods will not shadow association methods. | ||||
* | Merge pull request #3371 from yahonda/fix_ora_00932_error | Aaron Patterson | 2011-11-14 | 1 | -1/+1 |
|\ | | | | | Fix ORA-00932 error when trying to insert 0 to DATE type columns. | ||||
| * | Fix ORA-00932 error when trying to insert 0 to DATE type columns. | Yasuo Honda | 2011-10-19 | 1 | -1/+1 |
| | | |||||
* | | change_table bulk test case should check if the connection supports bulk alter | Vijay Dev | 2011-11-11 | 1 | -13/+15 |
| | | |||||
* | | Modify change_table to remove the need for the block argument. | Vijay Dev | 2011-11-11 | 1 | -0/+52 |
| | | |||||
* | | Checking the arity of the block passed to create_table | Vijay Dev | 2011-11-10 | 1 | -0/+15 |
| | | | | | | | | | | | | A recent change made to create_table does away with the need for the block argument. Checking the arity will prevent the mixing up of the two syntaxes. | ||||
* | | exclude ORDER BY clause when querying Relation#exists? | Akira Matsuda | 2011-11-09 | 1 | -0/+5 |
| | | |||||
* | | revises EXPLAIN tests for SQLite3 | Xavier Noria | 2011-11-06 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | | | | | | The output in Travis is a bit different. The SQLite documentation (http://www.sqlite.org/eqp.html) warns output may change dramatically between releases. I do not want to mock the result set because I want a real EXPLAIN to happen. I prefer a test that may fail in future releases than a test that may give false positives in future releases. | ||||
* | | Merge pull request #3521 from ↵ | Aaron Patterson | 2011-11-06 | 1 | -0/+4 |
| | | | | | | | | | | | | nulogy/fix_postgres_adapter_to_handle_spaces_between_schemas Fix postgres adapter to handle spaces between schemas | ||||
* | | Update ActiveRecord#attribute_present? to work as documented | Justin Mazzi | 2011-11-05 | 1 | -0/+18 |
| | | | | | | | | | | | | | | "Returns true if the specified attribute has been set by the user or by a database load and is neither nil nor empty?" Fixes #1613 | ||||
* | | implements AR::Relation#explain | Xavier Noria | 2011-11-05 | 3 | -0/+71 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a first implementation, EXPLAIN is highly dependent on the database and I have made some compromises. On one hand, the method allows you to run the most common EXPLAIN and that's it. If you want EXPLAIN ANALYZE in PostgreSQL you need to do it by hand. On the other hand, I've tried to construct a string as close as possible to the ones built by the respective shells. The rationale is that IMO the user should feel at home with the output and recognize it at first sight. Per database. I don't know whether this implementation is going to work well. Let's see whether people like it. | ||||
* | | Merge pull request #3525 from kennyj/fix_3440-1 | Jon Leighton | 2011-11-05 | 1 | -0/+5 |
|\ \ | | | | | | | Fixed an issue id false option is ignored on mysql/mysql2 (fix #3440) | ||||
| * | | Fixed an issue id false option is ignored on mysql/mysql2 (fix #3440) | kennyj | 2011-11-06 | 1 | -0/+5 |
| | | | |||||
* | | | Add ActiveRecord::Relation#uniq for toggling DISTINCT in the SQL query | Jon Leighton | 2011-11-05 | 3 | -1/+23 |
| | | | |||||
* | | | AR changes to support creating ordered (asc, desc) indexes | Vlad Jebelev | 2011-11-04 | 2 | -4/+24 |
|/ / | |||||
* | | Fix test as one more has_many added | Arun Agrawal | 2011-11-04 | 1 | -1/+1 |
| | | |||||
* | | Allow the :class_name option for associations to take a symbol. | Jon Leighton | 2011-11-04 | 1 | -1/+5 |
| | | | | | | | | | | This is to avoid confusing newbies, and to be consistent with the fact that other options like :foreign_key already allow a symbol or a string. | ||||
* | | Merge pull request #1163 from amatsuda/sexier_migration_31 | Aaron Patterson | 2011-11-04 | 1 | -0/+20 |
|\ \ | | | | | | | Sexier migrations | ||||
| * | | Tests for new create_table DSL | Akira Matsuda | 2011-05-20 | 1 | -0/+20 |
| | | | |||||
* | | | Merge pull request #3507 from jmazzi/issue-3503 | Jeremy Kemper | 2011-11-03 | 1 | -0/+15 |
| | | | | | | | | | | | | Preserve SELECT columns on the COUNT for finder_sql when possible | ||||
* | | | Fix #3271. | Jon Leighton | 2011-11-03 | 1 | -0/+6 |
| | | | | | | | | | | | | | | | | | | | | | | | | Building the conditions of a nested through association could potentially modify the conditions of the through and/or source association. This is a Bad Thing. | ||||
* | | | Remove all revelant through records. | Jon Leighton | 2011-11-03 | 1 | -0/+15 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | If a record is removed from a has_many :through, all of the join records relating to that record should also be removed from the through association's target. (Previously the records were removed in the database, but only one was removed from the in-memory target array.) | ||||
* | | | Fix adding multiple instances of the same record to a has_many :through. | Jon Leighton | 2011-11-03 | 1 | -0/+10 |
| | | | | | | | | | | | | Fixes #3425. | ||||
* | | | Fix #3247. | Jon Leighton | 2011-11-03 | 1 | -0/+5 |
| | | | | | | | | | | | | | | | Fixes creating records in a through association with a polymorphic source type. | ||||
* | | | assert_match takes a regexp and a string in that order | Vijay Dev | 2011-10-31 | 1 | -1/+1 |
| | | | |||||
* | | | dump_schema_information: explicitly order inserts into schema_migrations table | Laust Rud Jacobsen | 2011-10-31 | 1 | -0/+9 |
| | | | | | | | | | | | | | | | | | | | | | This change reduces churn in the db/development_structure.sql file when using :sql as active_record.schema_format, and makes comparing diffs much easier. Test ensures the output SQL-statements are lexically ordered by version. | ||||
* | | | Added failing test case for changing schema in migration not clearing the ↵ | Joe Van Dyk | 2011-10-27 | 1 | -0/+12 |
| | | | | | | | | | | | | prepared statement cache | ||||
* | | | More checks for instance writers. | Arun Agrawal | 2011-10-27 | 1 | -1/+2 |
| | | | |||||
* | | | Adding more checks for instance_writer false | Arun Agrawal | 2011-10-27 | 1 | -1/+2 |
| | | | |||||
* | | | Test fix Allow instances to disable record_timestamps | Arun Agrawal | 2011-10-27 | 1 | -1/+1 |
| | | | | | | | | | | | | Removed here 0d0176c4ffe5c58fd1002efbd8f7bd45a8872e33 | ||||
* | | | Allow instances to disable record_timestamps | Pratik Naik | 2011-10-26 | 1 | -0/+10 |
| | | | |||||
* | | | Merge branch 'master' of github.com:rails/rails | David Heinemeier Hansson | 2011-10-25 | 7 | -11/+98 |
|\ \ \ | |||||
| * | | | preserve decimal column attributes after migration | Greg Reinacker | 2011-10-21 | 1 | -0/+36 |
| | | | | |||||
| * | | | Merge pull request #3258 from ileitch/3-1-stable | Aaron Patterson | 2011-10-20 | 1 | -0/+16 |
| | |/ | |/| | | | | | | | Postgres: Do not attempt to deallocate a statement if the connection is no longer active. | ||||
| * | | only use now() on pg! | Aaron Patterson | 2011-10-18 | 1 | -1/+3 |
| | | | |||||
| * | | reset prepared statement when schema changes imapact statement results. ↵ | Aaron Patterson | 2011-10-18 | 1 | -0/+8 |
| | | | | | | | | | | | | fixes #3335 | ||||
| * | | use now() for dates in pg | Aaron Patterson | 2011-10-18 | 1 | -1/+1 |
| | | | |||||
| * | | Merge pull request #3340 from surfacedamage/exclude_destroy_in_all_blank_check | José Valim | 2011-10-17 | 1 | -0/+8 |
| |\ \ | | | | | | | | | Exclude _destroy parameter in :all_blank check (issue #2937) | ||||
| | * | | Exclude _destroy parameter in :all_blank check (issue #2937) | Aaron Christy | 2011-10-17 | 1 | -0/+8 |
| | | | | |||||
| * | | | Merge pull request #3334 from mperham/master | Aaron Patterson | 2011-10-16 | 1 | -5/+5 |
| |\ \ \ | | | | | | | | | | | Default timestamps to non-null | ||||
| | * | | | Default timestamps to non-null | Mike Perham | 2011-10-14 | 1 | -5/+5 |
| | |/ / | |||||
| * / / | fix to remove warning in test cases | Vishnu Atrai | 2011-10-16 | 1 | -2/+2 |
| |/ / | |||||
| * | | Includes stale record in StaleObjectError | Christian Bäuerlein | 2011-10-14 | 1 | -1/+18 |
| | | | |||||
| * | | Rails 4 is just around the corner. Stuck with 1.8 until then. | Jeremy Kemper | 2011-10-13 | 1 | -3/+3 |
| | | | |||||
* | | | Fix that changing a store should mark the store attribute as changed | David Heinemeier Hansson | 2011-10-25 | 1 | -0/+5 |
|/ / | |||||
* | | Added ActiveRecord::Base.store for declaring simple single-column key/value ↵ | David Heinemeier Hansson | 2011-10-13 | 1 | -0/+29 |
| | | | | | | | | stores [DHH] | ||||
* | | ambiguous first argument; put parentheses or even spaces Warning removed! | Arun Agrawal | 2011-10-10 | 1 | -2/+2 |
| | |