aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #6325 from kennyj/fix_5832-3Carlos Antonio da Silva2012-05-151-5/+1
|\ | | | | Remove unnecessary assertions.
| * Remove unnecessary assertions. We should only test the before_seq isn't same ↵kennyj2012-05-161-5/+1
| | | | | | | | to the after_seq when using sequencer.
* | Restore support for Model.pluck('sql fragment')Jeremy Kemper2012-05-151-0/+8
|/
* Set the primary key during #copy_table if necessary. Fixes [#2312]Sean Scally2012-05-141-0/+8
|
* Merge pull request #5807 from Antiarchitect/store-improvementRafael Mendonça França2012-05-131-1/+35
|\ | | | | Custom coders support for ActiveRecord::Store.
| * Custom coders support for ActiveRecord::Store. JSON, YAML, Marshal can be ↵Andrey Voronkov2012-05-091-1/+35
| | | | | | | | used out of the box.
* | fix todo: use minitest skip instead of return nilFrancesco Rodriguez2012-05-131-9/+8
| |
* | Merge pull request #6193 from mhfs/fix_oracle_specRafael Mendonça França2012-05-121-1/+1
|\ \ | | | | | | Fix failing AR test on Oracle
| * | Fix failing test on Oracle. Having a duplicated column specified in aMarcelo Silveira2012-05-071-1/+1
| |/ | | | | | | | | | | select with order on the same column makes Oracle complain about "column ambiguously defined" when an order is defined on such column (introduced by default order on `first`) (fixes #6147).
* | Remove #=== quirkJon Leighton2012-05-112-11/+0
| | | | | | | | Makes it consistent with Relation. Can't see a use for this.
* | CollectionProxy < RelationJon Leighton2012-05-115-9/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This helps bring the interfaces of CollectionProxy and Relation closer together, and reduces the delegation backflips we need to perform. For example, first_or_create is defined thus: class ActiveRecord::Relation def first_or_create(...) first || create(...) end end If CollectionProxy < Relation, then post.comments.first_or_create will hit the association's #create method which will actually add the new record to the association, just as post.comments.create would. With the previous delegation, post.comments.first_or_create expands to post.comments.scoped.first_or_create, where post.comments.scoped has no knowledge of the association.
* | Return false for exists? with new records - fixes #6199.Andrew White2012-05-102-0/+2
| |
* | Merge pull request #4254 from alexeymuranov/my-nicify-fixtures-rbJeremy Kemper2012-05-091-2/+2
|\ \ | | | | | | Rename variables and remove unused code in fixtures.rb
| * | Rename some variablesAlexey Muranov2012-05-091-2/+2
| |/ | | | | | | | | | | Rename some parameters and instance and local variables, mostly in fixtures.rb. Also remove an unused assignment to an instance variable. There are minor code changes.
* | Allow to run `connection_adapters/quoting_test.rb` independentlyPiotr Sarnacki2012-05-091-1/+3
| |
* | Merge pull request #5362 from zenprogrammer/quoting_bugAaron Patterson2012-05-091-0/+11
|\ \ | | | | | | Fixed bug in ActiveRecord that caused classes to be quoted incorrectly
| * | Fixed bug in Quoting that caused classes to be quoted incorrectlyRyan Oblak2012-03-091-0/+11
| | |
* | | make both cached and record_updated accessors in one lineHemant Kumar2012-05-091-2/+1
| | |
* | | after_commit :on => :update should be called when save isHemant Kumar2012-05-091-0/+7
| | | | | | | | | | | | called from after_commit callback
* | | Fix transaction state not changing when after record gets commitedHemant Kumar2012-05-091-0/+25
| |/ |/|
* | Merge pull request #6173 from mhfs/takes_instead_firstJeremy Kemper2012-05-052-1/+13
|\ \ | | | | | | Use `take` instead of `first` to avoid unwanted implicit ordering. Closes #6147.
| * | Use `take` instead of `first` to avoid unwanted implicit ordering (fixes #6147)Marcelo Silveira2012-05-052-1/+13
| | |
* | | Merge pull request #6069 from mipearson/use_strict_mode_in_mysqlJeremy Kemper2012-05-052-0/+29
|\ \ \ | | | | | | | | Use strict mode in mysql
| * | | Add config option, rdoc, tests for mysql(2) STRICT_ALL_TABLES mode.Michael Pearson2012-05-052-0/+29
| |/ /
* | | Merge pull request #6054 from flexoid/column-fixJon Leighton2012-05-051-0/+28
|\ \ \ | | | | | | | | Prevent creating valid time-like objects from blank string from db
| * | | Prevent creating valid time-like objects from blank string from dbEgor Lynko2012-05-051-0/+28
| | | | | | | | | | | | | | | | Issue #6045
* | | | Revert "Merge pull request #5494 from ↵Jon Leighton2012-05-051-8/+1
|/ / / | | | | | | | | | | | | | | | | | | armstrjare/active_record_relation_keep_association_join_context_on_merge" This reverts commit dcd04e76179611a9db28c9e391aa7d6c2a5b046a, reversing changes made to 58a49875df63729f07a9a81d1ee349087d258df5.
* | | Merge pull request #5494 from ↵Jon Leighton2012-05-051-1/+8
|\ \ \ | |/ / |/| | | | | | | | armstrjare/active_record_relation_keep_association_join_context_on_merge ActiveRecord::Relation - maintain context of joined associations on merges
| * | Allow ActiveRecord::Relation merges to maintain context of joined associationsJared Armstrong2012-05-041-1/+8
| | |
* | | Duplicate column_defaults properly (closes #6115)Piotr Sarnacki2012-05-041-1/+7
| | |
* | | Merge pull request #3713 from kf8a/masterAaron Patterson2012-05-041-0/+12
|\ \ \ | | | | | | | | postgresql adapter should quote not a number and infinity correctly for float columns
| * | | postgresql adapter handles quoting of not a number (NaN) and InfinitySven Bohm2011-11-211-0/+12
| | | |
* | | | extract deprecated dynamic methodsJon Leighton2012-05-041-2/+2
| | | |
* | | | extract code from AR::BaseJon Leighton2012-05-041-2/+2
| | | |
* | | | clean up implementation of dynamic methods. use method compilation etc.Jon Leighton2012-05-042-109/+2
| |/ / |/| |
* | | Fix issue with private kernel methods and collection associations. Closes #2508Carlos Antonio da Silva2012-05-021-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | Change CollectionProxy#method_missing to use scoped.public_send, to avoid a problem described in issue #2508 when trying to use class methods with names like "open", that clash with private kernel methods. Also changed the dynamic matcher instantiator to send straight to scoped, to avoid another roundtrip to method_missing.
* | | Introducing `take` as a replacement to the old behavior of `first`Marcelo Silveira2012-05-021-2/+24
| | |
* | | Made `first` finder consistent among database engines by adding aMarcelo Silveira2012-05-021-0/+6
| | | | | | | | | | | | default order clause (fixes #5103)
* | | Refactored remove_columnEdgars Beigarts2012-05-021-2/+2
| | |
* | | Merge pull request #6089 from frodsan/delete_all_limitAaron Patterson2012-05-011-0/+4
|\ \ \ | | | | | | | | delete_all raise an error if a limit is provided - fixes #4979
| * | | delete_all raise an error if a limit is provided - fixes #4979Francesco Rodriguez2012-04-301-0/+4
| | | |
* | | | Merge pull request #6092 from ↵Aaron Patterson2012-05-011-0/+24
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | jsanders/issue_4001_error_typecasting_non_integer_castable Don't type cast values that don't respond to to_i to 1
| * | | | Don't type cast values that don't respond to to_i to 1James Sanders & Jason Noble2012-04-301-0/+24
| |/ / /
* | | | remove useless assertionsAaron Patterson2012-04-301-10/+3
| | | |
* | | | return value of block is returnedAaron Patterson2012-04-301-1/+9
| | | |
* | | | only yield to finder block if something is foundAaron Patterson2012-04-301-0/+10
| | | |
* | | | Fix PR #6091Andrew White2012-04-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | 1. ActiveRecord::Base is not ActiveRecord::Relation 2. The order of records from an SQL query is uncertain without an ORDER clause 3. Run your own tests when submitting a pull request
* | | | Add ActiveRecord::Base#idstwinturbo2012-04-301-0/+4
|/ / /
* | | Build fix for observed_classesArun Agrawal2012-04-301-1/+1
| | | | | | | | | | | | | | | introduced here bad44e4f8f690039bd0db92ac25f10af536c6e71
* | | Remove unused assignments from activerecord testsMark Rushakoff2012-04-294-6/+2
| | |